[clang] 2a42c75 - [clang-format] [PR19056] Add support for access modifiers indentation

Author: Jakub Budiský Date: 2021-02-26T09:17:07+01:00 New Revision: 2a42c759ae7bb09dd448d188138f310d014fcab6 URL: https://github.com/llvm/llvm-project/commit/2a42c759ae7bb09dd448d188138f310d014fcab6 DIFF: https://github.com/llvm/llvm-project/commit/2a42c759ae7bb09dd448d188138f310d014fcab6.diff

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a42c759ae7b: [clang-format] [PR19056] Add support for access modifiers indentation (authored by Budovi, committed by curdeius). Changed prior to commit: https://reviews.llvm.org/D94661?vs=322645&id=326

[clang] d412dbe - [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

Author: Yu-Hsun Chiang Date: 2021-02-26T09:29:11+01:00 New Revision: d412dbe388819dd68bbe4a3967783fdf80400860 URL: https://github.com/llvm/llvm-project/commit/d412dbe388819dd68bbe4a3967783fdf80400860 DIFF: https://github.com/llvm/llvm-project/commit/d412dbe388819dd68bbe4a3967783fdf80400860.diff

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

This revision was automatically updated to reflect the committed changes. Closed by commit rGd412dbe38881: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new… (authored by oToToT, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

balazske added a comment. You can look into **misc/UnusedUsingDeclsCheck.cpp** (if not done yet), that check handles `using` too. And that check is related to this check, the module should be the same too (`misc`)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

balazske added a comment. There should be already a name lookup implemented somewhere in clang (`DeclContext`? or Sema) that maybe usable here (check if the name of the "used" entity is visible in the declaration context of the `using` statement). Probably it is not as simple to do because the

[PATCH] D97534: SEH: capture 'this'

ogoffart created this revision. ogoffart added reviewers: rnk, asl, cfe-commits. ogoffart requested review of this revision. Herald added a project: clang. Simply make sure that the CodeGenFunction::CXXThisValue and CXXABIThisValue are correctly initialized to the recovered value. For lambda captu

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Without this patch the file list of the index is derived from the keys, b

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. By default gRPC has no idletimeout and some

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX added reviewers: sammccall, kadircet, hokein. ArcsinX added a comment. Initial discussion D94952#inline-892421 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/ https://reviews.llvm.or

[clang] d5e0868 - [Basic] Fix Wreturn-type gcc warning (NFC)

Author: Yang Fan Date: 2021-02-26T17:14:13+08:00 New Revision: d5e0868e5e321e2a2f3bf73599ae9239c5aaa0c9 URL: https://github.com/llvm/llvm-project/commit/d5e0868e5e321e2a2f3bf73599ae9239c5aaa0c9 DIFF: https://github.com/llvm/llvm-project/commit/d5e0868e5e321e2a2f3bf73599ae9239c5aaa0c9.diff LOG:

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:84 +llvm::cl::opt IdleTimeoutSeconds( +"idle-timeout", llvm::cl::init(10), +llvm::cl::de

[clang] e9475a2 - [Sema] Fix MSVC "attribute is not recognized" warning (NFC)

Author: Yang Fan Date: 2021-02-26T17:28:24+08:00 New Revision: e9475a276267f1bc74d9624fc797c7a754b5b90b URL: https://github.com/llvm/llvm-project/commit/e9475a276267f1bc74d9624fc797c7a754b5b90b DIFF: https://github.com/llvm/llvm-project/commit/e9475a276267f1bc74d9624fc797c7a754b5b90b.diff LOG:

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

kadircet updated this revision to Diff 326632. kadircet marked an inline comment as done. kadircet added a comment. Change 10 seconds to 600 seconds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97536/new/ https://reviews.llvm.org/D97536 Files:

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:84 +llvm::cl::opt IdleTimeoutSeconds( +"idle-timeout", llvm::cl::init(10), +llvm::cl::desc("Maximum time a channel may stay idle until server closes " samm

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske updated this revision to Diff 326642. balazske added a comment. Rebase, fixes according to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97196/new/ https://reviews.llvm.org/D97196 Files: clang-tools-extra/clang-tidy/bug

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 326585. khchen marked 10 inline comments as done. khchen added a comment. 1. address Craig's comments. 2. use ListSeparator in some code snippet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://

[clang] 04c3071 - [Driver] Flush file in locked area

Author: Serge Pavlov Date: 2021-02-26T19:02:54+07:00 New Revision: 04c3071c16d799a4406c1742f239e8381c00b2b8 URL: https://github.com/llvm/llvm-project/commit/04c3071c16d799a4406c1742f239e8381c00b2b8 DIFF: https://github.com/llvm/llvm-project/commit/04c3071c16d799a4406c1742f239e8381c00b2b8.diff

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 326651. ASDenysPetrov added a comment. A bit improved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97388/new/ https://reviews.llvm.org/D97388 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h clang/lib/StaticAna

[clang] 8dc70bd - [clang][cli] Fix build failure in CompilerInvocation

Author: Jan Svoboda Date: 2021-02-26T13:14:23+01:00 New Revision: 8dc70bdcd0fe4efb65876dce0144d9c3386a2f07 URL: https://github.com/llvm/llvm-project/commit/8dc70bdcd0fe4efb65876dce0144d9c3386a2f07 DIFF: https://github.com/llvm/llvm-project/commit/8dc70bdcd0fe4efb65876dce0144d9c3386a2f07.diff L

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:84 +llvm::cl::opt IdleTimeoutSeconds( +"idle-timeout", llvm::cl::init(10), +llvm::cl::desc("Maximum time a channel may stay idle until se

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:666 + // semantics as the original. + SmallVector GeneratedArgs1; + Generate(DummyInvocation, GeneratedArgs1, SA); scui wrote: > This is failing our build, This line and

[clang] cb81135 - [clang][cli] Implement '-cuid=' marshalling

Author: Jan Svoboda Date: 2021-02-26T13:17:51+01:00 New Revision: cb81135f94e58ce0a0e91d764841acee90eeb59f URL: https://github.com/llvm/llvm-project/commit/cb81135f94e58ce0a0e91d764841acee90eeb59f DIFF: https://github.com/llvm/llvm-project/commit/cb81135f94e58ce0a0e91d764841acee90eeb59f.diff L

[PATCH] D97461: [clang][cli] Implement '-cuid=' marshalling

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb81135f94e5: [clang][cli] Implement '-cuid=' marshalling (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97461/new/ https://revie

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal added a comment. In D96976#2587513 , @RedDocMD wrote: > Many thanks for you comments, @steakhal! > I will address the issues you have pointed out in this comment. To clean > things up I should perhaps add some more clarification to the summary. >

[PATCH] D97534: SEH: capture 'this'

ogoffart updated this revision to Diff 326656. ogoffart added a comment. (git-clang-format) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97534/new/ https://reviews.llvm.org/D97534 Files: clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCXX/exceptions-seh-filter-captures.cpp In

[PATCH] D97544: [clang-tidy] Remove some test c++ mode restrictions.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added subscribers: kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some comments are redundant, others just simpl

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

steakhal added a comment. Please make sure that you specify the parent revision or the patch can be applied on top of the tree. Your lines clearly not match the top of the tree state. https://github.com/llvm/llvm-project/blob/13f4448ae7db1a477ec2d48776e46415a3401314/clang/include/clang/StaticAnal

[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. I think this is fine. Comment at: clang/docs/ReleaseNotes.rst:82 + if compilation target supports LSE. Atomic instructions are used directly in + that case. T

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM, just a few minor things: Comment at: clang/docs/UsersManual.rst:798 + Setting ``CC_PRINT_PROC_STAT`` to ``1`` enables the feature, the report goes to + the stdout in

[PATCH] D97548: [clangd] Introduce client state invalidation

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd can invalidate client state of featu

[PATCH] D97548: [clangd] Introduce client state invalidation

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/semantic-tokens-refresh.test:13 +# CHECK:"method": "workspace/semanticTokens/refresh", +# CHECK-NEXT: "params": null +# CHECK-NEXT: } lsp spec says `params: none` for this reques

[PATCH] D96586: [analyzer][CTU][NFC] Add an extra regression test

steakhal added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96586/new/ https://reviews.llvm.org/D96586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

kadircet updated this revision to Diff 326667. kadircet marked an inline comment as done. kadircet added a comment. - change default from 10 to 8 minutes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97536/new/ https://reviews.llvm.org/D97536 File

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

scui added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:666 + // semantics as the original. + SmallVector GeneratedArgs1; + Generate(DummyInvocation, GeneratedArgs1, SA); jansvoboda11 wrote: > scui wrote: > > This is failing our build

[clang-tools-extra] 1a5dfb7 - [clangd][remote] Add flag to set idletimeout

Author: Kadir Cetinkaya Date: 2021-02-26T15:04:44+01:00 New Revision: 1a5dfb7db23e3c0aec0b4356a60b9d6b7c8f9683 URL: https://github.com/llvm/llvm-project/commit/1a5dfb7db23e3c0aec0b4356a60b9d6b7c8f9683 DIFF: https://github.com/llvm/llvm-project/commit/1a5dfb7db23e3c0aec0b4356a60b9d6b7c8f9683.dif

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a5dfb7db23e: [clangd][remote] Add flag to set idletimeout (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97536: [clangd][remote] Add flag to set idletimeout

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:84 +llvm::cl::opt IdleTimeoutSeconds( +"idle-timeout", llvm::cl::init(10), +llvm::cl::desc("Maximum time a channel may stay idle until server closes " samm

[PATCH] D97552: [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, DiggerLin. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes failure of the `CodeGen/aix-i

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 updated this revision to Diff 326677. jansvoboda11 added a comment. Rebase on top of D97552 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97462 Files: clang/CMak

[PATCH] D97553: [clang][NFC] pack StaticDiagInfoRec

njames93 created this revision. njames93 added reviewers: rsmith, aaron.ballman. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Exchanging types, reordering fields and borrowing a bit from OptionGroupIndex shrinks this from 12 by

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. > So here you are implying that for reinterpret casts, the > `CastE->path_begin()-end()` range is empty? And that is why you need to > manually come up with a //possible// CXXBaseSpecifier list? @steakhal, Yes. For illustration, the following code: struct Base {

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal added a comment. In D96976#2590200 , @RedDocMD wrote: > Unfortunately, all the methods on CXXRecordDecl, like the one you mentioned, > are for querying and thus returns a `bool`, while I need the entire path. AFAIK the second overload accepts an

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

thakis added a comment. Thanks for fixing this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97437/new/ https://reviews.llvm.org/D97437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

Eugene.Zelenko added a comment. In D97361#2589673 , @balazske wrote: > You can look into **misc/UnusedUsingDeclsCheck.cpp** (if not done yet), that > check handles `using` too. And that check is related to this check, the > module should be the same too

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

kadircet updated this revision to Diff 326686. kadircet added a comment. - Update header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96245/new/ https://reviews.llvm.org/D96245 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-e

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, javed.absar. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D96245

[PATCH] D96439: [clangd][WIP] Introduce DiagnosticAugmentationModule

kadircet abandoned this revision. kadircet added a comment. see https://reviews.llvm.org/D97555 for revised version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96439/new/ https://reviews.llvm.org/D96439 __

[PATCH] D93347: [Test] Fix undef var in attr-speculative-load-hardening.c

thopre added reviewers: rsmith, rnk, kristof.beyls. thopre added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93347/new/ https://reviews.llvm.org/D93347 ___ cfe-commits mailing list cfe

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1037 + assert(AddrAlign >= ResultTy->getPrimitiveSizeInBits() / 8 && + "Expected at least natural alignment at this point."); jrtc27 wrote: > Doesn't this introduce anoth

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov added a comment. @steakhal > Please make sure that you specify the parent revision or the patch can be > applied on top of the tree. Sorry, probably missed to add a parent revision. Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97388/new/ https://reviews.llvm.org/

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT created this revision. oToToT added reviewers: sammccall, rsmith, klimek, dexonsmith. oToToT added a project: clang. oToToT requested review of this revision. Herald added a subscriber: cfe-commits. As proposed in D97109 , I tried to replace all similar tar

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:368 // Create the target instance. - Clang->setTarget(TargetInfo::CreateTargetInfo( - Clang->getDiagnostics(), Clang->getInvocation().TargetOpts)); - if (!Clang->hasTarget()) + if (!Cl

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

thakis added a comment. This seems to flag https://source.chromium.org/chromium/chromium/src/+/master:third_party/libsync/src/sync.c;l=142?q=sync.c&ss=chromium : info->sync_fence_info = (uint64_t) calloc(num_fences, sizeof(struct sync_fence_info)); if ((voi

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop updated this revision to Diff 326716. russell.gallop added a comment. Added comment on AllocatorSize. Applied Mingw changes suggested by @mstorsjo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96120/new/ https://reviews.llvm.org/D9

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 326719. dgoldman marked an inline comment as done. dgoldman added a comment. Limit changes to document symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files:

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:279 SymbolSlabs.push_back(FileAndSymbols.second); + for (const auto &S : *FileAndSymbols.second) { +if (S.Definition) iterating over all the symbols here

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb updated this revision to Diff 326723. cjdb edited the summary of this revision. cjdb added a comment. updates commit message to explain what's going on and why the change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/ https://reviews

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb added a comment. In D94640#2590512 , @thakis wrote: > This seems to flag > https://source.chromium.org/chromium/chromium/src/+/master:third_party/libsync/src/sync.c;l=142?q=sync.c&ss=chromium > : > > info->sync_fence_info = (uint64_t) calloc(num_f

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: hokein, aaron.ballman, alexfh, JonasToth, njames93. DmitryPolukhin added a project: clang. Herald added a subscriber: xazax.hun. DmitryPolukhin requested review of this revision. For some reason the initial implementation of th

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop marked 2 inline comments as done. russell.gallop added a comment. In D96120#2550941 , @mstorsjo wrote: > In D96120#2550876 , @russell.gallop > wrote: > >> In D96120#2546077

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:8321 +TreeTransform::TransformOMPCanonicalLoop(OMPCanonicalLoop *L) { + // The OMPCanonicalLoop will be recreated when transforming the loop-associted + // directive. jdenny wrote: >

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/modernize-concat-nested-namespaces/modernize-concat-nested-namespaces.h:7 +} // namespace nn1 +// CHECK-FIXES: } This fix line isn't actually contributing to the test.

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD updated this revision to Diff 326731. RedDocMD added a comment. Replaced BFS with existing CXXRecordDeclMethod Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 Files: clang/include/clang/StaticAna

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. @steakhal, you are absolutely right! It works. Thank you for pointing it out, not sure how I missed this earlier this evening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10320 + + const clang::CastKind Kind = Cast->getCastKind(); + if (Kind == clang::CK_BitCast && We don't typically use top-level `const` on locals or params. Comm

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 326729. vvereschaka added a comment. Updated diff: - updated doc parts @aganea thanks a lot for your suggestions for doc improvements. I have updated it accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD updated this revision to Diff 326733. RedDocMD added a comment. Removed unnecessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 Files: clang/include/clang/StaticAnalyzer/Core/PathSen

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 326734. DmitryPolukhin added a comment. Comments resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files: clang-tools-extra/clang-tidy/modernize/ConcatN

[PATCH] D97544: [clang-tidy] Remove some test c++ mode restrictions.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97544/new/ https://reviews.llvm.org/D97544 __

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. @njames93 thank you for quick response and good suggestion! Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-concat-nested-namespaces.cpp:4 +// RUN: FileCheck -input-file=%T/modern

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD marked an inline comment as done. RedDocMD added a comment. In D97183#2589445 , @NoQ wrote: > Nice! > > I suspect you're adding too many notes. The note needs to not be there if the > *raw* pointer is not tracked. Eg., I suspect that your patch w

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 326738. akhuang marked an inline comment as done. akhuang added a comment. -Add documentation -Add more test cases and semantics tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.ll

[PATCH] D97447: Add GNU attribute 'retain'

MaskRay added a comment. I have performed a large-scale internal test. I don't find any problem with a toolchain built with D97446 /D97447 /D97448 . Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97566: [WIP][RGT] Rotten Green Test checking for LLVM and Clang unittests

probinson created this revision. probinson added reviewers: MaskRay, dblaikie. Herald added a subscriber: mgrang. probinson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This is an enhancement of the 'googletest' support code, to rep

[PATCH] D97553: [clang][NFC] pack StaticDiagInfoRec

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Basic/DiagnosticIDs.cpp:171 const StaticDiagInfoRec StaticDiagInfo[] = { +// clang-format off #define DIAG(ENUM, CLASS, DEFAULT_SE

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay updated this revision to Diff 326739. MaskRay added a comment. Simplify with `CodeGenModule::getTriple()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97446/new/ https://reviews.llvm.org/D97446 Files: clang/lib/CodeGen/CGDecl.cpp clan

[clang] 28cb620 - Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

Author: Fangrui Song Date: 2021-02-26T10:42:07-08:00 New Revision: 28cb620321f5461255423f84c85e6891b5174c13 URL: https://github.com/llvm/llvm-project/commit/28cb620321f5461255423f84c85e6891b5174c13 DIFF: https://github.com/llvm/llvm-project/commit/28cb620321f5461255423f84c85e6891b5174c13.diff

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28cb620321f5: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D97488: [clang-tidy][NFC] Tweak some generation of diag messages

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thanks, these are really nice cleanups! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97488/new/ https://reviews.llvm.org/D9

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb updated this revision to Diff 326742. cjdb marked 2 inline comments as done. cjdb added a comment. applies comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/ https://reviews.llvm.org/D97512 Files: clang/lib/Sema/SemaChecking.

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb added a subscriber: rsmith. cjdb added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10320 + + const clang::CastKind Kind = Cast->getCastKind(); + if (Kind == clang::CK_BitCast && aaron.ballman wrote: > We don't typically use top-level `cons

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:908 + +// Compute Buitlin types +SmallVector ProtoMaskSeq = ProtoSeq; Buitlin->Bu

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-concat-nested-namespaces.cpp:4 +// RUN: FileCheck -input-file=%T/modernize-concat-nested-namespaces.h %S/Inputs/modernize-concat-nested-namespaces/modernize-concat-nested-namespaces

[clang-tools-extra] b18f14d - [clang-tidy] Remove some test c++ mode restrictions.

Author: Nathan James Date: 2021-02-26T19:09:28Z New Revision: b18f14d6897b9e9f34ffd0d8ed46b8ac596fbf05 URL: https://github.com/llvm/llvm-project/commit/b18f14d6897b9e9f34ffd0d8ed46b8ac596fbf05 DIFF: https://github.com/llvm/llvm-project/commit/b18f14d6897b9e9f34ffd0d8ed46b8ac596fbf05.diff LOG:

[PATCH] D97544: [clang-tidy] Remove some test c++ mode restrictions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb18f14d6897b: [clang-tidy] Remove some test c++ mode restrictions. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97544/new/ https://

[clang-tools-extra] 1a721b6 - [clang-tidy][NFC] Tweak some generation of diag messages

Author: Nathan James Date: 2021-02-26T19:10:25Z New Revision: 1a721b6a2634d9740b389a7604275b426c22600a URL: https://github.com/llvm/llvm-project/commit/1a721b6a2634d9740b389a7604275b426c22600a DIFF: https://github.com/llvm/llvm-project/commit/1a721b6a2634d9740b389a7604275b426c22600a.diff LOG:

[PATCH] D97488: [clang-tidy][NFC] Tweak some generation of diag messages

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a721b6a2634: [clang-tidy][NFC] Tweak some generation of diag messages (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97488/new/ http

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb updated this revision to Diff 326748. cjdb added a comment. `s/IgnoreImplicitAsWritten/IgnoreParenImpCasts/` since the latter seems to work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/ https://reviews.llvm.org/D97512 Files: cla

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb marked an inline comment as done. cjdb added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10326 + !isa( + Cast->getSubExpr()->IgnoreImplicitAsWritten()->IgnoreParens())) +return; cjdb wrote: > aaron.ballman wrote: > > I'm no

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

flx created this revision. flx added reviewers: aaron.ballman, sbenza. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Until now when determining all the const uses of a VarDecl we only considered h

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:56 +// +// e: type of "t" as is (identity) +// v: computes a vector type whose element type is "t" for the current LMUL khchen wrote: > jrtc27 wrote: > > Do we really need to

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

NoQ added a comment. The warning should be emitted but it shouldn't have a note at `P.get()` telling the user that an inner pointer was obtained. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 ___

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. One property of this patch that has bothered me is that OMPCanonicalLoop is not a loop. Instead, it's an AST node that is sandwiched between a directive and a loop to contain extra information about the loop. The TreeTransform issues we've been discussing highlight how

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:66 +// element type which is bool +// 0: void type, ignores "t" +// z: size_t, ignores "t" jrtc27 wrote: > khchen wrote: > > jrtc27 wrote: > > > Then why aren't the

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. Dropping my approval pending @jrtc27 comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.ll

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:116 + D = 1 << 2, + ZFH = 1 << 3 +}; Zfh Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:241 + case 8: +ExpResult = Log2LMUL + 3; +break; ---

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:567 + // Compute type transformers + for (char I : Transformer.take_front(Transformer.size() - 1)) { +switch (I) { jrtc27 wrote: > craig.topper wrote: > > Can we do Trans

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:567 + // Compute type transformers + for (char I : Transformer.take_front(Transformer.size() - 1)) { +switch (I) { craig.topper wrote: > jrtc27 wrote: > > craig.topper wrote: >

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:259-260 + +LMULType &LMULType::operator*=(unsigned RHS) { + this->Log2LMUL = this->Log2LMUL + RHS; + return *this; jrtc27 wrote: > That's not how multiplication works. This i

  1   2   >