njames93 added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/modernize-concat-nested-namespaces/modernize-concat-nested-namespaces.h:7 +} // namespace nn1 +// CHECK-FIXES: } ---------------- This fix line isn't actually contributing to the test. Perhaps a better case, assuming clang-format doesn't update the comment, would be: ```lang=c++ // CHECK-FIXES: void t(); // CHECK-FIXES-NEXT: } namespace nn1 ``` ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-concat-nested-namespaces.cpp:4 +// RUN: FileCheck -input-file=%T/modernize-concat-nested-namespaces.h %S/Inputs/modernize-concat-nested-namespaces/modernize-concat-nested-namespaces.h -check-prefix=CHECK-FIXES +// Restore header file and re-run with c++2b: +// RUN: cp %S/Inputs/modernize-concat-nested-namespaces/modernize-concat-nested-namespaces.h %T/modernize-concat-nested-namespaces.h ---------------- Why do we explicitly run on c++2b and not c++20? I understand there is no framework in place for using -std=c++17-or-later when header files are modified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
