[PATCH] D97370: [clang][cli] Remove marshalling from Opt{In, Out}FFlag

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8a8e5d6240a: [clang][cli] Remove marshalling from Opt{In,Out}FFlag (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D97370?vs=326028&id=326306#toc Repository: rG LLVM Gi

[clang] d8a8e5d - [clang][cli] Remove marshalling from Opt{In, Out}FFlag

Author: Jan Svoboda Date: 2021-02-25T08:53:58+01:00 New Revision: d8a8e5d6240a1db809cd95106910358e69bbf299 URL: https://github.com/llvm/llvm-project/commit/d8a8e5d6240a1db809cd95106910358e69bbf299 DIFF: https://github.com/llvm/llvm-project/commit/d8a8e5d6240a1db809cd95106910358e69bbf299.diff L

[PATCH] D92244: [OpenCL] Prevent adding vendor extensions for all targets

AlexeySotkin accepted this revision. AlexeySotkin added a comment. This revision is now accepted and ready to land. LGTM, Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92244/new/ https://reviews.llvm.org/D92244 ___ cfe-commits mailing

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

khchen updated this revision to Diff 326310. khchen added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96843/new/ https://reviews.llvm.org/D96843 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Basic/Targets/RISC

[clang-tools-extra] b218f7c - [clangd] NFC, remove an extra "class" keyword.

Author: Haojian Wu Date: 2021-02-25T09:32:36+01:00 New Revision: b218f7c4baada3d22bf22bd3ca6e849bb2ce9289 URL: https://github.com/llvm/llvm-project/commit/b218f7c4baada3d22bf22bd3ca6e849bb2ce9289 DIFF: https://github.com/llvm/llvm-project/commit/b218f7c4baada3d22bf22bd3ca6e849bb2ce9289.diff LO

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

achieveartificialintelligence updated this revision to Diff 326313. achieveartificialintelligence edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97138/new/ https://reviews.llvm.org/D97138 Files: clang/tools/driver/driver.cpp flang/tools/flang-drive

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Thanks @aganea. And I have a question that, should I use `argc` & `argv` or `argC` & `argV` in the flang part now ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97138/new/ ht

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:71 +OPENCL_EXTENSION(cl_khr_int64_extended_atomics, true, 100) +OPENCL_COREFEATURE(cl_khr_3d_image_writes, true, 100, OCL_C_20) Anastasia wrote: > azabaznov wrote: > > A

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

nullptr.cpp updated this revision to Diff 326320. nullptr.cpp retitled this revision from "[clang-tidy] Add misc-redundant-using check" to "[clang-tidy] Add readability-redundant-using check". nullptr.cpp added a comment. Modify according to suggestions Repository: rG LLVM Github Monorepo CH

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. > FYI, I would even be ok if we remove the need for enabling non-core AFAIU this can be done not for every extension to maintain backward compatibility. In this case I think https://reviews.llvm.org/D97052 can be useful. Also, I imagine that implicit type definition

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

azabaznov added a comment. I see the update regaring this functionality on github issue: https://github.com/KhronosGroup/OpenCL-Docs/issues/82#issuecomment-785496025. Is it a right way to reflect this information in`OpenCLExtensions.def`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks added a comment. In D97137#2584417 , @darwin wrote: > Hi guys, thanks for accepting the change. But I don't have commit access of > LLVM. Can someone commit it for me? Can and will do. Need the name and email for the commit. But I wil

[clang] a25e4a6 - [clang][cli] Store additional optimization remarks info

Author: Jan Svoboda Date: 2021-02-25T11:02:49+01:00 New Revision: a25e4a6da3fe43f631782b1668e0ac023f6b5848 URL: https://github.com/llvm/llvm-project/commit/a25e4a6da3fe43f631782b1668e0ac023f6b5848 DIFF: https://github.com/llvm/llvm-project/commit/a25e4a6da3fe43f631782b1668e0ac023f6b5848.diff L

[clang] d748908 - [clang][cli] Round-trip the whole CompilerInvocation

Author: Jan Svoboda Date: 2021-02-25T11:02:49+01:00 New Revision: d748908fa02b11c7840a7f03c7a52223126bdba9 URL: https://github.com/llvm/llvm-project/commit/d748908fa02b11c7840a7f03c7a52223126bdba9 DIFF: https://github.com/llvm/llvm-project/commit/d748908fa02b11c7840a7f03c7a52223126bdba9.diff L

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa25e4a6da3fe: [clang][cli] Store additional optimization remarks info (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

This revision was automatically updated to reflect the committed changes. Closed by commit rGd748908fa02b: [clang][cli] Round-trip the whole CompilerInvocation (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96280/new/ http

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

jhenderson added a comment. @ASDenysPetrov, if you run "ninja -v llvm-ar", what is the output of the line that actually builds the llvm-ar executable? That'll tell us which libraries are in use, which should hopefully point to the difference to our own environments. For example, the last line o

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. > This shows, for example, that the `libz.so` my build uses is located in > `/usr/lib/x86_64-linux-gnu`. By having your equivalent path, we can hopefully > confirm that the issue is caused by a different set of system libraries being > used. Hi, @jhenderson I cha

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal added a comment. In D96976#2585498 , @RedDocMD wrote: > @steakhal, could you please review this? The longer I stare at it the more questions I have. However, I don't know how member pointers work in the analyzer and I'm not really in the mood to

[PATCH] D97445: [clang][sema] Ignore xor-used-as-pow if both sides are macros

xbolva00 added a comment. No problem, +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97445/new/ https://reviews.llvm.org/D97445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] a54f160 - Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

Author: Harmen Stoppels Date: 2021-02-25T11:32:27+01:00 New Revision: a54f160b3a98b91cd241a555d904a6b6453affc4 URL: https://github.com/llvm/llvm-project/commit/a54f160b3a98b91cd241a555d904a6b6453affc4 DIFF: https://github.com/llvm/llvm-project/commit/a54f160b3a98b91cd241a555d904a6b6453affc4.dif

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

jhenderson added a comment. In D95246#2587123 , @ASDenysPetrov wrote: >> This shows, for example, that the `libz.so` my build uses is located in >> `/usr/lib/x86_64-linux-gnu`. By having your equivalent path, we can >> hopefully confirm that the issue i

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. @jhenderson > Thanks (for clarity, `libz` isn't what I'm looking for, it was just an > example of how this information might be useful). As it is, I think we might > need more information still - that commandline hides which files are actually > used slightly. Co

[clang-tools-extra] f0e4610 - Support standalone build of clang-tidy unittest

Author: serge-sans-paille Date: 2021-02-25T11:51:12+01:00 New Revision: f0e461057221ad334cd194211ef4fa31364054e3 URL: https://github.com/llvm/llvm-project/commit/f0e461057221ad334cd194211ef4fa31364054e3 DIFF: https://github.com/llvm/llvm-project/commit/f0e461057221ad334cd194211ef4fa31364054e3.d

[PATCH] D96788: Support standalone build of clang-tidy unittest

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e461057221: Support standalone build of clang-tidy unittest (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 _

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Thanks. I think it looks good too now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97233/new/ https://reviews.llvm.org/D97233 _

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

awarzynski created this revision. Herald added a reviewer: sscalpone. Herald added subscribers: jansvoboda11, dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds `-fdebug-dump-parsing-log` in the new driver. This option is

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

jhenderson added a comment. In D95246#2587167 , @ASDenysPetrov wrote: > @jhenderson > >> Thanks (for clarity, `libz` isn't what I'm looking for, it was just an >> example of how this information might be useful). As it is, I think we might >> need more

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

AMDChirag added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:88-95 +// Tweak the frontend configuration based on the frontend action +static void setUpFrontendBasedOnAction(FrontendOptions &opts) { + assert(opts.programAction_ != Fortran::frontend::Inva

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. @jhenderson > Sorry, but `-W --trace` is not the same as `-Wl,--trace`. The former is a > pair of options used by the compiler (one of which describes the files used > by the compiler). The latter is an option passed to the linker, and is what > we need. Please t

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:70 + // passing to the BUILTIN() macro in Builtins.def. + const std::string &builtin_str() const { return BuiltinStr; } + These method names should use CamelCase and start wi

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 326300. khchen marked 21 inline comments as done. khchen added a comment. 1. Rename Dump to Print. 2. Address Craig's comments, thanks for your patient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ h

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:270 + IsPointer(false), IsSize_t(false), IsPtrdiff_t(false), + ElementBitwidth(~0U), Scale(0) { + applyBasicType(); craig.topper wrote: > Why is ElementBitwidth default ~0

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:873 + // Dump switch body when the ir name changes from previous iteration. + RVVIntrinsic *PrevDef = Defs.begin()->get(); + for (auto &Def : Defs) { khchen wrote: > craig.t

[PATCH] D97423: Fix a test case that checks should check whether or not it is passed into lld

Conanap created this revision. Conanap added reviewers: yaxunl, PowerPC, nemanjai, saghir. Conanap added projects: LLVM, clang, PowerPC, AMDGPU. Herald added a subscriber: steven.zhang. Conanap requested review of this revision. This test case was causing a PowerPC buildbot to fail as it happened

[PATCH] D97423: Fix a test case that checks should check whether or not it is passed into lld

yaxunl added inline comments. Comment at: clang/test/Driver/hip-sanitize-options.hip:29 // CHECK-NOT: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address"}} -// CHECK-NOT: {{"[^"]*lld[^"]*".* ".*hip.bc"}} +// CHECK-NOT: {{"[^"]*lld".* ".*hip.bc"}} // CHECK: {{"[^"]*c

[PATCH] D97423: Fix a test case that checks should check whether or not it is passed into lld

yaxunl added inline comments. Comment at: clang/test/Driver/hip-sanitize-options.hip:29 // CHECK-NOT: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address"}} -// CHECK-NOT: {{"[^"]*lld[^"]*".* ".*hip.bc"}} +// CHECK-NOT: {{"[^"]*lld".* ".*hip.bc"}} // CHECK: {{"[^"]*c

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 326309. khchen added a comment. refine comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/include/clang

[PATCH] D97423: Fix a test case that checks should check whether or not it is passed into lld

Conanap updated this revision to Diff 326311. Conanap marked 2 inline comments as done. Conanap added a comment. Added .exe check for windows CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97423/new/ https://reviews.llvm.org/D97423 Files: clang/test/Driver/hip-sanitize-options.hip I

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

This revision was automatically updated to reflect the committed changes. Closed by commit rGa54f160b3a98: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk (authored by haampie, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D97423: Fix a test case that checks should check whether or not it is passed into lld

Conanap added inline comments. Comment at: clang/test/Driver/hip-sanitize-options.hip:29 // CHECK-NOT: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address"}} -// CHECK-NOT: {{"[^"]*lld[^"]*".* ".*hip.bc"}} +// CHECK-NOT: {{"[^"]*lld".* ".*hip.bc"}} // CHECK: {{"[^"]*

[PATCH] D97461: [clang][cli] Implement '-cuid=' marshalling

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds marshalling to the `-cuid=` option introd

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: mgorny. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enables cc1 argument round-trip for assert b

[PATCH] D97204: [RFC] Clang 64-bit source locations

miyuki added a comment. In D97204#2586111 , @rsmith wrote: > Thanks for doing this! > > The 8-9% memory hit is better than I'd feared, but still seems uncomfortably > large. I've left comments on a couple of places where I think we could > substantially

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

jhenderson added a comment. In D95246#2587277 , @ASDenysPetrov wrote: > @jhenderson > >> Sorry, but `-W --trace` is not the same as `-Wl,--trace`. The former is a >> pair of options used by the compiler (one of which describes the files used >> by the c

[clang] fa7eb3e - [clang][cli] NFC: Remove intermediate command line parsing functions

Author: Jan Svoboda Date: 2021-02-25T13:45:06+01:00 New Revision: fa7eb3e4a60c620b820ff6c616c678f659f4528e URL: https://github.com/llvm/llvm-project/commit/fa7eb3e4a60c620b820ff6c616c678f659f4528e DIFF: https://github.com/llvm/llvm-project/commit/fa7eb3e4a60c620b820ff6c616c678f659f4528e.diff L

[PATCH] D96323: [clang][cli] NFC: Remove intermediate command line parsing functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa7eb3e4a60c: [clang][cli] NFC: Remove intermediate command line parsing functions (authored by jansvoboda11). Changed prior to commit: https://re

[clang] 0c8b26b - [clang] Remove a superfluous semicolon, silencing GCC warnings. NFC.

Author: Martin Storsjö Date: 2021-02-25T14:54:19+02:00 New Revision: 0c8b26bf530b3fc65af9205c593583f26549da3e URL: https://github.com/llvm/llvm-project/commit/0c8b26bf530b3fc65af9205c593583f26549da3e DIFF: https://github.com/llvm/llvm-project/commit/0c8b26bf530b3fc65af9205c593583f26549da3e.diff

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. @jhenderson I think I'm done. Here is output: F15648076: linker_trace_output.txt Is it OK now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D9

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.org/D94640 __

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

aaron.ballman added reviewers: rjmccall, erik.pilkington. aaron.ballman added a comment. Adding some more reviewers who know ObjC better than I do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97371/new/ https://reviews.llvm.org/D97371 __

[PATCH] D97445: [clang][sema] Ignore xor-used-as-pow if both sides are macros

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small nit, thanks! Comment at: clang/lib/Sema/SemaExpr.cpp:12105 + // Do not diagnose if both LHS and RHS are macros + if (XorLHS.get()->getExpr

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

aganea accepted this revision. aganea added a comment. In D97138#2586988 , @achieveartificialintelligence wrote: > Thanks @aganea. And I have a question that, should I use `argc` & `argv` or > `argC` & `argV` in the flang part now ? Looks good as it is

[clang] baebc11 - [clang][driver] Set the input type to Fortran when reading from stdin

Author: Andrzej Warzynski Date: 2021-02-25T13:13:42Z New Revision: baebc1162f810f7bf5de48919054f75a2f81e180 URL: https://github.com/llvm/llvm-project/commit/baebc1162f810f7bf5de48919054f75a2f81e180 DIFF: https://github.com/llvm/llvm-project/commit/baebc1162f810f7bf5de48919054f75a2f81e180.diff

[PATCH] D96777: [clang][driver] Set the input type to Fortran when reading from stdin

This revision was automatically updated to reflect the committed changes. Closed by commit rGbaebc1162f81: [clang][driver] Set the input type to Fortran when reading from stdin (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you, this is a much appreciated improvement! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97138/new/ https://reviews.llvm.org/D97138 __

[clang] ad14ccc - [clang][flang] Improve the consistency of the code-base

Author: Shao-Ce Sun Date: 2021-02-25T21:25:43+08:00 New Revision: ad14ccc8c22e1480db7bfc1a176311e6f572c588 URL: https://github.com/llvm/llvm-project/commit/ad14ccc8c22e1480db7bfc1a176311e6f572c588 DIFF: https://github.com/llvm/llvm-project/commit/ad14ccc8c22e1480db7bfc1a176311e6f572c588.diff L

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad14ccc8c22e: [clang][flang] Improve the consistency of the code-base (authored by achieveartificialintelligence). Repository: rG LLVM Github Mono

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

jhenderson added a comment. In D95246#2587410 , @ASDenysPetrov wrote: > @jhenderson > I think I'm done. > Here is output: F15648076: linker_trace_output.txt > > Is it OK now? Thanks, yes that does the trick. As I exp

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. I don't think that's dead code, but I do think it's unclear code that should be fixed. The behavior for double square bracket attributes in C++ is correct in Clang and incorrect in GCC, according to: http://eel.is/c++draft/

[PATCH] D97423: Fix a test case that checks should check whether or not it is passed into lld

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97423/new/ https://reviews.llvm.org/D97423 ___ cfe-commits mailing list cfe-co

[PATCH] D97415: [clang-tidy] Move Checkname out of Diagnostic Message

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: usaxena95, kadircet, arphaman, xazax.hun. njames93 published this revision for review. njames93 added a subscriber: NoQ. njames93 added a comment. Herald added a project: clang. Herald added a

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

ymandel added a comment. In D96224#2581501 , @njames93 wrote: > Can you take a look at https://llvm.org/PR49330, I'm guessing this patch > introduced this regression. +1 We've had to disable the check in the meantime. Repository: rG LLVM Github Monor

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

balazske added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-redundant-using.cpp:114 +// CHECK-FIXES: {{^}} +} // namespace n11 Add more tests? ``` namespace outer { namespace inner { void func(); } // namespace inner using

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD marked 2 inline comments as done. RedDocMD added a comment. Many thanks for you comments, @steakhal! I will address the issues you have pointed out in this comment. To clean things up I should perhaps add some more clarification to the summary. > Could you elaborate on what approach did

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. In D95246#2587452 , @jhenderson wrote: > In D95246#2587410 , @ASDenysPetrov > wrote: > >> @jhenderson >> I think I'm done. >> Here is output: F15648076: linker_trace_output.

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

awarzynski updated this revision to Diff 326372. awarzynski added a comment. Remove spurious comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97457/new/ https://reviews.llvm.org/D97457 Files: clang/include/clang/Driver/Options.td flang/i

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. I created the following review https://reviews.llvm.org/D97472 which I think should fix the error on all platforms. Let me know if this fixes the issue on MSYS2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D97361: [clang-tidy] Add readability-redundant-using check

njames93 added a comment. Can you override the `isLanguageVersionSupported` method to ensure this check only runs over c++ code. Can you add some macro tests, typically we err on the side of caution and don't emit any fixes for macro code. You can use `SourceLocation::IsMacroID()` to detect mac

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

sammccall added a comment. @kadircet who was doing (or planning!) some measurements around this idea. Maybe it's possible to use this patch for them? My guess about risks: - currently, preamble patching covers relatively few extra headers in practice. Here we're likely to end up with larger di

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

yaxunl abandoned this revision. yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2824 + // which is equivalent to 16 bit integer. We need this to interop with + // gcc where 16 bit integer is used in pla

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

pdhaliwal added a comment. So, neither emit-llvm-bc or emit-llvm work well with save-temps. Therefore, I feel the current approach is still valid. This does not impact nvptx or any other target in any way. And I don't see how. I see valid concern regarding assembly output. This patch will surel

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

thakis added a comment. Re test: Maybe some combination of `-ivfsoverlay` (as a `/clang:` flag I suppose) and `/winsysroot` can be used to test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97437/new/ https://reviews.llvm.org/D97437 ___

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

awarzynski marked an inline comment as done. awarzynski added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:88-95 +// Tweak the frontend configuration based on the frontend action +static void setUpFrontendBasedOnAction(FrontendOptions &opts) { + assert(

[PATCH] D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97137/new/ https://reviews.llvm.org/D97137 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

AMDChirag added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:88-95 +// Tweak the frontend configuration based on the frontend action +static void setUpFrontendBasedOnAction(FrontendOptions &opts) { + assert(opts.programAction_ != Fortran::frontend::Inva

[clang] 2cc5846 - [clang][sema] Ignore xor-used-as-pow if both sides are macros

Author: Timm Bäder Date: 2021-02-25T16:31:07+01:00 New Revision: 2cc58463caf4c8a43c2954e4206d3647c762ba30 URL: https://github.com/llvm/llvm-project/commit/2cc58463caf4c8a43c2954e4206d3647c762ba30 DIFF: https://github.com/llvm/llvm-project/commit/2cc58463caf4c8a43c2954e4206d3647c762ba30.diff LO

[PATCH] D97445: [clang][sema] Ignore xor-used-as-pow if both sides are macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cc58463caf4: [clang][sema] Ignore xor-used-as-pow if both sides are macros (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D97445?vs=326294&id=326386#toc Repository: rG LLVM

[PATCH] D97445: [clang][sema] Ignore xor-used-as-pow if both sides are macros

tbaeder added a comment. Thanks everyone! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97445/new/ https://reviews.llvm.org/D97445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] 3b7104a - Fix a test case that should check whether or not it is passed into lld

Author: Albion Fung Date: 2021-02-25T10:32:32-05:00 New Revision: 3b7104a2f2033d100aebb605c46fbe0495ea320b URL: https://github.com/llvm/llvm-project/commit/3b7104a2f2033d100aebb605c46fbe0495ea320b DIFF: https://github.com/llvm/llvm-project/commit/3b7104a2f2033d100aebb605c46fbe0495ea320b.diff L

[PATCH] D97474: [PowerPC][AIX] Enable passing vectors in variadic functions (front-end).

sfertile created this revision. sfertile added reviewers: ZarkoCA, cebowleratibm, jasonliu. sfertile added a project: PowerPC. Herald added subscribers: shchenz, nemanjai. sfertile requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

thakis added a comment. (aside: Do you know if the sysroot vs clangd stuff works on non-win? I happened to see https://bugs.llvm.org/show_bug.cgi?id=27909) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97437/new/ https://reviews.llvm.org/D97437 _

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

pdhaliwal updated this revision to Diff 326392. pdhaliwal added a comment. Add extra llc step to produce assembly in the linker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96769/new/ https://reviews.llvm.org/D96769 Files: clang/lib/Driver/Dri

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD updated this revision to Diff 326393. RedDocMD marked 2 inline comments as done. RedDocMD added a comment. Removed explicit for-loop with range-for loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D969

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added a comment. Strictly speaking I suppose that's not a temporary file, since it isn't used for anything, but whenever I pass -save-temps I am likely to want to read the assembly. This looks like a great workaround to me. @jdoerfert? Repository: rG LLVM Github Monorepo CHA

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor wording suggestion on the documentation. Comment at: clang/include/clang/Basic/AttrDocs.td:4087-4088 -Marking virtual functions as ``n

[PATCH] D97461: [clang][cli] Implement '-cuid=' marshalling

jansvoboda11 updated this revision to Diff 326397. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97461/new/ https://reviews.llvm.org/D97461 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 updated this revision to Diff 326398. jansvoboda11 added a comment. Rebase on top of D97461 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97462/new/ https://reviews.llvm.org/D97462 Files: clang/CMak

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

probinson added a comment. > GNU ld has a rule "start_/stop_ references from a live input section retain > the associated C identifier name sections", which LLD may change in the future (D96914 ). The phrasing "may change" implies LLD could eliminate the rule; i

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

hliao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2821 +} else if (k == BuiltinType::Float16 || k == BuiltinType::Half) { + // AMD64 does not support operations on _Float16 or __fp16 other than + // load and store. For load/store operations,

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

hliao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2821 +} else if (k == BuiltinType::Float16 || k == BuiltinType::Half) { + // AMD64 does not support operations on _Float16 or __fp16 other than + // load and store. For load/store operations,

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4087-4088 -Marking virtual functions as ``not_tail_called`` is an error: +Marking virtual functions as ``not_tail_called`` will not have effect on the +overriding functions of derived classes:

[clang] 502b3bf - [AMDGPU] require s-memtime-inst for __builtin_amdgcn_s_memtime

Author: Stanislav Mekhanoshin Date: 2021-02-25T08:31:59-08:00 New Revision: 502b3bfc6a713e5b6640faf48e72de08d7cb0aba URL: https://github.com/llvm/llvm-project/commit/502b3bfc6a713e5b6640faf48e72de08d7cb0aba DIFF: https://github.com/llvm/llvm-project/commit/502b3bfc6a713e5b6640faf48e72de08d7cb0a

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

yaxunl marked an inline comment as done. yaxunl added a comment. So should we revive this patch by classifying _Float16 as SSE, then it will conform to the ABI. And we should be compatible with gcc assuming it also follows the ABI. @pengfei CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD updated this revision to Diff 326410. RedDocMD added a comment. Cleaned up tests, added test above class hierarchy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 Files: clang/include/clang/Stati

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD updated this revision to Diff 326413. RedDocMD added a comment. Added test for multiple inheritance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 Files: clang/include/clang/StaticAnalyzer/Core/

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

mibintc updated this revision to Diff 326412. mibintc added a comment. I rebased the patch and basically made no other changes. On the review there's a suggestion that 'blocklist' isn't the best word choice, do you have suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD updated this revision to Diff 326414. RedDocMD added a comment. Added some more comments to increase clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 Files: clang/include/clang/StaticAnaly

[PATCH] D97415: [clang-tidy] Move Checkname out of Diagnostic Message

njames93 updated this revision to Diff 326418. njames93 marked an inline comment as done. njames93 added a comment. Typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97415/new/ https://reviews.llvm.org/D97415 Files: clang-tools-extra/clang-tid

  1   2   3   >