Conanap added inline comments.
================ Comment at: clang/test/Driver/hip-sanitize-options.hip:29 // CHECK-NOT: {{"[^"]*clang[^"]*".* "-fcuda-is-device".* "-fsanitize=address"}} -// CHECK-NOT: {{"[^"]*lld[^"]*".* ".*hip.bc"}} +// CHECK-NOT: {{"[^"]*lld".* ".*hip.bc"}} // CHECK: {{"[^"]*clang[^"]*".* "-triple" "x86_64-unknown-linux-gnu".* "-fsanitize=address"}} ---------------- yaxunl wrote: > yaxunl wrote: > > this may fail on windows since lld becomes lld.exe > may be change to > > > ``` > {{"[^"]*lld[^"]*".* "-plugin-opt=.* ".*hip.bc"}} > ``` > > similar as below Should be fixed now CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97423/new/ https://reviews.llvm.org/D97423 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits