[PATCH] D96347: Include function return type in JSON AST dumps.

rokups added a comment. This seems to not be good enough, however. Somehow desugared version of type is not added anywhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96347/new/ https://reviews.llvm.org/D96347 _

[clang] df1a17c - [clang-check] Add tokens-dump in clang-check.

Author: Haojian Wu Date: 2021-02-11T09:40:47+01:00 New Revision: df1a17c219c073427f9d00eb042057bb3a4a3c64 URL: https://github.com/llvm/llvm-project/commit/df1a17c219c073427f9d00eb042057bb3a4a3c64 DIFF: https://github.com/llvm/llvm-project/commit/df1a17c219c073427f9d00eb042057bb3a4a3c64.diff LO

[PATCH] D96017: [clang-check] Add tokens-dump in clang-check.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf1a17c219c0: [clang-check] Add tokens-dump in clang-check. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

vsavchenko added a comment. Great job! I'd like to see more tests with the following cases: - more expressions with function calls - ternary expression, arithmetic, array literals, initializer lists, etc. - using/not using it in `if` statement with initializer - using/not using it in different p

[clang] 35a5e88 - [Syntax] NFC, Simplify a test with annotations

Author: Haojian Wu Date: 2021-02-11T09:49:06+01:00 New Revision: 35a5e883906f11b63b60574d8737791448dd478f URL: https://github.com/llvm/llvm-project/commit/35a5e883906f11b63b60574d8737791448dd478f DIFF: https://github.com/llvm/llvm-project/commit/35a5e883906f11b63b60574d8737791448dd478f.diff LO

[clang] e159a3c - [Syntax] Remove a strict valid source location assertion for TypeLoc.

Author: Haojian Wu Date: 2021-02-11T09:53:52+01:00 New Revision: e159a3ced4c54b539c165b1cc26424fa0b34d53e URL: https://github.com/llvm/llvm-project/commit/e159a3ced4c54b539c165b1cc26424fa0b34d53e DIFF: https://github.com/llvm/llvm-project/commit/e159a3ced4c54b539c165b1cc26424fa0b34d53e.diff LO

[PATCH] D96261: [Syntax] Remove a strict valid source location assertion for TypeLoc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe159a3ced4c5: [Syntax] Remove a strict valid source location assertion for TypeLoc. (authored by hokein). Repository: rG LLVM Github Monorepo CHA

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Driver/arm-target-as-mimplicit-it.s:26 +/// assembler flag appearing last (latter wins). +// RUN: %clang -target arm-linux-gnueabi -

[clang] 0b44885 - [OpenCL] Add cl_khr_subgroup_extended_types to TableGen BIFs

Author: Sven van Haastregt Date: 2021-02-11T09:32:42Z New Revision: 0b448854daffd57869254089ebb1bf69e8449823 URL: https://github.com/llvm/llvm-project/commit/0b448854daffd57869254089ebb1bf69e8449823 DIFF: https://github.com/llvm/llvm-project/commit/0b448854daffd57869254089ebb1bf69e8449823.diff

[PATCH] D96279: [OpenCL] Add cl_khr_subgroup_extended_types to TableGen BIFs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b448854daff: [OpenCL] Add cl_khr_subgroup_extended_types to TableGen BIFs (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 322921. massberg added a comment. Clarified option FlagBasicIncrements and removed base default constructor from class initializer list of FunctionASTVisitor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9628

[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

usaxena95 updated this revision to Diff 322922. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96353/new/ https://reviews.llvm.org/D96353 Files: clang-tool

[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:651 + auto Results = + completions("int main() { abs^ }", {func("absl"), func("absb")}); EXPECT_THAT(Results.Completions, hokein wrote: > sorry, I didn'

[PATCH] D96481: [NFC] Extract function which registers sanitizer passes

vitalybuka created this revision. vitalybuka added reviewers: aeubanks, tejohnson. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96481 Files: clang/lib/CodeGen

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka updated this revision to Diff 322924. vitalybuka marked an inline comment as done. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/Ba

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:230 + explicit FunctionASTVisitor(const bool IgnoreMacros) + : RecursiveASTVisitor(),

[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. maybe add some data (improvement DecisionForest vs heuristic) in the patch description. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:651 + auto Resu

[PATCH] D96376: [CodeComplete] Member completion: heuristically resolve some dependent base exprs

sammccall added inline comments. Comment at: clang/test/CodeCompletion/member-access.cpp:88 + TemplateClass &relatedField; + BaseTemplate &relatedFunction(); + hokein wrote: > hmm, inserting new code here will shift all offsets of below code, I would > append

[clang] 5c55d37 - [CodeComplete] Member completion: heuristically resolve some dependent base exprs

Author: Sam McCall Date: 2021-02-11T11:03:40+01:00 New Revision: 5c55d3747b0cab17aaa07729cf90a49dbda71bbe URL: https://github.com/llvm/llvm-project/commit/5c55d3747b0cab17aaa07729cf90a49dbda71bbe DIFF: https://github.com/llvm/llvm-project/commit/5c55d3747b0cab17aaa07729cf90a49dbda71bbe.diff LO

[PATCH] D96376: [CodeComplete] Member completion: heuristically resolve some dependent base exprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c55d3747b0c: [CodeComplete] Member completion: heuristically resolve some dependent base… (authored by sammccall). Repository: rG LLVM Github Mon

[PATCH] D96262: [clang][index] report references from unreslovedLookupExpr.

hokein updated this revision to Diff 322927. hokein added a comment. address comment, add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96262/new/ https://reviews.llvm.org/D96262 Files: clang-tools-extra/clangd/unittests/XRefsTests.c

[clang] 6c47eaf - [clang][index] report references from unreslovedLookupExpr.

Author: Haojian Wu Date: 2021-02-11T11:08:26+01:00 New Revision: 6c47eafb3973a8e3f7455c9655ed666883e7b513 URL: https://github.com/llvm/llvm-project/commit/6c47eafb3973a8e3f7455c9655ed666883e7b513 DIFF: https://github.com/llvm/llvm-project/commit/6c47eafb3973a8e3f7455c9655ed666883e7b513.diff LO

[PATCH] D96262: [clang][index] report references from unreslovedLookupExpr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG6c47eafb3973: [clang][index] report references from unreslovedLookupExpr. (authored by hokein). Repository:

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

dmgreen added a comment. This makes sense to me. If the user specifies the pragma then we send that through to the vectorizer, whatever it is. As much as `vectorize_width(1) interleave_count(4) vectorize_predicate(enable)` doesn't make a lot of sense, it's still something that should work. And

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

Anastasia added a comment. > Do I understand correctly that this means void pointer is not necessarily > points to generic AS? This is an internal Clang pointer type that is used in very few places as a pointer to anything, so it makes sense to add generic. I agree this change actually fixes a

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

malharJ added inline comments. Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:88 + +#pragma clang loop vectorize_predicate(enable) vectorize_width(1) + for (int i = 0; i < Length; i++) dmgreen wrote: > Can you add another test for `#pragma clang loo

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

Anastasia added a comment. PS, I will create a PR to follow up on the issue I have discovered. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96178/new/ https://reviews.llvm.org/D96178 ___ cfe-commits mai

[PATCH] D96483: [flang][driver] Add options for unparsing

awarzynski created this revision. Herald added subscribers: dang, mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: jansvoboda11. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds the following co

[PATCH] D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes

ASDenysPetrov added inline comments. Comment at: clang/docs/ReleaseNotes.rst:453 + equal or known to be non-equal. + +- Added :ref:`on-demand parsing ` capability to Cross Translation Szelethus wrote: > ASDenysPetrov wrote: > > I've added the patch "Reasoning a

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka updated this revision to Diff 322934. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-di

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1549 + Conf.OptPassBuilderHook = [&](PassBuilder &PB) { +addSanitizers(TargetTriple, CGOpts, LOpts, PB); + }; tejohnson wrote: > I can't find where this is defined. to avoid noi

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka updated this revision to Diff 322935. vitalybuka added a comment. new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn added a comment. In D96419#213 , @xbolva00 wrote: > Maybe we want these options in llvm 12 as well? > > (+ Release note) That's a good idea. The patch currently depends on D96418 . Not sure if we should pull tha

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

xbolva00 added a comment. In D96419#2556349 , @fhahn wrote: > In D96419#213 , @xbolva00 wrote: > >> Maybe we want these options in llvm 12 as well? >> >> (+ Release note) > > That's a good idea. The patch curren

[PATCH] D96487: Restore diagnostic handler after CodeGenAction::ExecuteAction

mantognini created this revision. Herald added a subscriber: dexonsmith. mantognini published this revision for review. mantognini added inline comments. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Comment at: llvm/include/llvm/IR/LLVM

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 322899. guiand added a comment. Updated to use -enable-noundef-analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/include/clang/Basic/CodeGenOptions

[PATCH] [clang-tidy] ensure run-clang-tidy reports children killed by signals

If a clang-tidy child process exits with a signal then run-clang-tidy will exit with an error but there is no hint why in the output, since the clang-tidy doesn't log anything and may not even have had the opportunity to do so depending on the signal used. `subprocess.CompletedProcess.returncode`

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:523 return getLangOpts().C11 || getLangOpts().C17 || getLangOpts().C2x; } jdoerfert wrote: > fhahn wrote: > > jdoerfert wrote: > > > Can you modify the documentation to

[clang] 81bc136 - Correct swift_bridge duplicate attribute warning logic

Author: Aaron Ballman Date: 2021-02-11T07:11:27-05:00 New Revision: 81bc1365d8f85a125a6db6a5a1acff3ceddcbe9e URL: https://github.com/llvm/llvm-project/commit/81bc1365d8f85a125a6db6a5a1acff3ceddcbe9e DIFF: https://github.com/llvm/llvm-project/commit/81bc1365d8f85a125a6db6a5a1acff3ceddcbe9e.diff

[PATCH] D96130: Correct swift_bridge duplicate attribute warning logic

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review! I've committed in 81bc1365d8f85a125a6db6a5a1acff3ceddcbe9e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:523 return getLangOpts().C11 || getLangOpts().C17 || getLangOpts().C2x; } aaron.ballman wrote: > jdoerfert wrote: > > fhahn wrote: > > > jdoerfert wrote: > > > > Can you modify

[PATCH] D94779: [Clang] Ensure vector predication pragma is ignored only when vectorization width is 1.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. OK Thanks. LGTM Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:88 + +#pragma clang loop vectorize_predicate(enable) vectorize_width(1) + for (int i = 0; i < L

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:523 return getLangOpts().C11 || getLangOpts().C17 || getLangOpts().C2x; } fhahn wrote: > aaron.ballman wrote: > > jdoerfert wrote: > > > fhahn wrote: > > > > jdoerfert

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

curdeius added a comment. Almost there. I hope I'm clear this time on what I'd like to see. Thanks for the release notes update. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1162 + + EXPECT_EQ(DefaultUnwrappedLines, Style.ShortNamespaceLines); + EXPECT

[clang] 3a29ac2 - [OpenCL] Fix missing const attributes for get_image_ builtins

Author: Sven van Haastregt Date: 2021-02-11T13:05:26Z New Revision: 3a29ac2a61f78aae049a46369203757ece315e23 URL: https://github.com/llvm/llvm-project/commit/3a29ac2a61f78aae049a46369203757ece315e23 DIFF: https://github.com/llvm/llvm-project/commit/3a29ac2a61f78aae049a46369203757ece315e23.diff

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. In D92808#2555868 , @ahatanak wrote: > In D92808#2555737 , @dexonsmith > wrote: > >> In D92808#2552354 , @rjmccall wrote: >> >>> The ultimate code-g

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

njames93 added a comment. How does this handle a macro where the argument has complex code. MACRO(if (...) {}); In this case the macro code is definitely increasing the complexity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96281/new/ https:

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @haowei @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing

[clang] 81a9707 - [Attr] Apply GNU-style attributes to expression statements

Author: Valeriy Savchenko Date: 2021-02-11T16:44:41+03:00 New Revision: 81a9707723845a5b880245da24633c519493205c URL: https://github.com/llvm/llvm-project/commit/81a9707723845a5b880245da24633c519493205c DIFF: https://github.com/llvm/llvm-project/commit/81a9707723845a5b880245da24633c519493205c.d

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

This revision was automatically updated to reflect the committed changes. Closed by commit rG81a970772384: [Attr] Apply GNU-style attributes to expression statements (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93630/new/

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp:22 +/* C++ std */ +"::std::async", // + aaron.ballman wrote: > The trailing comment markers don't really add much. it's a hack for clang-format,

[PATCH] D96495: [clangd] Retire the cross-file-rename command-line flag.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. This patch only focuses on the flag. Removing actual

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh updated this revision to Diff 322970. abidh added a comment. Changes in this version. 1. Added an explicit --sysroot argument. 2. Shortened "testroot-riscv{len}-baremetal-nogcc" string As pointed out by @MaskRay that some tests were failing when gcc-10-riscv64-linux-gnu was installed. Th

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp:22 +/* C++ std */ +"::std::async", // + segoon wrote: > aaron.ballman wrote: > > The trailing comment markers don't really add much. > it

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

NoQ added a comment. > but it is planned that the checker takes use of the planned new attributes to > determine if a function should be checked This is literally `__attribute__((warn_unused_result))` for which there already is a compiler warning. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

malharJ added inline comments. Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:88 + +#pragma clang loop vectorize_predicate(enable) vectorize_width(1) + for (int i = 0; i < Length; i++) dmgreen wrote: > malharJ wrote: > > dmgreen wrote: > > > Can you

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Can you please merge the tests into one file. There is no compelling reason to split them up and it is more difficult to review and make sense of what is going on. The test case

[PATCH] D96495: [clangd] Retire the cross-file-rename command-line flag.

njames93 added a comment. Those test failures look related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96495/new/ https://reviews.llvm.org/D96495 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

malharJ added a comment. I do not have commit access. Can someone with commit access please commit this patch ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94779/new/ https://reviews.llvm.org/D94779 _

[clang] 059a335 - Store the calculated constant expression value into the ConstantExpr object

Author: Aaron Ballman Date: 2021-02-11T10:18:16-05:00 New Revision: 059a335ee99e9c50442d8caa35c1b31b5cf47e9c URL: https://github.com/llvm/llvm-project/commit/059a335ee99e9c50442d8caa35c1b31b5cf47e9c DIFF: https://github.com/llvm/llvm-project/commit/059a335ee99e9c50442d8caa35c1b31b5cf47e9c.diff

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

Conanap updated this revision to Diff 323000. Conanap marked 6 inline comments as done. Conanap added a comment. Fixed up a few comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94627/new/ https://reviews.llvm.org/D94627 Files: lld/ELF/Config.h lld/ELF/Driver.cpp lld/ELF/Opt

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

curdeius added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/concurrency-async-no-new-threads.rst:14 + + The check doesn't identify synchronous and asynchronous code. Insead, it + assumes that all analyzed code is asynchronous and all blocking calls h

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn updated this revision to Diff 323003. fhahn added a comment. Add reference to standards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96418/new/ https://reviews.llvm.org/D96418 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CodeG

[PATCH] D96507: [clangd] Move command handlers into a map in ClangdLSPServer. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgrang. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Mono

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp:22 +/* C++ std */ +"::std::async", // + aaron.ballman wrote: > segoon wrote: > > aaron.ballman wrote: > > > The trailing comment markers don't r

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon updated this revision to Diff 323006. segoon added a comment. - add WinAPI support CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 Files: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp clang-tools-extra/clang-tidy

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon updated this revision to Diff 323008. segoon added a comment. -fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 Files: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp clang-tools-extra/clang-tidy/concurrenc

[PATCH] D96508: [clangd] Retire clang-tidy-checks flag.

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. In clangd-12 the ability to overr

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

JonChesterfield added a comment. Parameter to err_drv_omp_offload_target_missingbcruntime is sensible. @tianshilei1992? With this we can set the path for nvptx and amdgcn independently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96248/new/ htt

[PATCH] D96512: [PowerPC] Add option for ROP Protection

stefanp created this revision. stefanp added reviewers: lei, nemanjai. Herald added subscribers: dang, shchenz, kbarton, hiraditya. Herald added a reviewer: jansvoboda11. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Added -m

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman marked 2 inline comments as not done. aaron.ballman added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D93223: [analyzer] Create MacroExpansionContext member in AnalysisConsumer

steakhal updated this revision to Diff 323024. steakhal added a comment. Nothing changed. Rebased on top of 2407eb08a5748bc2613e95fa449fc1cae6f4ff8f . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93223/new/ https://r

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

steakhal updated this revision to Diff 323025. steakhal added a comment. Actually, somehow I messed up something previously. Now, the diff contains the latest version. Sorry for the inconvenience! Rebased on top of 2407eb08a5748bc2613e95fa449fc1cae6f4ff8f

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. Another thing I noticed that there's verifier support missing. I think we should at least check that only a single `clang.arc.rv` bundle is specified (https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/Verifier.cpp#L3191). We should probably also enforce that the

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia created this revision. Anastasia added reviewers: svenvh, arsenm. Herald added subscribers: dang, ebevhan, yaxunl. Herald added a reviewer: jansvoboda11. Anastasia requested review of this revision. Herald added a subscriber: wdng. See original RFC: https://lists.llvm.org/pipermail/cfe-

[PATCH] D96483: [flang][driver] Add options for unparsing

tskeith added inline comments. Comment at: flang/tools/f18/f18.cpp:541 driver.debugNoSemantics = true; -} else if (arg == "-funparse") { +} else if (arg == "-funparse" || arg == "-fdebug_unparse") { driver.dumpUnparse = true; This should be

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. The new review: https://reviews.llvm.org/D96515 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78979/new/ https://reviews.llvm.org/D78979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1066 PassBuilder::OptimizationLevel Level) { +if (CodeGenOpts.OptimizationLevel == 0) { + if (!CodeGenOpts.ThinLTOIndexFile.empty())

[PATCH] D95536: [clang][sema] Note decl location on missing member

aaron.ballman added a comment. In D95536#2553325 , @tbaeder wrote: > In D95536#2552258 , @aaron.ballman > wrote: > >> In D95536#2551332 , @tbaeder wrote: >> >>> Any update o

[clang-tools-extra] 7e3b9ab - [Timer] On macOS count number of executed instructions

Author: Alex Hoppen Date: 2021-02-11T17:26:37+01:00 New Revision: 7e3b9aba609f7f6c944baa319f0a61041ccdc707 URL: https://github.com/llvm/llvm-project/commit/7e3b9aba609f7f6c944baa319f0a61041ccdc707 DIFF: https://github.com/llvm/llvm-project/commit/7e3b9aba609f7f6c944baa319f0a61041ccdc707.diff L

[PATCH] D96049: [Timer] On macOS count number of executed instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e3b9aba609f: [Timer] On macOS count number of executed instructions (authored by ahoppen, committed by teemperor). Repository: rG LLVM Github Mon

[PATCH] D96049: [Timer] On macOS count number of executed instructions

thakis added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:356 +#cmakedefine HAVE_PROC_PID_RUSAGE 1 + Any reason to use `#cmakedefine` instead of `cmakedefine01` here? This type of check usually uses `#cmakedefine01` in this file. Repo

[PATCH] D96049: [Timer] On macOS count number of executed instructions

thakis added inline comments. Comment at: llvm/CMakeLists.txt:656 + list(APPEND CMAKE_REQUIRED_LIBRARIES proc) +endif() + also, any reason to not do this in `llvm/cmake/config-ix.cmake` where all the other checks like this are? Repository: rG LLVM Github Mo

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh updated this revision to Diff 323040. svenvh added a comment. Add test for new diagnostic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96051/new/ https://reviews.llvm.org/D96051 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/OpenCLBuiltins.td clan

[PATCH] D96049: [Timer] On macOS count number of executed instructions

thakis added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:356 +#cmakedefine HAVE_PROC_PID_RUSAGE 1 + thakis wrote: > Any reason to use `#cmakedefine` instead of `cmakedefine01` here? This type > of check usually uses `#cmakedefine01` in

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. Thanks for the review (here and D96304 )! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96285/new/ https://reviews.llvm.org/D96285

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Meinersbur added a comment. In D94779#2556274 , @dmgreen wrote: > This makes sense to me. If the user specifies the pragma then we send that > through to the vectorizer, whatever it is. As much as `vectorize_width(1) > interleave_count(4) vectorize_predi

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Meinersbur added a comment. To illustrate how complicated interpreting the vectorize pragma has become in the mid-end: TransformationMode llvm::hasVectorizeTransformation(Loop *L) { Optional Enable = getOptionalBoolLoopAttribute(L, "llvm.loop.vectorize.enable"); if (Enable =

[PATCH] D96519: [Clang][OpenMP] Fixed an issue that `target team` is emitted incorrectly

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, JonChesterfield, ABataev, grokos. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patc

[PATCH] D50106: [libc++] Fix tuple assignment from types derived from a tuple-like

ldionne updated this revision to Diff 323047. ldionne added a comment. Fix segfault on GCC and a few incorrect checks in the type traits. I reduced the GCC segfault and it appears to have been fixed on GCC trunk, so I won't be filing a bug report. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 323052. massberg marked 2 inline comments as done. massberg added a comment. Add test cases showing that when IgnoreMacros is set to 'true', also macro arguments are ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov added a comment. Hi, guys! Does anyone can review this item, except @steakhal (thanks him)? Please, look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90157/new/ https://reviews.llvm.org/D90157 ___ cfe-commits mailing list cfe-

[PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova updated this revision to Diff 323053. stella.stamenova edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96427/new/ https://reviews.llvm.org/D96427 Files: clang/test/Unit/lit.site.cfg.py.in lld/t

[PATCH] D96483: [flang][driver] Add options for unparsing

awarzynski updated this revision to Diff 323054. awarzynski added a comment. Fix typo in f18.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96483/new/ https://reviews.llvm.org/D96483 Files: clang/include/clang/Driver/Options.td flang/includ

[clang] ed98676 - Support multi-configuration generators correctly in several config files

Author: Stella Stamenova Date: 2021-02-11T09:32:20-08:00 New Revision: ed98676fa4833bb80632fc7c9db10c3328d78485 URL: https://github.com/llvm/llvm-project/commit/ed98676fa4833bb80632fc7c9db10c3328d78485 DIFF: https://github.com/llvm/llvm-project/commit/ed98676fa4833bb80632fc7c9db10c3328d78485.di

[PATCH] D96427: Support multi-configuration generators correctly in several config files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed98676fa483: Support multi-configuration generators correctly in several config files (authored by stella.stamenova). Repository: rG LLVM Github

[PATCH] D96483: [flang][driver] Add options for unparsing

awarzynski added inline comments. Comment at: flang/tools/f18/f18.cpp:541 driver.debugNoSemantics = true; -} else if (arg == "-funparse") { +} else if (arg == "-funparse" || arg == "-fdebug_unparse") { driver.dumpUnparse = true; tskeith wrot

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

steakhal added a comment. In D96090#2551664 , @ASDenysPetrov wrote: > Updated. Unlinked parent revision D95799 > from the stack. Made corresponding changes in this patch. > @steakhal I did it. The changes should be safer

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp:41 +/* WinAPI */ +"CreateThread", // +"CreateRemoteThread", // Missing the `::` in front of all of these identifiers. ===

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg added a comment. In D96281#2556586 , @njames93 wrote: > How does this handle a macro where the argument has complex code. > > MACRO(if (...) {}); I agree that macro arguments should account to the complexity. However, with this change macro

  1   2   >