dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
OK Thanks. LGTM
================
Comment at: clang/test/CodeGenCXX/pragma-loop-predicate.cpp:88
+
+#pragma clang loop vectorize_predicate(enable) vectorize_width(1)
+ for (int i = 0; i < Length; i++)
----------------
malharJ wrote:
> dmgreen wrote:
> > Can you add another test for `#pragma clang loop vectorize(disable)
> > vectorize_predicate(enable)`. My understanding is that it will produce the
> > same as `vectorize_predicate(enable) vectorize_width(1)`
> I believe test5( ) above takes care of this ?
>
> comparing the output of the two (test8 and test5), test8 produces an extra
> metadata :
>
> ```
> {!"llvm.loop.vectorize.scalable.enable", i1 false}
> ```
>
Oh yeah. I didn't see the existing checks. Strange that it would not emit
scalable then, but still doing the expected thing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94779/new/
https://reviews.llvm.org/D94779
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
