[PATCH] D96439: [clangd][WIP] Introduce DiagnosticAugmentationModule

kadircet added a comment. Note that this doesn't handle the execution yet, it is mostly to demonstrate the idea and to get some early feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96439/new/ https://reviews.llvm.org/D96439 _

[PATCH] D96244: [clangd] Introduce Modules

kadircet updated this revision to Diff 322754. kadircet added a comment. - Changes to propagate moduleset into clangd(lsp)server Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96244/new/ https://reviews.llvm.org/D96244 Files: clang-tools-extra/cl

[PATCH] D96439: [clangd][WIP] Introduce DiagnosticAugmentationModule

kadircet updated this revision to Diff 322755. kadircet added a comment. - Integrate with parseinputs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96439/new/ https://reviews.llvm.org/D96439 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/concurrency/AsyncNoNewThreadsCheck.cpp:22 +/* C++ std */ +"::std::async", // + The trailing comment markers don't really add much. Comment at: clang-tools-e

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn updated this revision to Diff 322791. fhahn added a comment. Herald added a subscriber: jfb. Document reasoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96418/new/ https://reviews.llvm.org/D96418 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:523 return getLangOpts().C11 || getLangOpts().C17 || getLangOpts().C2x; } jdoerfert wrote: > Can you modify the documentation to talk about what loops must make progress, > th

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

sammccall updated this revision to Diff 322802. sammccall added a comment. Rebase, now the feature parity stuff is in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95576/new/ https://reviews.llvm.org/D95576 Files: clang-tools-extra/clangd/Clangd

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 322803. fhahn added a comment. adjust naming of enum members as suggested, thanks! I think it cannot be an enum class unfortunately because the CodeGenOption machinery seems to use regular enums/unsigneds. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 4dc8365 - [clangd] Remove support for pre-standard semanticHighlighting notification

Author: Sam McCall Date: 2021-02-10T22:09:03+01:00 New Revision: 4dc8365f80823d8042ba4bdc3278de7a42619c24 URL: https://github.com/llvm/llvm-project/commit/4dc8365f80823d8042ba4bdc3278de7a42619c24 DIFF: https://github.com/llvm/llvm-project/commit/4dc8365f80823d8042ba4bdc3278de7a42619c24.diff LO

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dc8365f8082: [clangd] Remove support for pre-standard semanticHighlighting notification (authored by sammccall). Changed prior to commit: https:/

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:147 +No = 2, // No loop is assumed to be finite. + }; + jdoerfert wrote: > Can we have different names? > > `FiniteLoopsKind::None` sounds more like what ``FiniteLoopsKind

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers updated this revision to Diff 322807. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - reorder test checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96285/new/ https://reviews.llvm.org/D96285

[clang-tools-extra] bda5e57 - [clangd] Remove redundant -fno-delayed-template-parsing in tests. NFCI

Author: Sam McCall Date: 2021-02-10T22:20:23+01:00 New Revision: bda5e57742237dc38350e59892cf4220ae0de486 URL: https://github.com/llvm/llvm-project/commit/bda5e57742237dc38350e59892cf4220ae0de486 DIFF: https://github.com/llvm/llvm-project/commit/bda5e57742237dc38350e59892cf4220ae0de486.diff LO

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

nickdesaulniers added inline comments. Comment at: clang/test/Driver/arm-target-as-mimplicit-it.s:26 +/// assembler flag appearing last (latter wins). +// RUN: %clang -target arm-linux-gnueabi -### -mimplicit-it=never -Wa,-mimplicit-it=always %S/Inputs/wildcard1.c 2>&1 | FileChe

[PATCH] D96427: Support multi-configuration generators correctly in several config files

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. I'm surprised the `dsymutil` one slipped through the cracks, we have a bot that should (?) be testing this configuration: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ Repository: rG LLVM Github M

[clang] 228f00b - [NFC] Simplify test

Author: Vitaly Buka Date: 2021-02-10T13:57:36-08:00 New Revision: 228f00bd75d953545eb2492156d776fdac211a24 URL: https://github.com/llvm/llvm-project/commit/228f00bd75d953545eb2492156d776fdac211a24 DIFF: https://github.com/llvm/llvm-project/commit/228f00bd75d953545eb2492156d776fdac211a24.diff L

[clang] b6051f5 - [Clang, NewPM] Add KMSan support

Author: Vitaly Buka Date: 2021-02-10T14:07:49-08:00 New Revision: b6051f52acf5e735478dba87da9a7657bdc249f9 URL: https://github.com/llvm/llvm-project/commit/b6051f52acf5e735478dba87da9a7657bdc249f9 DIFF: https://github.com/llvm/llvm-project/commit/b6051f52acf5e735478dba87da9a7657bdc249f9.diff L

[PATCH] D96328: [Clang, NewPM] Add KMSan support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6051f52acf5: [Clang, NewPM] Add KMSan support (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D96328?vs=322643&id=322

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sbc100 added a comment. Why not just use crt1.o in both cases?If you are going to prefer crt1-command.o in all cases then a toolchain would have no reason to ever ship crt1.o would it? (since it would always be ignored?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D96456: [ThinLTO] Add Config::OptPassBuilderHook

vitalybuka created this revision. Herald added subscribers: steven_wu, hiraditya, inglorion. vitalybuka requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang needs to register sanitizer at OptimizerLastEPCallback. Nowever

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

vitalybuka added a comment. Test will follow if you agree with approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456 ___ cfe-commits mailing list cfe-commits@

[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

jdoerfert added a comment. Seems reasonable to me and makes things simpler. @atmnpatel Any thoughts? Comment at: clang/lib/CodeGen/CodeGenFunction.h:523 return getLangOpts().C11 || getLangOpts().C17 || getLangOpts().C2x; } fhahn wrote: > jdoerfert wro

[PATCH] D96320: [ThinLTO, Sanitizers] Skip instrumentation by testing backend

vitalybuka added a comment. In D96320#2554493 , @aeubanks wrote: > This seems like the wrong fix to me. > ThinLTO only runs the simplification pipeline pre-link, then runs it again > plus the optimization pipeline. The optimization pipeline is the only pl

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 ___

[PATCH] D96130: Correct swift_bridge duplicate attribute warning logic

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96130/new/ https://reviews.llvm.org/D96130 __

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sunfish added a comment. It's to ensure that older LLVM works with newer WASI libc, and newer clang works with older WASI libc. New-style commands require [lld support]. We can assume that if clang is updated, lld has the requisite support. That said, I'm open to other ideas here. [lld support

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

xbolva00 added a comment. Maybe we want these options in llvm 12 as well? (+ Release note) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D96419 ___ cfe-commits mailin

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1549 + Conf.OptPassBuilderHook = [&](PassBuilder &PB) { +addSanitizers(TargetTriple, CGOpts, LOpts, PB); + }; I can't find where this is defined. Comment at: l

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sbc100 added a comment. In D89274#211 , @sunfish wrote: > It's to ensure that older LLVM works with newer WASI libc, and newer clang > works with older WASI libc. New-style commands require [lld support]. We can > assume that if clang is updated, lld

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

dexonsmith added a comment. In D92808#2552354 , @rjmccall wrote: > The ultimate code-generation consequences of this feature aren't very > generic, so we shouldn't let ourselves get caught up designing an extremely > general feature that ultimately eithe

[PATCH] D89274: [WebAssembly] Use the new crt1-command.o if present.

sunfish added a comment. I don't see a way to do this with weak symbols, and an install script would be yet-another moving part that we'd have to make on end-user systems. How about this: once we reach a point where we don't support the old LLVM anymore, libc can make crt1.o be the same as crt1

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

MaskRay added a comment. In D96203#2548529 , @echristo wrote: > In D96203#2548495 , @aaron.ballman > wrote: > >> In D96203#2548471 , @mibintc wrote: >> >>> In D96203#2546856

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 322867. ahatanak added a comment. Fix two bugs which were discovered. - Fix bug in `replaceUsesOfNonProtoConstant`. - Teach SCCP not to replace the return of a "clang.arc.rv" call with a constant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[libunwind] 77fecc0 - [NFC][libunbind] Fix Sphinx error during CMake invocation

Author: xgupta Date: 2021-02-11T06:52:24+05:30 New Revision: 77fecc07955f51db3f184ba10d3f5fcd1f3f152d URL: https://github.com/llvm/llvm-project/commit/77fecc07955f51db3f184ba10d3f5fcd1f3f152d DIFF: https://github.com/llvm/llvm-project/commit/77fecc07955f51db3f184ba10d3f5fcd1f3f152d.diff LOG: [

[PATCH] D93023: Replace deprecated %T in 2 tests.

MaskRay added a comment. Ping @abidh Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93023/new/ https://reviews.llvm.org/D93023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak reopened this revision. ahatanak added a comment. This revision is now accepted and ready to land. In D92808#2555737 , @dexonsmith wrote: > In D92808#2552354 , @rjmccall wrote: > >> The ultimate code-genera

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry updated this revision to Diff 322880. kuzkry added a comment. Sorted code alphabetically as suggested by @HazardyKnusperkeks and applied almost all fixes proposed by @curdeius (entry in release notes + some changes in unit tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 3 inline comments as done. kuzkry added a comment. In D87587#2552232 , @HazardyKnusperkeks wrote: > Apart from my comments, this looks good to me and I really wonder why it > hasn't been pushed. (I would directly use it!) I don't know, may

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 3 inline comments as done. kuzkry added a comment. In D87587#2552314 , @curdeius wrote: > Please regroup tests and add release notes. Regroup tests - by that I think you meant all your 4 remarks about the tests. So I've done 3/4 :D Release

[clang] 2407eb0 - [analyzer] Update static analyzer to be support sarif-html

Author: Daniel Hwang Date: 2021-02-10T18:34:53-08:00 New Revision: 2407eb08a5748bc2613e95fa449fc1cae6f4ff8f URL: https://github.com/llvm/llvm-project/commit/2407eb08a5748bc2613e95fa449fc1cae6f4ff8f DIFF: https://github.com/llvm/llvm-project/commit/2407eb08a5748bc2613e95fa449fc1cae6f4ff8f.diff

[PATCH] D96389: [analyzer] Update static analyzer to be support sarif-html

This revision was automatically updated to reflect the committed changes. Closed by commit rG2407eb08a574: [analyzer] Update static analyzer to be support sarif-html (authored by Daniel Hwang , committed by haowei). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D96478: [clang][cli] Fix gcc warning (NFC)

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC warning: /llvm-project/clang/lib/Frontend/TestModuleFileExtension.cpp:131:20: warning: ‘llvm::raw_ostream& clang::operator<<(llvm::raw_os

[PATCH] D96478: [clang][cli] Fix gcc warning (NFC)

nullptr.cpp updated this revision to Diff 322896. nullptr.cpp added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96478/new/ https://reviews.llvm.org/D96478 Files: clang/lib/Frontend/TestModuleFileExtension.cpp Index: cla

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl updated this revision to Diff 322894. yaxunl added a comment. handle launch kernel by API and launch kernel in function pointer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86376/new/ https://reviews.llvm.org/D86376 Files: clang/lib/CodeGen/CGCUDANV.cpp clang/lib/CodeGen/C

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

Szelethus added reviewers: NoQ, vsavchenko. Szelethus added a comment. Looks like a neat checker! I guess the only question is the function matching, and I don't dislike it in its current state. @martong, do you have any thoughts on this? On another note, have you checked this on some projects

[clang] 984cfdc - [clang][cli] Fix gcc warning (NFC)

Author: Yang Fan Date: 2021-02-11T12:38:09+08:00 New Revision: 984cfdc6ee8b4550238dccf212d786c4ded49cf7 URL: https://github.com/llvm/llvm-project/commit/984cfdc6ee8b4550238dccf212d786c4ded49cf7 DIFF: https://github.com/llvm/llvm-project/commit/984cfdc6ee8b4550238dccf212d786c4ded49cf7.diff LOG:

[PATCH] D96456: [ThinLTO, NewPM] Add Config::OptPassBuilderHook

aeubanks added a comment. This makes sense to me, we need to add the PassBuilder callbacks in both the prelink/normal and postlink steps, and those are separated. Comment at: llvm/include/llvm/LTO/Config.h:54 + /// For adding passes that run by opt. + std::function OptPassBu

[PATCH] D96376: [CodeComplete] Member completion: heuristically resolve some dependent base exprs

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! this looks like a nice improvement! Comment at: clang/test/CodeCompletion/member-access.cpp:88 + TemplateClass &relatedField; + BaseTemplate &relatedFunction(); + -

[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:651 + auto Results = + completions("int main() { abs^ }", {func("absl"), func("absb")}); EXPECT_THAT(Results.Completions, sorry, I didn't infer the motivat

<    1   2