kuzkry marked 3 inline comments as done.
kuzkry added a comment.

In D87587#2552232 <https://reviews.llvm.org/D87587#2552232>, 
@HazardyKnusperkeks wrote:

> Apart from my comments, this looks good to me and I really wonder why it 
> hasn't been pushed. (I would directly use it!)

I don't know, maybe noone needed this except for us :D



================
Comment at: clang/include/clang/Format/Format.h:2821
            MaxEmptyLinesToKeep == R.MaxEmptyLinesToKeep &&
+           ShortNamespaceLines == R.ShortNamespaceLines &&
            NamespaceIndentation == R.NamespaceIndentation &&
----------------
HazardyKnusperkeks wrote:
> Could you sort this one alphabetically?
Oops, I just sed'ed through it when renaming and forgot to sort it. Thx :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87587/new/

https://reviews.llvm.org/D87587

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to