[PATCH] D96155: [clang][cli] Generate and round-trip Frontend options

jansvoboda11 added a comment. Thanks, a copy-paste mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96155/new/ https://reviews.llvm.org/D96155 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] d1522d3 - [-Wcompletion-handler] Support checks with builtins

Author: Valeriy Savchenko Date: 2021-02-09T11:32:24+03:00 New Revision: d1522d349f4d4b960ff7a37303103e95aa535af3 URL: https://github.com/llvm/llvm-project/commit/d1522d349f4d4b960ff7a37303103e95aa535af3 DIFF: https://github.com/llvm/llvm-project/commit/d1522d349f4d4b960ff7a37303103e95aa535af3.d

[PATCH] D96268: [-Wcompletion-handler] Support checks with builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1522d349f4d: [-Wcompletion-handler] Support checks with builtins (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

curdeius added a comment. It's getting into a good shape. Please fix the nits. Comment at: clang/unittests/Format/FormatTest.cpp:19059 + // Members are *two* levels below the record; + // Style.IndentWidth == 2, thus yielding a 4 spaces wide indentation + verifyFormat("class

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. @vsavchenko, anything else to add? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Great job! Thanks for dealing with all my nit-picking! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.or

[PATCH] D96280: [WIP][clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 updated this revision to Diff 322310. jansvoboda11 added a comment. Replace commented-out code with reason behind not generating arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96280/new/ https://reviews.llvm.org/D96280 Files:

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:356 + I->eraseFromParent(); +} + } I see you need force match bitcast then replace, add assert for no bitcast case Comment at: llvm/lib/Ta

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

jansvoboda11 added a comment. Updated the patch, removed `[WIP]` from the title and replied to comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1940-1941 case EDK_ProfileList: - GenerateArg(Args, OPT_fprofile_list_EQ, Dep.first, SA); + // Generated

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added a comment. In D69560#2549959 , @steveire wrote: > Why "easily" instead of "suspicious", "spuriously" or any of the other words > that are already used? The name was @aaron.ballman's idea after we postponed the `experimental-cppcoreguide

[clang] 40c261c - [clang][cli] Generate and round-trip language options

Author: Jan Svoboda Date: 2021-02-09T10:18:55+01:00 New Revision: 40c261c41c4ceb0dff802d6a83f7ae65af936af8 URL: https://github.com/llvm/llvm-project/commit/40c261c41c4ceb0dff802d6a83f7ae65af936af8 DIFF: https://github.com/llvm/llvm-project/commit/40c261c41c4ceb0dff802d6a83f7ae65af936af8.diff L

[PATCH] D95793: [clang][cli] Generate and round-trip language options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40c261c41c4c: [clang][cli] Generate and round-trip language options (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:433 +bool X86LowerAMXIntrinsics::visit() { + bool C; + SmallVector TileDPBSSDs; `bool C = false` Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cp

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

pengfei added inline comments. Comment at: llvm/test/CodeGen/X86/AMX/amx-low-intrinsics.ll:174-175 +; CHECK-NEXT:[[TMP13:%.*]] = bitcast i32 [[TMP12]] to <2 x i16> +; CHECK-NEXT:[[TMP14:%.*]] = zext <2 x i16> [[TMP11]] to <2 x i32> +; CHECK-NEXT:[[TMP15:%.*]] = shl <2

[PATCH] D96323: [clang][cli] NFC: Remove intermediate command line parsing functions

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Patch D96280 moved command line round-tripping from eac

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is a fix of the problem (rather than a pa

[PATCH] D96285: [clang][Arm] Fix handling of -Wa,-implicit-it=

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2307 +static bool AddImplicitITArgs(const ArgList &Args, ArgStringList &CmdArgs, + StringRef Value) { I would rename this AddARMImplicitITArgs to

[PATCH] D96270: [release][docs] Update contributions to LLVM 12 for scalable vectors.

david-arm updated this revision to Diff 322316. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96270/new/ https://reviews.llvm.org/D96270 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst === --- clang

[clang] ec12f5f - [clang][codegen] Remember string used to create llvm::Regex for optimization remarks

Author: Jan Svoboda Date: 2021-02-09T11:12:13+01:00 New Revision: ec12f5febed04dd32e7d4b766b2853d50fca9657 URL: https://github.com/llvm/llvm-project/commit/ec12f5febed04dd32e7d4b766b2853d50fca9657 DIFF: https://github.com/llvm/llvm-project/commit/ec12f5febed04dd32e7d4b766b2853d50fca9657.diff L

[PATCH] D96036: [clang][codegen] Remember string used to create llvm::Regex for optimization remarks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec12f5febed0: [clang][codegen] Remember string used to create llvm::Regex for optimization… (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev updated this revision to Diff 322321. kbobyrev added a comment. Implement constructors handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96324/new/ https://reviews.llvm.org/D96324 Files: clang-tools-extra/clangd/refactor/Rename.cp

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev added a comment. This likely needs some further thought on conflict detection. Assume we have void foo(int Argument^); // case 1 void foo(int OhWait); // case 2 void foo(int Argument); // case 3 void foo(int AnotherOne) {} // case 4 What should we do when renaming `Argument`?

[clang] e721bc9 - [clang][cli] Generate and round-trip CodeGen options

Author: Jan Svoboda Date: 2021-02-09T11:43:38+01:00 New Revision: e721bc9effefab8a625e913e7391bdd340693ddc URL: https://github.com/llvm/llvm-project/commit/e721bc9effefab8a625e913e7391bdd340693ddc DIFF: https://github.com/llvm/llvm-project/commit/e721bc9effefab8a625e913e7391bdd340693ddc.diff L

[PATCH] D96056: [clang][cli] Generate and round-trip CodeGen options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe721bc9effef: [clang][cli] Generate and round-trip CodeGen options (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D96247: [clangd] Fix false positive in local rename collision detetction

kbobyrev updated this revision to Diff 322323. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96247/new/ https://reviews.llvm.org/D96247 Files: clang-too

[clang] 2f994d4 - [-Wcompletion-handler][NFC] Remove unexpected warnings on Windows

Author: Valeriy Savchenko Date: 2021-02-09T13:50:11+03:00 New Revision: 2f994d4ee920983cf7624ce2208756e0c7d19007 URL: https://github.com/llvm/llvm-project/commit/2f994d4ee920983cf7624ce2208756e0c7d19007 DIFF: https://github.com/llvm/llvm-project/commit/2f994d4ee920983cf7624ce2208756e0c7d19007.d

[clang-tools-extra] b60428c - [clangd] Fix false positive in local rename collision detetction

Author: Kirill Bobyrev Date: 2021-02-09T11:51:18+01:00 New Revision: b60428c7ea685e338df3369807c9b650f994554b URL: https://github.com/llvm/llvm-project/commit/b60428c7ea685e338df3369807c9b650f994554b DIFF: https://github.com/llvm/llvm-project/commit/b60428c7ea685e338df3369807c9b650f994554b.diff

[PATCH] D96247: [clangd] Fix false positive in local rename collision detetction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb60428c7ea68: [clangd] Fix false positive in local rename collision detetction (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

stuart requested changes to this revision. stuart added a comment. This revision now requires changes to proceed. Looks good, just some suggestions about the test. Comment at: clang/test/CodeGenOpenCL/kernel-arg-info.cl:110 +kernel void foo9(signed char si1, global const sig

[clang] ea89109 - [NFC,Clang] Add LTO Driver Tsan tests

Author: Vitaly Buka Date: 2021-02-09T03:08:00-08:00 New Revision: ea891099f2bc5d1749c7ce123391e530ed2ab9ef URL: https://github.com/llvm/llvm-project/commit/ea891099f2bc5d1749c7ce123391e530ed2ab9ef DIFF: https://github.com/llvm/llvm-project/commit/ea891099f2bc5d1749c7ce123391e530ed2ab9ef.diff L

[clang] 9ff678f - [NFC,Clang] Add LTO Driver DFsan tests

Author: Vitaly Buka Date: 2021-02-09T03:08:00-08:00 New Revision: 9ff678f614d37487d0d117709aa3263fbc0d8423 URL: https://github.com/llvm/llvm-project/commit/9ff678f614d37487d0d117709aa3263fbc0d8423 DIFF: https://github.com/llvm/llvm-project/commit/9ff678f614d37487d0d117709aa3263fbc0d8423.diff L

[clang] dde9f0f - [NFC,Clang] Add LTO Driver MSan,KMsan tests

Author: Vitaly Buka Date: 2021-02-09T03:08:00-08:00 New Revision: dde9f0fa9834afe02e32e27cc822cccb8ef6aeff URL: https://github.com/llvm/llvm-project/commit/dde9f0fa9834afe02e32e27cc822cccb8ef6aeff DIFF: https://github.com/llvm/llvm-project/commit/dde9f0fa9834afe02e32e27cc822cccb8ef6aeff.diff L

[clang] 4ddf756 - [NFC,Clang] Add SanCov Driver tests

Author: Vitaly Buka Date: 2021-02-09T03:08:00-08:00 New Revision: 4ddf7562d5cce153b982cf16c2a776095495a2f9 URL: https://github.com/llvm/llvm-project/commit/4ddf7562d5cce153b982cf16c2a776095495a2f9 DIFF: https://github.com/llvm/llvm-project/commit/4ddf7562d5cce153b982cf16c2a776095495a2f9.diff L

[clang] 03c6a6d - [NFC,Clang] Add more Asan Driver tests

Author: Vitaly Buka Date: 2021-02-09T03:08:00-08:00 New Revision: 03c6a6d9ef5052a5eeedddf4d2d256be0e1d3348 URL: https://github.com/llvm/llvm-project/commit/03c6a6d9ef5052a5eeedddf4d2d256be0e1d3348 DIFF: https://github.com/llvm/llvm-project/commit/03c6a6d9ef5052a5eeedddf4d2d256be0e1d3348.diff L

[PATCH] D96328: [Clang, NewPM] Add KMSan support

vitalybuka created this revision. vitalybuka added reviewers: glider, eugenis. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D96320 . Repository: rG LLVM Github Monorepo https://

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

Anastasia updated this revision to Diff 322330. Anastasia added a comment. Renamed variables in CHECK statements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96161/new/ https://reviews.llvm.org/D96161 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGenOpenCL/kernel-arg-i

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/kernel-arg-info.cl:112-118 +// CHECK: !kernel_arg_addr_space ![[SINT_AS_QUAL:[0-9]+]] +// CHECK: !kernel_arg_access_qual ![[MD42]] +// CHECK: !kernel_arg_type ![[SINT_TY:[0-9]+]] +// CHECK: !kernel_arg_base_typ

[PATCH] D90595: [clangd] Fix race in background index rebuild, where index could stay stale.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:850 +if (++IdleCount <= 2) { + Q.push(Task); + Q.push(Task); kadircet wrote: > as discussed offline there are no guarantees on these

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop added a comment. In D96120#2546077 , @mstorsjo wrote: > As is, this breaks compilation for mingw. With the three modifications I > suggest here, it no longer breaks compilation for me - I have no idea if it > actually works in mingw config

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 322339. whisperity added a comment. - Added a C test file with some C-specific language constructs that we may or may not match. - Explained limitations with regards to variadics, templates, etc. better in the docs, and added test cases for these too. - W

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added a comment. In D92715#2544233 , @craig.topper wrote: > In D92715#2544178 , @HsiangKai wrote: > >> In D92715#2520925 , @craig.topper >> wrote: >> >>> I wonder

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

aqjune added a comment. I'm fine with any direction that helps people land test updates/implementations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 ___ cfe-c

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

Jim added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:2 -RISCVV_BUILTIN(vadd_vv_i8m1_vl, "q8Scq8Scq8Scz", "n") -RISCVV_BUILTIN(vadd_vv_i8m1_m_vl, "q8Scq8bq8Scq8Scq8Scz", "n") -RISCVV_BUILTIN(vadd_vv_i16m1_vl, "q4Ssq4Ssq4Ssz", "n") -RISCVV_BUILTIN(va

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

Jim added inline comments. Comment at: llvm/docs/CommandGuide/tblgen.rst:141 - Generate RISCV compressed instructions. + Generate RISC-V compressed instructions. It is typo fix. Could you fix it in a separate patch? Repository: rG LLVM Github Monorepo

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 322297. khchen marked 3 inline comments as done. khchen added a comment. 1. address Jim's comment. 2. remove suffix `_vl` according by https://github.com/riscv/rvv-intrinsic-doc/pull/64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:2 -RISCVV_BUILTIN(vadd_vv_i8m1_vl, "q8Scq8Scq8Scz", "n") -RISCVV_BUILTIN(vadd_vv_i8m1_m_vl, "q8Scq8bq8Scq8Scq8Scz", "n") -RISCVV_BUILTIN(vadd_vv_i16m1_vl, "q4Ssq4Ssq4Ssz", "n") -RISCVV_BUILTIN

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 322300. khchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/include/clang/Basic/C

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

Jim added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:2 -RISCVV_BUILTIN(vadd_vv_i8m1_vl, "q8Scq8Scq8Scz", "n") -RISCVV_BUILTIN(vadd_vv_i8m1_m_vl, "q8Scq8bq8Scq8Scq8Scz", "n") -RISCVV_BUILTIN(vadd_vv_i16m1_vl, "q4Ssq4Ssq4Ssz", "n") -RISCVV_BUILTIN(va

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop added a comment. In D96120#2545151 , @aganea wrote: > A few questions: Does this work on x86 targets? I haven't tried. I'll test this out. > Are the scudo tests below being built with /MD or with /MT? The lit tests? They don't specify eit

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity marked 4 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:255 + std::string NodeTypeName = + Node->getType().getAsString(Node->getASTContext().getPrintingPolicy()); +

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

mstorsjo added a comment. In D96120#2550876 , @russell.gallop wrote: > In D96120#2546077 , @mstorsjo wrote: > >> As is, this breaks compilation for mingw. With the three modifications I >> suggest here, it no long

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TargetMachine.cpp:416 + if (TM->getOptLevel() == CodeGenOpt::None) +addPass(createX86LowerAMXIntrinsicsPass()); + else { We may add both pass anyway and skip the pass based on the option le

[PATCH] D96231: [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd.

pengfei updated this revision to Diff 322344. pengfei marked 7 inline comments as done. pengfei added a comment. Address Sanjay's comments. Thanks for the thoroughly review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96231/new/ https://reviews.l

[PATCH] D96231: [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd.

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13829 CGM.getIntrinsic(Intrinsic::vector_reduce_fadd, Ops[1]->getType()); +Builder.getFastMathFlags().setAllowReassoc(true); return Builder.CreateCall(F, {Ops[0], Ops[1]}); --

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

FarisRehman updated this revision to Diff 322347. FarisRehman marked 3 inline comments as done. FarisRehman added a comment. Address review comment Address review comment by @awarzynski Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96032/new/ http

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

FarisRehman added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:25-26 Args.AddAllArgs(CmdArgs, {options::OPT_ffixed_form, options::OPT_ffree_form, -options::OPT_ffixed_line_length_EQ}); +options::OPT_

[PATCH] D96231: [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96231/new/ https://reviews.llvm.org/D96231 ___ c

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis added a comment. In D95534#2534510 , @smeenai wrote: > I saw this on LLVM Weekly, and I like it a lot :) > > Now if only Windows could case-correct their SDKs so we didn't need VFS > overlays and symlinks for the linker... We use ciopfs for this,

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis added a comment. > We use ciopfs for this, > https://source.chromium.org/chromium/chromium/src/+/master:build/vs_toolchain.py;l=485?q=ciopfs > That code has worked without changes for the last 2.5 years. (ciopfs is user-space, so it can be set up transparently by a normal post-pull hook

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

awarzynski accepted this revision. awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:25-26 Args.AddAllArgs(CmdArgs, {options::OPT_ffixed_form, options::OPT_ffree_form, -options::OPT_ffixed_line_length_EQ}); +

[clang] dd2460e - [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd.

Author: Wang, Pengfei Date: 2021-02-09T21:14:06+08:00 New Revision: dd2460ed5d77d908327ce29a15630cd3268bd76e URL: https://github.com/llvm/llvm-project/commit/dd2460ed5d77d908327ce29a15630cd3268bd76e DIFF: https://github.com/llvm/llvm-project/commit/dd2460ed5d77d908327ce29a15630cd3268bd76e.diff

[PATCH] D96231: [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd2460ed5d77: [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd. (authored by pengfei). Repository: rG LLVM Github Monorepo C

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added a comment. @pengfei Would you be happy to commandeer this patch to make it match D96231 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https://reviews.llvm.org/D93179

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 322357. whisperity added a comment. Made detection of macros as "parameter type names" more robust. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new/ https://reviews.llvm.org/D69560 Files: clang-to

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity marked an inline comment as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:255 + std::string NodeTypeName = + Node->getType().getAsString(Node->getASTContext().getPrintingPolicy()); +

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 322362. balazske added a comment. Added `quick_exit` to POSIX-allowed set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bugpro

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 322364. balazske added a comment. Update relative to previous commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bugprone/Si

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 322363. whisperity added a comment. **NFC** (With all the restructuring and trying to figure out how to implement the latest change, I managed to upload the wrong, unclean diff...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

jansvoboda11 updated this revision to Diff 322365. jansvoboda11 added a comment. Remove the need for {Warnings,Remarks}AsWritten field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96274/new/ https://reviews.llvm.org/D96274 Files: clang/include/

[clang-tools-extra] 98146c1 - [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

Author: poelmanc Date: 2021-02-09T14:02:45Z New Revision: 98146c1f5d0c772aec56149724119d49990f4d0c URL: https://github.com/llvm/llvm-project/commit/98146c1f5d0c772aec56149724119d49990f4d0c DIFF: https://github.com/llvm/llvm-project/commit/98146c1f5d0c772aec56149724119d49990f4d0c.diff LOG: [cla

[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

This revision was automatically updated to reflect the committed changes. Closed by commit rG98146c1f5d0c: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator… (authored by poelmanc, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

jansvoboda11 added a comment. Got rid of `{Warnings,Remarks}AsWritten` entirely. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:745 + +A->render(Args, Rendered); } dexonsmith wrote: > It's not obvious why this renders the args instead of calling

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

tianshilei1992 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:193 CC1Args.push_back("-emit-llvm-bc"); + + std::string BitcodeSuffix = "amdgcn-" + GpuArch.str(); JonChesterfield wrote: > tianshilei1992 wrote: > > JonChesterfiel

[clang] 521e173 - [clang][cli] Store InputKind in FrontendOptions

Author: Jan Svoboda Date: 2021-02-09T15:19:26+01:00 New Revision: 521e1733f1496f6d554e6ce8b69cd4251499b15e URL: https://github.com/llvm/llvm-project/commit/521e1733f1496f6d554e6ce8b69cd4251499b15e DIFF: https://github.com/llvm/llvm-project/commit/521e1733f1496f6d554e6ce8b69cd4251499b15e.diff L

[PATCH] D96149: [clang][cli] Store InputKind in FrontendOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG521e1733f149: [clang][cli] Store InputKind in FrontendOptions (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D96270: [release][docs] Update contributions to LLVM 12 for scalable vectors.

willlovett added a comment. LGTM. Would prefer someone else accept CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96270/new/ https://reviews.llvm.org/D96270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

probinson added a comment. I don't claim to be very familiar with this area but "round-trip" and "test" would make me think those bits should be in a lit test or unittest. As it is, it's not obvious what is functional and what is testing here. Possibly I am misunderstanding something fundamental

[clang] 7369bfb - [clang][cli] Look up program action argument in a table

Author: Jan Svoboda Date: 2021-02-09T15:29:33+01:00 New Revision: 7369bfb8abb6f62eebd045b8b243972863bf3190 URL: https://github.com/llvm/llvm-project/commit/7369bfb8abb6f62eebd045b8b243972863bf3190 DIFF: https://github.com/llvm/llvm-project/commit/7369bfb8abb6f62eebd045b8b243972863bf3190.diff L

[PATCH] D96269: [clang][cli] Look up program action argument in a table

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7369bfb8abb6: [clang][cli] Look up program action argument in a table (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D96270: [release][docs] Update contributions to LLVM 12 for scalable vectors.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96270/new/ https://reviews.llvm.org/D96270 ___ cfe-commits mailing list cfe-commi

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

mantognini accepted this revision. mantognini added a comment. LGTM, thanks. All the comments seem to be addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96161/new/ https://reviews.llvm.org/D96161 ___ cfe-commits mailing list cfe-comm

[clang] 396d6a3 - [clang][cli] Store unsigned instead of OptSpecifier in table

Author: Jan Svoboda Date: 2021-02-09T15:46:10+01:00 New Revision: 396d6a3220ee131f58ce46ca47f6f98cf7a3fcae URL: https://github.com/llvm/llvm-project/commit/396d6a3220ee131f58ce46ca47f6f98cf7a3fcae DIFF: https://github.com/llvm/llvm-project/commit/396d6a3220ee131f58ce46ca47f6f98cf7a3fcae.diff L

[PATCH] D96324: [clangd] Rename references to function arguments within the same file

kbobyrev updated this revision to Diff 322382. kbobyrev added a comment. Rebase on top of D96247 , check for conflicts in specialization bodies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96324/new/ https://revi

[PATCH] D96017: [clang-check] Add tokens-dump in clang-check.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96017/new/ https://reviews.llvm.org/D96017 __

[clang] 79b222c - [OpenCL] Fix types with signed prefix in arginfo metadata.

Author: Anastasia Stulova Date: 2021-02-09T15:13:19Z New Revision: 79b222c39f0e4377b49191b6aba080b1607f3fa7 URL: https://github.com/llvm/llvm-project/commit/79b222c39f0e4377b49191b6aba080b1607f3fa7 DIFF: https://github.com/llvm/llvm-project/commit/79b222c39f0e4377b49191b6aba080b1607f3fa7.diff

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG79b222c39f0e: [OpenCL] Fix types with signed prefix in arginfo metadata. (authored by Anastasia). Herald added a project:

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl added a comment. Actually there is one issue with this approach. HIP have API's to launch kernels, which accept kernel as function pointer argument. Currently when taking address of kernel, we get the stub function. These kernel launching API's will not work if we use kernel symbol to re

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

sammccall marked 2 inline comments as done. sammccall added a comment. Thanks for the excellent comments, and sorry for the radio silence. (Kids got quarantined recently so work time has been... scarce). I think there are improvements to be had here but it's probably time to land this... In D7

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder added a comment. Any update on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang-tools-extra] dd8fb21 - [clangd] Implement semanticTokens modifiers

Author: Sam McCall Date: 2021-02-09T16:31:22+01:00 New Revision: dd8fb21227cef26b1cdd44792a1ee77910afd86a URL: https://github.com/llvm/llvm-project/commit/dd8fb21227cef26b1cdd44792a1ee77910afd86a DIFF: https://github.com/llvm/llvm-project/commit/dd8fb21227cef26b1cdd44792a1ee77910afd86a.diff LO

[PATCH] D77811: [clangd] Implement semanticTokens modifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd8fb21227ce: [clangd] Implement semanticTokens modifiers (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77811?vs=320

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 created this revision. arnamoy10 added reviewers: awarzynski, sscalpone, clementval, tskeith, AMDChirag, SouraVX. Herald added a subscriber: dang. Herald added a reviewer: jansvoboda11. arnamoy10 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscrib

[clang] 5e8a246 - [clang][cli] Generate and round-trip Frontend options

Author: Jan Svoboda Date: 2021-02-09T16:40:30+01:00 New Revision: 5e8a246ac9966e6ca43e7bd84db6df78b27d2201 URL: https://github.com/llvm/llvm-project/commit/5e8a246ac9966e6ca43e7bd84db6df78b27d2201 DIFF: https://github.com/llvm/llvm-project/commit/5e8a246ac9966e6ca43e7bd84db6df78b27d2201.diff L

[PATCH] D96155: [clang][cli] Generate and round-trip Frontend options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e8a246ac996: [clang][cli] Generate and round-trip Frontend options (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

khchen added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:89 +#define BUILTIN(ID, TYPE, ATTRS) \ + {"__builtin_rvv_" #ID, TYPE, ATTRS, nullptr, ALL_LANGUAGES, nullptr}, +#include "clang/Basic/BuiltinsRISCV.def" ---

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

thakis added a comment. This makes clang assert for some inputs. See https://bugs.chromium.org/p/chromium/issues/detail?id=1175886#c10 for a repro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 _

[PATCH] D96262: [clang][index] report references from unreslovedLookupExpr.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. LG. Couple of comments about adding tests to clangd as well. Comment at: clang/test/Index/Core/index-dependent-source.cpp:233 +// CHECK: [[@LINE-1]]:3 | functio

[PATCH] D96347: Include function return type in JSON AST dumps.

rokups created this revision. rokups requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For some reason return type was not included. Even though it is present in full type dump, it is not good enough as C++ types can get quite complex. Beside

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

Anastasia added a comment. @svenvh We haven't looked into address spaces in details when adding this. I wonder what behavior would make sense for new/delete? Do we plan to allow new/delete in named address spaces or only in generic? It might be more helpful to allow named address spaces since g

[clang] de1966e - Revert "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly"

Author: Nico Weber Date: 2021-02-09T11:06:32-05:00 New Revision: de1966e5427985163f8e816834b3a0564b5e24cd URL: https://github.com/llvm/llvm-project/commit/de1966e5427985163f8e816834b3a0564b5e24cd DIFF: https://github.com/llvm/llvm-project/commit/de1966e5427985163f8e816834b3a0564b5e24cd.diff LO

  1   2   >