Anastasia added inline comments.
================ Comment at: clang/test/CodeGenOpenCL/kernel-arg-info.cl:112-118 +// CHECK: !kernel_arg_addr_space ![[SINT_AS_QUAL:[0-9]+]] +// CHECK: !kernel_arg_access_qual ![[MD42]] +// CHECK: !kernel_arg_type ![[SINT_TY:[0-9]+]] +// CHECK: !kernel_arg_base_type ![[SINT_TY]] +// CHECK: !kernel_arg_type_qual ![[SINT_QUAL:[0-9]+]] +// CHECK-NOT: !kernel_arg_name +// ARGINFO: !kernel_arg_name ![[SINT_ARG_NAMES:[0-9]+]] ---------------- stuart wrote: > Would suggest `SCHAR_AS_QUAL` and `SCHAR_TY` now that this is using a signed > char. FYI also `SCHAR_ARG_NAMES` and `SCHAR_QUAL` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96161/new/ https://reviews.llvm.org/D96161 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
