[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

MaskRay updated this revision to Diff 321524. MaskRay edited the summary of this revision. MaskRay added a comment. Rebase to re-cycle bots Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95849/new/ https://reviews.llvm.org/D95849 Files: clang/tes

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

kpn added a comment. In D95948#2542884 , @mibintc wrote: > Should we add tests for mlong-double-64, -80, -128? Assuming Ty->getScalarSizeInBits() returns 64, 80, or 128 in those cases, I think it's good enough to just add an AArch64 (or some other 128-bi

[PATCH] D95849: [FileCheck] Default --allow-unused-prefixes to false

MaskRay added subscribers: pengfei, RKSimon. MaskRay added a comment. @nikic D95849 has already changed `llvm/test/` to default to `--allow-unused-prefixes`. I updated a few directories to be `--allow-unused-prefixes` clean (this uncovered improvement to many

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

stefanp added a comment. Just nits this time around. Comment at: lld/ELF/Driver.cpp:765 +// instructions in stubs. +static bool getP10StubOpt(opt::InputArgList &args) { + Conanap wrote: > For this function here, I realize we can inline all the ifs into a giant

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; Quuxplusone wrote: > aaron.ballman wrote: > > rjmccall w

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

tbaeder created this revision. tbaeder added reviewers: rsmith, EricWF, ldionne, tstellar, hfinkel. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, currently the following fails: clang++ -stdlib=libc++ -static ./test.cpp be

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4409 + calls to other ``swiftasynccall`` functions must be in tail position + (in all language modes). In particular: + - For C, this implies that ``return async_f();`` (``async_f`` is another --

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 321544. v.g.vassilev marked 6 inline comments as done. v.g.vassilev added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files: clang/include/clang/CodeGen/CodeGenAction.

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. @teemperor, thanks for the hints. Comment at: clang/include/clang/Interpreter/Transaction.h:1 +//===--- Transaction.h - Incremental Compilation and Execution---*- C++ -*-===// +// teemperor wrote: > Could this whole file just be p

[PATCH] D96027: [clangd] Trace queue state for each TUScheduler action.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:511 llvm::Optional> LatestPreamble; - std::queue PreambleRequests; /* GUARDED_BY(Mutex) */ + std::deque PreambleRequests; /* GUARDED_BY(Mutex) */ /// Signaled whenever LatestPreamble chan

[PATCH] D96009: [clangd] Improve name conflict detection

kbobyrev updated this revision to Diff 321545. kbobyrev added a comment. Can't instantiate DynTypedNode with FunctionProtoTypeLoc, has to be just TypeLoc :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96009/new/ https://reviews.llvm.org/D96009

[clang-tools-extra] e8a2b7c - [clangd] Improve name conflict detection

Author: Kirill Bobyrev Date: 2021-02-04T21:37:41+01:00 New Revision: e8a2b7c91563169b68d2a878c65deecc85ced466 URL: https://github.com/llvm/llvm-project/commit/e8a2b7c91563169b68d2a878c65deecc85ced466 DIFF: https://github.com/llvm/llvm-project/commit/e8a2b7c91563169b68d2a878c65deecc85ced466.diff

[PATCH] D96009: [clangd] Improve name conflict detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a2b7c91563: [clangd] Improve name conflict detection (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

mstorsjo added a comment. I'm not convinced that this is the right way of handling it. Libc++ can be used on top of a number of C++ ABI libraries (both libsupc++/libstdc++ and libcxxabi), and how they are linked varies with how a toolchain is assembled. In particular, if libcxx is built with `L

[clang] cd2f65b - Correct some confused diagnostic terminology

Author: Aaron Ballman Date: 2021-02-04T15:52:07-05:00 New Revision: cd2f65b71a4239dcb5a4bcfe25da32a9ac9620cb URL: https://github.com/llvm/llvm-project/commit/cd2f65b71a4239dcb5a4bcfe25da32a9ac9620cb DIFF: https://github.com/llvm/llvm-project/commit/cd2f65b71a4239dcb5a4bcfe25da32a9ac9620cb.diff

[clang] fcb90cb - Fix miscomputation of dependence for elaborated types that are

Author: Richard Smith Date: 2021-02-04T13:14:15-08:00 New Revision: fcb90cbd3b4ae3934bdd05d538647d37ce899962 URL: https://github.com/llvm/llvm-project/commit/fcb90cbd3b4ae3934bdd05d538647d37ce899962 DIFF: https://github.com/llvm/llvm-project/commit/fcb90cbd3b4ae3934bdd05d538647d37ce899962.diff

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre updated this revision to Diff 321554. thopre added a comment. Add AArch64 testcase and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95948/new/ https://reviews.llvm.org/D95948 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/Cod

[PATCH] D96058: [CodeComplete] Guess type for designated initializers

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Parse/ParseInit.cpp:163 +DesignatorCompletionInfo DesignatorCompletion) { + if (!getPreprocessor().isCodeCompletionEnabled()) +DesignatorCompletion.PreferredBaseType = Qual

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre added inline comments. Comment at: clang/test/CodeGen/aarch64-strictfp-builtins.c:1 +// RUN: %clang_cc1 %s -emit-llvm -ffp-exception-behavior=maytrap -fexperimental-strict-floating-point -o - -triple arm64-none-linux-gnu | FileCheck %s + AArch64 is not S

[clang] eb4ab33 - [CodeComplete] Guess type for designated initializers

Author: Sam McCall Date: 2021-02-04T22:14:49+01:00 New Revision: eb4ab3358cd4dc834a761191b5531b38114f7b13 URL: https://github.com/llvm/llvm-project/commit/eb4ab3358cd4dc834a761191b5531b38114f7b13 DIFF: https://github.com/llvm/llvm-project/commit/eb4ab3358cd4dc834a761191b5531b38114f7b13.diff LO

[PATCH] D96058: [CodeComplete] Guess type for designated initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb4ab3358cd4: [CodeComplete] Guess type for designated initializers (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D96

[clang] 0211877 - [HIP] Add __managed__ macro to header

Author: Yaxun (Sam) Liu Date: 2021-02-04T16:22:42-05:00 New Revision: 0211877a0754c06e3aeaba690a1c860c6edf6288 URL: https://github.com/llvm/llvm-project/commit/0211877a0754c06e3aeaba690a1c860c6edf6288 DIFF: https://github.com/llvm/llvm-project/commit/0211877a0754c06e3aeaba690a1c860c6edf6288.dif

[PATCH] D96027: [clangd] Trace queue state for each TUScheduler action.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1054 Requests.push_back({std::move(Task), std::string(Name), steady_clock::now(), -std::move(Ctx), Update, Invalidation, -std::move(Invalida

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

joerg added a comment. The NetBSD part is most definitely not acceptable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96070/new/ https://reviews.llvm.org/D96070 ___ cfe-commits mailing list cfe-commits

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. It is difficult for clang driver to make the decision because libc++ has multiple C++ ABI implementations as @mstorsjo said. Persoanlly I use: `clang++ -stdlib=libc++ -static-libs

[PATCH] D95745: Support unwinding from inline assembly

rnk added a comment. Basically, this seems totally reasonable and I think this is the right direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-co

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

tstellar added a comment. The goal here is for distributions to be able to build libc++ one way and then have it work with clang without requiring that users add additional linker flags besides -static or -stdlib=libc++. Is there a combination of CMake arguments we can use when building libc++

[PATCH] D96080: format

LukasHanel created this revision. Herald added a subscriber: nullptr.cpp. LukasHanel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96080 Files: clang-tools-extra/clang-ti

[PATCH] D95691: Implement P2173 for attributes on lambdas

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rjmccall wrote: > Quuxplusone wrote: > > aaron.ballman wro

[clang] e355110 - [CUDA][HIP] Fix checking dependent initalizer

Author: Yaxun (Sam) Liu Date: 2021-02-04T18:04:54-05:00 New Revision: e355110040d17dcbf0fcfcba386c4d96fe6fe7ec URL: https://github.com/llvm/llvm-project/commit/e355110040d17dcbf0fcfcba386c4d96fe6fe7ec DIFF: https://github.com/llvm/llvm-project/commit/e355110040d17dcbf0fcfcba386c4d96fe6fe7ec.dif

[PATCH] D95840: [CUDA][HIP] Fix checking dependent initalizer

This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rGe355110040d1: [CUDA][HIP] Fix checking dependent initalizer (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.or

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel created this revision. Herald added subscribers: nullptr.cpp, xazax.hun, mgorny. LukasHanel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96082 Files: clang-to

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel updated this revision to Diff 321580. LukasHanel edited projects, added clang-tools-extra; removed clang. LukasHanel added a comment. Herald added a project: clang. Add the real changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96082/

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

ASDenysPetrov updated this revision to Diff 321585. ASDenysPetrov added a comment. Updated. Moved comments as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95799/new/ https://reviews.llvm.org/D95799 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang/lib/StaticAnalyzer

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, steakhal, xazax.hun. ASDenysPetrov added a project: clang. Herald added subscribers: nullptr.cpp, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. ASDenysPetr

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rsmith wrote: > rjmccall wrote: > > Quuxplusone wrote: >

[PATCH] D96091: [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

sunfish created this revision. sunfish added a reviewer: tlively. Herald added subscribers: ecnelises, jfb, jgravelle-google, sbc100, dschuff. sunfish requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. When the -matomics feature is not

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

ASDenysPetrov added a comment. Herald added a subscriber: nullptr.cpp. HTML sample looks fine! But there is the same problem as in D92639 . IE doesn't draw arrows. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:166 + ArrowMap(un

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma updated this revision to Diff 321611. tiagoma added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Fo

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

zequanwu created this revision. zequanwu added reviewers: rsmith, rnk. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR48582 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96092 Files: clang/lib/AST/ExprCon

[PATCH] D96091: [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96091/new/ https://reviews.llvm.org/D96091 __

[PATCH] D95168: [clang-format] Add InsertBraces option

tiagoma marked 5 inline comments as done. tiagoma added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17996 +format(ForSourceLong, Style)); +} + njames93 wrote: > MyDeveloperDay wrote: > > MyDeveloperDay wrote: > > > MyDeveloperDa

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ExprConstant.cpp:10032-10033 + +// FIXME: Diagnostics here should point to the end of the initializer +// list, not the start. +if (

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

zequanwu updated this revision to Diff 321617. zequanwu marked an inline comment as done. zequanwu added a comment. Remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96092/new/ https://reviews.llvm.org/D96092 Files: clang/lib/AST/Exp

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

zequanwu added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10032-10033 + +// FIXME: Diagnostics here should point to the end of the initializer +// list, not the start. +if (!HandleLValueMember(Info, E, Subobject, Field, &Layout)) rsmi

[clang] 96fb49c - [AST] Update LVal before evaluating lambda decl fields.

Author: Zequan Wu Date: 2021-02-04T17:01:09-08:00 New Revision: 96fb49c3ff8e08680127ddd4ec45a0e6c199243b URL: https://github.com/llvm/llvm-project/commit/96fb49c3ff8e08680127ddd4ec45a0e6c199243b DIFF: https://github.com/llvm/llvm-project/commit/96fb49c3ff8e08680127ddd4ec45a0e6c199243b.diff LOG

[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96fb49c3ff8e: [AST] Update LVal before evaluating lambda decl fields. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

Eugene.Zelenko added a comment. New check must be mentioned in Release Notes. Comment at: clang-tools-extra/clang-tidy/readability/UselessReturnValueCheck.cpp:1 +//===--- UselessReturnValueCheck.cpp - clang-tidy +//---===// Please m

[PATCH] D95691: Implement P2173 for attributes on lambdas

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rjmccall wrote: > rsmith wrote: > > rjmccall wrote: > > >

[clang] 95da64d - [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

Author: Dan Gohman Date: 2021-02-04T18:16:48-08:00 New Revision: 95da64da23ac3a5855a8934a738b0fa10aa1323c URL: https://github.com/llvm/llvm-project/commit/95da64da23ac3a5855a8934a738b0fa10aa1323c DIFF: https://github.com/llvm/llvm-project/commit/95da64da23ac3a5855a8934a738b0fa10aa1323c.diff LO

[PATCH] D96091: [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95da64da23ac: [WebAssembly] Use single-threaded mode when -matomics isn't enabled. (authored by sunfish). Repository: rG LLVM Github Monorepo CHA

[PATCH] D96091: [WebAssembly] Use single-threaded mode when -matomics isn't enabled.

sbc100 added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.cpp:260 + if (!HasAtomics) { +Opts.POSIXThreads = false; +Opts.setThreadModel(LangOptions::ThreadModelKind::Single); POSIXThreads already defaults to false I think. It gets s

[PATCH] D96102: [clangd] Fix missing __syncthreads.

oToToT created this revision. oToToT added reviewers: tra, chandlerc, jdoerfert, gtbercea, emankov, JDevlieghere. Herald added subscribers: usaxena95, kadircet, arphaman. oToToT requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project

[PATCH] D96102: [clangd] Fix missing __syncthreads.

oToToT updated this revision to Diff 321652. oToToT added a comment. I guess __nvvm_bar_sync is the right instruction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96102/new/ https://reviews.llvm.org/D96102 Files: clang/lib/Headers/__clang_cuda_device_functions.h Index: clang/lib/

[PATCH] D96105: [CUDA][HIP] Pass -fgpu-rdc to host clang -cc1

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently -fgpu-rdc is not passed to host clang -cc1. This causes issue because -fgpu-rdc affects shadow variable linkage in host compilation. https://reviews.llvm.org/D96105 Files: clang/lib

[PATCH] D96102: [clangd] Fix missing __syncthreads.

jdoerfert added a comment. I doubt this compiles: https://godbolt.org/z/c51v5d even with adjusted type, this fails because `__syncthreads` is a builtin (right now): https://godbolt.org/z/jP7e6h (and `__nvvm_bar_sync` requires an argument). CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D96110: [X86] Pass to transform tdpbf16ps intrinsics to scalar operation.

yubing created this revision. Herald added subscribers: pengfei, hiraditya. yubing requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96110 Files: clang/incl

<    1   2