zequanwu added inline comments.
================ Comment at: clang/lib/AST/ExprConstant.cpp:10032-10033 + + // FIXME: Diagnostics here should point to the end of the initializer + // list, not the start. + if (!HandleLValueMember(Info, E, Subobject, Field, &Layout)) ---------------- rsmith wrote: > I don't think this FIXME is appropriate in the new context; just remove it. > `E` here should already be providing the best location information we have. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96092/new/ https://reviews.llvm.org/D96092 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
