[PATCH] D95057: [clangd] Allow configuration database to be specified in config.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigCompileTests.cpp:140 + EXPECT_THAT(Diags.Diagnostics, IsEmpty()); +} + maybe also try with an absolute path in `CompilationDatabase` ? Repository: rG LLVM Github Monorepo C

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge added a comment. Thanks for the thoughtful comments about the API surface and such! I think I've addressed or responded to most of them. There are a few outstanding comments about how the HeuristicResolver object is stored and passed around (const, pointer, etc.), which I'll come back to

[clang] 46ec025 - [clang][cli] NFC: Move prefix to the front of BoolOption

Author: Jan Svoboda Date: 2021-01-25T09:15:33+01:00 New Revision: 46ec0254a97dcf35a0f9f023ea7632e7ee72a1ee URL: https://github.com/llvm/llvm-project/commit/46ec0254a97dcf35a0f9f023ea7632e7ee72a1ee DIFF: https://github.com/llvm/llvm-project/commit/46ec0254a97dcf35a0f9f023ea7632e7ee72a1ee.diff L

[clang] 209f461 - [clang][cli] NFC: Pass CC1Option explicitly to BoolOption

Author: Jan Svoboda Date: 2021-01-25T09:15:33+01:00 New Revision: 209f4618891365f5f655214581ab4edd27cacde4 URL: https://github.com/llvm/llvm-project/commit/209f4618891365f5f655214581ab4edd27cacde4 DIFF: https://github.com/llvm/llvm-project/commit/209f4618891365f5f655214581ab4edd27cacde4.diff L

[PATCH] D95221: [clang][cli] NFC: Move prefix to the front of BoolOption

This revision was automatically updated to reflect the committed changes. Closed by commit rG46ec0254a97d: [clang][cli] NFC: Move prefix to the front of BoolOption (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95221/new/

[PATCH] D95225: [clang][cli] NFC: Pass CC1Option explicitly to BoolOption

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG209f46188913: [clang][cli] NFC: Pass CC1Option explicitly to BoolOption (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius accepted this revision. curdeius added a comment. LGTM. Thanks for being prompt at addressing the comments. I'll merge it today for you if @MyDeveloperDay has no more remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

jhenderson added a subscriber: grimar. jhenderson added a comment. Sorry, could you revert this please. I don't think this is a good fix, as you've reduced coverage within the test, and some changes are completly redundant/add extra noise. I've commented inline with examples. Skimming D94239

[clang] 01d9f13 - Revert "[clang][AVR] Improve avr-ld command line options"

Author: Ben Shi Date: 2021-01-25T16:33:58+08:00 New Revision: 01d9f13c3a5914baf9739348ef666e348a7b2a2f URL: https://github.com/llvm/llvm-project/commit/01d9f13c3a5914baf9739348ef666e348a7b2a2f DIFF: https://github.com/llvm/llvm-project/commit/01d9f13c3a5914baf9739348ef666e348a7b2a2f.diff LOG:

[clang] f00a20e - [clang-format] Add the possibility to align assignments spanning empty lines or comments

Author: Marek Kurdej Date: 2021-01-25T09:36:55+01:00 New Revision: f00a20e51c1d186e72844939aad10416e1cc99de URL: https://github.com/llvm/llvm-project/commit/f00a20e51c1d186e72844939aad10416e1cc99de DIFF: https://github.com/llvm/llvm-project/commit/f00a20e51c1d186e72844939aad10416e1cc99de.diff

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

This revision was automatically updated to reflect the committed changes. Closed by commit rGf00a20e51c1d: [clang-format] Add the possibility to align assignments spanning empty lines or… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

curdeius added a comment. I've committted it, but... something went wrong and you're not visible as the author. Sorry for that @tinloaf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

benshi001 reopened this revision. benshi001 added a comment. This revision is now accepted and ready to land. It still cases many build failures, due to not enough test. I will redo it with a full test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93579/new/ https://reviews.llvm.org/D

[clang] 7b9d88a - Revert "[clang-format] Add the possibility to align assignments spanning empty lines or comments"

Author: Marek Kurdej Date: 2021-01-25T09:40:46+01:00 New Revision: 7b9d88ab389e19d26432b1c1a6d57f554feb9a20 URL: https://github.com/llvm/llvm-project/commit/7b9d88ab389e19d26432b1c1a6d57f554feb9a20 DIFF: https://github.com/llvm/llvm-project/commit/7b9d88ab389e19d26432b1c1a6d57f554feb9a20.diff

[clang] 2563147 - [clang-format] Add the possibility to align assignments spanning empty lines or comments

Author: Lukas Barth Date: 2021-01-25T09:41:50+01:00 New Revision: 256314711f3fa724bff1bb2d8b93c5252265b5c7 URL: https://github.com/llvm/llvm-project/commit/256314711f3fa724bff1bb2d8b93c5252265b5c7 DIFF: https://github.com/llvm/llvm-project/commit/256314711f3fa724bff1bb2d8b93c5252265b5c7.diff L

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

curdeius added a comment. Fixed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] c6bd660 - Fix a build-bot failure.

Author: Haojian Wu Date: 2021-01-25T09:46:29+01:00 New Revision: c6bd6607bf8abfe259fef6a41e695581a88c88f0 URL: https://github.com/llvm/llvm-project/commit/c6bd6607bf8abfe259fef6a41e695581a88c88f0 DIFF: https://github.com/llvm/llvm-project/commit/c6bd6607bf8abfe259fef6a41e695581a88c88f0.diff LO

[PATCH] D93940: [clang-tidy] Add a check for blocking types and functions.

segoon added a comment. alexfh, hi! any comments on the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93940/new/ https://reviews.llvm.org/D93940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] 666815d - [RISCV] Implement new architecture extension macros

Author: Simon Cook Date: 2021-01-25T08:58:46Z New Revision: 666815d61bc2475aa7b3ecf8e3a91022d6ccce4b URL: https://github.com/llvm/llvm-project/commit/666815d61bc2475aa7b3ecf8e3a91022d6ccce4b DIFF: https://github.com/llvm/llvm-project/commit/666815d61bc2475aa7b3ecf8e3a91022d6ccce4b.diff LOG: [R

[PATCH] D94403: [RISCV] Implement new architecture extension macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG666815d61bc2: [RISCV] Implement new architecture extension macros (authored by simoncook). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

sammccall added a comment. I'm not convinced this is clearer - these methods do in fact return `null`. And it adds more duplicative code. Is it necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95270/new/ https://reviews.llvm.org/D95270 ___

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8943 + Style); + Style = getLLVMStyle(); + Style.EmptyLineBeforeAccessModifier = FormatStyle::ELBAMS_Never; Redundant line. Repository: rG LLVM Github Monorepo

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added a comment. In D93986#2519013 , @curdeius wrote: > Fixed! Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93986/new/ https://reviews.llvm.org/D93986 __

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

sammccall added a comment. In D95270#2519052 , @sammccall wrote: > I'm not convinced this is clearer - these methods do in fact return `null`. > And it adds more duplicative code. Is it necessary? Doh, of course I misread - inputs rather than outputs. Yes

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:496 } + bool TraverseCXXBaseSpecifier(const CXXBaseSpecifier &X) { +auto N = DynTypedNode::create(X); can we not use traverseNode here, rather than repeating? ==

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

kito-cheng added a comment. Could you also update macros and attributes which implemented in https://reviews.llvm.org/D94403 and https://reviews.llvm.org/D94931 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94583/new/ https://reviews.llvm.org/D945

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

grimar added a comment. As far I understand, looking on the description of D94239 , the message on z/OS looks like "EDC5129I No such file or directory.". I guess the `EDC5129I` is a stable error code? So why not to check for a possible `EDC5129I` prefix word ins

[PATCH] D95336: [clang] NFC: Remove else if after return

kbobyrev created this revision. kbobyrev added reviewers: kadircet, sammccall. kbobyrev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update the code to be compatible with LLVM Coding Guidelines. Repository: rG LLVM Github Monorepo h

[PATCH] D95336: [clang] NFC: Remove else if after return

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! (trivial changes like this can also be submitted without review) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95336/new/ https://

[clang] 7e5d41a - [clang] NFC: Remove else if after return

Author: Kirill Bobyrev Date: 2021-01-25T10:58:22+01:00 New Revision: 7e5d41a68255d2a890977047be339091cc113e25 URL: https://github.com/llvm/llvm-project/commit/7e5d41a68255d2a890977047be339091cc113e25 DIFF: https://github.com/llvm/llvm-project/commit/7e5d41a68255d2a890977047be339091cc113e25.diff

[PATCH] D95336: [clang] NFC: Remove else if after return

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e5d41a68255: [clang] NFC: Remove else if after return (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] 33a63a3 - [clang-format] [docs] Fix RST indentation.

Author: Marek Kurdej Date: 2021-01-25T11:00:46+01:00 New Revision: 33a63a36d3cb0a59ef80054a02babe7a28a9842a URL: https://github.com/llvm/llvm-project/commit/33a63a36d3cb0a59ef80054a02babe7a28a9842a DIFF: https://github.com/llvm/llvm-project/commit/33a63a36d3cb0a59ef80054a02babe7a28a9842a.diff

[clang] c8d2ae5 - [clang] NFC: Remove else-after-return pattern from some files

Author: Kirill Bobyrev Date: 2021-01-25T11:14:17+01:00 New Revision: c8d2ae52c15b4c886e70587cbc3f61aaa7bd6692 URL: https://github.com/llvm/llvm-project/commit/c8d2ae52c15b4c886e70587cbc3f61aaa7bd6692 DIFF: https://github.com/llvm/llvm-project/commit/c8d2ae52c15b4c886e70587cbc3f61aaa7bd6692.diff

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

HsiangKai updated this revision to Diff 318929. HsiangKai added a comment. Herald added subscribers: jdoerfert, hiraditya. Herald added a project: LLVM. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94583/new/ https://reviews.llvm.org/D9458

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:496 } + bool TraverseCXXBaseSpecifier(const CXXBaseSpecifier &X) { +auto N = DynTypedNode::create(X); sammccall wrote: > can we n

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 updated this revision to Diff 318930. njames93 marked 2 inline comments as done. njames93 added a comment. Update behaviour to keep RecordTypeLoc seletion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95231/new/ https://reviews.llvm.org/D

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (I don't see a new snapshot but LG with the traverseNode change) Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:272-283 + R"cpp( +

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

hans added inline comments. Comment at: clang/test/CodeGen/switch-to-lookup-table.c:2 +// Check switch to lookup optimization in fPIC and fno-PIC mode +// RUN: %clang_cc1 %s -triple=aarch64-unknown-fuchsia -O2 -fno-PIC -S -emit-llvm -o - | FileCheck %s --check-prefix=CHECK --che

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 318932. njames93 added a comment. Update getSelectedRecord to work now that BaseSpecifier may contain nested Nodes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94942/new/ https://reviews.llvm.org/D94942 Fi

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:272-283 + R"cpp( +struct Foo {}; +struct Bar : [[private Fo^o]] {}; + )cpp", + "CXXBaseS

[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

njames93 updated this revision to Diff 318933. njames93 marked an inline comment as done. njames93 added a comment. Remove FindTarget to instead add in a follow up patch. Side note, Think I'll wait til after tomorrow to land this, unsure if the changes will break anything elsewhere. Repository:

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

vsavchenko added a comment. In D95307#2518592 , @NoQ wrote: > This patch shoots the messenger but someone still needs to conduct a proper > investigation. The assertion is losing a lot more of its bug-finding power > than necessary to uncover the current

[PATCH] D95338: [clangd] FindTarget resolves base specifier

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. FindTarget on the virtual keyword

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD added a comment. In D95307#2519283 , @vsavchenko wrote: > In D95307#2518592 , @NoQ wrote: > >> This patch shoots the messenger but someone still needs to conduct a proper >> investigation. The assertion is

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

vsavchenko added a comment. In D95307#2519300 , @RedDocMD wrote: > In D95307#2519283 , @vsavchenko > wrote: > >> In D95307#2518592 , @NoQ wrote: >> >>> This patch shoots the

[clang] 8fdd578 - [OpenCL][Docs] Describe tablegen BIFs declarations.

Author: Anastasia Stulova Date: 2021-01-25T11:17:03Z New Revision: 8fdd5784f0d30b165602343a96a34611779b007b URL: https://github.com/llvm/llvm-project/commit/8fdd5784f0d30b165602343a96a34611779b007b DIFF: https://github.com/llvm/llvm-project/commit/8fdd5784f0d30b165602343a96a34611779b007b.diff

[PATCH] D95038: [OpenCL][Docs] Describe tablegen BIFs declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fdd5784f0d3: [OpenCL][Docs] Describe tablegen BIFs declarations. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D95038?vs=318208&id=318938#toc

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD added a comment. Funnily enough, when I run `ninja clang-check` I don't get any errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95307/new/ https://reviews.llvm.org/D95307 ___ cfe-commits m

[PATCH] D95340: [clang][cli] NFC: Simplify BoolOption API

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added subscribers: dang, jfb. jansvoboda11 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The `Boo

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

njames93 updated this revision to Diff 318942. njames93 marked an inline comment as done. njames93 added a comment. Remove unnecessary specialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95270/new/ https://reviews.llvm.org/D95270 Files:

[PATCH] D95270: [clangd][NFC] Simplify handing on methods with no params

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:262 + template + void bind(const char *Method, +void (ClangdLSPServer::*Handler)(const NoParams &, kadircet wrote: > why do we need this one ? Good point, this

[PATCH] D95342: [clang][cli] Store LangStandard::Kind in LangOptions

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `LangStandard::Kind` parsed from command line argumen

[clang] 14947cd - [clang] Fix signedness in vector bitcast evaluation

Author: Sven van Haastregt Date: 2021-01-25T12:01:42Z New Revision: 14947cd04701d923a57a0161fd1967b81e00ff5e URL: https://github.com/llvm/llvm-project/commit/14947cd04701d923a57a0161fd1967b81e00ff5e DIFF: https://github.com/llvm/llvm-project/commit/14947cd04701d923a57a0161fd1967b81e00ff5e.diff

[PATCH] D95135: Fix signedness in vector bitcast evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rG14947cd04701: [clang] Fix signedness in vector bitcast evaluation (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95135/new/ https://rev

[PATCH] D95342: [clang][cli] Store LangStandard::Kind in LangOptions

jansvoboda11 updated this revision to Diff 318951. jansvoboda11 added a comment. Remove Digraphs from CompilerInvocation.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95342/new/ https://reviews.llvm.org/D95342 Files: clang/include/clang/Basi

[PATCH] D95343: [clang][cli] Port GNU language options to marshalling system

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Port some GNU-related language options to the marshalling

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:128 + // after an underscore (_). It is instantiated like Prototype. + string MangledSuffix = managed_suffix; + mangled_suffix Comment at: clang/include/cl

[PATCH] D95344: [clang][cli] Accept strings instead of options in ImpliedByAnyOf

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. To be able to use a constant keypaths (

[PATCH] D95345: [clang][cli] Port GPU-related language options to marshalling system

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Port some GPU-related language options to the marshalling

[PATCH] D95346: [clang][cli] Port LangOpts to marshalling system, pt.1

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Port some miscellaneous language options to the marshalli

[PATCH] D95347: [clang][cli] Port LangOpts to marshalling system, pt. 2

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Port some miscellaneous language options to the marshalli

[PATCH] D95345: [clang][cli] Port GPU-related language options to marshalling system

jansvoboda11 updated this revision to Diff 318963. jansvoboda11 added a comment. Remove diagnostics from ParseLangArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95345/new/ https://reviews.llvm.org/D95345 Files: clang/include/clang/Driver/Opt

[PATCH] D95348: [clang][cli] Port OpenMP-related LangOpts to marshalling system

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: dang, guansong, yaxunl. jansvoboda11 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: cla

[clang] b16fb1f - Revert "[clang] Fix signedness in vector bitcast evaluation"

Author: Sven van Haastregt Date: 2021-01-25T12:43:30Z New Revision: b16fb1ffc3ceebdff1f570668e73f257d7f7e499 URL: https://github.com/llvm/llvm-project/commit/b16fb1ffc3ceebdff1f570668e73f257d7f7e499 DIFF: https://github.com/llvm/llvm-project/commit/b16fb1ffc3ceebdff1f570668e73f257d7f7e499.diff

[PATCH] D95338: [clangd] FindTarget resolves base specifier

njames93 updated this revision to Diff 318968. njames93 added a comment. Remove unintended formatting change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95338/new/ https://reviews.llvm.org/D95338 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 318970. jansvoboda11 added a comment. Preserve pointer identity when round-tripping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472 Files: clang/include/clang/Dr

[PATCH] D95349: [clangd] Allow diagnostics to be suppressed with configuration

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This has been specifically reques

[clang-tools-extra] d6d36ba - Add a --use-color option to clang-query to allow forcing the behavior

Author: Tom Ritter Date: 2021-01-25T08:06:54-05:00 New Revision: d6d36baa33e76ace11ac20c03de1097d48bd9246 URL: https://github.com/llvm/llvm-project/commit/d6d36baa33e76ace11ac20c03de1097d48bd9246 DIFF: https://github.com/llvm/llvm-project/commit/d6d36baa33e76ace11ac20c03de1097d48bd9246.diff LO

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

aaron.ballman closed this revision. aaron.ballman added a comment. In D94624#2516540 , @tomrittervg wrote: > Try rebasing it... Thanks, that was sufficient for me to apply it. I've commit on your behalf in d6d36baa33e76ace11ac20c03de1097d48bd9246

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 318975. jansvoboda11 added a comment. Undo changes to string allocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472 Files: clang/include/clang/Driver/Options

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

vsavchenko added a comment. In D95307#2519309 , @RedDocMD wrote: > Funnily enough, when I run `ninja clang-check` I don't get any errors. I believe that `ninja check-clang` is the right command (clang-check is a tool) :-) Repository: rG LLVM Github M

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

ZarkoCA updated this revision to Diff 318971. ZarkoCA marked an inline comment as done. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Emit error message only when option is active - Changed description of patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94986

[clang] 84851a2 - Revert "[SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued"

Author: Abhina Sreeskantharajan Date: 2021-01-25T08:29:38-05:00 New Revision: 84851a274e2beaa3cdafd6a70e6d1128cabf8b21 URL: https://github.com/llvm/llvm-project/commit/84851a274e2beaa3cdafd6a70e6d1128cabf8b21 DIFF: https://github.com/llvm/llvm-project/commit/84851a274e2beaa3cdafd6a70e6d1128cabf

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan reopened this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. In D95246#2518989 , @jhenderson wrote: > Sorry, could you revert this please. I don't think this is a good fix, as >

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov added a comment. @steakhal > Why don't you use the `SValVisitor` instead? I simply didn't know of its exsistence. We can try to transform this patch using `SValVisitor` in the next revision to make the review easier and avoid additional complexity. Comment at:

[PATCH] D95145: [clang] Fix a nullptr dereference bug on invalid code

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2 +// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify +#include + adamcz

[PATCH] D95057: [clangd] Allow configuration database to be specified in config.

sammccall updated this revision to Diff 318980. sammccall marked 4 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95057/new/ https://reviews.llvm.org/D95057 Files: clang-tools-e

[PATCH] D95057: [clangd] Allow configuration database to be specified in config.

sammccall added a comment. In D95057#2518903 , @kadircet wrote: > I believe we should log some warning at startup if user has provided > `--compile-commands-dir`. Saying that "CDB search customizations through > config is disabled". So I considered this

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

jhenderson added a comment. In D95246#2519642 , @abhina.sreeskantharajan wrote: > In D95246#2518989 , @jhenderson > wrote: > >> Sorry, could you revert this please. I don't think this is a good fix, as >> you've

[PATCH] D95145: [clang] Fix a nullptr dereference bug on invalid code

This revision was automatically updated to reflect the committed changes. Closed by commit rGd462aa5a619a: [clang] Fix a nullptr dereference bug on invalid code (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95145/new/ https://r

[clang] d462aa5 - [clang] Fix a nullptr dereference bug on invalid code

Author: Adam Czachorowski Date: 2021-01-25T15:02:25+01:00 New Revision: d462aa5a619ab9fdf8b024e48c19bc8820fe8781 URL: https://github.com/llvm/llvm-project/commit/d462aa5a619ab9fdf8b024e48c19bc8820fe8781 DIFF: https://github.com/llvm/llvm-project/commit/d462aa5a619ab9fdf8b024e48c19bc8820fe8781.d

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:647-650 + // Array to pointer. + if (isa(OriginalTy)) +if (CastTy->isPointerType() || CastTy->isReferenceType()) return UnknownVal(); ASDenysPetrov wrote: > ste

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan added a comment. In D95246#2519729 , @jhenderson wrote: > In D95246#2519642 , > @abhina.sreeskantharajan wrote: > >> In D95246#2518989 , @jhenderson

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov updated this revision to Diff 318991. ASDenysPetrov added a comment. Updated. Naming fixes. Member access changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90157/new/ https://reviews.llvm.org/D90157 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValB

[PATCH] D95349: [clangd] Allow diagnostics to be suppressed with configuration

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:808 +llvm::StringRef Code(CodePtr); +Code.consume_front("err_"); +if (Suppress.contains(Code)) --

[PATCH] D95057: [clangd] Allow configuration database to be specified in config.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:278 + // Drop trailing slash to put the path in canonical form. + // Should makeAbs

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added a comment. In D94472#2508018 , @dexonsmith wrote: > I have three concerns with the approach: > > 1. Churn. This adds a lot of code that will eventually be removed / > refactored away. One example is that shifting the `NDEBUG` logic to t

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

ASDenysPetrov added a comment. What about this change? Did you make more measurements? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86295/new/ https://reviews.llvm.org/D86295 ___ cfe-commits mailing lis

[clang] 0005438 - [clangd] Fix a crash when indexing invalid ObjC method declaration

Author: Adam Czachorowski Date: 2021-01-25T15:43:11+01:00 New Revision: 00054382b95a9d95e2df6457e7fe1fca2323d287 URL: https://github.com/llvm/llvm-project/commit/00054382b95a9d95e2df6457e7fe1fca2323d287 DIFF: https://github.com/llvm/llvm-project/commit/00054382b95a9d95e2df6457e7fe1fca2323d287.d

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG00054382b95a: [clangd] Fix a crash when indexing invalid ObjC method declaration (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94919/ne

[clang-tools-extra] 7e506b3 - [clangd] Allow diagnostics to be suppressed with configuration

Author: Sam McCall Date: 2021-01-25T15:59:07+01:00 New Revision: 7e506b30a1e1500c3b0b54fba88ea664bc4232e5 URL: https://github.com/llvm/llvm-project/commit/7e506b30a1e1500c3b0b54fba88ea664bc4232e5 DIFF: https://github.com/llvm/llvm-project/commit/7e506b30a1e1500c3b0b54fba88ea664bc4232e5.diff LO

[PATCH] D95349: [clangd] Allow diagnostics to be suppressed with configuration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e506b30a1e1: [clangd] Allow diagnostics to be suppressed with configuration (authored by sammccall). Changed prior to commit: https://reviews.llv

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added inline comments. Comment at: clang/lib/AST/Expr.cpp:1402 const FunctionType *FnType = CalleeType->castAs(); return FnType->getReturnType(); Here occurs the problem: If `CalleeType` is of type `BuiltinType::Overload` it does not cast to `Fu

[PATCH] D95362: [clangd] Parse Diagnostics block, and nest ClangTidy block under it.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. (ClangTidy configuration block ha

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

tmatheson marked 2 inline comments as done. tmatheson added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93101/new/ https://reviews.llvm.org/D93101 ___ cfe-commits mailing list cfe-commi

[PATCH] D82862: [ThinLTO] Always parse module level inline asm with At&t dialect

anirudhp added a comment. In D82862#2513044 , @rnk wrote: > In D82862#2512908 , @uweigand wrote: > >> So why do you want GNU inline asm for clang-cl anyway? I thought the whole >> point of clang-cl was to be comp

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 319000. khchen marked 7 inline comments as done. khchen added a comment. 1. address @HsiangKai's comments 2. remove test generator to make td simpler. 3. remove MangledSuffix, it should be MangledName Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:161 + // This builtin is valid for the given exponental LMULs. + list ELMUL = [0, 1, 2, 3, -1, -2, -3]; + HsiangKai wrote: > EMUL according to specification. Here ELMUL means e

[PATCH] D95365: [clangd] Add include-fixer fixit for no_member_template diagnostic.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D95362: [clangd] Parse Diagnostics block, and nest ClangTidy block under it.

njames93 added a comment. LG, Obviously we need to get this in before the branch or get it cherrypicked. Also documentation will need updating on https://github.com/llvm/clangd-www. Do you want to sort that out? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

  1   2   3   >