kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, lgtm! ================ Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:278 + // Drop trailing slash to put the path in canonical form. + // Should makeAbsolute do this? + llvm::StringRef Rel = llvm::sys::path::relative_path(*Path); ---------------- sammccall wrote: > kadircet wrote: > > +1 i think it should. > Right... the reason I didn't make the change in this patch is that it > affected MountPoint of indexes, and there were tests of that, and code using > starts_with in a way that suggested it might be important. > > So we should clean this up somehow, but I didn't want to bite it off here. SG. As a note to future self, I don't remember the tests but in theory the startswith should be fine with and without the trailing slash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95057/new/ https://reviews.llvm.org/D95057 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
