[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. In D93747#2481383 , @hoy wrote: > In D93747#2481304 , @tmsriram wrote: > >> In D93747#2481223 , @tmsriram wrote: >> >>> In D93747#2481163

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

danielmarjamaki added a comment. > I also agree with @NoQ's D92634#2478703 > comment. well.. maybe it's better that I stop programming then and take this code I had and test it out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D93796: [clangd][fuzzyFind] Do not show stale symbols in the result.

This revision was automatically updated to reflect the committed changes. Closed by commit rG979228f120f4: [clangd][fuzzyFind] Do not show stale symbols in the result. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93796/new/ h

[clang-tools-extra] 979228f - [clangd][fuzzyFind] Do not show stale symbols in the result.

Author: Aleksandr Platonov Date: 2021-01-06T11:17:12+03:00 New Revision: 979228f120f4aa1265648b1c06f65a84bcca1ed6 URL: https://github.com/llvm/llvm-project/commit/979228f120f4aa1265648b1c06f65a84bcca1ed6 DIFF: https://github.com/llvm/llvm-project/commit/979228f120f4aa1265648b1c06f65a84bcca1ed6.

[PATCH] D94021: [OpenCL] Add clang extension for function pointers

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94021/new/ https://reviews.llvm.org/D94021 ___ cfe-commits mailing list cfe-com

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

mantognini added a comment. LGTM, just one question: I see in the other review you updated clang/test/SemaOpenCL/extension-version.cl. Do you need to do the same here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94027/new/ https://reviews.llvm.org/D94027

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

RKSimon accepted this revision. RKSimon added a comment. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

xbolva00 added a comment. Patch title should be adjusted I think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. LGTM, except for a minor typo. Otherwise my comments have been addressed. Thanks. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+==+==+

[PATCH] D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel.

Esme created this revision. Esme added reviewers: steven.zhang, nemanjai, qiucf, shchenz, PowerPC. Herald added a subscriber: kbarton. Esme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch added the following variants of vec_sel.

[PATCH] D93453: [flang][driver] Add support for `-I`

sscalpone added a comment. Flang supports include files and module files. The search path is used to look for both include files and module files. The help text doesn't include info about module files. The help text refers to the -isystem option. Is that implemented for flang, and if so, ou

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

NoQ updated this revision to Diff 314846. NoQ added a comment. Handle conflicts across redeclarations! Fix typos and documentation formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91898/new/ https://reviews.llvm.org/D91898 Files: clang/include/clang/Basic/Attr.td clang/inc

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

NoQ added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11087 +// TCB warnings +def err_tcb_conflicting_attributes : Error< + "attributes '%0(\"%2\")' and '%1(\"%2\")' are mutually exclusive">; aaron.ballman wrote: > NoQ wrote: >

[PATCH] D94131: [clang-tidy] Use new mapAnyOf matcher

njames93 added a comment. Theres a few compile errors here in the pre merge. Is this patch based against trunk or some local branch? Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:313 // may be instantiated to use std::move() on built-i

[PATCH] D38968: [OpenMP] Implement omp_is_initial_device() as builtin

JonChesterfield added subscribers: jdoerfert, JonChesterfield. JonChesterfield added a comment. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a reviewer: jdoerfert. @jdoerfert suggested replacing this with a context selector. One less special case in clang. Related, if this

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314856. Anastasia added a comment. Another fix from Marco. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/UsersManual.

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

aaron.ballman added a comment. In D94092#2481276 , @rjmccall wrote: > Without bothering to look it up, I would guess that the attribute-parsing > code used to generically handle the ambiguity between identifier expressions > and identifier attribute argu

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 added a comment. @thakis Thanks for the heads-up and sorry for the inconvenience. @rnk You're right. This patch accidentally changed `Group` to `Group` for `-g[no-]column-info`. In the linked build, this caused expansion of the driver flag `-gcolumn-info` to cc1 flag `-debug-info

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

steakhal updated this revision to Diff 314857. steakhal marked 11 inline comments as done. steakhal added a comment. - move `MacroExpansionRangeRecorder` to `clang::detail` and mark it as a friend class - fix comment typo in `getExpandedMacroForLocation` - rename `getExpandedMacroForLocation` ->

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 314858. reikdas marked an inline comment as done. reikdas added a comment. Address @rsmith review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/inclu

[PATCH] D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94083/new/ https://reviews.llvm.org/D94083 ___ cfe

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 314859. reikdas marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/StmtDataCollectors.td clang/include

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

aaron.ballman added subscribers: cfe-commits, aaron.ballman. aaron.ballman added reviewers: rsmith, jyknight. aaron.ballman added a comment. Adding some reviewers and subscribing the mailing lists. FWIW, the changes seem reasonable to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski created this revision. Herald added a subscriber: dang. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The help text for `-I` was recently expanded in this commit: - 8dd4e3ceb804a58bcf25e6856fc6fde5e1995a66

[PATCH] D93453: [flang][driver] Add support for `-I`

awarzynski added a comment. In D93453#2481720 , @sscalpone wrote: > Flang supports include files and module files. The search path is used to > look for both include files and module files. The help text doesn't include > info about module files. Good

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

xbolva00 added a comment. int a, b; int f(void) { while (1) { if (a != b) return 1; } return 0; } int g(int a, int b) { while (1) { if (a != b) return 1; } return 0; } LLVM does not catch these cases; gcc does. https://godbo

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

jansvoboda11 updated this revision to Diff 314866. jansvoboda11 added a comment. Instead of making Diags optional everywhere, pass an ignoring Diags into ParseDiagnosticArgs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93701/new/ https://reviews

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added a comment. In D93377#2481312 , @rjmccall wrote: > Are you committed to the name `__ibm128`? Insofar as that's what GCC on Power (for example, `gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0` from 2017) has shipped with for several y

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

Anastasia updated this revision to Diff 314869. Anastasia added a comment. Added missing testing in extension-version.cl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94027/new/ https://reviews.llvm.org/D94027 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/OpenC

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

Anastasia added a comment. In D94027#2481597 , @mantognini wrote: > LGTM, just one question: I see in the other review you updated > clang/test/SemaOpenCL/extension-version.cl. Do you need to do the same here? Good spot! Thanks! CHANGES SINCE LAST ACTI

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806 ___

[PATCH] D94172: [clang][cli] NFC: Move marshalling macros closer together

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch moves marshalling macros closer together. In a future patch that starts reusing them, th

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94027/new/ https://reviews.llvm.org/D94027 ___ cfe-commits ma

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 updated this revision to Diff 314873. jansvoboda11 added a comment. Pass local variables to macros explicitly, rebase on top of prep patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93702/new/ https://reviews.llvm.org/D93702 Files

[PATCH] D94172: [clang][cli] NFC: Move marshalling macros closer together

jansvoboda11 updated this revision to Diff 314876. jansvoboda11 added a comment. Only more parseSimpleArgs closer to ParseDiagnosticArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94172/new/ https://reviews.llvm.org/D94172 Files: clang/lib/Fr

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

erichkeane added a comment. In D94092#2481857 , @aaron.ballman wrote: > In D94092#2481276 , @rjmccall wrote: > >> Without bothering to look it up, I would guess that the attribute-parsing >> code used to generical

[clang] 29d375f - [OpenCL][NFC] Improve OpenCL test file naming

Author: Sven van Haastregt Date: 2021-01-06T14:16:44Z New Revision: 29d375f5ff27dc49c2c88c2ec1093cfcd826d449 URL: https://github.com/llvm/llvm-project/commit/29d375f5ff27dc49c2c88c2ec1093cfcd826d449 DIFF: https://github.com/llvm/llvm-project/commit/29d375f5ff27dc49c2c88c2ec1093cfcd826d449.diff

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 updated this revision to Diff 314877. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93702/new/ https://reviews.llvm.org/D93702 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clang/lib/

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 314879. achieveartificialintelligence marked 5 inline comments as done. achieveartificialintelligence added a comment. Thanks for suggestions. We updated the code again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11087 +// TCB warnings +def err_tcb_conflicting_attributes : Error< + "attributes '%0(\"%2\")' and '%1(\"%2\")' are mutually exclusive">; NoQ wrote: > aaron.ballman

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 314887. jansvoboda11 added a comment. Rebase on top of prep patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files: clang/include/clang/Basic/DiagnosticOp

[clang] 0c41b1c - [Driver][MachineOutliner] Support outlining option with LTO

Author: Yvan Roux Date: 2021-01-06T16:01:38+01:00 New Revision: 0c41b1c9f93c09966b87126820d3cf41d8eebbf9 URL: https://github.com/llvm/llvm-project/commit/0c41b1c9f93c09966b87126820d3cf41d8eebbf9 DIFF: https://github.com/llvm/llvm-project/commit/0c41b1c9f93c09966b87126820d3cf41d8eebbf9.diff LOG

[PATCH] D93385: [Driver][MachineOutliner] Support outlining option with LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c41b1c9f93c: [Driver][MachineOutliner] Support outlining option with LTO (authored by yroux). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D94177: [analyze] Add better support for leaks (and similar diagnostics)

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, jkorous, aaron.ballman, martong, Szelethus, steakhal. Herald added subscribers: Charusso, rnkovacs. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In

[clang] 3fa6ced - Fix MaterializeTemporaryExpr's type when its an incomplete array.

Author: Erich Keane Date: 2021-01-06T07:17:12-08:00 New Revision: 3fa6cedb6be809092f8a8b27e63bd4f6dc526a08 URL: https://github.com/llvm/llvm-project/commit/3fa6cedb6be809092f8a8b27e63bd4f6dc526a08 DIFF: https://github.com/llvm/llvm-project/commit/3fa6cedb6be809092f8a8b27e63bd4f6dc526a08.diff L

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fa6cedb6be8: Fix MaterializeTemporaryExpr's type when its an incomplete array. (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93587: [hip] Fix HIP version parsing.

yaxunl added a comment. Pls address Artem's comments. LGTM otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93587/new/ https://reviews.llvm.org/D93587 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

NoQ updated this revision to Diff 314898. NoQ marked 2 inline comments as done. NoQ added a comment. Drop broken attributes. Fix naming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91898/new/ https://reviews.llvm.org/D91898 Files: clang/include/clang/Basic/Attr.td clang/include/c

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

NoQ added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11087 +// TCB warnings +def err_tcb_conflicting_attributes : Error< + "attributes '%0(\"%2\")' and '%1(\"%2\")' are mutually exclusive">; aaron.ballman wrote: > NoQ wrote: >

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 314900. jansvoboda11 added a comment. Introduce `IsDiag` mixin, add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files: clang/include/clang/Basic/Diagnos

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

jhuber6 updated this revision to Diff 314899. jhuber6 retitled this revision from "[NVPTX] Strip debugging symbols for optimized NVPTX targets." to "[NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled". jhuber6 edited the summary of this revision. jhuber6 added a

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

fhahn added a comment. In D94092#2482035 , @erichkeane wrote: > In D94092#2481857 , @aaron.ballman > wrote: > >> In D94092#2481276 , @rjmccall wrote: >> >>> Without botherin

[PATCH] D93453: [flang][driver] Add support for `-I`

FarisRehman updated this revision to Diff 314905. FarisRehman added a comment. Address minor changes in review comments Summary of changes - Add a TODO for future search-path related options - Change the text which the driver-help tests look for, which matches the help message in #D94169 - Rena

[clang] 7809fa2 - [flang][driver] Add support for `-D`, `-U`

Author: Faris Rehman Date: 2021-01-06T16:17:13Z New Revision: 7809fa2040fd40b4a4b56696c7fbcd0f0fa9 URL: https://github.com/llvm/llvm-project/commit/7809fa2040fd40b4a4b56696c7fbcd0f0fa9 DIFF: https://github.com/llvm/llvm-project/commit/7809fa2040fd40b4a4b56696c7fbcd0f0fa9.diff LOG:

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7809fa204000: [flang][driver] Add support for `-D`, `-U` (authored by FarisRehman, committed by awarzynski). Changed prior to commit: https://revi

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 314907. jansvoboda11 added a comment. Use arrow instead of dot in keypath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files: clang/include/clang/Basic/Diagno

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm added a comment. Hi everyone, I realise that most people have probably been on holiday recently, but just a gentle ping here to see if anyone could take another look? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89031/new/ https://reviews.llvm.org/D89031 ___

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return MarshallingInfo:

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3040 -#define OPTION_WITH_MARSHALLING( \ -PREFIX_TYPE, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM, \ -HELPTEXT, ME

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

Xiangling_L updated this revision to Diff 314911. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Add pre-committing tests with the incorrect behaviour as part of the NFC patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/ https://reviews.llvm.org/

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfd3384feeca: [InstCombine] Update valueCoversEntireFragment to use TypeSize (authored by fpetrogalli, committed by peterwaller-arm). Repository:

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman added inline comments. Comment at: clang/test/Sema/reserved-identifier.c:9 +int _foo() { return 0; }// expected-warning {{'_foo' is a reserved identifier}} + +// This one is explicitly skipped by -Wreserved-identifier Can you add a test tha

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. thanks for working on this! just one tiny nit and lgtm Comment at: clang/lib/AST/ExprConstant.cpp:11408 // If we point to before the start of the

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; balazske wrote: > shafik wrote: > > Is this to fix th

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. LGTM, perhaps wait a day with committing in case there are more comments. Comment at: clang/include/clang/Basic/Attr.td:3356 EnumArgument<"State", "LoopHintState", - ["en

[clang] 7ef9139 - [Clang] Remove unnecessary Attr.isArgIdent checks.

Author: Florian Hahn Date: 2021-01-06T18:01:41Z New Revision: 7ef9139a391a6d526afab0216a97f9d65a6b5563 URL: https://github.com/llvm/llvm-project/commit/7ef9139a391a6d526afab0216a97f9d65a6b5563 DIFF: https://github.com/llvm/llvm-project/commit/7ef9139a391a6d526afab0216a97f9d65a6b5563.diff LOG:

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ef9139a391a: [Clang] Remove unnecessary Attr.isArgIdent checks. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

jdoerfert added a comment. OK with me, @tra ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94123/new/ https://reviews.llvm.org/D94123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

rjmccall added a comment. In D94092#2481857 , @aaron.ballman wrote: > In D94092#2481276 , @rjmccall wrote: > >> Without bothering to look it up, I would guess that the attribute-parsing >> code used to generically

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2481494 , @dblaikie wrote: > In D93747#2481383 , @hoy wrote: > >> In D93747#2481304 , @tmsriram wrote: >> >>> In D93747#2481223

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added a comment. In D93377#2481957 , @hubert.reinterpretcast wrote: > In D93377#2481312 , @rjmccall wrote: > >> Are you committed to the name `__ibm128`? > > Insofar as that's what GCC on Power (for exampl

[PATCH] D89490: Introduce __attribute__((darwin_abi))

rjmccall added a comment. I'm not calling Wine a niche use-case, I'm calling this feature a niche use-case. The lack of this feature has not blocked Wine from being a successful project. The feature has to stand on its own and be more broadly useful than the momentary convenience of a few dev

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94123/new/ https://reviews.llvm.org/D94123 ___ cfe-co

[PATCH] D93587: [hip] Fix HIP version parsing.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:97 for (auto Part : VersionParts) { auto Splits = Part.split('='); +if (Splits.first == "HIP_VERSION_MAJOR") { tra wrote: > `Part.t

[PATCH] D93587: [hip] Fix HIP version parsing.

hliao updated this revision to Diff 314941. hliao marked an inline comment as done. hliao added a comment. Revise following reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93587/new/ https://reviews.llvm.org/D93587 Files: clan

[clang] 1ca5e68 - [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

Author: Joseph Huber Date: 2021-01-06T13:43:22-05:00 New Revision: 1ca5e68aa07e30567c6aa2409c5641e0a2d77355 URL: https://github.com/llvm/llvm-project/commit/1ca5e68aa07e30567c6aa2409c5641e0a2d77355 DIFF: https://github.com/llvm/llvm-project/commit/1ca5e68aa07e30567c6aa2409c5641e0a2d77355.diff

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca5e68aa07e: [NVPTX] Fix debugging information being added to NVPTX target if remarks are… (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao updated this revision to Diff 314943. hliao added a comment. Only mark HD attributes in ymath.h wrapper header when compiled with MSVC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 Files: clang/l

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inl

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

MaskRay added a comment. If you use `arc diff`, you can obtain `Reviewed-by:` line from Phabricator. It is more useful than `Reviewers: ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94123/new/ https://reviews.llvm.org/D94123 ___

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

jdoerfert added a comment. In D94123#2482636 , @MaskRay wrote: > If you use `arc diff`, you can obtain `Reviewed-by:` line from Phabricator. > It is more useful than `Reviewers: ` (a list of reviewers do not mean they > endorse or accept the patch) `arc

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

tra added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double _Cosh(double

[PATCH] D94185: [OpenMP][Docs] Mark finished features as done

jdoerfert created this revision. jdoerfert added a reviewer: ABataev. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

apazos added a comment. Can you confirm when the GNU toolchain will have this flag supported in their assembler? Compatibility between LLVM and GNU toolchains is important. Stephen - I think we can abandon this review. Users will need to be made aware of this additional assembler flag when buil

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

rnk added a comment. Generally makes sense, but I had a concern. Comment at: clang/include/clang/Basic/LangOptions.h:333 + /// the -ffuchsia-c++-abi flag. + bool UseFuchsiaCXXABI; + Why isn't this part of the LangOptions.def xmacro list? Repository: rG LL

[PATCH] D93587: [hip] Fix HIP version parsing.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM overall. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:92 +// Parse and extract version numbers from `.hipVersion`. Return `true` if +// the parsing fails. +bool RocmInst

[PATCH] D94185: [OpenMP][Docs] Mark finished features as done

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94185/new/ https://reviews.llvm.org/D94185 ___ c

[PATCH] D94186: [FPEnv][PowerPC] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

kpn created this revision. kpn added reviewers: steven.zhang, nemanjai. kpn added a project: clang. Herald added subscribers: shchenz, kbarton. kpn requested review of this revision. Herald added a subscriber: cfe-commits. Currently clang is not correctly retrieving from the AST the metadata for

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2482519 , @tmsriram wrote: > In D93747#2481494 , @dblaikie wrote: > >> In D93747#2481383 , @hoy wrote: >> >>> In D93747#2481304

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 314955. hoy added a comment. Renaming debug linkage name if it preexisits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2482726 , @hoy wrote: > In D93747#2482519 , @tmsriram wrote: > >> In D93747#2481494 , @dblaikie wrote: >> >>> In D93747#2481383

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2482730 , @tmsriram wrote: > In D93747#2482726 , @hoy wrote: > >> In D93747#2482519 , @tmsriram wrote: >> >>> In D93747#2481494

[clang-tools-extra] 0bfe100 - [NFC] Test case refactor

Author: Nathan James Date: 2021-01-06T20:00:15Z New Revision: 0bfe100145634988e4a914da776b55509ba0bec0 URL: https://github.com/llvm/llvm-project/commit/0bfe100145634988e4a914da776b55509ba0bec0 DIFF: https://github.com/llvm/llvm-project/commit/0bfe100145634988e4a914da776b55509ba0bec0.diff LOG:

[PATCH] D92270: [ConstantFold] Fold more operations to poison

thakis added a comment. We bisected a test failure to this (https://bugs.chromium.org/p/angleproject/issues/detail?id=5500#c17). Can you expand a bit on what this patch means in practice? I'm guessing it makes UB in C++ code have bad effects more often? If so, what type of UB? Repository: r

[PATCH] D92954: [clang-offload-bundler] Add option -list

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:176 + /// List bundle IDs in \a Input. + virtual Error listBundleIDs(MemoryBuffer &Input) { +if (Error Err = ReadHeader(Input)) -

[PATCH] D92954: [clang-offload-bundler] Add option -list

yaxunl updated this revision to Diff 314957. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92954/new/ https://reviews.llvm.org/D92954 Files: clang/test/Driver/clang-offload-bundler.c clang/

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

dexonsmith added inline comments. Comment at: clang/include/clang/Driver/Options.td:1193-1195 +defm caret_diagnostics : BoolFOption<"caret-diagnostics", + "DiagnosticOpts->ShowCarets", DefaultsToTrue, + ChangedBy, ResetBy>, IsDiag; There was one thing in the or

[PATCH] D94172: [clang][cli] NFC: Move parseSimpleArgs

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94172/new/ https://reviews.llvm.org/D94172

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93702/new/ https://reviews.llvm.org/D93702

[clang] 4fde2b6 - [OpenCL] Add clang extension for function pointers.

Author: Anastasia Stulova Date: 2021-01-06T20:39:57Z New Revision: 4fde2b6a0c080cb2a598383b5850038d67ca6833 URL: https://github.com/llvm/llvm-project/commit/4fde2b6a0c080cb2a598383b5850038d67ca6833 DIFF: https://github.com/llvm/llvm-project/commit/4fde2b6a0c080cb2a598383b5850038d67ca6833.diff

  1   2   >