SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
LGTM, perhaps wait a day with committing in case there are more comments.
================
Comment at: clang/include/clang/Basic/Attr.td:3356
EnumArgument<"State", "LoopHintState",
- ["enable", "disable", "numeric", "assume_safety",
"full"],
- ["Enable", "Disable", "Numeric", "AssumeSafety",
"Full"]>,
+ ["enable", "disable", "numeric", "fixed_width",
"scalable_width", "assume_safety", "full"],
+ ["Enable", "Disable", "Numeric", "FixedWidth",
"ScalableWidth", "AssumeSafety", "Full"]>,
----------------
aaron.ballman wrote:
> david-arm wrote:
> > aaron.ballman wrote:
> > > Should the documentation in AttrDocs.td be updated for this change?
> > Hi @aaron.ballman I had a look at LoopHintDocs in AttrDocs.td and it didn't
> > explicitly mention these states, i.e. "assume_safety", "numeric", etc., so
> > I'm not sure if it's necessary to add anything there?
> Oh, I see now, we're deferring to the documentation in the language
> extensions document. I suppose that's fine as far as this patch goes, sorry
> for the noise.
Nit: formatting, exceeding 80 columns?
================
Comment at: clang/include/clang/Basic/Attr.td:3357
+ ["enable", "disable", "numeric", "fixed_width",
"scalable_width", "assume_safety", "full"],
+ ["Enable", "Disable", "Numeric", "FixedWidth",
"ScalableWidth", "AssumeSafety", "Full"]>,
ExprArgument<"Value">];
----------------
same?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89031/new/
https://reviews.llvm.org/D89031
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
