[clang] f67d3db - [clang] - Also look for devtoolset-10

Author: Petr Hosek Date: 2021-01-04T14:24:46-08:00 New Revision: f67d3dbdb930eaf92668b47696e51ef0b2c3c3a5 URL: https://github.com/llvm/llvm-project/commit/f67d3dbdb930eaf92668b47696e51ef0b2c3c3a5 DIFF: https://github.com/llvm/llvm-project/commit/f67d3dbdb930eaf92668b47696e51ef0b2c3c3a5.diff LO

[PATCH] D92792: [clang] - Also look for devtoolset-10

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf67d3dbdb930: [clang] - Also look for devtoolset-10 (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

dblaikie added a comment. Please add a clang test for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94019/new/ https://reviews.llvm.org/D94019 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

aeubanks added a comment. I don't think a test is necessary for an NFC change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94019/new/ https://reviews.llvm.org/D94019 ___ cfe-commits mailing list cfe-co

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

hoy added a comment. In D94019#2478045 , @dblaikie wrote: > Please add a clang test for this. There is the original clang test `unique-internal-linkage-names.cpp` that still works with the change here. What kind of new test would you like? Repository:

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

dblaikie added a comment. In D94019#2478047 , @hoy wrote: > In D94019#2478045 , @dblaikie wrote: > >> Please add a clang test for this. > > There is the original clang test `unique-internal-linkage-names.cpp` that

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

dblaikie added a comment. In D94019#2478046 , @aeubanks wrote: > I don't think a test is necessary for an NFC change. My understanding is that this change does have a functional change. It's not a refactoring change but changes the resulting output of Cl

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

tinloaf added inline comments. Comment at: clang/include/clang/Format/Format.h:117 +/// int b= 23; +/// +/// int ccc = 23; HazardyKnusperkeks wrote: > You are adding a Tab here, or do I misinterpret this? Shouldn't that be fixed > by clang-f

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. @alokmishra.besu, I'm trying to play/learn with your patch so I downloaded the diff and apply it to the master branch, however, I'm getting error messages everywhere if `llvm::omp::OMPD_metadirective` appears: llvm-project/clang/include/clang/AST/StmtOpenMP.h:384:43: er

[PATCH] D92792: [clang] - Also look for devtoolset-10

phosek added a comment. In D92792#2475182 , @stephan.dollberg wrote: > Ping @phosek Merged, sorry about the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92792/new/ https://reviews.llvm.org/D92792

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, dexonsmith, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. C

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

hoy added a comment. In D94019#2478048 , @dblaikie wrote: > In D94019#2478047 , @hoy wrote: > >> In D94019#2478045 , @dblaikie wrote: >> >>> Please add a clang test for this.

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

dblaikie added a comment. In D94019#2478206 , @hoy wrote: > In D94019#2478048 , @dblaikie wrote: > >> In D94019#2478047 , @hoy wrote: >> >>> In D94019#2478045

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

hoy added a comment. In D94019#2478253 , @dblaikie wrote: > In D94019#2478206 , @hoy wrote: > >> In D94019#2478048 , @dblaikie wrote: >> >>> In D94019#2478047

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:943 +static MCRegister convertGPRToGPRPD(MCRegister Reg) { + assert(Reg >= RISCV::X0 && Reg <= RISCV::X31 && !((Reg - RISCV::X0) & 1) && + "Invalid register");

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

dblaikie added a comment. In D94019#2478277 , @hoy wrote: > In D94019#2478253 , @dblaikie wrote: > >> In D94019#2478206 , @hoy wrote: >> >>> In D94019#2478048

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

hoy added a comment. In D94019#2478284 , @dblaikie wrote: > In D94019#2478277 , @hoy wrote: > >> In D94019#2478253 , @dblaikie wrote: >> >>> In D94019#2478206

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

dblaikie added a comment. In D94019#2478308 , @hoy wrote: > In D94019#2478284 , @dblaikie wrote: > >> In D94019#2478277 , @hoy wrote: >> >>> In D94019#2478253

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

aeubanks added a comment. Oh sorry, yeah this isn't NFC. But I still don't think this needs a new test. We're going from a custom Clang implementation of adding passes to something more generic that's also more tested within LLVM. So IMO we just need an end to end test, which we already have in

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

dblaikie added a comment. In D94019#2478378 , @aeubanks wrote: > Oh sorry, yeah this isn't NFC. > > But I still don't think this needs a new test. We're going from a custom > Clang implementation of adding passes to something more generic that's also > m

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

aeubanks added a comment. In D94019#2478423 , @dblaikie wrote: > In D94019#2478378 , @aeubanks wrote: > >> Oh sorry, yeah this isn't NFC. >> >> But I still don't think this needs a new test. We're going from a custo

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

OikawaKirie added a comment. In D92634#2477342 , @danielmarjamaki wrote: >> However, the mainstream compilers like GCC and Clang implement this as the >> overflowed value, and some programmers also use this feature to do some >> tricky things. > > hmm..

[PATCH] D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, jdoerfert, ABataev. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a

[PATCH] D93385: [Driver][MachineOutliner] Support outlining option with LTO

yroux added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93385/new/ https://reviews.llvm.org/D93385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 314509. nullptr.cpp added a comment. Fix use-of-uninitialized-value and `-Wreturn-std-move` with delete function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Fil

<    1   2