[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added a comment. In D92039#2458392 , @aaron.ballman wrote: > > There have been efforts to add cross-TU support to the static analyzer, so > I'm less worried about cross-TU inter-procedural bugs over the long term as I > would expect that

[PATCH] D93522: [WIP] [clangd] Extend heuristic resolution to support nested templates

nridge created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. https://github.com/clangd/clangd/issues/451 Repository: rG

[clang] f4511ae - [clang][cli] Port HeaderSearch simple string options to new option parsing system

Author: Jan Svoboda Date: 2020-12-18T09:30:32+01:00 New Revision: f4511aec2bf482f2ae5bbd14138a229b72c41c80 URL: https://github.com/llvm/llvm-project/commit/f4511aec2bf482f2ae5bbd14138a229b72c41c80 DIFF: https://github.com/llvm/llvm-project/commit/f4511aec2bf482f2ae5bbd14138a229b72c41c80.diff L

[PATCH] D84670: [clang][cli] Port HeaderSearch simple string options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4511aec2bf4: [clang][cli] Port HeaderSearch simple string options to new option parsing… (authored by jansvoboda11). Changed prior to commit: htt

[PATCH] D84670: [clang][cli] Port HeaderSearch simple string options to new option parsing system

jansvoboda11 added a comment. Committing with whitespace fix and with `std::string` constructors removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84670/new/ https://reviews.llvm.org/D84670 ___ cfe-

[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

nridge added a comment. In D92290#2460748 , @sammccall wrote: > my manager was appalled when we added it... :-) > Does this enable some future work, or is it reasonable to evaluate this patch > in isolation? I was inspired to do this by a work-in-progr

[PATCH] D93522: [WIP] [clangd] Extend heuristic resolution to support nested templates

nridge added a comment. (This is not ready for review, I just posted it in case it helps inform discussion in D92290 .) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93522/new/ https://reviews.llvm.org/D93522

[clang] ff4b76d - [clang][cli] Port TargetOpts simple string based options to new option parsing system

Author: Jan Svoboda Date: 2020-12-18T09:40:56+01:00 New Revision: ff4b76d74f38a3816495c9914789e87a95525cf4 URL: https://github.com/llvm/llvm-project/commit/ff4b76d74f38a3816495c9914789e87a95525cf4 DIFF: https://github.com/llvm/llvm-project/commit/ff4b76d74f38a3816495c9914789e87a95525cf4.diff L

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff4b76d74f38: [clang][cli] Port TargetOpts simple string based options to new option parsing… (authored by jansvoboda11). Changed prior to commit:

[clang] aec2991 - [clang][cli] Port LangOpts simple string based options to new option parsing system

Author: Jan Svoboda Date: 2020-12-18T09:44:02+01:00 New Revision: aec2991d083a9c5b92f94d84a7b3a7bbed405af8 URL: https://github.com/llvm/llvm-project/commit/aec2991d083a9c5b92f94d84a7b3a7bbed405af8 DIFF: https://github.com/llvm/llvm-project/commit/aec2991d083a9c5b92f94d84a7b3a7bbed405af8.diff L

[PATCH] D84671: [clang][cli] Port LangOpts simple string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaec2991d083a: [clang][cli] Port LangOpts simple string based options to new option parsing… (authored by jansvoboda11). Repository: rG LLVM Github

[clang] d1b3f82 - [clang][cli] Port PreprocessorOpts simple string based options to new option parsing system

Author: Jan Svoboda Date: 2020-12-18T09:52:20+01:00 New Revision: d1b3f82e51378dd9fb5a23806d8fa906151f5e7b URL: https://github.com/llvm/llvm-project/commit/d1b3f82e51378dd9fb5a23806d8fa906151f5e7b DIFF: https://github.com/llvm/llvm-project/commit/d1b3f82e51378dd9fb5a23806d8fa906151f5e7b.diff L

[PATCH] D84672: [clang][cli] Port PreprocessorOpts simple string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1b3f82e5137: [clang][cli] Port PreprocessorOpts simple string based options to new option… (authored by jansvoboda11). Changed prior to commit: h

[clang] 333d41e - [clang][cli] Port FrontendOpts simple string based options to new option parsing system

Author: Jan Svoboda Date: 2020-12-18T10:00:03+01:00 New Revision: 333d41e9eb8b5f6cd67d318e84ee8dba99b840cc URL: https://github.com/llvm/llvm-project/commit/333d41e9eb8b5f6cd67d318e84ee8dba99b840cc DIFF: https://github.com/llvm/llvm-project/commit/333d41e9eb8b5f6cd67d318e84ee8dba99b840cc.diff L

[PATCH] D84190: [clang][cli] Port FrontendOpts simple string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG333d41e9eb8b: [clang][cli] Port FrontendOpts simple string based options to new option… (authored by jansvoboda11). Changed prior to commit: https

[clang] 9e08e51 - [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

Author: Richard Smith Date: 2020-12-18T01:08:41-08:00 New Revision: 9e08e51a20d0d2b1c5724bb17e969d036fced4cd URL: https://github.com/llvm/llvm-project/commit/9e08e51a20d0d2b1c5724bb17e969d036fced4cd DIFF: https://github.com/llvm/llvm-project/commit/9e08e51a20d0d2b1c5724bb17e969d036fced4cd.diff

[clang] 569676c - Make Expr::HasSideEffect more precise for instantiation-dependent

Author: Richard Smith Date: 2020-12-18T01:08:42-08:00 New Revision: 569676c05725d79909bd8a9224bc709bd621553c URL: https://github.com/llvm/llvm-project/commit/569676c05725d79909bd8a9224bc709bd621553c DIFF: https://github.com/llvm/llvm-project/commit/569676c05725d79909bd8a9224bc709bd621553c.diff

[clang] 95d3cc6 - [clang][cli] Port CodeGenOpts simple string flags to new option parsing system

Author: Jan Svoboda Date: 2020-12-18T10:28:48+01:00 New Revision: 95d3cc67caac04668ef808f65c30ced60ed14f5d URL: https://github.com/llvm/llvm-project/commit/95d3cc67caac04668ef808f65c30ced60ed14f5d DIFF: https://github.com/llvm/llvm-project/commit/95d3cc67caac04668ef808f65c30ced60ed14f5d.diff L

[PATCH] D84669: [clang][cli] Port CodeGenOpts simple string flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95d3cc67caac: [clang][cli] Port CodeGenOpts simple string flags to new option parsing system (authored by jansvoboda11). Changed prior to commit:

[clang] 7d246cb - [flang][driver] Add support for `-fsyntax-only`

Author: Andrzej Warzynski Date: 2020-12-18T09:35:02Z New Revision: 7d246cb19db9fce65946fb4bac6e570787dbe78a URL: https://github.com/llvm/llvm-project/commit/7d246cb19db9fce65946fb4bac6e570787dbe78a DIFF: https://github.com/llvm/llvm-project/commit/7d246cb19db9fce65946fb4bac6e570787dbe78a.diff

[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

sammccall added a comment. Ah, I suspected something like this was afoot! The patch looks... exciting :-) And I definitely agree we should remove the hacks if we're going to have access to ASTContext anyway. I think an explicit parameter here is probably a good idea, it's a bit sad to lose tar

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d246cb19db9: [flang][driver] Add support for `-fsyntax-only` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam created this revision. saiislam added reviewers: grokos, hfinkel, jdoerfert, JonChesterfield, ronlieb, ABataev, mdtoguchi, kbobrovs, sdmitriev, gregrodgers, kkwli0, dreachem, Tyker, jsjodin. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:217 + if (!Buf || (*Buf)->getBufferSize() != Stat->getSize()) { +Size = NoFileCached; +elog("Failed to read {0}: {1}", Path, sammccall wrote: > adamcz wro

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam added a comment. Refer to D80816 for earlier review of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 ___

[clang-tools-extra] 9899319 - [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

Author: Sam McCall Date: 2020-12-18T11:16:46+01:00 New Revision: 98993193e9037345ad13720a62974064a5f3d953 URL: https://github.com/llvm/llvm-project/commit/98993193e9037345ad13720a62974064a5f3d953 DIFF: https://github.com/llvm/llvm-project/commit/98993193e9037345ad13720a62974064a5f3d953.diff LO

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98993193e903: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt (authored by sammccall). Changed prior to commit: https://rev

[PATCH] D84189: Let denormalizer decide how to render the option based on the option class

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84189/new/ https://reviews.llvm.org/D

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, krasimir, klimek, sammccall, benhamilton. MyDeveloperDay added projects: clang, clang-format. Herald added a subscriber: mgorny. MyDeveloperDay requested review of this revision. I find as I develop I'm moving between

[PATCH] D93452: [clangd] Trim memory after buildINdex

njames93 added a comment. In D93452#2460563 , @sammccall wrote: > I think we should pass a nonzero `pad` to malloc_trim of several MB. It only > affects the main thread, but the main thread is constantly allocating small > short-lived objects (e.g. JSON

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 312741. vsavchenko added a comment. Detect all conventions for captured parameters as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 Files: clang/include/cla

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312742. ArcsinX added a comment. Fix format Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-e

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

thakis added a comment. Seems to break tests on windows: http://45.33.8.238/win/30129/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92663/new/ https://reviews.llvm.org/D92663 ___ cfe-commits m

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau updated this revision to Diff 312747. qchateau marked 5 inline comments as done. qchateau added a comment. - Verify documentation in hover test on 'auto' - Fixed comments - Converted raw string to string to avoid trailing whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau added a comment. You can land this if it is still fine after my final update. email: quentin.chat...@gmail.com Thanks ! Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:2452 // In namespace ns ret_type foo(params) {})", }, I've

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Reusing the buffers for reading m

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2461510 , @mstorsjo wrote: > In D87188#2461497 , @lebedev.ri > wrote: > >> @mstorsjo i've bothered @dmajor to give this a try on some of mozilla's CI, >> and unfortunately it ca

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

curdeius added a comment. Why not using clang-format's support for JavaScript? It seems more complicated now, but it will probably allow to more easily change/add style options. WDYT? And what happens when reformatting only a part of a JSON? Should there be some tests for that? Repository: r

[clang-tools-extra] e35f922 - [clangd] Ignore the static index refs from the dynamic index files.

Author: Aleksandr Platonov Date: 2020-12-18T15:36:30+03:00 New Revision: e35f9229dcb264be4a0a1ecf5cca2493f2c48878 URL: https://github.com/llvm/llvm-project/commit/e35f9229dcb264be4a0a1ecf5cca2493f2c48878 DIFF: https://github.com/llvm/llvm-project/commit/e35f9229dcb264be4a0a1ecf5cca2493f2c48878.

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe35f9229dcb2: [clangd] Ignore the static index refs from the dynamic index files. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau updated this revision to Diff 312757. qchateau added a comment. Fix ExpandAutoType to not expand undeduced auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93227/new/ https://reviews.llvm.org/D93227 Files: clang-tools-extra/clangd/AST

[clang-tools-extra] e69e551 - new altera single work item barrier check

Author: Frank Derry Wanye Date: 2020-12-18T07:52:20-05:00 New Revision: e69e551e0e5fddffb6479da6a2998457104ba9e6 URL: https://github.com/llvm/llvm-project/commit/e69e551e0e5fddffb6479da6a2998457104ba9e6 DIFF: https://github.com/llvm/llvm-project/commit/e69e551e0e5fddffb6479da6a2998457104ba9e6.d

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

aaron.ballman closed this revision. aaron.ballman added a comment. In D72241#2461921 , @ffrankies wrote: > @aaron.ballman hmm, that is strange. I've rebased the patch and updated the > diff, let me know if this one doesn't work either or there's something

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

njames93 added a comment. In D72241#2461921 , @ffrankies wrote: > @aaron.ballman hmm, that is strange. I've rebased the patch and updated the > diff, let me know if this one doesn't work either or there's something else > you'd like me to try. Thanks! Fo

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

njames93 added a comment. 100% sure that failure is from trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93531/new/ https://reviews.llvm.org/D93531 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D84189: [clang][cli] Let denormalizer decide how to render the option based on the option class

jansvoboda11 updated this revision to Diff 312761. jansvoboda11 added a comment. Rebase, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84189/new/ https://reviews.llvm.org/D84189 Files: clang/include/clang/Driver/Options.td clang/lib/

[clang] 2d2498e - No longer reject tag declarations in the clause-1 of a for loop.

Author: Aaron Ballman Date: 2020-12-18T07:56:17-05:00 New Revision: 2d2498ec6c42b12eae873257e6ddcefe8348 URL: https://github.com/llvm/llvm-project/commit/2d2498ec6c42b12eae873257e6ddcefe8348 DIFF: https://github.com/llvm/llvm-project/commit/2d2498ec6c42b12eae873257e6ddcefe8348.diff

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the review! I've commit in 2d2498ec6c42b12eae873257e6ddcefe8348 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/ https://r

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

aaron.ballman added a comment. In D92039#2462255 , @vsavchenko wrote: > In D92039#2458392 , @aaron.ballman > wrote: > >> > > > >> There have been efforts to add cross-TU support to the static analyzer, so >> I'm

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

njames93 updated this revision to Diff 312780. njames93 added a comment. Extend buffer behaviour to sendMessage. Calls to this function seem to be guarded(up the call stack) by a mutex so again we shouldn't worry about races. Besides there is no synchronization in the function currently when wri

[clang-tools-extra] 0336ff0 - [clangd] Fix broken JSON test on windows

Author: Sam McCall Date: 2020-12-18T15:11:08+01:00 New Revision: 0336ff0a17e6aec831334aeb50e6685f6b184065 URL: https://github.com/llvm/llvm-project/commit/0336ff0a17e6aec831334aeb50e6685f6b184065 DIFF: https://github.com/llvm/llvm-project/commit/0336ff0a17e6aec831334aeb50e6685f6b184065.diff LO

[PATCH] D93221: [ARM] Add clang command line support for -mharden-sls=

kristof.beyls added a comment. In D93221#2459903 , @ostannard wrote: > Why is this restricted to v7-A or later? The DSB and ISB instructions have > existed since v6T2 and v6M. This mitigation is never needed for M-class cores nor for v6T2. By restricting

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

sammccall added a comment. In D92663#2462642 , @thakis wrote: > Seems to break tests on windows: http://45.33.8.238/win/30129/step_9.txt Sorry (and for the delay getting back to keyboard). 0336ff0a17e6aec831334aeb50e6685f6b184065

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

HazardyKnusperkeks added a reviewer: HazardyKnusperkeks. HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. I don't know if this really fixes the problem. From the Docs: > An alternative way to attach meta-dat

[PATCH] D93452: [clangd] Trim memory after buildINdex

qchateau updated this revision to Diff 312781. qchateau added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. - Add MallocTrim to llvm::sys::Process - Implement malloc trimming in ClangdLSPServer Repository: rG LLVM Github Monorepo CHANG

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay added a comment. In D93528#2462723 , @curdeius wrote: > Why not using clang-format's support for JavaScript? It seems more > complicated now, but it will probably allow to more easily change/add style > options. WDYT? > And what happens wh

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added a comment. In D92039#2462889 , @aaron.ballman wrote: > Your test cases suggest that this is not inter-procedurally checked; it seems > to require all of the APIs to be annotated in order to get the same effect > that an inter-procedural

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

thakis added a comment. Thanks for the fix :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92663/new/ https://reviews.llvm.org/D92663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D84674: Allow users to specify a conditional to prevent parsing options with MarshallingInfo

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84674/new/ https://reviews.llvm.org/D

[PATCH] D84674: Allow users to specify a conditional to prevent parsing options with MarshallingInfo

jansvoboda11 updated this revision to Diff 312785. jansvoboda11 added a comment. Rebase, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84674/new/ https://reviews.llvm.org/D84674 Files: clang/include/clang/Driver/Options.td clang/lib/

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

HazardyKnusperkeks added a comment. In D93528#2462969 , @MyDeveloperDay wrote: > So I guess my question is: > > 1. is this useful to pursue (either as is, or by switching to us the reformat > method) > 2. is this useful standalone as the first pass > 3.

[PATCH] D93540: [clang] Use enum for LangOptions::SYCLVersion instead of unsigned

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese, bader, ABataev. Herald added subscribers: Anastasia, ebevhan, yaxunl. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `LangOptions::SYCLVe

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

sammccall added a comment. This adds a bit of complexity, making the code here a fair amount harder to follow and verify the correctness of. - Do we have evidence that these allocations are causing a problem? (e.g. do we observe a significant decrease in RSS after the patch)? Naively I would ex

[PATCH] D84675: Streamline MarhsallingInfoFlag description

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84675/new/ https://reviews.llvm.org/D

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

MyDeveloperDay added a comment. Maybe @JVApen can help as they logged https://bugs.llvm.org/show_bug.cgi?id=48539 I'm not a Qt developer so I can't really comment beyond fixing what was in the bug rpeort Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D84675: [clang][cli] Streamline MarhsallingInfoFlag description

jansvoboda11 updated this revision to Diff 312790. jansvoboda11 added a comment. Rebase, remove `DefaultValue` to avoid confusion with `Default` used for `BoolOptionBase`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84675/new/ https://reviews.ll

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

curdeius added a comment. In D93528#2463030 , @HazardyKnusperkeks wrote: > In D93528#2462969 , @MyDeveloperDay > wrote: > >> So I guess my question is: >> >> 1. is this useful to pursue (either as is, or by switch

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

sammccall added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:353 if (auto *AT = D->getType()->getContainedAutoType()) { - if (!AT->getDeducedType().isNull()) -DeducedType = AT->getDeducedType(); + DeducedType = AT->desugar(); } ---

[clang-tools-extra] c46c7c9 - [clangd] Smarter hover on auto and decltype

Author: Quentin Chateau Date: 2020-12-18T16:27:09+01:00 New Revision: c46c7c9bcf9752971fe4bbcf67140c99066ad2e0 URL: https://github.com/llvm/llvm-project/commit/c46c7c9bcf9752971fe4bbcf67140c99066ad2e0 DIFF: https://github.com/llvm/llvm-project/commit/c46c7c9bcf9752971fe4bbcf67140c99066ad2e0.dif

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

This revision was automatically updated to reflect the committed changes. Closed by commit rGc46c7c9bcf97: [clangd] Smarter hover on auto and decltype (authored by qchateau, committed by sammccall). Changed prior to commit: https://reviews.llvm.org/D93227?vs=312757&id=312791#toc Repository:

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

njames93 added a comment. In D93531#2463052 , @sammccall wrote: > This adds a bit of complexity, making the code here a fair amount harder to > follow and verify the correctness of. > > - Do we have evidence that these allocations are causing a problem? (

[PATCH] D93543: clang-tidy: Leave the possibility of opting out having coloured diagnostic messages.

Abpostelnicu created this revision. Abpostelnicu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Afer this commit landed we always have coloured diagno

[clang-tools-extra] 95c7b6c - [clangd] zap a few warnings

Author: Sam McCall Date: 2020-12-18T16:34:34+01:00 New Revision: 95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc URL: https://github.com/llvm/llvm-project/commit/95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc DIFF: https://github.com/llvm/llvm-project/commit/95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc.diff LO

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:353 if (auto *AT = D->getType()->getContainedAutoType()) { - if (!AT->getDeducedType().isNull()) -DeducedType = AT->getDeducedType(); + DeducedType = AT->desugar(); }

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

aaron.ballman added a comment. In D92039#2462995 , @vsavchenko wrote: > In D92039#2462889 , @aaron.ballman > wrote: > >> Your test cases suggest that this is not inter-procedurally checked; it >> seems to require

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added inline comments. Comment at: clang/test/SemaObjC/attr-called-once.m:7 +void test2(double x CALLED_ONCE); // expected-error{{'called_once' attribute only applies to function-like parameters}} + +void test3(void (*foo)() CALLED_ONCE); // no-error ---

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2671-2673 + // See if this is a VLST coerced to a VLAT at the function boundary and + // the types match up. If so, use llvm.experimental.vector.extract to + // perform the conversion. ---

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

njames93 updated this revision to Diff 312796. njames93 added a comment. Moved a few members out of the class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93531/new/ https://reviews.llvm.org/D93531 Files: clang-tools-extra/clangd/JSONTransport

[PATCH] D93546: [clangd][NFC] Improve clangd status messages

qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. clangd actions have

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm updated this revision to Diff 312802. david-arm edited the summary of this revision. Herald added a subscriber: NickHung. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89031/new/ https://reviews.llvm.org/D89031 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Ba

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies added a comment. @aaron.ballman @njames93 thanks for testing this out, the feedback, and the commit! Could you also take a look at D72235 unroll loops check ? It's been updated and is ready for review. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3356 EnumArgument<"State", "LoopHintState", - ["enable", "disable", "numeric", "assume_safety", "full"], - ["Enable", "Disable",

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

dmgreen added a comment. Thanks for the reproducer. I verified that it does indeed fail with this patch. It seems to be doing this as a knock-on effect: https://godbolt.org/z/Y4z3je, which does not verify: https://alive2.llvm.org/ce/z/PN7Rv5 ? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D72235: [clang-tidy] new altera unroll loops check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:22 +void UnrollLoopsCheck::registerMatchers(MatchFinder *Finder) { + const auto ANYLOOP = anyOf(forStmt(), whileStmt(), doStmt()); + Finder->addMatcher(stmt(allOf(ANYLOOP, // Ma

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:142-144 + } else { +return Triple; + } No need `else` here Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:953-957

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

ftynse added a comment. Thanks! I have a couple of comments, but I will defer to @jdoerfert for approval in any case. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:676 + + /// Capture the above-defined paraneters for the parallel regions. + /// ---

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92054/new/ https://reviews.llvm.org/D92054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a comment. In D87188#2463285 , @dmgreen wrote: > Thanks for the reproducer. I verified that it does indeed fail with this > patch. > > It seems to be doing this as a knock-on effect: https://godbolt.org/z/Y4z3je, > which does not verify:

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop updated this revision to Diff 312827. russell.gallop edited the summary of this revision. russell.gallop added a comment. Apologies for the delay, I've had other things taking my time. Latest version uploaded. This fixes stage1 lit tests (on Windows and Linux) and adds scudo_cxx t

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

dmgreen added a comment. Yeah. The reproducer seems to work OK with a patch something like this: diff --git a/llvm/lib/Analysis/InstructionSimplify.cpp b/llvm/lib/Analysis/InstructionSimplify.cpp index 35c21a0..c517286 100644

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a comment. In D87188#2463447 , @dmgreen wrote: > Yeah. The reproducer seems to work OK with a patch something like this: > > diff --git a/llvm/lib/Analysis/InstructionSimplify.cpp > b/llvm/lib/Analysis/InstructionSimplify.cpp > index

[PATCH] D93553: [clangd] Make our printing policies for Hover more consistent, especially tags

sammccall created this revision. sammccall added a reviewer: qchateau. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Different cases were using a bu

[PATCH] D93221: [ARM] Add clang command line support for -mharden-sls=

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. Ok, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93221/new/ https://reviews.llvm.org/D93221 ___

[clang] 7fef551 - Revert "Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.""

Author: Kevin P. Neal Date: 2020-12-18T12:42:06-05:00 New Revision: 7fef551cb123d9f1956f8ec7a142bd8a63d25fa9 URL: https://github.com/llvm/llvm-project/commit/7fef551cb123d9f1956f8ec7a142bd8a63d25fa9 DIFF: https://github.com/llvm/llvm-project/commit/7fef551cb123d9f1956f8ec7a142bd8a63d25fa9.diff

[PATCH] D93170: [clang-format][NFC] Expand BreakBeforeBraces examples

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e5ef5359742: [clang-format][NFC] Expand BreakBeforeBraces examples (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES

[clang] 5e5ef53 - [clang-format][NFC] Expand BreakBeforeBraces examples

Author: Björn Schäpers Date: 2020-12-18T19:08:03+01:00 New Revision: 5e5ef5359742c3feb6f41058a356a28c7ab3ea6d URL: https://github.com/llvm/llvm-project/commit/5e5ef5359742c3feb6f41058a356a28c7ab3ea6d DIFF: https://github.com/llvm/llvm-project/commit/5e5ef5359742c3feb6f41058a356a28c7ab3ea6d.diff

[clang] 897c985 - [InstCombine] Canonicalize SPF to abs intrinsic

Author: Roman Lebedev Date: 2020-12-18T21:18:14+03:00 New Revision: 897c985e1e21927b2870f964bb07ff293bd74407 URL: https://github.com/llvm/llvm-project/commit/897c985e1e21927b2870f964bb07ff293bd74407 DIFF: https://github.com/llvm/llvm-project/commit/897c985e1e21927b2870f964bb07ff293bd74407.diff

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG897c985e1e21: [InstCombine] Canonicalize SPF to abs intrinsic (authored by lebedev.ri). Changed prior to commit: https://reviews.llvm.org/D87188?v

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a comment. Once again, thank you @mstorsjo and @dmgreen! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87188/new/ https://reviews.llvm.org/D87188 ___ cfe-commits mailing list cfe-commits

[PATCH] D93553: [clangd] Make our printing policies for Hover more consistent, especially tags

qchateau added a comment. Looks good to me, it removes a lot of duplication and corner cases. I'd have printed the tag for reference and pointers as well (`class Foo*` instead of `Foo*`). I don't think `Foo*` is much more understandable than `Foo`, so we decide that printing `class Foo` is easi

  1   2   >