[PATCH] D93248: Frontend: Fix layering between create{,Default}OutputFile, NFC

dexonsmith created this revision. dexonsmith added a reviewer: erik.pilkington. Herald added subscribers: ributzka, jfb. dexonsmith requested review of this revision. Herald added a project: clang. Fix layering between `CompilerInstance::createDefaultOutputFile` and the two versions of `createOutp

[clang] a40db55 - Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

Author: Duncan P. N. Exon Smith Date: 2020-12-14T14:35:11-08:00 New Revision: a40db5502b2515a6f2f1676b5d7a655ae0f41179 URL: https://github.com/llvm/llvm-project/commit/a40db5502b2515a6f2f1676b5d7a655ae0f41179 DIFF: https://github.com/llvm/llvm-project/commit/a40db5502b2515a6f2f1676b5d7a655ae0f4

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGa40db5502b25: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92975/new/

[clang] 90d056c - AST: Silence an instance of -Wsign-compare, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-14T14:36:59-08:00 New Revision: 90d056ceb97d5e3242a37dfc1c9f6bf11af9a053 URL: https://github.com/llvm/llvm-project/commit/90d056ceb97d5e3242a37dfc1c9f6bf11af9a053 DIFF: https://github.com/llvm/llvm-project/commit/90d056ceb97d5e3242a37dfc1c9f6bf11af9

[PATCH] D93068: [clang-offload-bundler] Add option -allow-missing-bundles

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. The patch could use an OK with OMP folks, considering that we've changed the way offload bunder is invoked for OMP. Comment at: clang/tools/clang-offload-bundler/ClangOfflo

[clang] b61f288 - Add comment to closing brace of anonymous namespace, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-14T14:38:12-08:00 New Revision: b61f288a58e40430a739900ab74df61e711a2c55 URL: https://github.com/llvm/llvm-project/commit/b61f288a58e40430a739900ab74df61e711a2c55 DIFF: https://github.com/llvm/llvm-project/commit/b61f288a58e40430a739900ab74df61e711a

[PATCH] D93249: Frontend: Fix memory leak in CompilerInstance::setVerboseOutputStream

dexonsmith created this revision. dexonsmith added a reviewer: erik.pilkington. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93249 Files: clang/lib/Frontend/Comp

[clang] 7c0e3a7 - [clang][IR] Add support for leaf attribute

Author: Gulfem Savrun Yeniceri Date: 2020-12-14T14:48:17-08:00 New Revision: 7c0e3a77bc43a9c4d05f68ffd4e84d0f75efbd91 URL: https://github.com/llvm/llvm-project/commit/7c0e3a77bc43a9c4d05f68ffd4e84d0f75efbd91 DIFF: https://github.com/llvm/llvm-project/commit/7c0e3a77bc43a9c4d05f68ffd4e84d0f75efb

[PATCH] D90275: [clang][IR] Add support for leaf attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c0e3a77bc43: [clang][IR] Add support for leaf attribute (authored by gulfem, committed by haowei). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D92720#2448890 , @yaxunl wrote: > Output of `-E` for HIP combined host/device compilation is a plain text. It > has C++ comments inserted between preproce

[PATCH] D93220: [clangd] Add error handling (elog) in code completion.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:187-188 + if (auto Header = headerToInsertIfAllowed(Opts)) { +auto HeaderFile = toHeaderFile(*Header, FileName); +if (HeaderFile) { if (auto Spelled = ---

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

rsmith added a comment. In D91488#2451755 , @teemperor wrote: > I believe rsmith is in GMT-8, so I assume this won't get a fix soon and I > went ahead and reverted in 22ccdb787024e954318e35fcf904fd4fa36f5679 >

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. In D92600#2453124 , @tmroeder wrote: > Change the DeclMatcher.h test code to expose the ability to not assert on > null Nodes from a match. > > This allows the tests for GenericSelectionExpr to handle the null case on > Windows

[PATCH] D90275: [clang][IR] Add support for leaf attribute

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Apologies for being silent for too long. This is missing a lang ref entry for `nocallback` and the `attributes.ll` test is arguably broken (see below). The "definition" in `llvm/include/

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 311738. tmroeder added a comment. Update to the latest head. No changes from previous diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTM

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield created this revision. JonChesterfield added a reviewer: t-tye. Herald added subscribers: tpr, dstuttard, yaxunl, kzhuravl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. [amdgpu] Default to code object

[clang] 54e03d0 - [PGO] Verify BFI counts after loading profile data

Author: Rong Xu Date: 2020-12-14T15:56:10-08:00 New Revision: 54e03d03a7a4d47f09d40bcbcfe484066a52a077 URL: https://github.com/llvm/llvm-project/commit/54e03d03a7a4d47f09d40bcbcfe484066a52a077 DIFF: https://github.com/llvm/llvm-project/commit/54e03d03a7a4d47f09d40bcbcfe484066a52a077.diff LOG:

[PATCH] D91813: [PGO] verify BFI counts after loading profile data

This revision was automatically updated to reflect the committed changes. Closed by commit rG54e03d03a7a4: [PGO] Verify BFI counts after loading profile data (authored by xur). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

faisalv added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92733/new/ https://reviews.llvm.org/D92733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

thakis added a comment. One of the changes in https://github.com/llvm/llvm-project/compare/6af2c4ca9bd...2733a5a5b44 broke check-clang on windows. This change looks the most likely to me. Can you take a look? http://45.33.8.238/win/29852/step_7.txt Repository: rG LLVM Github Monorepo CHAN

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei added a comment. In D93179#2452932 , @spatel wrote: > If we're going by existing behavior/compatibility, gcc/icc use packed ops too: > https://godbolt.org/z/9jEhaW > ...so there's an implicit 'nnan nsz' in these intrinsics (and that should be > do

[PATCH] D91813: [PGO] verify BFI counts after loading profile data

dmajor added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1948 + // xur + fprintf(stderr, "hihi 2\n"); + // FuncAttrs.addAttribute(llvm::Attribute::Hot); This looks like something for temporary local debugging, was it intentional

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield updated this revision to Diff 311745. JonChesterfield added a comment. Herald added subscribers: llvm-commits, dang, kerbowa, nhaehnle, jvesely. Herald added a project: LLVM. - update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield updated this revision to Diff 311746. JonChesterfield added a comment. - another part of docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258 Files: clang/include/clang/Driver/Options.td

[clang] d2ed9d6 - Revert "ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC"

Author: Reid Kleckner Date: 2020-12-14T17:04:06-08:00 New Revision: d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b URL: https://github.com/llvm/llvm-project/commit/d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b DIFF: https://github.com/llvm/llvm-project/commit/d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b.diff

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 311747. ayermolo marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/

[PATCH] D93258: [amdgpu] Default to code object v3

t-tye added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:2874-2876 .. warning:: Code object V3 is not the default code object version emitted by this version of LLVM. Move this to the "Code Object V4 Metadata" section. Repository: rG LLVM Git

[PATCH] D93258: [amdgpu] Default to code object v3

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258 ___ cfe

[clang] 4b2e7d0 - [amdgpu] Default to code object v3

Author: Jon Chesterfield Date: 2020-12-15T01:11:09Z New Revision: 4b2e7d0215021d0d1df1a6319884b21d33936265 URL: https://github.com/llvm/llvm-project/commit/4b2e7d0215021d0d1df1a6319884b21d33936265 DIFF: https://github.com/llvm/llvm-project/commit/4b2e7d0215021d0d1df1a6319884b21d33936265.diff L

[PATCH] D93258: [amdgpu] Default to code object v3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b2e7d021502: [amdgpu] Default to code object v3 (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 9c49b0b - Remove the ast_type_traits namespace.

Author: Alexander Kornienko Date: 2020-12-15T02:16:12+01:00 New Revision: 9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479 URL: https://github.com/llvm/llvm-project/commit/9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479 DIFF: https://github.com/llvm/llvm-project/commit/9c49b0bba0fcbe8b10c0f44ce60a8d26e6f30479

[PATCH] D93244: Remove the ast_type_traits namespace.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c49b0bba0fc: Remove the ast_type_traits namespace. (authored by alexfh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D91302: Handle template instantiations better in clang-tidy check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Please fix the typo that results in a compile error. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:107 + h

[PATCH] D91303: Simplify implementation of container-size-empty

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Pre-merge builder can't apply this patch: https://buildkite.com/llvm-project/diff-checks/builds/18651 Is it based on https://reviews.llvm.org/D91302 ? Do we need the intermediate sta

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 311751. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D93260: Frontend: Simplify handling of non-seeking streams in CompilerInstance, NFC

dexonsmith created this revision. dexonsmith added a reviewer: erik.pilkington. Herald added subscribers: ributzka, hiraditya. dexonsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. Add a new `raw_pwrite_ostream` variant, `buffer_

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 added a comment. In D92155#2450474 , @nridge wrote: > In D92155#2419549 , @sammccall wrote: > >> In D92155#2419346 , @psionic12 >> wrote: >> >>> Or, could you help

[PATCH] D93258: [amdgpu] Default to code object v3

thakis added a comment. This seems to break check-clang everywhere: http://45.33.8.238/linux/35295/step_7.txt PTAL, and if it takes a while to investigate, please revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://re

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4033 +dwarfArgs->render(Args, CmdArgs); + } + Delete unneeded braces http://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loo

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added a comment. > This is missing a lang ref entry for `nocallback` and the `attributes.ll` > test is arguably broken (see below). Could you please elaborate on missing lang ref entry? Where that should be added? > The "definition" in `llvm/include/llvm/IR/Attributes.td` (see below), d

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe

hoy created this revision. Herald added subscribers: dexonsmith, wenlei, hiraditya. hoy requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. Sample re-annotation is required in LTO time to achieve a reasonable post-

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 311764. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[clang] c36f31c - [PGO] remove unintentional code in early commit

Author: Rong Xu Date: 2020-12-14T18:41:49-08:00 New Revision: c36f31c4db065e987160a776749f5da81efc24c5 URL: https://github.com/llvm/llvm-project/commit/c36f31c4db065e987160a776749f5da81efc24c5 DIFF: https://github.com/llvm/llvm-project/commit/c36f31c4db065e987160a776749f5da81efc24c5.diff LOG:

Re: [PATCH] D91813: [PGO] verify BFI counts after loading profile data

Thanks for catching that. I messed up the commit from another patch. Fixed in commit c36f31c. -Rong On Mon, Dec 14, 2020 at 4:50 PM dmajor via Phabricator < revi...@reviews.llvm.org> wrote: > dmajor added inline comments. > > > > Comment at: clang/lib/CodeGen/CGCall.cpp:1948 > +

[clang] c9ede6f - Revert "[amdgpu] Default to code object v3"

Author: Nico Weber Date: 2020-12-14T22:01:26-05:00 New Revision: c9ede6f3367a627baeef78f30d18078af9a4ffca URL: https://github.com/llvm/llvm-project/commit/c9ede6f3367a627baeef78f30d18078af9a4ffca DIFF: https://github.com/llvm/llvm-project/commit/c9ede6f3367a627baeef78f30d18078af9a4ffca.diff LO

[PATCH] D93258: [amdgpu] Default to code object v3

thakis added a comment. reverted in c9ede6f3367a627baeef78f30d18078af9a4ffca for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258 __

[clang-tools-extra] 7799ef7 - Revert "Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef"

Author: Nico Weber Date: 2020-12-14T22:05:08-05:00 New Revision: 7799ef7121aa7d59f4bd95cdf70035de724ead6f URL: https://github.com/llvm/llvm-project/commit/7799ef7121aa7d59f4bd95cdf70035de724ead6f DIFF: https://github.com/llvm/llvm-project/commit/7799ef7121aa7d59f4bd95cdf70035de724ead6f.diff LO

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

thakis added a comment. Reverted in 7799ef7121aa7d59f4bd95cdf70035de724ead6f for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92975/new/ https://reviews.llvm.org/D92975 ___ cfe-commits mailing list

[clang] 7799ef7 - Revert "Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef"

Author: Nico Weber Date: 2020-12-14T22:05:08-05:00 New Revision: 7799ef7121aa7d59f4bd95cdf70035de724ead6f URL: https://github.com/llvm/llvm-project/commit/7799ef7121aa7d59f4bd95cdf70035de724ead6f DIFF: https://github.com/llvm/llvm-project/commit/7799ef7121aa7d59f4bd95cdf70035de724ead6f.diff LO

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/M68k.h:38 +} // end namespace m68k +} // namespace tools +} // end namespace driver mismatching `end` and no `end`? clang-format seems to drop `end`. I th

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

thakis added a comment. The revert helped, check-clang is no longer failing on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92975/new/ https://reviews.llvm.org/D92975 ___ cfe-commits mailing li

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

Meinersbur added a comment. Can I help fixing the Windows build problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 ___ cfe-commits mailing list cfe-commits@

[PATCH] D93258: [amdgpu] Default to code object v3

yaxunl reopened this revision. yaxunl added a comment. This revision is now accepted and ready to land. @JonChesterfield Did this patch pass ePSDB in gerrlit? Better do that before committing it to trunk since we don't know if math libs are compatible with this patch. Also you need to fix lit te

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

OikawaKirie added a comment. Replies from the original author Hao Zhang --- Sorry for replying late. > I think it would be good to understand why the tests failed. Are some clients > relying on the name matching the query? If so, why? I'm currently working on this. Maybe try making `FileMana

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield added a comment. In D93258#2453724 , @thakis wrote: > reverted in c9ede6f3367a627baeef78f30d18078af9a4ffca > for now Thanks! Just saw the CI emails come through. I didn

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

yaxunl marked an inline comment as done. yaxunl added a comment. In D92720#2453277 , @tra wrote: > In D92720#2448890 , @yaxunl wrote: > >> Output of `-E` for HIP combined host/device compilation is a plain text. It

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

OikawaKirie added a comment. I think it could be better to implement this check with a checker on `PreStmt` and so on. And IMO, checkers have enough functionalities to report these problems. Besides, the return value should be the exact value computed from the two integers, even unknown, rathe

[PATCH] D93258: [amdgpu] Default to code object v3

yaxunl added a comment. In D93258#2453815 , @JonChesterfield wrote: > In D93258#2453724 , @thakis wrote: > >> reverted in c9ede6f3367a627baeef78f30d18078af9a4ffca >>

[PATCH] D93273: [CodeGen][ObjC] Destroy callee-destroyed arguments in the caller function when the receiver is nil

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, jkorous. ahatanak requested review of this revision. Callee-destroyed arguments to a method have to be destroyed in the caller function when the receiver is ni

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Thanks. `update_test_prefix.py` assumes the conflicting output. You may need to change the expection of it as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

ChuanqiXu updated this revision to Diff 311789. ChuanqiXu added a comment. add `verifyFormat("return *a", PASLeftStyle);` to clarify the change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91245/new/ https://reviews.llvm.org/D91245 Files: clang/lib/Format/TokenAnnotator.cpp clang/

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7759-7761 + // The default setting for PointerAlignment is PAS_Right. + // But if we set PointerAlignment as PAS_Left, the formatter + // would mis-format the pointer alignment. ---

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

ChuanqiXu added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7759-7761 + // The default setting for PointerAlignment is PAS_Right. + // But if we set PointerAlignment as PAS_Left, the formatter + // would mis-format the pointer alignment.

<    1   2