[clang] 25f5df7 - SemaType.cpp - use castAs<> instead of getAs<> for dereferenced pointers

Author: Simon Pilgrim Date: 2020-12-08T16:37:20Z New Revision: 25f5df7e0bc950ad244e8da000ce4248bd41c140 URL: https://github.com/llvm/llvm-project/commit/25f5df7e0bc950ad244e8da000ce4248bd41c140 DIFF: https://github.com/llvm/llvm-project/commit/25f5df7e0bc950ad244e8da000ce4248bd41c140.diff LOG:

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

PiotrFusik accepted this revision. PiotrFusik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 ___ cfe-commits mailing list cfe-com

[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

njames93 added a comment. In D91925#2439666 , @sammccall wrote: > (I'm not sure how it resolves the problem, but certainly looks nicer!) It's something to do with the derived to base unique_ptr conversion not working properly with NRVO. However removing

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 updated this revision to Diff 310242. josemonsalve2 added a comment. Removing globalized record for parallel regions When globalization occurs in parallel regions, a record was crerated that is not necessary anymore. This is expected to be done in the back end. Repository: rG L

[clang-tools-extra] 4a0528e - [clangd][NFC] Small tweak to combined provider

Author: Nathan James Date: 2020-12-08T17:12:56Z New Revision: 4a0528e4a0e3e4504db8650bf2bf7d6977ffa018 URL: https://github.com/llvm/llvm-project/commit/4a0528e4a0e3e4504db8650bf2bf7d6977ffa018 DIFF: https://github.com/llvm/llvm-project/commit/4a0528e4a0e3e4504db8650bf2bf7d6977ffa018.diff LOG:

[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a0528e4a0e3: [clangd][NFC] Small tweak to combined provider (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 added a comment. I'm working on the other tests right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90670/new/ https://reviews.llvm.org/D90670 ___ cfe-commits mailing list cfe-commits@

[PATCH] D92857: [clang][cli] Don't always emit -f[no-]experimental-new-pass-manager

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. We don't need to always generate `-f[no-]experimental-new-pass-manager`.

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 updated this revision to Diff 310249. jansvoboda11 added a comment. Split out change to "always emit" behavior of `-f[no-]experimental-new-pass-manager` and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92775/new/ https://revi

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:226 ASSERT_THAT(GeneratedArgs, - Contains(StrEq("-fno-experimental-new-pass-manager"))); + Not(Contains(StrEq("-fno-experimental-new-pass-manager";

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

aganea added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llvm.org/D43002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] 27ea7d0 - Fix inconsistent availability attribute message string literal check.

Author: Nigel Perks Date: 2020-12-08T12:33:59-05:00 New Revision: 27ea7d0a6e0dc51e0214707bcc265fa6f9dc9bc6 URL: https://github.com/llvm/llvm-project/commit/27ea7d0a6e0dc51e0214707bcc265fa6f9dc9bc6 DIFF: https://github.com/llvm/llvm-project/commit/27ea7d0a6e0dc51e0214707bcc265fa6f9dc9bc6.diff L

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

aaron.ballman closed this revision. aaron.ballman added a comment. In D92108#2439223 , @nigelp-xmos wrote: > Many thanks for review and approval. Please could it be committed as I do not > have commit access? (I will request.) Happy to do so! I've commit

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

MaskRay added a comment. Herald added a subscriber: shchenz. Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92054/new/ https://reviews.llvm.org/D92054 ___ cfe-commits mailing list cfe-commits@

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/performance/NoIntToPtrCheck.cpp:21 + Finder->addMatcher(castExpr(hasCastKind(CK_IntegralToPointer), +

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:17-23 +#define cl_khr_subgroup_extended_types +#define cl_khr_subgroup_non_uniform_vote +#define cl_khr_subgroup_ballot +#define cl_khr_subgroup_non_uniform_arithmetic +#define cl_khr_subgroup_shuffle

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

aaron.ballman added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:65 + DiagnosticsEngine::Error, + "'example' attribute only allowed at most three arguments"); + S.Diag(Attr.getLoc(), ID); only allowed -> accepts ===

[PATCH] D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

aaron.ballman added a comment. In D91975#2436212 , @gridaphobe wrote: > I've added the non-narrowing tests, are we good to merge? Yes, this still LGTM! Thank you! Do you need someone to commit on your behalf? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

gridaphobe added a comment. Yes please! I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91975/new/ https://reviews.llvm.org/D91975 ___ cfe-commits mailing list cfe-commits@lists

[clang-tools-extra] c6348e8 - cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

Author: Eric Seidel Date: 2020-12-08T13:10:41-05:00 New Revision: c6348e8c95ee1eaa9dd2322b278def7a4127ff26 URL: https://github.com/llvm/llvm-project/commit/c6348e8c95ee1eaa9dd2322b278def7a4127ff26 DIFF: https://github.com/llvm/llvm-project/commit/c6348e8c95ee1eaa9dd2322b278def7a4127ff26.diff L

[PATCH] D91975: [clang-tidy] cppcoreguidelines Narrowing Conversions Check: detect narrowing conversions involving typedefs

aaron.ballman closed this revision. aaron.ballman added a comment. In D91975#2440426 , @gridaphobe wrote: > Yes please! I don't have commit rights. I've commit on your behalf in c6348e8c95ee1eaa9dd2322b278def7a4127ff26

[clang] 1821265 - [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

Author: Yuanfang Chen Date: 2020-12-08T10:13:19-08:00 New Revision: 1821265db681cd2289fce9331e3aed26bdf814e3 URL: https://github.com/llvm/llvm-project/commit/1821265db681cd2289fce9331e3aed26bdf814e3 DIFF: https://github.com/llvm/llvm-project/commit/1821265db681cd2289fce9331e3aed26bdf814e3.diff

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1821265db681: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the… (authored by ychen). Repository: rG LLVM Github Monor

[PATCH] D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExpandAutoType.cpp:73 if (!Result.getTypePtr()->isDecltypeAuto() && !isStructuredBindingT

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 310269. gulfem added a comment. Added more Sema test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

RKSimon added inline comments. Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:800 case Instruction::Invoke: - return getModRefInfo((const InvokeInst *)I, Loc, AAQIP); + return getModRefInfo((const CallBase *)I, Loc, AAQIP); case Instruction::CatchPad:

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem marked an inline comment as done. gulfem added inline comments. Comment at: clang/test/Sema/attr-leaf.c:4 + +void f() __attribute__((leaf)); aaron.ballman wrote: > Can you also add tests that show the attribute diagnoses being written on the > wrong subje

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

BillyONeal added a comment. In D87974#2439043 , @jwakely wrote: > In D87974#2438723 , @zoecarver wrote: > >> In D87974#2438682 , @BillyONeal >> wrote: >> Are they actua

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

aaron.ballman added a comment. Thank you for your patience with the delays getting to your review! Along with the documentation question, one line of thinking I'm also not clear on is whether this should be a type-based attribute rather than a declaration-based attribute. For instance, if you w

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added a comment. Thanks for the new tests! Comment at: clang/test/Sema/attr-leaf.c:13 +} \ No newline at end of file Can you add the newline to the end of the file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added a comment. In D80391#2438447 , @MaskRay wrote: > In D80391#2437926 , @dblaikie wrote: > >> Looks like GCC has changed the semantics here despite the backwards >> compatibility break - as much as I'd r

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

flx updated this revision to Diff 310285. flx marked 5 inline comments as done. flx added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91893/new/ https://reviews.llvm.org/D91893 Files: clang-tools-extra/clang

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

flx added a comment. Thanks for the review, Aaron! I appreciate it. Please let me know if you have any questions about the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91893/new/ https://reviews.llvm.org/D91893 __

[PATCH] D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas.

adamcz updated this revision to Diff 310289. adamcz marked 2 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92847/new/ https://reviews.llvm.org/D92847 Files: clang-tools-e

[PATCH] D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas.

adamcz added a comment. Also added some "const" to make clang-tidy happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92847/new/ https://reviews.llvm.org/D92847 ___ cfe-commits mailing list cfe-commits@

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 310290. gulfem marked an inline comment as done. gulfem added a comment. Add a new line at the end of the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 Files

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

jwakely added a comment. In D87974#2440533 , @BillyONeal wrote: > Of course if it's already publicly documented for you the horse has > presumably already left the barn which makes the discussion moot? It's not in a shipping release yet. But the point of

[PATCH] D67429: Improve code generation for thread_local variables:

wristow added a comment. This commit appears to be the root cause of a run-time crash related to the interaction of global initializers and the wrapper functions to access `thread_local` variables -- reported as PR48030 . Repository: rL LLVM CHA

[PATCH] D92809: [Driver] Add -gno-split-dwarf which can disable debug fission

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92809/new/ https://reviews.llvm.org/D92809 __

[clang-tools-extra] 3c5bed7 - [clangd] ExpandAutoType: Do not offer code action on lambdas.

Author: Adam Czachorowski Date: 2020-12-08T20:03:16+01:00 New Revision: 3c5bed734f9e02bd3bc4fbd1e0acc53506823ebf URL: https://github.com/llvm/llvm-project/commit/3c5bed734f9e02bd3bc4fbd1e0acc53506823ebf DIFF: https://github.com/llvm/llvm-project/commit/3c5bed734f9e02bd3bc4fbd1e0acc53506823ebf.d

[PATCH] D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c5bed734f9e: [clangd] ExpandAutoType: Do not offer code action on lambdas. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] fc750f6 - [PPC] Fixing a typo in altivec.h. Commenting out an unnecessary macro

Author: Masoud Ataei Date: 2020-12-08T19:21:02Z New Revision: fc750f609dfb2fd51b6810cc55058568dfe4b3a9 URL: https://github.com/llvm/llvm-project/commit/fc750f609dfb2fd51b6810cc55058568dfe4b3a9 DIFF: https://github.com/llvm/llvm-project/commit/fc750f609dfb2fd51b6810cc55058568dfe4b3a9.diff LOG:

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov added inline comments. Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:800 case Instruction::Invoke: - return getModRefInfo((const InvokeInst *)I, Loc, AAQIP); + return getModRefInfo((const CallBase *)I, Loc, AAQIP); case Instruction::CatchPad:

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Add instrumentation in ConfigCompi

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri added a comment. In D91055#2440344 , @aaron.ballman wrote: > LGTM! Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91055/new/ https://reviews.llvm.org/D91055 __

[PATCH] D64034: [c++] Implement P1957R0 - narrowing pointer-to-bool

lichray abandoned this revision. lichray added a comment. Implemented in 7ef45f45f67 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64034/new/ https://reviews.llvm.org/D64034 _

[clang-tools-extra] 39431e4 - [clang-tidy] Introduce misc No Integer To Pointer Cast check

Author: Roman Lebedev Date: 2020-12-08T22:55:13+03:00 New Revision: 39431e479ffddc81120911f031921b2d637e967f URL: https://github.com/llvm/llvm-project/commit/39431e479ffddc81120911f031921b2d637e967f DIFF: https://github.com/llvm/llvm-project/commit/39431e479ffddc81120911f031921b2d637e967f.diff

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39431e479ffd: [clang-tidy] Introduce misc No Integer To Pointer Cast check (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

dexonsmith added a comment. @kadircet, ping, do you still have concerns? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91297/new/ https://reviews.llvm.org/D91297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang-tools-extra] 2755393 - [clang-tidy] Add support for diagnostics with no location

Author: Nathan James Date: 2020-12-08T20:29:31Z New Revision: 27553933a8693d508eb7f7c24a14f66b3d006d2c URL: https://github.com/llvm/llvm-project/commit/27553933a8693d508eb7f7c24a14f66b3d006d2c DIFF: https://github.com/llvm/llvm-project/commit/27553933a8693d508eb7f7c24a14f66b3d006d2c.diff LOG:

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

This revision was automatically updated to reflect the committed changes. Closed by commit rG27553933a869: [clang-tidy] Add support for diagnostics with no location (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91885/new/ htt

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new/ https://reviews.llvm.org/D73413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

GGanesh added a comment. In D92812#2439324 , @RKSimon wrote: > it looks like a very bad merge imo. Yep, Thank you! I will post smaller incremental patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9281

[clang] 51f3432 - Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-08T12:52:17-08:00 New Revision: 51f3432f4b5217b35dc2694c6e46d6cfc7defad6 URL: https://github.com/llvm/llvm-project/commit/51f3432f4b5217b35dc2694c6e46d6cfc7defad6 DIFF: https://github.com/llvm/llvm-project/commit/51f3432f4b5217b35dc2694c6e46d6cfc7de

[PATCH] D91296: Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG51f3432f4b52: Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added a comment. I have also notified ChromeOS/Android NDK/Bazel maintainers since they use -gsplit-dwarf (though might not be affected). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80391/new/ https://reviews.llvm.org/D80391 ___

[clang] 843f2db - [Driver] Don't make -gsplit-dwarf imply -g2

Author: Fangrui Song Date: 2020-12-08T13:14:34-08:00 New Revision: 843f2dbf003f2a51d0d4ab8cf40647c99ded2e93 URL: https://github.com/llvm/llvm-project/commit/843f2dbf003f2a51d0d4ab8cf40647c99ded2e93 DIFF: https://github.com/llvm/llvm-project/commit/843f2dbf003f2a51d0d4ab8cf40647c99ded2e93.diff

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG843f2dbf003f: [Driver] Don't make -gsplit-dwarf imply -g2 (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91997: APINotes: add bitcode format schema definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb13f74151137: APINotes: add bitcode format schema definitions (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D91997?vs=

[clang] b13f741 - APINotes: add bitcode format schema definitions

Author: Saleem Abdulrasool Date: 2020-12-08T21:15:41Z New Revision: b13f74151137f33327e0549adc9778aebf98a299 URL: https://github.com/llvm/llvm-project/commit/b13f74151137f33327e0549adc9778aebf98a299 DIFF: https://github.com/llvm/llvm-project/commit/b13f74151137f33327e0549adc9778aebf98a299.diff

[PATCH] D92809: [Driver] Add -gno-split-dwarf which can disable debug fission

MaskRay updated this revision to Diff 310331. MaskRay added a comment. Test there is no -ggnu-pubnames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92809/new/ https://reviews.llvm.org/D92809 Files: clang/include/clang/Driver/Options.td clang/

[clang] 85c18d3 - [Driver] Add -gno-split-dwarf which can disable debug fission

Author: Fangrui Song Date: 2020-12-08T13:24:59-08:00 New Revision: 85c18d3521e87a22c742be512245665d6bb5bfe2 URL: https://github.com/llvm/llvm-project/commit/85c18d3521e87a22c742be512245665d6bb5bfe2 DIFF: https://github.com/llvm/llvm-project/commit/85c18d3521e87a22c742be512245665d6bb5bfe2.diff

[PATCH] D92809: [Driver] Add -gno-split-dwarf which can disable debug fission

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85c18d3521e8: [Driver] Add -gno-split-dwarf which can disable debug fission (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] b85c6e5 - ARCMigrate: Use hash_combine in the DenseMapInfo for EditEntry

Author: Duncan P. N. Exon Smith Date: 2020-12-08T13:46:21-08:00 New Revision: b85c6e5bcd1a9de941c318f9a5dc742818752a56 URL: https://github.com/llvm/llvm-project/commit/b85c6e5bcd1a9de941c318f9a5dc742818752a56 DIFF: https://github.com/llvm/llvm-project/commit/b85c6e5bcd1a9de941c318f9a5dc74281875

[PATCH] D92630: ARCMigrate: Use hash_combine in the DenseMapInfo for EditEntry

This revision was automatically updated to reflect the committed changes. Closed by commit rGb85c6e5bcd1a: ARCMigrate: Use hash_combine in the DenseMapInfo for EditEntry (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92630/ne

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc updated this revision to Diff 310338. mibintc added a comment. Thanks @Anastasia ; I modified CGBuiltin.cpp to use EmitRuntimeCall when creating calls to runtime functions instead of Builder.CreateCall so this is setting the CallingConvention on the Call node using the ABIInfo. I change

[PATCH] D92883: De-templatify EmitCallArgs argument type checking, NFCI

rnk created this revision. rnk added reviewers: compnerd, aeubanks, rsmith. rnk requested review of this revision. Herald added a project: clang. This template exists to abstract over FunctionPrototype and ObjCMethodDecl, which have similar APIs for storing parameter types. In place of a template,

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

JDevlieghere added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:735 + /// Redirect each of the remapped files from first to second. + static std::unique_ptr + create(ArrayRef> RemappedFiles, - Do you need to know that this is a `

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. I've been able to check what Ubuntu 20.10 offers in terms of x32 support. Its kernel supports x32 binaries, it provides x32 versions of core system libraries in separate packages (e.g. libc6-x32, libx32stdc++6, libx32z1), and it provides a compiler that targets x32 by de

[PATCH] D92883: De-templatify EmitCallArgs argument type checking, NFCI

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGCall.cpp:3824 +// that may have type parameters in its signature. +static bool isObjCMethodWithTypeParams(const ObjCMethodDecl *method

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2441094 , @hvdijk wrote: > I've been able to check what Ubuntu 20.10 offers in terms of x32 support. Its > kernel supports x32 binaries, it provides x32 versions of core system > libraries in separate packages (e.g. li

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

jrtc27 added a comment. In D52050#2441133 , @glaubitz wrote: > In D52050#2441094 , @hvdijk wrote: > >> I've been able to check what Ubuntu 20.10 offers in terms of x32 support. >> Its kernel supports x32 binaries,

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

jrtc27 added a comment. i.e. can we not just support both approaches and prefer x86_64-linux-gnux32 if it exists? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52050/new/ https://reviews.llvm.org/D52050 ___

[PATCH] D91281: [CUDA][HIP] Diagnose reference of host variable

tra added a comment. It appears that we need to add special handling for texture/surface references. Nominally they are host-side objects, but they are accessed/used from device functions as far as Sema is concerned. E.g. https://godbolt.org/z/z1YnE3 NVCC and older clang compile it, but the re

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

dexonsmith added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:735 + /// Redirect each of the remapped files from first to second. + static std::unique_ptr + create(ArrayRef> RemappedFiles, JDevlieghere wrote: > - Do you need to k

[clang-tools-extra] 86436a4 - [clang-tidy][NFC] Made Globlist::contains const

Author: Nathan James Date: 2020-12-08T22:26:55Z New Revision: 86436a4343628f0f98d72169a013cf99a3be5973 URL: https://github.com/llvm/llvm-project/commit/86436a4343628f0f98d72169a013cf99a3be5973 DIFF: https://github.com/llvm/llvm-project/commit/86436a4343628f0f98d72169a013cf99a3be5973.diff LOG:

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

rjmccall added a comment. Your patch description doesn't mention the changes to the inliner. Comment at: clang/lib/CodeGen/CGObjC.cpp:2282 +static const char *markerKey = "clang.arc.retainAutoreleasedReturnValueMarker"; + This is too generic for a global vari

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2441141 , @jrtc27 wrote: > What gets done currently for i386? That suffers potentially the same problem > given both /usr/lib/gcc/x86_64-linux-gnu/$V/32 and > /usr/lib/gcc/i386-linux-gnu/$V are possible locations for a

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 updated this revision to Diff 310352. njames93 added a comment. Made GlobList::specifies const. Made check validation function static and only taking a StringRef. This will make it easier to refactor out at a later date if this functionality wants to be used elsewhere. Repository: r

[PATCH] D92886: [Sema] Warn about unused functions even when they're inline

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, efriedma, rsmith. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Being inline doesn't change anything about a function having internal linkage, s

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev updated this revision to Diff 310357. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92181/new/ https://reviews.llvm.org/D92181 Files: clang-to

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to check this patch again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92220/new/ https://reviews.llvm.org/D92220 ___ cfe-commi

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 ___ cfe-comm

[PATCH] D92888: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, dblaikie. Herald added subscribers: usaxena95, ributzka, kadircet, arphaman. dexonsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Allow a `std::unique_pt

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

dexonsmith added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:735 + /// Redirect each of the remapped files from first to second. + static std::unique_ptr + create(ArrayRef> RemappedFiles, dexonsmith wrote: > JDevlieghere wrote: >

[PATCH] D92886: [Sema] Warn about unused functions even when they're inline

Quuxplusone added subscribers: mpark, Quuxplusone. Quuxplusone added a comment. I agree with your reasoning, but in practice I still see a lot of people using `static inline` for functions (especially function templates) in .h files. I'm not sure exactly why — maybe to reduce the burden on the l

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DirectoryEntry.h:104 + bool isSpecialDenseMapKey() const { +return ME == llvm::DenseMapInfo::getEmptyKey() || + ME == llvm::DenseMapInfo::getTombstoneKey(); jansvoboda11 wrote:

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

tra created this revision. tra added reviewers: yaxunl, hliao. Herald added a subscriber: bixia. tra requested review of this revision. Herald added a project: clang. `isCUDADeviceBuiltinSurfaceType()`/`isCUDADeviceBuiltinTextureType()` do not work on dependent types as they rely on specific type

[PATCH] D92888: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good with one minor tweak Comment at: llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:180 + template + IntrusiveRefCntPtr(std::unique_ptr &&S) : Obj(S.release()) { +

[PATCH] D92888: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

dexonsmith added a comment. Thanks for the review! Comment at: llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:180 + template + IntrusiveRefCntPtr(std::unique_ptr &&S) : Obj(S.release()) { +retain(); dblaikie wrote: > Pass 'S' by value here - that's the usual

[PATCH] D92886: [Sema] Warn about unused functions even when they're inline

efriedma added a comment. I'm not sure this direction really makes sense. There's a long history of defining utility functions in headers as "static inline". Non-static inline functions in C have confusing semantics. In C++, the semantics are less confusing, but "static inline" still isn't ra

[PATCH] D92267: [clang-tidy][NFC] Use moves instead of copies when constructing OptionsProviders.

njames93 updated this revision to Diff 310378. njames93 marked 2 inline comments as done. njames93 added a comment. Use pass by value for FileOptionsBaseProvider constructor. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92267/new/ https://re

[PATCH] D92888: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92888/new/ https://reviews.llvm.org/D92888 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with the other patches. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91317/new/ https://reviews.llvm.org/D91317 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:114 assert(!ProjectRoot.empty()); +ChannelStatusWatcher = std::thread([&Channel]() { + grpc_connectivity_state Status = sammccall wrote: > The thread is a b

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 310381. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools

[PATCH] D91281: [CUDA][HIP] Diagnose reference of host variable

tra added a comment. In D91281#2441147 , @tra wrote: > I think `isCUDADeviceBuiltinTextureType` has problem handling texture refs > within templates. Proposed fix: https://reviews.llvm.org/D92893 Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

eugenis added a comment. > simply naming it as %clang_noundef would be clearer, Hmm, yeah, that's a little better. > This new substitution is going to be used for the noundef checks in D81678 > only anyway. I'm not sure what you mean by this. The substitution

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

eugenis requested changes to this revision. eugenis added a comment. This revision now requires changes to proceed. I wonder if we could just disable unused argument warning for both -disable-noundef-analysis -Xclang -disable-noundef-analysis I don't see any precedents for this kind of thing

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:296 +def warn_drv_dwarf_version_limited_by_target : Warning< + "debug information option '%0' is not supported. It needs DWARF-%2 but target '%1' only provides DWARF-%3.">, + InGroup; ---

<    1   2   3   >