JDevlieghere added inline comments.
================ Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:735 + /// Redirect each of the remapped files from first to second. + static std::unique_ptr<RedirectingFileSystem> + create(ArrayRef<std::pair<std::string, std::string>> RemappedFiles, ---------------- - Do you need to know that this is a `RedirectingFileSystem` or can it be a `FileSystem`? - Is there a reason this should be a `unique_ptr` instead of an `IntrusiveRefCntPtr` (which is more prevalent across the VFS, although I'm not sure why) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91317/new/ https://reviews.llvm.org/D91317 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
