[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak created this revision. ahatanak added reviewers: rjmccall, smeenai, dexonsmith, pete, fhahn. ahatanak added projects: clang, LLVM. Herald added subscribers: ributzka, pengfei, jkorous, hiraditya, kristof.beyls. ahatanak requested review of this revision. Background: === This fixe

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

smeenai added a reviewer: compnerd. smeenai resigned from this revision. smeenai added a subscriber: compnerd. smeenai added a comment. I'm super excited to see this happen, but it's also well out of my review comfort zone, unfortunately. Adding @compnerd to take a look. Repository: rG LLVM G

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added a comment. In D87974#2438682 , @BillyONeal wrote: >> Are they actually the same, with the same handling of corner cases like >> unions and tail padding? >> There's more to this than just the name, and if they aren't the same, it >> seems

[PATCH] D92809: [Driver] Add -gno-split-dwarf which can disable debug fission

MaskRay created this revision. MaskRay added reviewers: debug-info, dblaikie. Herald added a subscriber: dang. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently when -gsplit-dwarf is specified (could be buried in a build sys

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

khchen added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true) +RVV_VECTOR_TYPE_INT("__r

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

__simt__ added a comment. I think Jonathan is asking whether there is a match in the gray areas. The two cases people bring up most: 1. Unions, where the padding overlaps for all the possible active members. 2. Tail padding, up to the allocator granularity / alignment size. If the implementatio

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added a comment. > If the implementation-specific builtins don't match on these, then maybe they > should have different names, is his argument I think. That's a fair point. And I agree, if they don't match, maybe it would be best to have different names. I'm hoping that we can all ag

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen updated this revision to Diff 310079. ychen marked an inline comment as done. ychen added a comment. - `clang/test/Misc/time-passes.c`: add -fno-experimental-new-pass-manager - `llvm/test/Other/time-passes.ll`: makes sure each pass has one entry. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen added inline comments. Comment at: llvm/lib/IR/PassTimingInfo.cpp:47 +cl::desc("Time each pass run, printing elapsed time for each run on exit"), +cl::callback([](const bool &) { TimePassesIsEnabled = true; })); + aeubanks wrote: > is this necessary

[clang] 6e614b0 - [NFC][MSan] Round up OffsetPtr in PoisonMembers

Author: Vitaly Buka Date: 2020-12-07T19:57:49-08:00 New Revision: 6e614b0c7ed3a9a66428f342bf2a4b3700525395 URL: https://github.com/llvm/llvm-project/commit/6e614b0c7ed3a9a66428f342bf2a4b3700525395 DIFF: https://github.com/llvm/llvm-project/commit/6e614b0c7ed3a9a66428f342bf2a4b3700525395.diff L

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e614b0c7ed3: [NFC][MSan] Round up OffsetPtr in PoisonMembers (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

aeubanks added inline comments. Comment at: llvm/lib/IR/PassTimingInfo.cpp:47 +cl::desc("Time each pass run, printing elapsed time for each run on exit"), +cl::callback([](const bool &) { TimePassesIsEnabled = true; })); + ychen wrote: > aeubanks wrote: >

[PATCH] D92810: [clang-tidy] Recognize single character needles for absl::StrContains.

ckennelly created this revision. ckennelly added reviewers: EricWF, ymandel, hokein. Herald added a subscriber: xazax.hun. ckennelly requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit fbdff6f3ae0b in the Abseil tree adds an overload for

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

GGanesh created this revision. GGanesh added reviewers: RKSimon, craig.topper, lebedev.ri, courbet. GGanesh added projects: LLVM, clang. Herald added subscribers: mstojanovic, pengfei, jfb, gbedwell, hiraditya. Herald added a reviewer: andreadb. GGanesh requested review of this revision. Herald add

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

craig.topper added a comment. Please upload the patch with full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

craig.topper added a subscriber: bkramer. craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:548 break; - case CK_ZNVER3: -defineCPUMacros(Builder, "znver3"); Why is this being deleted? Comment at: clang/l

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

kito-cheng added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true) +RVV_VECTOR_TYPE_INT(

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

vitalybuka added a subscriber: kcc. vitalybuka added a comment. I've chatted about that with @kcc and @eugenis . It seems the problem the patch is trying to solve is less important than regressions. Even with the current state when rare false ODR reports are possible it still useful. It would be

[clang] 5e85a2b - [PowerPC] Implement intrinsic for DARN instruction

Author: Qiu Chaofan Date: 2020-12-08T14:08:52+08:00 New Revision: 5e85a2ba1645c3edbf26bba096631fbd318ada47 URL: https://github.com/llvm/llvm-project/commit/5e85a2ba1645c3edbf26bba096631fbd318ada47 DIFF: https://github.com/llvm/llvm-project/commit/5e85a2ba1645c3edbf26bba096631fbd318ada47.diff L

[PATCH] D92465: [PowerPC] Implement intrinsic for DARN instruction

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e85a2ba1645: [PowerPC] Implement intrinsic for DARN instruction (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D92792: [clang] - Also look for devtoolset-10

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92792/new/ https://reviews.llvm.org/D92792 ___ c

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. In D92257#2435906 , @lebedev.ri wrote: > In D92257#2435902 , @MyDeveloperDay > wrote: > >> In D92257#2435899 , >> @HazardyKnusperkeks wrote:

[PATCH] D92661: [RFC] Fix TLS and Coroutine

hoy added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1309 +// Intrinsic to obtain the address of a thread_local variable. +def int_threadlocal : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>; + lxfind wrote: > hoy wrote: > > lxfind wrote: > > > hoy

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Could we consider dropping the maximum? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/ https://reviews.llvm.

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein updated this revision to Diff 309817. hokein marked 2 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92157/new/ https://reviews.llvm.org/D92157 Files: clang-tools-ex

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:41 +const char *getLanguage(const clang::LangOptions &Lang) { + if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x) +return "C"; sammccall wrote: > Testing for specific C versions

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:44 +return; + const char *LanguageLabel = Lang.CPlusPlus ? "C++" : Lang.ObjC ? "ObjC" : "C"; static cons

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

qiucf added a comment. Ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90213/new/ https://reviews.llvm.org/D90213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:724 + ReturnStmtVisitor V; + for (const auto *RootStmt : ExtZone.RootStmts) { +V.TraverseStmt(const_cast(RootStmt)); nit: s/auto/Stmt ==

[PATCH] D92704: [clangd] Publish config file errors over LSP

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The pre-merging bot seems to be failed on windows: https://reviews.llvm.org/harbormaster/unit/view/215879/. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:833 + llvm

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 marked 4 inline comments as done. psionic12 added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:81 +D->addAttr(AnnotateAttr::Create(S.Context, "example", &Arg0, +Attr.getNumArgs(), Attr.getRange())); ret

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko added a comment. This option was created to have an option of removing this break, because without my patch it breaks before ASM colon in long lines. That's why I saved the behavior of BreakBeforeInlineASMColon=true as it was initially. Therefore, I'm asking you is this a b

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

steven.zhang accepted this revision. steven.zhang added a comment. This revision is now accepted and ready to land. LGTM as it seems the missing part. Please also fix the error message if with Power8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D92677: Provide default location of sysroot for Baremetal toolchain.

This revision was automatically updated to reflect the committed changes. Closed by commit rG275592e71413: Provide default location of sysroot for Baremetal toolchain. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92677/new/ ht

[clang] 275592e - Provide default location of sysroot for Baremetal toolchain.

Author: Hafiz Abid Qadeer Date: 2020-12-07T09:19:52Z New Revision: 275592e714130345a481a5cb889c89b73a98614f URL: https://github.com/llvm/llvm-project/commit/275592e714130345a481a5cb889c89b73a98614f DIFF: https://github.com/llvm/llvm-project/commit/275592e714130345a481a5cb889c89b73a98614f.diff

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:44 +return; + const char *LanguageLabel = Lang.CPlusPlus ? "C++" : Lang.ObjC ? "ObjC" : "C"; static constexpr trace::Metric SelectionUsedRecovery( sammccall wrote: > This cl

[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1df0677e6ac6: [clangd] Add language metrics for recovery AST usage. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92157/new/ https://r

[clang-tools-extra] 1df0677 - [clangd] Add language metrics for recovery AST usage.

Author: Haojian Wu Date: 2020-12-07T10:52:05+01:00 New Revision: 1df0677e6ac65e18da54b1dd5c391bf17a4c2737 URL: https://github.com/llvm/llvm-project/commit/1df0677e6ac65e18da54b1dd5c391bf17a4c2737 DIFF: https://github.com/llvm/llvm-project/commit/1df0677e6ac65e18da54b1dd5c391bf17a4c2737.diff LO

[PATCH] D92704: [clangd] Publish config file errors over LSP

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGfed9af29c2b5: [clangd] Publish config file errors over LSP (authored by sammccall). Changed prior to com

[clang-tools-extra] fed9af2 - [clangd] Publish config file errors over LSP

Author: Sam McCall Date: 2020-12-07T11:07:32+01:00 New Revision: fed9af29c2b5f289744254390c7372e8871e45e5 URL: https://github.com/llvm/llvm-project/commit/fed9af29c2b5f289744254390c7372e8871e45e5 DIFF: https://github.com/llvm/llvm-project/commit/fed9af29c2b5f289744254390c7372e8871e45e5.diff LO

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

hokein created this revision. hokein added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D49890: Clang-Tidy Export Problem

jwillemsen added a comment. I am trying to use run-clang-tidy on ACE/TAO (see https://github.com/DOCGroup/ACE_TAO) but it doesn't work, also the error reported here. When only running modernize-use-override I get a yaml file of 110167 lines but that can't also be applied using clang-apply-repla

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

hokein accepted this revision. hokein added a comment. thanks, I think this patch is good, feel free to land it (and sorry for the delay). As @lebedev.ri commented, would be nice to mention the motivation of the change (`make_shared_for_overwrite`?) in the description. Repository: rG LLVM G

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf29dbb1541: [PowerPC] [Clang] Enable float128 feature on P9 by default (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

njames93 added a comment. How does this handle Dependent base classes (including CRTP). Can tests be added to demonstrate that behaviour if its supported. Comment at: clang-tools-extra/clangd/XRefs.cpp:1200 + } +if (const auto *D = dyn_cast(ND)) { + IDs.insert(ge

[clang] 6bf29db - [PowerPC] [Clang] Enable float128 feature on P9 by default

Author: Qiu Chaofan Date: 2020-12-07T18:31:00+08:00 New Revision: 6bf29dbb1541aff717e52b5c5fb12b84f5b38f21 URL: https://github.com/llvm/llvm-project/commit/6bf29dbb1541aff717e52b5c5fb12b84f5b38f21 DIFF: https://github.com/llvm/llvm-project/commit/6bf29dbb1541aff717e52b5c5fb12b84f5b38f21.diff L

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 updated this revision to Diff 309853. psionic12 marked 2 inline comments as done. psionic12 added a comment. Use a vector to collect arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92006/new/ https://reviews.llvm.org/D92006 Files

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:712 + // - .clang_format and .clang-tidy + // - compile_commands.json } Any reason for re-specifying compile_commands.json here? Comment at: clang-too

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 added inline comments. Comment at: clang/examples/Attribute/Attribute.cpp:81 +D->addAttr(AnnotateAttr::Create(S.Context, "example", &Arg0, +Attr.getNumArgs(), Attr.getRange())); return AttributeApplied; psion

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

liaolucy added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true) +RVV_VECTOR_TYPE_INT("_

[PATCH] D92751: Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby created this revision. Herald added a subscriber: kristof.beyls. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC on WoA64 includes isCXX14Aggregate in its definition. This is de-facto specification on that platfor

[PATCH] D92704: [clangd] Publish config file errors over LSP

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/29315/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92704/new/ https://reviews.llvm.org/D92704 ___ cfe-c

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true) +RVV_VECTOR_TYPE_INT("__r

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, JakeMerdichAMD, krasimir. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. A quick search of

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. This needs rebasing against main. Can't be applied cleanly in its current state. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:398-404 + std::string OptionVal = StrMap.lookup(OptionKey); + llvm::transform(OptionVal,

Re: [PATCH] D92704: [clangd] Publish config file errors over LSP

Yep, thanks. This uncovered an existing error, so rather than reverting the whole thing I've disabled the assert on windows while I fix it. f1357264b8e3070bef5bb4ff35ececa4d6c76108 On Mon, Dec 7, 2020 at 12:22 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comme

[clang-tools-extra] f135726 - [clangd] Temporarily test that uncovered broken behavior on windows

Author: Sam McCall Date: 2020-12-07T12:34:17+01:00 New Revision: f1357264b8e3070bef5bb4ff35ececa4d6c76108 URL: https://github.com/llvm/llvm-project/commit/f1357264b8e3070bef5bb4ff35ececa4d6c76108 DIFF: https://github.com/llvm/llvm-project/commit/f1357264b8e3070bef5bb4ff35ececa4d6c76108.diff LO

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

njames93 added a comment. Should this be controlled on a case by case basis, maybe control indentation using a regex over the pragma arguments, WDYT? Comment at: clang/docs/ClangFormatStyleOptions.rst:1923-1924 + + When ``false``, pragmas are flushed left or follow IndentPPDi

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

MyDeveloperDay added a comment. I think my expectation would be that if you are going to have an option `BreakBeforeInlineASMColon` then it should do it for all case long and short, otherwise its not going to be clear. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://r

[clang-tools-extra] 2542ef8 - [clangd] Fix windows slashes in project config diagnostics

Author: Sam McCall Date: 2020-12-07T12:54:38+01:00 New Revision: 2542ef83ed7c5a10f8b394ec8e7764558dc71d32 URL: https://github.com/llvm/llvm-project/commit/2542ef83ed7c5a10f8b394ec8e7764558dc71d32 DIFF: https://github.com/llvm/llvm-project/commit/2542ef83ed7c5a10f8b394ec8e7764558dc71d32.diff LO

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1cb9cbf5c49: Add ability to load a FixedCompilationDatabase from a buffer. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92640/new/

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay updated this revision to Diff 309869. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92753/new/ https://reviews.llvm.org/D92753 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[clang] a1cb9cb - Add ability to load a FixedCompilationDatabase from a buffer.

Author: Sam McCall Date: 2020-12-07T13:07:10+01:00 New Revision: a1cb9cbf5c4939e78a6c3b3677cf8e3dbdf51932 URL: https://github.com/llvm/llvm-project/commit/a1cb9cbf5c4939e78a6c3b3677cf8e3dbdf51932 DIFF: https://github.com/llvm/llvm-project/commit/a1cb9cbf5c4939e78a6c3b3677cf8e3dbdf51932.diff LO

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

This revision was automatically updated to reflect the committed changes. Closed by commit rG980618145bf0: [clang-tidy][docs] Update check options with boolean values instead of non… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay marked 7 inline comments as done. MyDeveloperDay added a comment. > Should this be controlled on a case by case basis, maybe control indentation > using a regex over the pragma arguments, WDYT? Most uses of pragmas seem to be at the 0'th level of scrope `#pragma once` etc Most ot

[clang-tools-extra] 9806181 - [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

Author: Nathan James Date: 2020-12-07T12:13:57Z New Revision: 980618145bf00a8e212cf3c6db46fb0a83081d69 URL: https://github.com/llvm/llvm-project/commit/980618145bf00a8e212cf3c6db46fb0a83081d69 DIFF: https://github.com/llvm/llvm-project/commit/980618145bf00a8e212cf3c6db46fb0a83081d69.diff LOG:

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 309873. nullptr.cpp added a comment. Herald added a subscriber: lxfind. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/Di

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. I tend to agree with @krasimir I don't see where you really use Maximum to mean anything, the nested configuration seems perhaps unnecessarily confusing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/ http

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:893 /*BeforeLambdaBody=*/false, + /*BeforeStructInitialization=*/false, /*BeforeWhile=*/false, an

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

aqjune added a comment. Hello all, What is the status of this patch? Do we need someone who look into the lit change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

curdeius added a comment. This LGTM in general. I just have a doubt. You've added `messUp` parameter to `verifyFormat`, because, IIUC, pragmas wouldn't be at the desired scope level indentation otherwise. Shouldn't clang-format find out what the correct indentation level for pragmas should be in

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4626 CES_AllowExceptionVariables = 4, -CES_FormerDefault = (CES_AllowParameters), -CES_Default = (CES_AllowParameters | CES_AllowDifferentTypes), -CES_AsIfByStdMove = (CES_AllowParamet

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92755 Repository: rG

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc planned changes to this revision. mibintc added a comment. I'm going to make further changes to this patch, it's not working as desired. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92721/new/ https://reviews.llvm.org/D92721 _

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko added inline comments. Comment at: clang/lib/Format/Format.cpp:893 /*BeforeLambdaBody=*/false, + /*BeforeStructInitialization=*/false, /*BeforeWhile=*/false,

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4626 CES_AllowExceptionVariables = 4, -CES_FormerDefault = (CES_AllowParameters), -CES_Default = (CES_AllowParameters | CES_AllowDifferentTypes), -CES_AsIfByStdMove = (CES_AllowParamet

[clang-tools-extra] 8625f5b - [clang-tidy][NFC] Streamline CheckOptions error reporting.

Author: Nathan James Date: 2020-12-07T14:05:49Z New Revision: 8625f5bc799f4ee1c85126bd007166fe6dff14a1 URL: https://github.com/llvm/llvm-project/commit/8625f5bc799f4ee1c85126bd007166fe6dff14a1 DIFF: https://github.com/llvm/llvm-project/commit/8625f5bc799f4ee1c85126bd007166fe6dff14a1.diff LOG:

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay added a comment. In D92753#2436852 , @curdeius wrote: > You've added `messUp` parameter to `verifyFormat`, because, IIUC, pragmas > wouldn't be at the desired scope level indentation otherwise. messUp was pull the line below onto the pragm

[PATCH] D91893: [clang-tidy] performance-unnecessary-copy-initialization: Prevent false positives when dependent variable is modified.

flx added a comment. Could someone take a first pass at this change? It would be great progress on this as this is the last currently known case that generates false positives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91893/new/ https://revie

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay updated this revision to Diff 309896. MyDeveloperDay added a comment. Add for(...) test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92753/new/ https://reviews.llvm.org/D92753 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h c

[PATCH] D51650: Implement target_clones multiversioning

erichkeane added a comment. In D51650#2418749 , @lebedev.ri wrote: > In D51650#1305509 , @erichkeane > wrote: > >> Fix @rsmith s comments, rebase on the big CPUDispatch refactor. > > Ping. What's the status here?

[PATCH] D92742: [clang] Add support for attribute 'swift_async'

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a minor nit. Comment at: clang/include/clang/Basic/AttrDocs.td:4367 +``actuallyAsync:callThisAsync`` wouldn't have been imported as ``async`` if not +for ``swift_async`` because it doesn't matc

[PATCH] D92761: [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts

joechrisellis created this revision. joechrisellis added reviewers: peterwaller-arm, DavidTruby. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. joechrisellis requested review of this revision. Herald added projects: clang, LLVM. Herald added subscriber

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

joechrisellis created this revision. joechrisellis added reviewers: peterwaller-arm, DavidTruby. Herald added subscribers: psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. joechrisellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: c

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

This revision was automatically updated to reflect the committed changes. Closed by commit rGb49b8f096c03: [PowerPC][Clang] Remove QPX support (authored by jsji). Changed prior to commit: https://reviews.llvm.org/D92329?vs=308405&id=309908#toc Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

martong created this revision. martong added a reviewer: steakhal. Herald added subscribers: ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. martong requ

[clang] b49b8f0 - [PowerPC][Clang] Remove QPX support

Author: Jinsong Ji Date: 2020-12-07T10:15:39-05:00 New Revision: b49b8f096c0382da17d3203dfaa3f54d04a47d27 URL: https://github.com/llvm/llvm-project/commit/b49b8f096c0382da17d3203dfaa3f54d04a47d27 DIFF: https://github.com/llvm/llvm-project/commit/b49b8f096c0382da17d3203dfaa3f54d04a47d27.diff LO

[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

kpn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2992 // floating point environment in the loop. +//XXX true? llvm::BasicBlock *startBB = Builder.GetInsertBlock(); mibintc wrote: > did you mean to leave this here? (blame shows t

[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3006 + CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, OpInfo.FPFeatures); SourceLocation Loc = E->getExprLoc(); kpn wrote: > mibintc wrote: > > What's the rule to follow about w

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

curdeius added a comment. Maybe it would be judicious to add a FIXME to `test::messUp` for the pragmas? Or fix it in this patch? Comment at: clang/unittests/Format/FormatTest.cpp:17641-17651 + verifyFormat("void foo() {\n" + " #pragma omp simd\n" +

[PATCH] D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

steakhal added a comment. LGTM besides my inline comment. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1737 .ArgConstraint( ArgumentCondition(4, WithinRange, Range(0, IntMax; `mmap` should hav

[PATCH] D92727: [CodeGen][MSan] Don't use offsets of zero-sized fields

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92727/new/ https://reviews.llvm.org/D92727 ___

[PATCH] D92658: [libTooling] Add `describe` stencil for formatting AST nodes for diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6bc4a71e345: [libTooling] Add `describe` combinator for formatting AST nodes for diagnostics. (authored by ymandel). Changed prior to commit: htt

[clang] e6bc4a7 - [libTooling] Add `describe` combinator for formatting AST nodes for diagnostics.

Author: Yitzhak Mandelbaum Date: 2020-12-07T16:08:05Z New Revision: e6bc4a71e3450d7230205683f63d6e22fbf9bf05 URL: https://github.com/llvm/llvm-project/commit/e6bc4a71e3450d7230205683f63d6e22fbf9bf05 DIFF: https://github.com/llvm/llvm-project/commit/e6bc4a71e3450d7230205683f63d6e22fbf9bf05.diff

[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

kpn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3006 + CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, OpInfo.FPFeatures); SourceLocation Loc = E->getExprLoc(); mibintc wrote: > kpn wrote: > > mibintc wrote: > > > What's the rule

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembersgetFieldOffset(layoutStartOffset) for current calleds is expected topoint to the first trivial field or the one which follows non-trivial

morehouse added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1742 + Context.toCharUnitsFromBits(Layout.getFieldOffset(layoutStartOffset) + + Context.getCharWidth() - 1); + llvm::ConstantInt *OffsetSizePtr = ---

[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. Thanks for the additional info @kpn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92596/new/ https://reviews.llvm.org/D92596

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay updated this revision to Diff 309926. MyDeveloperDay added a comment. Allow the tests to messUp() the code, turns out its some sort of interaction ONLY with the BeforeHash case (last test) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92753/new/ https://reviews.llvm.org/

[PATCH] D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

martong updated this revision to Diff 309931. martong marked an inline comment as done. martong added a comment. - Use -1 for mmap too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92764/new/ https://reviews.llvm.org/D92764 Files: clang/lib/Stat

[PATCH] D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1737 .ArgConstraint( ArgumentCondition(4, WithinRange, Range(0, IntMax; steakhal wrote: > `mmap` should have the same

  1   2   3   >