njames93 added a comment. This needs rebasing against main. Can't be applied cleanly in its current state.
================ Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:398-404 + std::string OptionVal = StrMap.lookup(OptionKey); + llvm::transform(OptionVal, OptionVal.begin(), toupper); + + if (OptionVal == "1" || OptionVal == "TRUE" || OptionVal == "ON") + return true; + + return false; ---------------- There's no need to build a string and transform it here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
