[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

hokein marked 2 inline comments as done. hokein added a comment. sorry for the delay, picking it up now. Comment at: clang/lib/Sema/SemaCoroutine.cpp:864 ExprResult R = buildPromiseCall(*this, Promise, Loc, "await_transform", E); -if (R.isInvalid()) { +if (R.isInva

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 308269. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Herald added a subscriber: jfb. Use WaitForStateChange instead. Simplify code structure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev added a comment. Yes, the idea here is to provide logging for gRPC server state. My original thought was that default `HealthCheck` might not be enough and we might want to add more things in the mechanism but I guess it's not obvious what these extensions might be and getting `grpc_co

[clang] ec6c5e9 - [clang] Improve diagnostics for auto-return-type function if the return expr had an error.

Author: Haojian Wu Date: 2020-11-30T09:19:15+01:00 New Revision: ec6c5e920a89db0e1c5f73b8349ee0b84192072d URL: https://github.com/llvm/llvm-project/commit/ec6c5e920a89db0e1c5f73b8349ee0b84192072d DIFF: https://github.com/llvm/llvm-project/commit/ec6c5e920a89db0e1c5f73b8349ee0b84192072d.diff LO

[PATCH] D92211: [clang] Improve diagnostics for auto-return-type function if the return expr had an error

This revision was automatically updated to reflect the committed changes. Closed by commit rGec6c5e920a89: [clang] Improve diagnostics for auto-return-type function if the return expr… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS added a comment. Another way to avoid UB in that case is to use value initialization, i.e. `PathDiagnosticConsumerOptions options{};`. Can you commit this, please? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[clang] c219282 - [AST][RecoveryAST] Preseve more invalid return stmt.

Author: Haojian Wu Date: 2020-11-30T09:26:41+01:00 New Revision: c21928285430cc25905f774a89cb948867ae55b6 URL: https://github.com/llvm/llvm-project/commit/c21928285430cc25905f774a89cb948867ae55b6 DIFF: https://github.com/llvm/llvm-project/commit/c21928285430cc25905f774a89cb948867ae55b6.diff LO

[PATCH] D82284: [AST][RecoveryAST] Preseve invalid return stmt, and suppress the diagnostics for missing return stmt in constexpr func.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc21928285430: [AST][RecoveryAST] Preseve more invalid return stmt. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D92299: [clangd] Go-to-definition on pure virtual method decls jumps to all overrides.

hokein created this revision. hokein added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:276-277 "-fembed-bitcode is not supported on versions of iOS prior to 6.0">; +def err_drv_stack_clash_protection_unsupported_on_toolchain : Error< + "-fstack-clash-protecti

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2356-2359 + auto *CD = cast(OldParam->getDeclContext()); + // If the typedef is not a local typedef, then skip the transform. + if (OldTypedefDecl->getDeclContext() != CD->getDeclContext()) +

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

nikic added inline comments. Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:661 + } +} } These fixes look unrelated. Is it possible to test them separately? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] 8da7efb - [clang-tidy] add concurrency module

Author: Vasily Kulikov Date: 2020-11-30T12:27:17+03:00 New Revision: 8da7efbb0d5ec315a27b7b5286dbdd25694905ad URL: https://github.com/llvm/llvm-project/commit/8da7efbb0d5ec315a27b7b5286dbdd25694905ad DIFF: https://github.com/llvm/llvm-project/commit/8da7efbb0d5ec315a27b7b5286dbdd25694905ad.diff

[PATCH] D91656: [clang-tidy] add concurrency module

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da7efbb0d5e: [clang-tidy] add concurrency module (authored by segoon, committed by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ ht

[clang-tools-extra] cac5be4 - [clang-tidy] implement concurrency-mt-unsafe

Author: Vasily Kulikov Date: 2020-11-30T12:27:17+03:00 New Revision: cac5be495ed88b269ad7a3000305e714cce60e63 URL: https://github.com/llvm/llvm-project/commit/cac5be495ed88b269ad7a3000305e714cce60e63 DIFF: https://github.com/llvm/llvm-project/commit/cac5be495ed88b269ad7a3000305e714cce60e63.diff

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

This revision was automatically updated to reflect the committed changes. Closed by commit rGcac5be495ed8: [clang-tidy] implement concurrency-mt-unsafe (authored by segoon, committed by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944

[PATCH] D92291: clang/test: Remove platform-linker feature

serge-sans-paille added a comment. If that's okay with @leonardchan in terms of RISCV validation, I'm fine with that one. Any branch removed is less path to cover! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92291/new/ https://reviews.llvm.org/D92291

[PATCH] D91799: [clang-format] State where clang-format-diff.py should be run from

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5fbc60e4de4: [clang-format] State where clang-format-diff.py should be run from (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[clang] b5fbc60 - [clang-format] State where clang-format-diff.py should be run from

Author: David Spickett Date: 2020-11-30T10:00:49Z New Revision: b5fbc60e4de45f2b56331281a706b78ff52bd286 URL: https://github.com/llvm/llvm-project/commit/b5fbc60e4de45f2b56331281a706b78ff52bd286 DIFF: https://github.com/llvm/llvm-project/commit/b5fbc60e4de45f2b56331281a706b78ff52bd286.diff LOG

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 308290. sylvestre.ledru added a comment. Fix the error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 Files: clang/include/clang/Basic/DiagnosticDriv

[clang-tools-extra] 317ca3e - [NFC][clang-tidy] Do link FrontendOpenMP into concurrency module after all

Author: Roman Lebedev Date: 2020-11-30T13:34:00+03:00 New Revision: 317ca3ecf8244cabb4ca9d45e626ad3cf0f8e4b2 URL: https://github.com/llvm/llvm-project/commit/317ca3ecf8244cabb4ca9d45e626ad3cf0f8e4b2 DIFF: https://github.com/llvm/llvm-project/commit/317ca3ecf8244cabb4ca9d45e626ad3cf0f8e4b2.diff

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. I think fundamentally from my perspective this seem ok, out of interest can I ask what drove you to require it? My assumption is that some people write comments like // Free comment without space\n" and you want to be able to consistently format it to be (N sp

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added inline comments. Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:661 + } +} } nikic wrote: > These fixes look unrelated. Is it possible to test them separately? So my understanding is that the actual line that fixes the compile tim

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! The testing can be improved before committing! Comment at: clang/lib/Sema/SemaDecl.cpp:8638 // array, this recursive call only happens once. re

[PATCH] D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

steakhal created this revision. steakhal added reviewers: martong, NoQ, vsavchenko, balazske, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a proj

[PATCH] D83979: Port LangOpts option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D

[PATCH] D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1738 Optional Off64_tTy = lookupTy("off64_t"); -Optional Off64_tMax = getMaxValue(Off_tTy); // void *mmap64(void *addr, size_t length, int prot, int flags,

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308311. jansvoboda11 added a comment. Rebase, move options back, port new options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basi

[PATCH] D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

vsavchenko added a comment. That's a good fix! How did this happen though that max value of `off_t` was even used for `fd`. Seems pretty odd! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92307/new/ https://reviews.llvm.org/D92307 __

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308312. jansvoboda11 added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions.h clang/inclu

[PATCH] D92270: [ConstantFold] Fold more operations to poison

uabelho added a comment. Hi, I'm seeing a miscompile with this patch. I'm not very good at the semantic differences between undef and poison so I don't know really where it goes wrong. Before Early CSE I see this in the input: entry: %cmp1 = icmp uge i16 1015, 16, !dbg !9 %shr = lshr

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

njames93 added a comment. Can this be moved from bugprone to the new concurrency module added in D91656 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 ___

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308322. jansvoboda11 added a comment. Revert accidental changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. While it would be nice for `dereferenceable` to not imply nonnull, the implementation currently assumes it does and will speculate loads based on that. See `llvm::Value::getPointerDereferenc

[PATCH] D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

martong added a comment. In D92307#2422468 , @vsavchenko wrote: > That's a good fix! > How did this happen though that max value of `off_t` was even used for `fd`. > Seems pretty odd! I used a semi-automated approach to create these summaries from cppch

[PATCH] D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92307/new/ https://reviews.llvm.org/D92307

[clang] 33eac0f - [VE] Specify vector alignments

Author: Kazushi (Jam) Marukawa Date: 2020-11-30T22:09:21+09:00 New Revision: 33eac0f2830ee3f362ec0207a3d0e5f0861de8f1 URL: https://github.com/llvm/llvm-project/commit/33eac0f2830ee3f362ec0207a3d0e5f0861de8f1 DIFF: https://github.com/llvm/llvm-project/commit/33eac0f2830ee3f362ec0207a3d0e5f0861de

[PATCH] D92256: [VE] Specify vector alignments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33eac0f2830e: [VE] Specify vector alignments (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

vsavchenko accepted this revision. vsavchenko added a comment. In D92307#2422603 , @martong wrote: > In D92307#2422468 , @vsavchenko > wrote: > >> That's a good fix! >> How did this happen though that max value of

[PATCH] D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

joerg added a comment. off_t is s signed type. Please fix the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92307/new/ https://reviews.llvm.org/D92307 ___ cfe-commits mailing list cfe-commit

[PATCH] D92270: [ConstantFold] Fold more operations to poison

aqjune added a comment. Hi, It seems it is related to two optimizations: (1) `select i1 x, true, y` -> `or i1 x, y` (2) `or i1 x, poison` -> `poison` Semantically, the first one is broken. It needs to freeze y. But, it will introduce a lot of freeze instructions. The clang patches that introduc

[PATCH] D92270: [ConstantFold] Fold more operations to poison

uabelho added a comment. In D92270#2422625 , @aqjune wrote: > Hi, > > It seems it is related to two optimizations: > (1) `select i1 x, true, y` -> `or i1 x, y` > (2) `or i1 x, poison` -> `poison` > > Semantically, the first one is broken. It needs to freez

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong updated this revision to Diff 308335. martong marked 2 inline comments as done. martong added a comment. - Check for dependent DeclContext - Remove "dump()" calls from tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92101/new/ https://r

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

martong added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:2356-2359 + auto *CD = cast(OldParam->getDeclContext()); + // If the typedef is not a local typedef, then skip the transform. + if (OldTypedefDecl->getDeclContext() != CD->getDeclContext())

[PATCH] D92198: [clangd] Log remote index connectivity status

sammccall added a comment. Thanks! Hooking into the native status stuff seems much nicer! Sorry if it seems like we're going in circles here, I think we should be careful about adding background threads so want to look at an alternative too. Comment at: clang-tools-extra/clan

[PATCH] D92270: [ConstantFold] Fold more operations to poison

aqjune added a comment. In D92270#2422661 , @uabelho wrote: > Should langref also be updated to describe this? Or does it already? > I just found this > "An instruction that depends on a poison value, produces a poison value > itself." > here > http://l

[PATCH] D92270: [ConstantFold] Fold more operations to poison

uabelho added a comment. In D92270#2422741 , @aqjune wrote: > In D92270#2422661 , @uabelho wrote: > >> Should langref also be updated to describe this? Or does it already? >> I just found this >> "An instruction th

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

arsenm updated this revision to Diff 308354. arsenm added a comment. Fix bitcode upgrade after rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91840/new/ https://reviews.llvm.org/D91840 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/attr-x86-interrupt.c clang/tes

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

emaste added a comment. Can we add a test that the feature can be enabled on an OS other than Linux / Windows / Darwin? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 _

[clang] d5aaf60 - [windows-itanium] handle dllimport/export code paths separately and share with PS4

Author: Ben Dunbobbin Date: 2020-11-30T14:36:39Z New Revision: d5aaf6021476243de73f8eb8a7479a2288582225 URL: https://github.com/llvm/llvm-project/commit/d5aaf6021476243de73f8eb8a7479a2288582225 DIFF: https://github.com/llvm/llvm-project/commit/d5aaf6021476243de73f8eb8a7479a2288582225.diff LOG:

[PATCH] D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5aaf6021476: [windows-itanium] handle dllimport/export code paths separately and share with… (authored by Ben Dunbobbin ). Herald added a project: clang. Herald added a subscriber

[PATCH] D91874: [GNU ObjC] Fix a regression listing methods twice.

theraven added a comment. I'd like to get this into the 11 point release, so it would be good to have a review... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91874/new/ https://reviews.llvm.org/D91874 ___

[PATCH] D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC)

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211

[PATCH] D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4027-4031 + if (((FLAGS)&options::CC1Option) && \ + (ALWAYS_EMIT || \ + (EXTRACT

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 308373. aorlov added a comment. Improved solution. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files: clang/include/clang/Parse/Parser.h clang/

[PATCH] D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

steakhal added a comment. In D92307#2422624 , @joerg wrote: > off_t is s signed type. Please fix the description. Oh, thanks. Updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92307/new/ https://revie

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:13 kernel void no_ptrptr(global int * global *i) { } +kernel void no_ptrptrptr(global int * global * global *i) { } Anastasia wrote: > Btw this was missing in the orig

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

jsji created this revision. Herald added subscribers: cfe-commits, dang, shchenz, kbarton, nemanjai. Herald added a project: clang. jsji requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Clean up QPX code in clang missed in https://reviews.

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

RKSimon added a comment. In D52050#2369856 , @glaubitz wrote: > In D52050#2369838 , @dschuff wrote: > >> One other question then: do you know if Debian and/or Ubuntu still have the >> same support for running x32 p

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90053/new/ https://reviews.llvm.org/D90053 ___ cfe-commits mailing list cf

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

qiucf added a comment. Another small place also needs remove? (but not related to clang) `llvm/test/Transforms/LoopVectorize/PowerPC/vectorize-only-for-real.ll`: attributes #0 = { nounwind "target-cpu"="a2q" "target-features"="+qpx,-altivec,-bpermd,-crypto,-direct-move,-extdiv,-power8-vector,

[PATCH] D90485: Lex: Update Module::findHeader to return FileEntryRef, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90485/new/ https://reviews.llvm.org/D90485 ___ cfe-commits mailing list cf

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90497/new/ https://reviews.llvm.org/D90497 ___ cfe-commits mailing list cf

[PATCH] D91310: [AMDGPU] Add -mcode-object-version=n

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91310/new/ https://reviews.llvm.org/D91310 ___ cfe-commits mailing list cfe-commits

[clang] 70eb2ce - [ASTImporter] Support import of CXXDeductionGuideDecl

Author: Gabor Marton Date: 2020-11-30T17:55:25+01:00 New Revision: 70eb2ce395be1fe39ceede6719aa667658d1e5a3 URL: https://github.com/llvm/llvm-project/commit/70eb2ce395be1fe39ceede6719aa667658d1e5a3 DIFF: https://github.com/llvm/llvm-project/commit/70eb2ce395be1fe39ceede6719aa667658d1e5a3.diff

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70eb2ce395be: [ASTImporter] Support import of CXXDeductionGuideDecl (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Left tiny question inline, but LGTM anyways. Comment at: clang/unittests/Basic/FileEntryTest.cpp:95 OptionalFileEntryRefDegradesToFileEntryPtr M0; Optiona

[clang] abfbc55 - [FPEnv] clang should get from the AST the metadata for constrained FP builtins

Author: Kevin P. Neal Date: 2020-11-30T11:59:37-05:00 New Revision: abfbc5579bd4507ae286d4f29f8a157de0629372 URL: https://github.com/llvm/llvm-project/commit/abfbc5579bd4507ae286d4f29f8a157de0629372 DIFF: https://github.com/llvm/llvm-project/commit/abfbc5579bd4507ae286d4f29f8a157de0629372.diff

[PATCH] D92122: [FPEnv] clang should get from the AST the metadata for constrained FP builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGabfbc5579bd4: [FPEnv] clang should get from the AST the metadata for constrained FP builtins (authored by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D92122: [FPEnv] clang should get from the AST the metadata for constrained FP builtins

kpn added a comment. Thanks for the quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92122/new/ https://reviews.llvm.org/D92122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

dmajor added a comment. In D91747#2412346 , @alanphipps wrote: > Looks like _LIBCPP_HAS_NO_THREADS is being set for libcxxabi, and the build > now fails with this change: > > llvm-project/libcxxabi/../libcxx/include/__config:1172:2: error: > _LIBCPP_HAS_

[clang] ee073c7 - [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

Author: Balazs Benics Date: 2020-11-30T18:06:28+01:00 New Revision: ee073c798515e56b23463391a7b40d5ee6527337 URL: https://github.com/llvm/llvm-project/commit/ee073c798515e56b23463391a7b40d5ee6527337 DIFF: https://github.com/llvm/llvm-project/commit/ee073c798515e56b23463391a7b40d5ee6527337.diff

[PATCH] D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

This revision was automatically updated to reflect the committed changes. Closed by commit rGee073c798515: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64 (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D92330: [clang-scan-deps] Improve argument parsing to find target object file path.

saudi created this revision. saudi added reviewers: arphaman, jkolek, Bigcheese. saudi added a project: clang. Herald added subscribers: cfe-commits, tschuett. saudi requested review of this revision. This patch adds support for the joined version of `-o` (e.g. `-ofilename`) command parameter wh

[clang] bc7b268 - Add -fintegrated-as to second invocation of clang in test case.

Author: Zarko Todorovski Date: 2020-11-30T12:15:25-05:00 New Revision: bc7b2688d6762687ab4ec103d214ce5bb5d4210f URL: https://github.com/llvm/llvm-project/commit/bc7b2688d6762687ab4ec103d214ce5bb5d4210f DIFF: https://github.com/llvm/llvm-project/commit/bc7b2688d6762687ab4ec103d214ce5bb5d4210f.di

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 308402. sylvestre.ledru added a comment. Herald added subscribers: llvm-commits, pengfei. Herald added a project: LLVM. extend the test (thanks serge) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

jdoerfert added a comment. In D92297#2422568 , @bkramer wrote: > While it would be nice for `dereferenceable` to not imply nonnull, the > implementation currently assumes it does and will speculate loads based on > that. See `llvm::Value::getPointerDeref

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

jsji updated this revision to Diff 308405. jsji added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fix llvm test as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92329/new/ https://reviews.llvm.org/D92329

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. In D92004#2420121 , @svenvh wrote: >> I am still unclear what should we do with testing though. > > We probably don't want to hold up this patch until we have more thorough > testing in place, since we don't even have any concre

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2423144 , @RKSimon wrote: > Were you able to compare against GCC and also determine debian/ubuntu's > x86_64 current support for x32 executables? Not yet. Currently freeing up space on my VM host so I can perform a fre

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. Herald added a subscriber: hoy. @tejohnson @MaskRay Do you have other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 ___ cfe-c

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

hoy abandoned this revision. hoy added a comment. Abandoning this diff which has been broken into four other diffs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/ https://reviews.llvm.org/D86193 __

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc083fededfa6: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe… (authored by hoy). Repository: rG LLVM Github Monorepo CHANG

[clang] c083fed - [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

Author: Hongtao Yu Date: 2020-11-30T10:16:54-08:00 New Revision: c083fededfa63df6e1a560334bdb78797da9ee57 URL: https://github.com/llvm/llvm-project/commit/c083fededfa63df6e1a560334bdb78797da9ee57 DIFF: https://github.com/llvm/llvm-project/commit/c083fededfa63df6e1a560334bdb78797da9ee57.diff LO

[PATCH] D92291: clang/test: Remove platform-linker feature

leonardchan added a subscriber: phosek. leonardchan added a comment. @phosek This shouldn't affect supporting riscv with our toolchain, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92291/new/ https://reviews.llvm.org/D92291 ___ cfe-co

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

MaskRay updated this revision to Diff 308419. MaskRay edited the summary of this revision. MaskRay added a comment. Add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92297/new/ https://reviews.llvm.org/D92297 Files: clang/lib/CodeGen/CGCal

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

svenvh added a comment. >> We probably don't want to hold up this patch until we have more thorough >> testing in place, since we don't even have any concrete plans for such >> testing at the moment. > > Well accepting such a significant change that implements the entire > functionality of a ne

[PATCH] D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2176 +} else { + // FIXME dereferenceable should be correct here, regardless of + // NullPointerIsValid. However, dereferenceable currently does not always @rsmith @jdoerfert

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin updated this revision to Diff 308422. mtrofin added a comment. Fixed the LTO case. Also fixed the p46945 test, which, post - D90566 , was passing without the need of a preliminary always-inlier pass. The reason is that the order of the traversal of the f

[PATCH] D91428: Add support for multiple program address spaces

pmatos abandoned this revision. pmatos added a comment. In D91428#2413292 , @pmatos wrote: > Thanks, @arichardson and @jrtc27 for your comments. > I am definitely surprised to find that if you explicitly mark the call with > the address space, this patch

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. In D92004#2423441 , @svenvh wrote: >>> We probably don't want to hold up this patch until we have more thorough >>> testing in place, since we don't even have any concrete plans for such >>> testing at the moment. >> >> Well ac

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:48 + const DataLayout &DL = MMI->getModule()->getDataLayout(); + const unsigned PointerSize = DL.getPointerSizeInBits() == 64 ? 8 : 4; + nit: Why not just call `getPointerS

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. aside from some nits, lgtm thanks for doing this! Comment at: clang/test/Frontend/optimization-remark-line-directive.c:5 -// RUN: %clang_cc1 %s -Rpass=inline -debug-inf

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D92330: [clang-scan-deps] Improve argument parsing to find target object file path.

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92330/new/ https://reviews.llvm.org/D92330 __

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang updated this revision to Diff 308433. weiwang added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basi

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:889 + CompactUnwindSection = + Ctx->getXCOFFSection(".eh_info_table", XCOFF::StorageMappingClass::XMC_RW, + XCOFF::XTY_SD, SectionKind::getData()); I thi

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

ymandel added inline comments. Comment at: clang/lib/AST/ASTTypeTraits.cpp:138 +return ASTNodeKind(NKI_##A##Attr); +#include "clang/Basic/AttrList.inc" + } aaron.ballman wrote: > Oye, this brings up an interesting point. Plugin-based attributes currently >

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thank you, lgtm! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84467/new/ https://reviews.llvm.org/D84467 ___ cfe-commits mailing list cfe-commi

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin updated this revision to Diff 308441. mtrofin marked 5 inline comments as done. mtrofin added a comment. fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91567/new/ https://reviews.llvm.org/D91567 Files: clang/test/CodeGen/thinlto-dis

  1   2   3   >