[PATCH] D91590: [NVPTX] Efficently support dynamic index on CUDA kernel aggregate parameters.

hliao added a comment. As mentioned earlier, that's very experimental support. Even though the SASS looks reasonable, it still needs verifying on real systems. For non-kernel functions, it seems we share the path. So that we should do a similar thing. The current approach fixes that in the code

[clang] 955341a - test commit

Author: Thorsten Schütt Date: 2020-11-18T09:20:37+01:00 New Revision: 955341a722a0a204c79f6b948e4fe0f23bb56e30 URL: https://github.com/llvm/llvm-project/commit/955341a722a0a204c79f6b948e4fe0f23bb56e30 DIFF: https://github.com/llvm/llvm-project/commit/955341a722a0a204c79f6b948e4fe0f23bb56e30.dif

[PATCH] D91626: [clangd] Implement textDocument/implementation.

hokein added a comment. thanks, just reviewed at the xrefs code. I think we can narrow the scope of the patch by splitting it into two patches - find-implementation in xrefs.cpp - LSP & clangd server layer (needs a smoke lit test) Comment at: clang-tools-extra/clangd/XRefs.c

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

ro added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:455-520 +#if SANITIZER_SOLARIS +// dlpi_tls_modid is only available since Solaris 11.4 SRU 10. Use +// dlinfo(RTLD_DI_LINKMAP) instead which works on both Solaris 11.3 and Illumos

[clang-tools-extra] 9d77584 - [clangd] Call hierarchy (Protocol layer)

Author: Nathan Ridge Date: 2020-11-18T03:41:31-05:00 New Revision: 9d77584fe04010a2aa536308d4032bf5677d7000 URL: https://github.com/llvm/llvm-project/commit/9d77584fe04010a2aa536308d4032bf5677d7000 DIFF: https://github.com/llvm/llvm-project/commit/9d77584fe04010a2aa536308d4032bf5677d7000.diff

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d77584fe040: [clangd] Call hierarchy (Protocol layer) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:109 +/// Get call hierarchy information at \p Pos. +llvm::Optional> +prepareCallHierarchy(ParsedAST &AST, Position Pos, const SymbolIndex *Index, kadircet wrote: > nridge wrote: > > kadirc

[PATCH] D85600: [clang-format] use spaces for alignment of binary/ternary expressions with UT_AlignWithSpaces

sylvestre.ledru added a comment. I am not 100% that it is thanks to this patch but reformatting Firefox code with clang-format 11 significantly improves the readability of the usage of ternary operators. See: https://phabricator.services.mozilla.com/D90795 Thanks for the change! Repository:

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over the revision, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83298/new/ https://reviews.llvm.org

[clang] 2be5698 - [clang][cli] Add ability to make fixups to CompilerInvocation after option parsing

Author: Jan Svoboda Date: 2020-11-18T10:35:38+01:00 New Revision: 2be569870486a2068667f4625723c0a7409f4c97 URL: https://github.com/llvm/llvm-project/commit/2be569870486a2068667f4625723c0a7409f4c97 DIFF: https://github.com/llvm/llvm-project/commit/2be569870486a2068667f4625723c0a7409f4c97.diff L

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2be569870486: [clang][cli] Add ability to make fixups to CompilerInvocation after option… (authored by jansvoboda11). Changed prior to commit: htt

[PATCH] D83315: Turn arcmt-* options into a single option

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83315/new/ https://reviews.llvm.org/D

[PATCH] D83315: Turn arcmt-* options into a single option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05eeda9752b3: [clang][cli] Turn arcmt-* options into a single option (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 05eeda9 - [clang][cli] Turn arcmt-* options into a single option

Author: Jan Svoboda Date: 2020-11-18T10:53:41+01:00 New Revision: 05eeda9752b393c074dd22716670bc3b9671270d URL: https://github.com/llvm/llvm-project/commit/05eeda9752b393c074dd22716670bc3b9671270d DIFF: https://github.com/llvm/llvm-project/commit/05eeda9752b393c074dd22716670bc3b9671270d.diff L

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein updated this revision to Diff 306015. hokein marked 9 inline comments as done. hokein added a comment. rebase and address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 Files: cla

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein added a comment. In D84637#2345353 , @rsmith wrote: > There are a couple of cases where you're returning `EvalStmtResult` from a > function with a `bool` return type, that I'd like to see fixed before this > lands. > > All the other comments are d

[PATCH] D91162: Give up on evaluating value-dependent potential constexpr before hitting the assertion.

hokein added a comment. In D91162#2400723 , @hokein wrote: > oops, this reminds me of the patch https://reviews.llvm.org/D84637 (I should > have landed it, sorry), that patch should fix a general recovery-expr crash > inside constexpr function body. I th

[PATCH] D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83406/new/ https://reviews.llvm.org/D

[PATCH] D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e696d895bde: [clang][cli] Remove NormalizerRetTy and use the decltype of the KeyPath instead (authored by jansvoboda11). Changed prior to commit:

[clang] 5e696d8 - [clang][cli] Remove NormalizerRetTy and use the decltype of the KeyPath instead

Author: Jan Svoboda Date: 2020-11-18T11:31:13+01:00 New Revision: 5e696d895bde1eb584a9de5c9feba1a98c6bb487 URL: https://github.com/llvm/llvm-project/commit/5e696d895bde1eb584a9de5c9feba1a98c6bb487 DIFF: https://github.com/llvm/llvm-project/commit/5e696d895bde1eb584a9de5c9feba1a98c6bb487.diff L

[PATCH] D83690: Port Migator option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83690/new/ https://reviews.llvm.org/D

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 306020. segoon retitled this revision from "[clang-tidy] implement concurrent-mt-unsafe" to "[clang-tidy] implement concurrency-mt-unsafe". segoon added a comment. - concurrent -> concurrency - split the patch apart CHANGES SINCE LAST ACTION https://review

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

hokein created this revision. hokein added a reviewer: adamcz. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. to be consistent witih other code actions. Repository

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 306022. segoon retitled this revision from "[clang-tidy] add concurrent module" to "[clang-tidy] add concurrency module". segoon added a comment. - concurrent -> concurrency CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.ll

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. MarkMurrayARM requested review of this revision. Add support for the Neoverse N2 CPU to the ARM and AArch64 backends. Repository:

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

njames93 added a comment. If you are doing this may as well cover `DefineOutline` and `RemoveUsingNamespace` - that one can do away with formatv too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91694/new/ https://reviews.llvm.org/D91694 ___

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306026. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve some comments, simplify the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:239 + if (const auto *Template = D->getPrimaryTemplate()) +return canonicalRenameDecl(Template); + return D; hokein wrote: > the `auto` + varies `canonicalRenameDecl` o

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 306027. kbobyrev added a comment. Remove leftover test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp Index: c

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

JonChesterfield added a comment. If data mappings can overlap, then it follows that copies to/from the target must be done sequentially by the runtime, unless additional information on their independence exists. Alias analysis style. I see the programmer convenience angle, but it is a shame to

[clang] 1e6fc2f - [clang][cli] Port Migrator option flags to new option parsing system

Author: Jan Svoboda Date: 2020-11-18T12:18:27+01:00 New Revision: 1e6fc2fa532c280abec04f83410dfdb3760dfc0f URL: https://github.com/llvm/llvm-project/commit/1e6fc2fa532c280abec04f83410dfdb3760dfc0f DIFF: https://github.com/llvm/llvm-project/commit/1e6fc2fa532c280abec04f83410dfdb3760dfc0f.diff L

[PATCH] D83690: Port Migator option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e6fc2fa532c: [clang][cli] Port Migrator option flags to new option parsing system (authored by jansvoboda11). Changed prior to commit: https://re

[PATCH] D91656: [clang-tidy] add concurrency module

njames93 added a comment. Now that you have added the concurrency module as a new patch, all that code needs removing from this diff. If you generate the diff from that patch it should work. You should only be left with the code needed to add this check to that module. CHANGES SINCE LAST ACTI

[PATCH] D91656: [clang-tidy] add concurrency module

njames93 added a comment. Can you remove the code related to adding the mt-unsafe-posix check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 306035. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clang/lib/

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

abidh updated this revision to Diff 306036. abidh added a comment. Handle review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91559/new/ https://reviews.llvm.org/D91559 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/test/Driver/baremetal.cpp Index: clang/test/Dr

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

abidh marked an inline comment as done. abidh added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:39 +llvm::sys::path::append(SysRoot, "lib"); +getFilePaths().push_back(std::string(SysRoot.str())); + } jroelofs wrote: > Is the ex

[clang] 680931a - [Matrix] Adjust matrix pointer type for inline asm arguments.

Author: Florian Hahn Date: 2020-11-18T11:44:11Z New Revision: 680931af2757fb495c5727d335ffa580fb3dbe98 URL: https://github.com/llvm/llvm-project/commit/680931af2757fb495c5727d335ffa580fb3dbe98 DIFF: https://github.com/llvm/llvm-project/commit/680931af2757fb495c5727d335ffa580fb3dbe98.diff LOG:

[PATCH] D91631: [Matrix] Adjust matrix pointer type for inline asm arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG680931af2757: [Matrix] Adjust matrix pointer type for inline asm arguments. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

joechrisellis created this revision. joechrisellis added reviewers: fpetrogalli, peterwaller-arm. Herald added subscribers: cfe-commits, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. joechrisellis requested review of this revision. Previously, l

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

RKSimon added subscribers: stephenkelly, RKSimon. RKSimon added a comment. @stephenkelly This is breaking a large number of bots - please can you revert your patch series to get things green again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9098

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

willlovett added a comment. I found this one. The fix looks sensible, and I believe the test is correct and consistent with the spec. I'll leave it to someone else to accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91696/new/ https://revie

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/ https://reviews.llvm.org/D

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 updated this revision to Diff 306042. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/ https://reviews.llvm.org/D83691 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[PATCH] D83691: Port Comment option flags to new parsing system

jansvoboda11 added a comment. WDYT @Bigcheese? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83691/new/ https://reviews.llvm.org/D83691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

joechrisellis updated this revision to Diff 306043. joechrisellis added a comment. Remove redundant tests from clang/test/Sema/attr-arm-sve-vector-bits.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91696/new/ https://reviews.llvm.org/D91696 Fil

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 306044. segoon added a comment. - remove garbage files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/ClangTidyForceLinker.

[PATCH] D91656: [clang-tidy] add concurrency module

segoon added a comment. In D91656#2402245 , @njames93 wrote: > Can you remove the code related to adding the mt-unsafe-posix check. Sorry, I've added unnecessary files. Removed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

arichardson added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +if (!CodeGenOpts.NullPointerIsValid && +getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) { + Attrs.addAttribute(llvm::Attribute::NonNull); rjmccall wr

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

hokein updated this revision to Diff 306045. hokein added a comment. Fix other code actions as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91694/new/ https://reviews.llvm.org/D91694 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsin

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

hokein added a comment. In D91694#2402203 , @njames93 wrote: > If you are doing this may as well cover `DefineOutline` and > `RemoveUsingNamespace` - that one can do away with formatv too. good catch, thanks! Repository: rG LLVM Github Monorepo CHAN

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin updated this revision to Diff 306046. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. - addressed comments in the diff - stop ignoring system macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90835/n

[PATCH] D83693: Port analyzer flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Herald added a subscriber: steakhal. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D83693: Port analyzer flags to new option parsing system

jansvoboda11 updated this revision to Diff 306047. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83693/new/ https://reviews.llvm.org/D83693 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[PATCH] D83693: Port analyzer flags to new option parsing system

jansvoboda11 added a comment. WDYT @Bigcheese? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83693/new/ https://reviews.llvm.org/D83693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin added a comment. @njames93 thank you for the feedback! Still waiting for more feedback and especially high level one about this feature in general. Does it look useful? Should it be behind a flag i.e. changing default behaviour is too dangerous? Comment at: cl

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

dmgreen added a comment. Can you add the cpuid to host.cpp too? Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:154 +AARCH64_CPU_NAME("neoverse-n2", ARMV8_5A, FK_CRYPTO_NEON_FP_ARMV8, false, + (AArch64::AEK_BF16 | AArch64::AEK_DOTPROD | AArch64::AE

[clang] 8cdc538 - Add sysroot/lib to library search path of baremetal toolchain.

Author: Hafiz Abid Qadeer Date: 2020-11-18T12:38:52Z New Revision: 8cdc538873879bd57c3ba71956d68b49a2973a45 URL: https://github.com/llvm/llvm-project/commit/8cdc538873879bd57c3ba71956d68b49a2973a45 DIFF: https://github.com/llvm/llvm-project/commit/8cdc538873879bd57c3ba71956d68b49a2973a45.diff

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

This revision was automatically updated to reflect the committed changes. abidh marked an inline comment as done. Closed by commit rG8cdc53887387: Add sysroot/lib to library search path of baremetal toolchain. (authored by abidh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bcaa198 - Remove unportable test

Author: Stephen Kelly Date: 2020-11-18T12:42:07Z New Revision: bcaa19894994f1363a10c082541efb67435399d1 URL: https://github.com/llvm/llvm-project/commit/bcaa19894994f1363a10c082541efb67435399d1 DIFF: https://github.com/llvm/llvm-project/commit/bcaa19894994f1363a10c082541efb67435399d1.diff LOG:

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

OikawaKirie added a comment. In D91410#2400018 , @tejohnson wrote: > > ... the new checking is a mix of assert and fatal errors. Is that intended? No. The added checks are based on the checks on other calls to the `Target::createXXX` functions in thi

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

steveire added a comment. I've removed the offending test (which in this case is the correct fix - it is not a temporary fix). @RKSimon Is there some way I can see what is causing the failures on the other platforms? Was it because of this test? How can I monitor this? I knew how to see it in

[PATCH] D91696: [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. This LGTM. May I ask to extend the commit message to add a reference to the paragraph in section "3.7.3.3", item 2 on page 23 of the specs version 00bet6? Repository: rG LLVM Gith

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

paulwalker-arm added a comment. As I see it there are a bunch of pragmas that all enable vectorisation, with each pragma providing a unit of information. One component of this information is the vectorisation factor hint provided by vectorize_width. With the introduction of scalable vectors th

[clang] 871fe71 - Fix typo for hasAnyOverloadedOperatorName; NFC

Author: Keishi Hattori Date: 2020-11-18T07:48:59-05:00 New Revision: 871fe71f2951cb19421a2b47ddb54ed6b3c8cba2 URL: https://github.com/llvm/llvm-project/commit/871fe71f2951cb19421a2b47ddb54ed6b3c8cba2 DIFF: https://github.com/llvm/llvm-project/commit/871fe71f2951cb19421a2b47ddb54ed6b3c8cba2.diff

[PATCH] D91592: [ASTMatchers] Fix typo for hasAnyOverloadedOperatorName

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix, I've commit on your behalf in 871fe71f2951cb19421a2b47ddb54ed6b3c8cba2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 306059. reikdas added a comment. Addresses @rsmith 's comments. > On that basis, I think it would be preferable to change > TemplateArgument::print to accept not a bool indicating whether the type was > known, but instead a const NamedDecl * for the corresp

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM updated this revision to Diff 306062. MarkMurrayARM added a comment. Herald added a subscriber: dexonsmith. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 Files:

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM updated this revision to Diff 306063. MarkMurrayARM added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 Files: clang/test/Driver/aarch64-cpus.c clang/t

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:4554 + + // Language rules define if it is legal to cast from one address space + // to another, and which address space we should use as a "common asavonic wrote: > bader wrote: > >

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

tschuett added a comment. In the first version N2 had FeatureTME. Did you remove that on purpose? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 ___ cfe-commits

[clang-tools-extra] aad3ea8 - [clangd] Remove the trailing "." in add-using message.

Author: Haojian Wu Date: 2020-11-18T14:46:26+01:00 New Revision: aad3ea8983a84827f8d4bc81d76b2a5fe218430e URL: https://github.com/llvm/llvm-project/commit/aad3ea8983a84827f8d4bc81d76b2a5fe218430e DIFF: https://github.com/llvm/llvm-project/commit/aad3ea8983a84827f8d4bc81d76b2a5fe218430e.diff LO

[PATCH] D91694: [clangd] Remove the trailing "." in add-using message.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaad3ea8983a8: [clangd] Remove the trailing "." in add-using message. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91694/new/ https://

[PATCH] D91702: [clangd] Implement textDocument/implementation (Xref layer)

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Implements textdocument/implementation (https://microsoft.github.io/language-se

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 306076. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tool

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1153 + Index->relations(Req, [&](const SymbolID &Subject, const Symbol &Object) { +if (auto Loc = symbolToLocation(Object, *MainFilePath)) + Results.References.push_back(*Loc); -

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ymandel added a comment. LGTM. I'll leave it to Aaron, though, to accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91015/new/ https://reviews.llvm.org/D91015 ___ cfe-commits mailing list cfe-commits

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 306079. usaxena95 added a comment. Added test for no implementation for concrete methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/c

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ https://reviews.llvm.org/D86671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

abelkocsis updated this revision to Diff 306080. abelkocsis added a comment. Fixes, `std::atomic` variables add Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77493/new/ https://reviews.llvm.org/D77493 Files: clang-tools-extra/clang-tidy/bugprone/

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM added a comment. In D91695#2402495 , @tschuett wrote: > In the first version N2 had FeatureTME. Did you remove that on purpose? Yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ h

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

tschuett added a comment. The features still differ from gcc. https://github.com/gcc-mirror/gcc/blob/cb1a4876a0e724ca3962ec14dce9e7819fa72ea5/gcc/config/aarch64/aarch64-cores.def#L146 It has SVE2_Bitperm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

MarkMurrayARM added a comment. In D91695#2402616 , @tschuett wrote: > The features still differ from gcc. > https://github.com/gcc-mirror/gcc/blob/cb1a4876a0e724ca3962ec14dce9e7819fa72ea5/gcc/config/aarch64/aarch64-cores.def#L146 > It has SVE2_Bitperm. I'

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

aganea added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43002/new/ https://reviews.llvm.org/D43002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ye-luo added a comment. 1. Could you separate the reordering related changes to separate patch? 2. Could you mention which line in spec 4.5 was the restriction? Even 5.0/5.1 has some restrictions. Need to be clear which one you refer to. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91626: [clangd] Implement textDocument/implementation.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The patch description is a bit stale now. Comment at: clang-tools-extra/clangd/XRefs.cpp:1130 + std::vector Results; + // We rely on index to find the implementations in su

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:699 + let Inst{51-48} = addr{19-16}; // base reg + let Inst{55-52} = dst; + let Inst{47-32} = addr{15-0}; // offset There is another mismatch between what I implemented in the kern

[clang] bd4662c - [AST] Enhance the const expression evaluator to support error-dependent exprs.

Author: Haojian Wu Date: 2020-11-18T15:48:06+01:00 New Revision: bd4662cd3f3743e08699e6bab976d9e7b163ece0 URL: https://github.com/llvm/llvm-project/commit/bd4662cd3f3743e08699e6bab976d9e7b163ece0 DIFF: https://github.com/llvm/llvm-project/commit/bd4662cd3f3743e08699e6bab976d9e7b163ece0.diff LO

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd4662cd3f37: [AST] Enhance the const expression evaluator to support error-dependent exprs. (authored by hokein). Repository: rG LLVM Github Mono

[PATCH] D90928: [OpenCL] Add assertions to extension lookup

erik2020 updated this revision to Diff 306094. erik2020 added a comment. Changed asserting code to return `false` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90928/new/ https://reviews.llvm.org/D90928 Files: clang/include/clang/Basic/

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 306097. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/StmtDataCollectors.td clang/include/clang/AST/TemplateBase.h clang/lib/AST/ASTContext.cpp clang/lib/AST/ASTTypeTra

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:51 + // check specific version of feature) + void supportFeatureForPreOCL30(StringRef Feat, bool On = true) { +assert(CLVer < 300 && "Can'be called for OpenCL C higher 3.0");

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

ABataev added a comment. In D86119#2402661 , @ye-luo wrote: > 1. Could you separate the reordering related changes to separate patch? It is impossible. There is a separate patch for removing extra TGT_TARGET_PARAM but it cannot be separated from this pat

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the testing request. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-else-after-return.cpp:313 +#endif +} n

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

steveire requested changes to this revision. steveire added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:34 + return; +auto &Collection = Collections[SM.getFileID(Loc)]; +

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

tejohnson added a comment. In D91410#2401751 , @OikawaKirie wrote: > In D91410#2400018 , @tejohnson wrote: > >> > > > >> ... the new checking is a mix of assert and fatal errors. Is that intended? > > No. The added

[clang] 5ba324c - [OPENMP]Fix PR48174: compile-time crash with target enter data on a global struct.

Author: Alexey Bataev Date: 2020-11-18T07:48:58-08:00 New Revision: 5ba324ccadce35a146b0c04e90d6414c3dc42546 URL: https://github.com/llvm/llvm-project/commit/5ba324ccadce35a146b0c04e90d6414c3dc42546 DIFF: https://github.com/llvm/llvm-project/commit/5ba324ccadce35a146b0c04e90d6414c3dc42546.diff

[PATCH] D91660: [OPENMP]Fix PR48174: compile-time crash with target enter data on a global struct.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ba324ccadce: [OPENMP]Fix PR48174: compile-time crash with target enter data on a global… (authored by ABataev). Repository: rG LLVM Github Monor

[PATCH] D91625: [clang] Do not crash on pointer wchar_t pointer assignment.

adamcz updated this revision to Diff 306108. adamcz added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91625/new/ https://reviews.llvm.org/D91625 Files: clang/lib/AST/ASTContext.cpp clang/test/SemaCXX/wchar

[PATCH] D91625: [clang] Do not crash on pointer wchar_t pointer assignment.

adamcz added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:8726 +else if (!lhptee->isWideCharType() && + lhptee->hasSignedIntegerRepresentation()) ltrans = S.Context.getCorrespondingUnsignedType(ltrans); hokein wrote: > I'm wonde

  1   2   3   >