dmgreen added a comment.
Can you add the cpuid to host.cpp too?
================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:154
+AARCH64_CPU_NAME("neoverse-n2", ARMV8_5A, FK_CRYPTO_NEON_FP_ARMV8, false,
+ (AArch64::AEK_BF16 | AArch64::AEK_DOTPROD | AArch64::AEK_I8MM
| AArch64::AEK_MTE | AArch64::AEK_RAS |
+ AArch64::AEK_RCPC | AArch64::AEK_SB | AArch64::AEK_SSBS |
AArch64::AEK_SVE2))
----------------
The lines are getting a little long here.
Does it need things like DOTPROD, if it's already 8.5?
================
Comment at: llvm/include/llvm/Support/ARMTargetParser.def:304
+ARM_CPU_NAME("neoverse-n2", ARMV8_5A, FK_CRYPTO_NEON_FP_ARMV8, false,
+ (ARM::AEK_BF16 | ARM::AEK_DOTPROD | ARM::AEK_I8MM | ARM::AEK_RAS
| ARM::AEK_SB))
ARM_CPU_NAME("neoverse-v1", ARMV8_4A, FK_CRYPTO_NEON_FP_ARMV8, false,
----------------
Formatting
================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:993
EXPECT_TRUE(testAArch64CPU(
"neoverse-n1", "armv8.2-a", "crypto-neon-fp-armv8",
AArch64::AEK_CRC | AArch64::AEK_CRYPTO | AArch64::AEK_DOTPROD |
----------------
There should be tests like this, I think. Same for ARM below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91695/new/
https://reviews.llvm.org/D91695
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
