[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

This revision was automatically updated to reflect the committed changes. Closed by commit rGace9653c11c6: [clang-tidy] performance-unnecessary-copy-initialization: Check for const… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D900

[clang-tools-extra] ace9653 - [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

Author: Felix Berger Date: 2020-11-16T17:08:18-05:00 New Revision: ace9653c11c6308401dcda2e8b26bf97e6e66e30 URL: https://github.com/llvm/llvm-project/commit/ace9653c11c6308401dcda2e8b26bf97e6e66e30 DIFF: https://github.com/llvm/llvm-project/commit/ace9653c11c6308401dcda2e8b26bf97e6e66e30.diff

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne added a comment. What the attribute achieves is great, however I must say I'm really with Arthur's original comment regarding the ergonomics of it. IMO, it makes a lot more sense to permit the typedef author to pick how their typedef is going to be "named" by the compiler. If they pick

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:483 +// Skip values with an assumed address space. +if (TTI->getAssumedAddrSpace(TopVal) == UninitializedAddressSpace) { + for (Value *PtrOperand : getPointerOperands(*TopVal,

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin created this revision. mtrofin added reviewers: aeubanks, jdoerfert, davidxl, eraman. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. mtrofin requested review of this revision. Enable performing mandatory inlinings upfront, by reusing the

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. Please note: the patch isn't 100% ready, there are those tests that check how the pipeline is composed, which are unpleasant to fix, so I want to defer them to after we get agreement over the larger points this patch brings (i.e. pre-performing always inlinings, value i

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson updated this revision to Diff 305603. Herald added a subscriber: lxfind. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGCall.cpp clang/test/CXX/except/except.spec/p14-ir.cpp

[clang] 499bce3 - Revert "Revert "[analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.""

Author: Artem Dergachev Date: 2020-11-16T14:37:50-08:00 New Revision: 499bce3abab8a362b9b4197944bd40b826c736c4 URL: https://github.com/llvm/llvm-project/commit/499bce3abab8a362b9b4197944bd40b826c736c4 DIFF: https://github.com/llvm/llvm-project/commit/499bce3abab8a362b9b4197944bd40b826c736c4.dif

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

jdoerfert added a comment. Please modify the commit subject and add a proper message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

CJ-Johnson added a comment. In D17993#2398337 , @jdoerfert wrote: > Please modify the commit subject and add a proper message. Thank you for the reminder! It slipped my mind. Fixed :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ ht

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers added inline comments. Comment at: llvm/test/Transforms/Inline/inline_nossp.ll:3 +; RUN: opt -passes='cgscc(inline)' %s -S | FileCheck %s +; RUN: opt -always-inline -o - -S %s | FileCheck %s + aeubanks wrote: > This test fails with the NPM, > `opt

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

jdoerfert accepted this revision. jdoerfert added a comment. LGTM, thx! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

dblaikie added a comment. > Performing the mandatory inlinings first simplifies the problem the full > inliner needs to solve That confuses me a bit - is that suggesting that we don't run the AlwaysInliner when we are running the Inliner (ie: we only run the AlwaysInliner at -O0, and use the I

[PATCH] D91580: [Frontend] Add flag to allow PCM generation despite compiler errors

bnbarham created this revision. bnbarham added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, dang, arphaman. Herald added a project: clang. bnbarham requested review of this revision. As with precompiled headers, it's useful for indexers to be able to continue through compiler errors

[PATCH] D91580: [Frontend] Add flag to allow PCM generation despite compiler errors

bnbarham updated this revision to Diff 305622. bnbarham added a comment. Noticed I had left in the `-fdisable-module-hash` flags in the test, removed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91580/new/ https://reviews.llvm.org/D91580 Files: clang/include/clang/Driver/Optio

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2398440 , @dblaikie wrote: >> Performing the mandatory inlinings first simplifies the problem the full >> inliner needs to solve > > That confuses me a bit - is that suggesting that we don't run the > AlwaysInliner when

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

aeubanks added inline comments. Comment at: llvm/test/Transforms/Inline/inline_nossp.ll:3 +; RUN: opt -passes='cgscc(inline)' %s -S | FileCheck %s +; RUN: opt -always-inline -o - -S %s | FileCheck %s + nickdesaulniers wrote: > aeubanks wrote: > > This test fails

[PATCH] D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords

keith commandeered this revision. keith added a reviewer: ksuther. keith added a comment. Note the test case shown here passes on master, so we can drop this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17922/new/ https://reviews.llvm.org/D17922 ___

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2393434 , @jansvoboda11 wrote: > Hi @ayermolo, do you think this might be triggered by D82756 > ? (my only upstream patch ATM) Oh, no. Sorry I wasn't clear. I was just looking for peop

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2394109 , @wenlei wrote: > This change covers non-LTO cases. For LTO, I think we would need to pass it > from driver to LTO. Something like this: tools::addLTOOptions -> lld -> > lto::Config (Config->TargetOptions->MCT

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith marked an inline comment as done. rsmith added a comment. In D91311#2398144 , @ldionne wrote: > What the attribute achieves is great, however I must say I'm really with > Arthur's original comment regarding the ergonomics of it. I do agree, the er

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG69cd776e1ee7: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer (authored by CJ-Johnson, committed by rsmith). Herald added a project: clang. Changed prior to commit: https://reviews

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks fine as far as it goes, but it looks like we're also missing a cast in function pointer initialization via function conversion: void f() noexcept; void (*p)() = f; results in |-

Re: [clang] 5f12f4f - Suppress printing of inline namespace names in diagnostics by default,

Neat! On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-11-11T15:05:51-08:00 > New Revision: 5f12f4ff9078455cad9d4806da01f570553a5bf9 > > URL: > https://github.com/llvm/llvm-project/commit/5f12f4ff9078455cad9d4806da01f570553a5bf9 > DIFF

Re: [clang] e7f3e21 - Suppress printing template arguments that match default template

On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-11-11T15:05:51-08:00 > New Revision: e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 > > URL: > https://github.com/llvm/llvm-project/commit/e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 > DIFF: > ht

[clang] 3f4b589 - [AMDGPU] Add option -munsafe-fp-atomics

Author: Yaxun (Sam) Liu Date: 2020-11-16T21:52:12-05:00 New Revision: 3f4b5893efed620d93015896d79eb276628286f8 URL: https://github.com/llvm/llvm-project/commit/3f4b5893efed620d93015896d79eb276628286f8 DIFF: https://github.com/llvm/llvm-project/commit/3f4b5893efed620d93015896d79eb276628286f8.dif

[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG3f4b5893efed: [AMDGPU] Add option -munsafe-fp-atomics (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

Re: [clang] e7f3e21 - Suppress printing template arguments that match default template

On Mon, 16 Nov 2020 at 18:49, David Blaikie wrote: > On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits > wrote: > > > > > > Author: Richard Smith > > Date: 2020-11-11T15:05:51-08:00 > > New Revision: e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 > > > > URL: > https://github.com/llvm/llvm

[PATCH] D90507: Adding DWARF64 clang flag

dblaikie added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

dblaikie added a comment. In D91567#2398461 , @mtrofin wrote: > In D91567#2398440 , @dblaikie wrote: > >>> Performing the mandatory inlinings first simplifies the problem the full >>> inliner needs to solve >> >> T

Re: [clang] e7f3e21 - Suppress printing template arguments that match default template

On Mon, Nov 16, 2020 at 7:24 PM Richard Smith wrote: > > On Mon, 16 Nov 2020 at 18:49, David Blaikie wrote: >> >> On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits >> wrote: >> > >> > >> > Author: Richard Smith >> > Date: 2020-11-11T15:05:51-08:00 >> > New Revision: e7f3e2103cdb567dd

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2398623 , @dblaikie wrote: > In D91567#2398461 , @mtrofin wrote: > >> In D91567#2398440 , @dblaikie wrote: >> Performing the mandatory

[PATCH] D90507: Adding DWARF64 clang flag

ikudrin added a comment. It looks like `lld/test/COFF/lto-new-pass-manager.ll.obj` was added to the patch by accident and should be removed. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(D

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

aeubanks created this revision. aeubanks added reviewers: ychen, asbirlea, tejohnson. Herald added subscribers: llvm-commits, cfe-commits, wenlei, lxfind, steven_wu, modocache, JDevlieghere, hiraditya. Herald added projects: clang, LLVM. aeubanks requested review of this revision. This moves hand

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ckennelly updated this revision to Diff 305649. ckennelly added a comment. Applied review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91015/new/ https://reviews.llvm.org/D91015 Files: clang-tools-extra/clang-tidy/bugprone/StringConstr

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ckennelly added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:65 + const auto hasStringCtorName = + hasAnyNameStdString(removeNamespaces(StringNames)); + aaron.ballman wrote: > It took me a while to realize th

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91009/new/ https://reviews.llvm.org/D91009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ckennelly updated this revision to Diff 305652. ckennelly marked 5 inline comments as done. ckennelly added a comment. Applied review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91015/new/ https://reviews.llvm.org/D91015 Files: clang-

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

dylanmckay accepted this revision. dylanmckay added a comment. This revision is now accepted and ready to land. Looks good to me, thanks for the patch @benshi001 NOTE: It looks like you will need to rebase this one prior to merge. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88410/new/

[PATCH] D91590: [NVPTX] Efficently support dynamic index on CUDA kernel aggregate parameters.

hliao created this revision. hliao added a reviewer: tra. Herald added subscribers: llvm-commits, cfe-commits, arphaman, hiraditya, yaxunl, mgorny, jholewinski. Herald added projects: clang, LLVM. hliao requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D91590: [NVPTX] Efficently support dynamic index on CUDA kernel aggregate parameters.

hliao added a comment. This's an experimental or demo-only patch in my spare time on eliminating private memory usage in https://godbolt.org/z/EPPn6h. The attachment F14026286: sample.tar.xz includes both the reference and new IR, PTX, and SASS (sm_60) outpu

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. Sent https://lists.llvm.org/pipermail/llvm-dev/2020-November/146676.html "Add -fbinutils-version=" (cross posted to cfe-dev) so that more folks can notice it. About "generate code and don't care about GNU as/ld compatibility/limitation", I am open for suggestions. Curre

<    1   2