ikudrin added a comment.
It looks like `lld/test/COFF/lto-new-pass-manager.ll.obj` was added to the
patch by accident and should be removed.
================
Comment at: clang/include/clang/Basic/CodeGenOptions.def:35
CODEGENOPT(AsmVerbose , 1, 0) ///< -dA, -fverbose-asm.
+CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64.
CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comments.
----------------
dblaikie wrote:
> Is there any precedent to draw from for this flag name? (Does GCC support
> DWARF64? Does it support it under this flag name or some other? (similarly
> with other gcc-like compilers (Intel's? Whoever else... )))
It looks like we are pioneering in that area. To me, the proposed name looks
consonant with other debug-related switches.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4025
+ << A->getAsString(Args) << "64 bit architecutre";
+ else
+ CmdArgs.push_back("-gdwarf64");
----------------
We also should check that the output format is ELF.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90507/new/
https://reviews.llvm.org/D90507
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
