[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

hokein added a comment. didn't finish all parts (looked at the FunctionDecl and RecordDecl), I think we need more documentation/comments in the code to specify the canonical behavior (templates are tricky). Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:239 + if (c

[PATCH] D91519: [AST][Mach0] Fix unused-variable warnings

ehjogab created this revision. ehjogab added reviewers: dsanders, arsenm, qcolombet, ab, bjope, rovka. Herald added a project: clang. Herald added a subscriber: cfe-commits. ehjogab requested review of this revision. Herald added a subscriber: wdng. Change-Id: Id37948be57aad3551eb14fc16b2aea2441a4

[PATCH] D83071: Add support for options with two flags for controlling the same field.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f3055c543f8: [clang][cli] Add support for options with two flags for controlling the same… (authored by jansvoboda11). Changed prior to commit: h

[clang] 2f3055c - [clang][cli] Add support for options with two flags for controlling the same field.

Author: Jan Svoboda Date: 2020-11-16T10:21:54+01:00 New Revision: 2f3055c543f8f5e8cd975350fae5f4b0ac4871c3 URL: https://github.com/llvm/llvm-project/commit/2f3055c543f8f5e8cd975350fae5f4b0ac4871c3 DIFF: https://github.com/llvm/llvm-project/commit/2f3055c543f8f5e8cd975350fae5f4b0ac4871c3.diff L

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D8

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91055/new/ https://reviews.llvm.org/D91055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 305437. jansvoboda11 added a comment. Rebase and add documenting possible reference lifetime extension issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files:

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90691/new/ https://reviews.llvm.org/D90691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

SjoerdMeijer added a comment. > This approach should be fully complementary to `vectorize_with` so that it > would be possible to have: > > // Use scalable vectors, but leave it to the cost-model to choose the most > efficient N in . > // If the pragma is not specified, it defaults to vector

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 305439. abelkocsis added a comment. Fixes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clan

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 added a comment. Addressed review feedback. WDYT @Bigcheese? Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)&options::CC1Option) { \ +const auto &Extracted = EXTRACTOR(this->KEYPATH);

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:68 +const SourceManager &SM, Preprocessor *pp, Preprocessor *ModuleExpanderPP) { + PP = pp; +} whisperity wrote: > Global state is alw

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

peterwaller-arm added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp: if (srcIsVector || destIsVector) { +// We can bitcast between SVE VLATs and VLSTs, and vice-versa. +if (Self.isValidSveBitcast(SrcType, DestType)) { It's good to avoid

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1267 assert(!isa(constant)); - emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant); + emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant, true); } jdoerfert wr

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca2e7e59994d: [IRGen] Add !annotation metadata for auto-init stores. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D91417

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2388622 , @bader wrote: > In D89909#2353931 , @Anastasia wrote: > >> In the RFC it has been discussed to either use target address spaces or >> perhaps to introduce a new attrib

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 305460. segoon added a comment. - minor changes to docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc/MiscTidyMo

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon added a comment. In D90944#2380910 , @lebedev.ri wrote: > What i would however like to be improved, is better docs. I hope I'll addressed your questions in documentation. Please tell me whether you still have any unanswered questions. CHANGES SI

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

njames93 added a comment. Just a general drive by point, is it wise to add a new tidy module to clang-tidy called `threads` (or similar). We have got a few other checks related to multi-threaded code in the pipeline (D77493 , D75229

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer updated this revision to Diff 305468. DaanDeMeyer added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91509/new/ https://reviews.llvm.org/D91509 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extr

[clang] 6c185ac - Revert "Move the test compiler setup in a common place. NFCI"

Author: Vitaly Buka Date: 2020-11-16T04:21:28-08:00 New Revision: 6c185acfffc1f7cdf2a6e785cb4a422140c34f06 URL: https://github.com/llvm/llvm-project/commit/6c185acfffc1f7cdf2a6e785cb4a422140c34f06 DIFF: https://github.com/llvm/llvm-project/commit/6c185acfffc1f7cdf2a6e785cb4a422140c34f06.diff L

[PATCH] D91061: Move the test compiler setup in a common place. NFCI

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reverted because of memory leaks: http://lab.llvm.org:8011/#/builders/5/builds/1262 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91061/

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

lebedev.ri added a comment. `Libc` option name doesn't really make sense to me, maybe `FunctionSet` would fit better. Comment at: clang-tools-extra/clang-tidy/misc/MtUnsafeCheck.cpp:32-33 + +// Initial list was extracted from gcc documentation +static const StringRef glibcFunc

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Would you like me to commit this one on your behalf or would you like to request your own commit access (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

tschuett added a comment. I am happy, if you could commit this for me. I am still learning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91506/new/ https://reviews.llvm.org/D91506 ___ cfe-commits mailin

[PATCH] D91061: Move the test compiler setup in a common place. NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG54e655b3f8dc: Reland "Move the test compiler setup in a common place. NFCI" (authored by v.g.vassilev). Changed prior to commit: https://reviews.llvm.org/D91061?vs=305327&id=305483#toc Repository: rG

[clang] 54e655b - Reland "Move the test compiler setup in a common place. NFCI"

Author: Vassil Vassilev Date: 2020-11-16T13:22:10Z New Revision: 54e655b3f8dc1d005655d9138880f3823d58224f URL: https://github.com/llvm/llvm-project/commit/54e655b3f8dc1d005655d9138880f3823d58224f DIFF: https://github.com/llvm/llvm-project/commit/54e655b3f8dc1d005655d9138880f3823d58224f.diff LO

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

aaron.ballman added a comment. In D91506#2397158 , @tschuett wrote: > I am happy, if you could commit this for me. I am still learning. I'm happy to do so -- how would you like me to attribute the patch? Is `Thorsten ` what you'd like me to use? Reposi

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

tschuett added a comment. Yes. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91506/new/ https://reviews.llvm.org/D91506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] a6ac2b3 - Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum; NFC

Author: Thorsten Date: 2020-11-16T08:28:21-05:00 New Revision: a6ac2b32fbab9679c8f2fa97a3b1123e3a9654c8 URL: https://github.com/llvm/llvm-project/commit/a6ac2b32fbab9679c8f2fa97a3b1123e3a9654c8 DIFF: https://github.com/llvm/llvm-project/commit/a6ac2b32fbab9679c8f2fa97a3b1123e3a9654c8.diff LOG:

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

aaron.ballman closed this revision. aaron.ballman added a comment. In D91506#2397181 , @tschuett wrote: > Yes. Thank you! You're welcome! I've commit on your behalf in a6ac2b32fbab9679c8f2fa97a3b1123e3a9654c8

[PATCH] D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I'll land on your behalf momentarily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91498/new/ https://reviews.llvm.org/D914

[PATCH] D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum

aaron.ballman added a comment. In D91498#2397187 , @aaron.ballman wrote: > LGTM! I'll land on your behalf momentarily. I lied. The patch doesn't apply cleanly for me -- can you rebase and upload a new diff? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D91428: Add support for multiple program address spaces

pmatos updated this revision to Diff 305488. pmatos added a comment. Ensure the program address spaces vector doesn't contain duplicates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91428/new/ https://reviews.llvm.org/D91428 Files: clang/lib/C

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer updated this revision to Diff 305489. DaanDeMeyer added a comment. Fix all the bugs after doing some proper testing. One thing we don't handle yet is header files since those don't appear in the compilation database. Maybe we need to add prebuilding for those as well? Repository:

[PATCH] D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum

tschuett updated this revision to Diff 305490. tschuett added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91498/new/ https://reviews.llvm.org/D91498 Files: clang/include/clang/AST/TypeLoc.h clang/include/clang/Basic/Specifiers.h clang/include/clang/Sema/DeclS

[clang] 7c6412e - Convert TypeSpecifierSign from Specifiers.h to a scoped enum; NFC

Author: Thorsten Date: 2020-11-16T09:08:08-05:00 New Revision: 7c6412e0ccf5e00a9f59c5805df9df6ff6720ed2 URL: https://github.com/llvm/llvm-project/commit/7c6412e0ccf5e00a9f59c5805df9df6ff6720ed2 DIFF: https://github.com/llvm/llvm-project/commit/7c6412e0ccf5e00a9f59c5805df9df6ff6720ed2.diff LOG:

[PATCH] D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum

aaron.ballman closed this revision. aaron.ballman added a comment. In D91498#2397251 , @tschuett wrote: > rebased Thanks! I've commit on your behalf in 7c6412e0ccf5e00a9f59c5805df9df6ff6720ed2

[clang] f7c881b - Adding some explicit casts to appease build bots; NFC

Author: Aaron Ballman Date: 2020-11-16T09:13:24-05:00 New Revision: f7c881b89eabec1af65073ede344da818292d62b URL: https://github.com/llvm/llvm-project/commit/f7c881b89eabec1af65073ede344da818292d62b DIFF: https://github.com/llvm/llvm-project/commit/f7c881b89eabec1af65073ede344da818292d62b.diff

[clang] f9e639e - Fix bots that are running with assertions enabled; NFC.

Author: Aaron Ballman Date: 2020-11-16T09:23:10-05:00 New Revision: f9e639efda4aa391a2f247abf69912ca2d29217f URL: https://github.com/llvm/llvm-project/commit/f9e639efda4aa391a2f247abf69912ca2d29217f DIFF: https://github.com/llvm/llvm-project/commit/f9e639efda4aa391a2f247abf69912ca2d29217f.diff

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added a comment. In D89869#2392032 , @Anastasia wrote: > In D89869#2388499 , @azabaznov wrote: > >> Addressed all concerns except replacing //__opencl_c_int64 //definition into >> header. The reason for t

[PATCH] D91540: [preprocessor] Assertions on the inferrable null pointers in Preprocessor befere dereference

OikawaKirie created this revision. OikawaKirie added reviewers: dnsampaio, rsmith, lattner, ilya-biryukov. OikawaKirie added a project: clang. Herald added a subscriber: cfe-commits. OikawaKirie requested review of this revision. This patch asserts on some smart pointers that can be statically inf

[PATCH] D91311: Add new 'preferred_name' attribute.

aaron.ballman added inline comments. Comment at: libcxx/include/regex:2520 +_LIBCPP_PREFERRED_NAME(wregex) +basic_regex { rsmith wrote: > Quuxplusone wrote: > > Why does this attribute go on the class template? Shouldn't it be an > > attribute on the ty

[PATCH] D91519: [AST][Mach0] Fix unused-variable warnings

arsenm added inline comments. Comment at: lld/MachO/SymbolTable.cpp:137 // error message. -if (auto *defined = dyn_cast(s)) +if (dyn_cast(s)) error("found defined symbol with illegal name " + DSOHandle::name); Should use isa Repository: rG

[PATCH] D87981: [X86] AMX programming model prototype.

wxiao3 added inline comments. Comment at: llvm/include/llvm/CodeGen/LiveRegMatrix.h:44 VirtRegMap *VRM; + MachineRegisterInfo *MRI; what's the purpose of this member? Comment at: llvm/lib/Target/X86/X86RegisterInfo.cpp:917 + } + for (MC

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

joechrisellis updated this revision to Diff 305494. joechrisellis added a comment. Remove failing test; it was checking that a conversion _failed_, although the conversion should now _pass_ given the changes in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D87981: [X86] AMX programming model prototype.

wxiao3 added a comment. Please add register allocation code owner: "qcolombet" to the reviewer list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 ___ cfe-commi

[clang] 02bdbdc - [clang][SveEmitter] Fix enum declarations. [NFCI]

Author: Francesco Petrogalli Date: 2020-11-16T14:49:45Z New Revision: 02bdbdc76021fcfb8cae465363b362cb889406d2 URL: https://github.com/llvm/llvm-project/commit/02bdbdc76021fcfb8cae465363b362cb889406d2 DIFF: https://github.com/llvm/llvm-project/commit/02bdbdc76021fcfb8cae465363b362cb889406d2.dif

[PATCH] D91333: [clang][SveEmitter] Fix enum declarations. [NFCI]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02bdbdc76021: [clang][SveEmitter] Fix enum declarations. [NFCI] (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91311: Add new 'preferred_name' attribute.

Quuxplusone added inline comments. Comment at: libcxx/include/regex:2520 +_LIBCPP_PREFERRED_NAME(wregex) +basic_regex { aaron.ballman wrote: > rsmith wrote: > > Quuxplusone wrote: > > > Why does this attribute go on the class template? Shouldn't it be an

[PATCH] D91047: Add a call super attribute plugin example

aaron.ballman added inline comments. Comment at: clang/docs/ClangPlugins.rst:117 +Defining CallSuperAttr +=== + psionic12 wrote: > aaron.ballman wrote: > > psionic12 wrote: > > > aaron.ballman wrote: > > > > aaron.ballman wrote: > > > > > The numb

[clang] 8dbe44c - Add pass to add !annotate metadata from @llvm.global.annotations.

Author: Florian Hahn Date: 2020-11-16T14:57:11Z New Revision: 8dbe44cb2936ecafea4b26ef16d1727371ad203f URL: https://github.com/llvm/llvm-project/commit/8dbe44cb2936ecafea4b26ef16d1727371ad203f DIFF: https://github.com/llvm/llvm-project/commit/8dbe44cb2936ecafea4b26ef16d1727371ad203f.diff LOG:

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dbe44cb2936: Add pass to add !annotate metadata from @llvm.global.annotations. (authored by fhahn). Herald added a project: clang. Herald added a su

[clang] 9e407af - [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Author: Xiangling Liao Date: 2020-11-16T10:07:57-05:00 New Revision: 9e407afd9bd3b5181db24b08f78cb43344bd8292 URL: https://github.com/llvm/llvm-project/commit/9e407afd9bd3b5181db24b08f78cb43344bd8292 DIFF: https://github.com/llvm/llvm-project/commit/9e407afd9bd3b5181db24b08f78cb43344bd8292.diff

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e407afd9bd3: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link… (authored by Xiangling_L). Changed prior to commit: https://reviews.llvm.org/D91361?vs=305160&id=305501#toc Reposi

[clang] 4369223 - BPF: make __builtin_btf_type_id() return 64bit int

Author: Yonghong Song Date: 2020-11-16T07:08:41-08:00 New Revision: 4369223ea73c4b8a3fa9a8a84533125c7d0eea98 URL: https://github.com/llvm/llvm-project/commit/4369223ea73c4b8a3fa9a8a84533125c7d0eea98 DIFF: https://github.com/llvm/llvm-project/commit/4369223ea73c4b8a3fa9a8a84533125c7d0eea98.diff

[PATCH] D91489: BPF: make __builtin_btf_type_id() return 64bit int

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4369223ea73c: BPF: make __builtin_btf_type_id() return 64bit int (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D91195: Add Annotation2MD pass to add !annotate metadata from llvm.global.annotations

fhahn marked an inline comment as done. fhahn added a comment. Thanks Jessica & Francis! I committed the initial version, with a small change to only run if the `!annotation` remarks are enabled. Comment at: llvm/include/llvm/Transforms/IPO/Annotation2Metadata.h:1 +//===- SCCP

[PATCH] D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

avieira updated this revision to Diff 305504. avieira added a comment. Rebased on top of trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91438/new/ https://reviews.llvm.org/D91438 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64.h clang/test/Preproc

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington updated this revision to Diff 305506. erik.pilkington added a comment. Use a bit on Declarator instead of an ad-hoc bool parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 Files: clang/include/clang/Sema/DeclSpec.h cl

[PATCH] D91543: [clang-tidy] Improving bugprone-sizeof-expr check.

balazske created this revision. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. Herald added a project: clang. balazske requested review of this revision. Do not warn for "pointer to aggregate" in a `sizeof(A) / sizeof(A[0])` expression if `A`

[PATCH] D90984: Update matchers to be traverse-aware

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3115 + + if (!Finder->isTraversalAsIs() && (*MatchIt)->isImplicit()) +return false; aaron.ballman wrote: > If the traversal is not `AsIs`, that doesn't mean it's > `Ig

[PATCH] D90188: Add support for attribute 'using_if_exists'

aaron.ballman added a comment. In D90188#2394361 , @erik.pilkington wrote: > Add support for C++11-style attributes on using-declarations. FWIW, it'd be a bit easier if those changes were split off into their own patch, as they're orthogonal to `using_i

[PATCH] D91544: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. ymandel requested review of this revision. Adds support for setting the `Rule` field. In the process, refactors the code that accesses that field and adds a co

[PATCH] D91428: Add support for multiple program address spaces

pmatos updated this revision to Diff 305521. pmatos added a comment. Fix type check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91428/new/ https://reviews.llvm.org/D91428 Files: clang/lib/CodeGen/CGException.cpp clang/lib/CodeGen/CodeGenMod

[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, arsenm. Herald added subscribers: dang, kerbowa, jfb, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. Add an option -munsafe-fp-atomics for AMDGPU ta

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/test/CodeGen/aix-constructor-attribute.cpp:8 -int foo() __attribute__((constructor(180))); +// CHECK: @llvm.global_ctors = appending global [3 x { i32, void ()*, i8* }] [{ i32, v

[PATCH] D91428: Add support for multiple program address spaces

jdoerfert added a subscriber: tianshilei1992. jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. I'll be on the lookout for the RFC. There, and in an updated commit message, you have to provide more details. http://lists.llvm.o

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd added a comment. Ping; I'd let to get this sorted out so I can continue to make progress towards serialization and deserialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91104/new/ https://reviews.llvm.org/D91104

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 305526. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Update testcases; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/C

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao marked 3 inline comments as done. hliao added a comment. Kindly ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91121/new/ https://reviews.llvm.org/D91121 ___ cfe-commits mailing lis

[PATCH] D90984: Update matchers to be traverse-aware

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3115 + + if (!Finder->isTraversalAsIs() && (*MatchIt)->isImplicit()) +return false; steveire wrote: > aaron.ballman wrote: > > If the traversal is not `AsIs`, that

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added a comment. Sorry I was disrupted and not able to work on this last week! I've just got started trying to integrate this with my kernel patches. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:666 +def XADDD : XADD; + } +} FYI - I just spott

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

tra added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533 + if (!LD) +return -1; + Is there a suitable constant for `don't know` result? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Patch description could use a pointer to more details about the unsafe atomics. Comment at: clang/include/clang/Basic/TargetOptions.h:78 + /// \brief If enabled, allow AM

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; jackmanb wrote: > Sorry I'm a beginner with the LLVM code, could you explain what

[PATCH] D72184: [BPF] support atomic instructions

jackmanb added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:684 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = val; + let Inst{7-4} = Opc.Value; jackmanb wrote: > jackmanb wrote: > > Sorry I'm a beginner with the LLVM code, co

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:666 +def XADDD : XADD; + } +} jackmanb wrote: > FYI - I just spotted some stray `\t` in here (is it helpful to point this > out? If not let me know, I will ignore in future

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

RKSimon added a comment. Some very minor nits - the 68060 omission is the biggest one (apple might not have used it but commodore did!) Comment at: clang/include/clang/Driver/Options.td:155 +def m_m68k_Features_Group: OptionGroup<"">, + Group, DocNa

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533 + if (!LD) +return -1; + tra wrote: > Is there a suitable constant for `don't know` result? I would say all generic pointers loaded from the constant memory are safe

[PATCH] D91546: [AMDGPU] Add option -munsafe-fp-atomics

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:78 + /// \brief If enabled, allow AMDGPU unsafe floating point atomics. + bool AllowAMDGPUUnsafeFPAtomics = false; tra wrote: > I'm cu

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

vtjnash added a comment. I think this, and similar recent commits, are causing the shared library builds to fail some tests if this code gets linked into libLLVM.so: https://bugs.llvm.org/show_bug.cgi?id=48181. I assume it might actually a bug in ld (GNU Binutils for Ubuntu 2.34), as I don't un

[PATCH] D78903: [Driver] Add option -fproc-stat-report

tschuett added a comment. Could you add quotation marks around the executable name to make the CSV file easier to parse? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903

[clang] 41b65f1 - Convert ConstexprKind from Specifiers.h to a scoped enum; NFC

Author: Thorsten Date: 2020-11-16T14:10:19-05:00 New Revision: 41b65f166b51760f77d0f9e465b3858f46e101f0 URL: https://github.com/llvm/llvm-project/commit/41b65f166b51760f77d0f9e465b3858f46e101f0 DIFF: https://github.com/llvm/llvm-project/commit/41b65f166b51760f77d0f9e465b3858f46e101f0.diff LOG:

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D90042 ___

[PATCH] D91552: [OPENMP]Fix PR48076: mapping of data member pointer.

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, fixed the problem on my machine and passes the unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91552/new/ https://reviews.llvm

[PATCH] D91507: [clang-format] Add option for case sensitive regexes for sorted includes

HazardyKnusperkeks added a comment. Do I have to do something? For me it doesn't look like the build failure is due to my changes. Locally I've only build and run the FormatTests target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91507/new/ ht

[PATCH] D90982: Ignore implicit nodes in IgnoreUnlessSpelledInSource mode

aaron.ballman added a comment. Thank you for this, I think it's mostly looking good! Comment at: clang/include/clang/AST/ASTNodeTraverser.h:88 void Visit(const Decl *D) { +if (Traversal != TK_AsIs && D->isImplicit()) + return; Similar to the feedbac

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

abidh created this revision. abidh added reviewers: jroelofs, clang. Herald added a project: clang. Herald added a subscriber: cfe-commits. abidh requested review of this revision. Baremetal toolchain is not adding sysroot/lib to the library search path. This is forcing the user to do it manually.

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh updated this revision to Diff 305573. abidh added a comment. Made the condition consistent in both places where Baremetal toolchain is instantiated as suggested in review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91442/new/ https://reviews.llvm.org/D91442 Files: clang/lib

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 305575. Conanap added a comment. clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/lib/Target/Pow

[PATCH] D91559: Add sysroot/lib to library search path of baremetal toolchain.

jroelofs accepted this revision. jroelofs added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:39 +llvm::sys::path::append(SysRoot, "lib"); +getFilePaths().push_back(std::string(SysRoot.str())); + }

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh marked an inline comment as done. abidh added a comment. In D91442#2394501 , @jroelofs wrote: > Seems reasonable. > > I could see someone wanting to use `--gcc-toolchain` to point at the > baremetal toolchain for their target, but that's unlikely to

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jrtc27 added inline comments. Comment at: clang/test/Driver/riscv64-toolchain.c:5 +// RUN: %clang %s -### -no-canonical-prefixes -target riscv64 \ +// RUN: --gcc-toolchain=%S/Inputs/basic_riscv64_tree 2>&1 | FileCheck -check-prefix=CC1 %s // CC1: clang{{.*}} "-cc1" "-triple" "r

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx added a comment. In D90042#2397885 , @aaron.ballman wrote: > LGTM, thank you for the fix! Thanks for helping track down the difference in our definition of std::function :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM with nits Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533 + if (!LD) +return -1; + hliao wrote: > tra wrote: > > Is there a suitable

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

arsenm added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:483 +// Skip values with an assumed address space. +if (TTI->getAssumedAddrSpace(TopVal) == UninitializedAddressSpace) { + for (Value *PtrOperand : getPointerOperands(*TopVal,

[clang] f375885 - [InferAddrSpace] Teach to handle assumed address space.

Author: Michael Liao Date: 2020-11-16T17:06:33-05:00 New Revision: f375885ab86d1b3e82269725c8e9aa49f347b4a7 URL: https://github.com/llvm/llvm-project/commit/f375885ab86d1b3e82269725c8e9aa49f347b4a7 DIFF: https://github.com/llvm/llvm-project/commit/f375885ab86d1b3e82269725c8e9aa49f347b4a7.diff

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf375885ab86d: [InferAddrSpace] Teach to handle assumed address space. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D9112

  1   2   >