tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
LGTM. Patch description could use a pointer to more details about the unsafe atomics. ================ Comment at: clang/include/clang/Basic/TargetOptions.h:78 + /// \brief If enabled, allow AMDGPU unsafe floating point atomics. + bool AllowAMDGPUUnsafeFPAtomics = false; ---------------- I'm curious -- what does `unsafe` mean here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91546/new/ https://reviews.llvm.org/D91546 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
