[PATCH] D90447: [AMDGPU] Add gfx1033 target

t-tye requested changes to this revision. t-tye added inline comments. This revision now requires changes to proceed. Comment at: llvm/docs/AMDGPUUsage.rst:317 + names. + ``gfx1033``

[PATCH] D90447: [AMDGPU] Add gfx1033 target

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.org/D90447 _

[PATCH] D90447: [AMDGPU] Add gfx1033 target

t-tye added inline comments. Comment at: llvm/test/tools/llvm-readobj/ELF/amdgpu-elf-headers.test:61-64 +# RUN: yaml2obj %s -o %t -DCPU=GFX90C +# RUN: llvm-readobj -h %t | FileCheck %s --match-full-lines -DFILE=%t -DCPU=GFX90C -DFLAGS=0x32 + # RUN: yaml2obj %s -o %t -DCPU=GFX10

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

ille updated this revision to Diff 301966. ille added a comment. Satisfy clang-format bot, at the cost of formatting a few adjacent lines. The other bot failures seem pretty clearly unrelated to this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

danielkiss added inline comments. Herald added a subscriber: ormris. Comment at: clang/include/clang/Basic/FileEntry.h:186 + + constexpr bool hasValue() const noexcept { +return MaybeRef.hasOptionalValue(); This broke the build, `constexpr` could be dropped

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/FileEntry.h:186 + + constexpr bool hasValue() const noexcept { +return MaybeRef.hasOptionalValue(); danielkiss wrote: > This broke the build, `constexpr` could be dropped IMHO. > FileEnt

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

Quuxplusone added a comment. I believe the organization of that directory implies that the path should be `class/class.init/class.copy.elision/`, not `special/class.copy/`. Otherwise LGTM, and I like this new test better than the old one! I still can't help re actually landing this patch, as I do

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. Herald added a subscriber: dexonsmith. I'm going to follow up with another RFC about this on llvm-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83088/new/ https://reviews.llvm.org/D83088 _

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

rsmith added inline comments. Comment at: clang/docs/LanguageExtensions.rst:466 + typedef bool bool4 __attribute__((ext_vector_type(4))); + // Objects of bool8 type hold 8 bits, sizeof(bool8) == 1 + Comment talks about `bool8` but we defined the type `bool4`.

[clang] ac49500 - Reapply "FileManager: Improve the FileEntryRef API and customize its OptionalStorage"

Author: Duncan P. N. Exon Smith Date: 2020-10-30T15:06:01-04:00 New Revision: ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 URL: https://github.com/llvm/llvm-project/commit/ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 DIFF: https://github.com/llvm/llvm-project/commit/ac49500cd0484e1b2dcf37fa4c0dade6f113

[PATCH] D90419: [AMDGPU] Add gfx90c target

scott.linder added inline comments. Comment at: llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml:161 # RUN: yaml2obj --docnum=41 %s > %t.o.41 # RUN: llvm-readobj -s -file-headers %t.o.41 | FileCheck --check-prefixes=ELF-ALL,ELF-GFX1031 %s Heads up, I just

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

dexonsmith added a comment. Just pushed again in ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 ; bots look happier with this version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D898

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

rupprecht added a comment. In D84604#2364568 , @aaronpuchert wrote: > In D84604#2363768 , @rupprecht wrote: > >> I applied D87194 locally and rebuilt the >> original source, and n

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith updated this revision to Diff 301989. dexonsmith added a comment. Rebased on top of ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90484/new/ https://reviews.llvm.o

[PATCH] D90430: [clang][NFC] Remove unused FileCheck prefix

google-llvm-upstream-contributions accepted this revision. google-llvm-upstream-contributions added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90430/new/ https://reviews.llvm.org/D

[PATCH] D90430: [clang][NFC] Remove unused FileCheck prefix

mtrofin accepted this revision. mtrofin added a comment. In D90430#2365397 , @google-llvm-upstream-contributions wrote: > lgtm ugh, sorry, that's an alias I am auto-logged in on my personal account. Still LGTM :) Repository: rG LLVM Github Monorepo

[clang] 3859fc6 - AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

Author: Peter Collingbourne Date: 2020-10-30T12:51:30-07:00 New Revision: 3859fc653fb49f4acfb61b6f2c38736ec9bfae06 URL: https://github.com/llvm/llvm-project/commit/3859fc653fb49f4acfb61b6f2c38736ec9bfae06 DIFF: https://github.com/llvm/llvm-project/commit/3859fc653fb49f4acfb61b6f2c38736ec9bfae06

[PATCH] D90422: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3859fc653fb4: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks. (authored by pcc). Repository: rG LLVM Github Monorep

[clang] c9b1a2b - AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan checks.

Author: Peter Collingbourne Date: 2020-10-30T12:53:15-07:00 New Revision: c9b1a2b41dca6e6734aa39833a0dab0d0a8b53d3 URL: https://github.com/llvm/llvm-project/commit/c9b1a2b41dca6e6734aa39833a0dab0d0a8b53d3 DIFF: https://github.com/llvm/llvm-project/commit/c9b1a2b41dca6e6734aa39833a0dab0d0a8b53d3

[PATCH] D90424: AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan checks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b1a2b41dca: AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan… (authored by pcc). Repository: rG LLVM Github Monor

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

rsmith added a comment. In D88295#2365312 , @Quuxplusone wrote: > I believe the organization of that directory implies that the path should be > `class/class.init/class.copy.elision/`, not `special/class.copy/`. > Otherwise LGTM, and I like this new test

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

aaronpuchert added a comment. In D88295#2365474 , @rsmith wrote: > The other is whether implicitly move in a `co_return` statement. In that > case, I think the use of `CES_AsIfByStdMove` is a mistake, and we should be > using `CES_Default` there. I did

[clang] 814141f - Remove `noexcept` from ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 to fix bots

Author: Duncan P. N. Exon Smith Date: 2020-10-30T16:29:16-04:00 New Revision: 814141f9bd0a64bbedae05773972d140f04f654d URL: https://github.com/llvm/llvm-project/commit/814141f9bd0a64bbedae05773972d140f04f654d DIFF: https://github.com/llvm/llvm-project/commit/814141f9bd0a64bbedae05773972d140f04f

[PATCH] D90430: [clang][NFC] Remove unused FileCheck prefix

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbf02e18f536: [clang][NFC] Remove unused FileCheck prefix (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] bbf02e1 - [clang][NFC] Remove unused FileCheck prefix

Author: Keith Smiley Date: 2020-10-30T13:32:14-07:00 New Revision: bbf02e18f53681c079f7a88b2726d0714d92e1a0 URL: https://github.com/llvm/llvm-project/commit/bbf02e18f53681c079f7a88b2726d0714d92e1a0 DIFF: https://github.com/llvm/llvm-project/commit/bbf02e18f53681c079f7a88b2726d0714d92e1a0.diff

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

dexonsmith added a comment. In D89834#2365358 , @dexonsmith wrote: > Just pushed again in ac49500cd0484e1b2dcf37fa4c0dade6f113c2c9 > ; bots > look happier with this version. Not all of

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

Quuxplusone added a comment. > So, how about we add another `CES` flag As the original author of `CES_AsIfByStdMove`, I am opposed to any attempt to complicate this patch. My medium-term goal, now that P1155 has been adopted, is to //eliminate// the complexity

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith updated this revision to Diff 302010. dexonsmith added a comment. Rebase on top of 814141f9bd0a64bbedae05773972d140f04f654d . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90484/new/ https://reviews.llvm.or

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Push `FileEntryRef` and `DirectoryEntryRef` further, using it them `Module::Umbrella`, `Module::Header::Entry`, and `Module::Dire

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

dexonsmith updated this revision to Diff 302022. dexonsmith edited the summary of this revision. dexonsmith added a comment. Removed the `FIXME`s about the `...AsWritten` fields, as I just took a deeper look and we need them. The headers/etc. are looked up in the `FileManager` with the module di

[PATCH] D90504: [WebAssembly] Prototype i64x2.widen_{low,high}_i32x4_{s,u}

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. As proposed in https://git

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

majnemer added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2782 + +// construct the vector of 'unsigned char' type +QualType CharVecTy = Ctx.getVectorType(Ctx.CharTy, NumVectorBytes, The code as written seems to be 'char' type, not 'uns

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo created this revision. ayermolo added a reviewer: llvm-commits. Herald added subscribers: cfe-commits, dexonsmith, wenlei, dang. Herald added a project: clang. ayermolo requested review of this revision. @ikudrin enabled support for dwarf64 in D87011 . A

[PATCH] D90508: [WebAssembly] Prototype i64x2.eq

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. As proposed in https://git

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

aaronpuchert added a comment. In D88295#2365474 , @rsmith wrote: > ... where `X` has a volatile copy constructor and a volatile move > constructor, I think we should produce the warning suggesting use of > `std::move`. If I read this correctly, we'd hav

[clang] 1cb0b56 - [WebAssembly] Prototype i64x2.widen_{low, high}_i32x4_{s, u}

Author: Thomas Lively Date: 2020-10-30T15:44:04-07:00 New Revision: 1cb0b5660777cb563637ff6bb80722f449ee97eb URL: https://github.com/llvm/llvm-project/commit/1cb0b5660777cb563637ff6bb80722f449ee97eb DIFF: https://github.com/llvm/llvm-project/commit/1cb0b5660777cb563637ff6bb80722f449ee97eb.diff

[PATCH] D90504: [WebAssembly] Prototype i64x2.widen_{low,high}_i32x4_{s,u}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cb0b5660777: [WebAssembly] Prototype i64x2.widen_{low,high}_i32x4_{s,u} (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 8a28a29 - [clang-tidy][test] Fix test failure when LLVM_ENABLE_WERROR is set.

Author: Nathan James Date: 2020-10-30T23:17:11Z New Revision: 8a28a29c736e6ae88c86a8687e61a62b41e1c430 URL: https://github.com/llvm/llvm-project/commit/8a28a29c736e6ae88c86a8687e61a62b41e1c430 DIFF: https://github.com/llvm/llvm-project/commit/8a28a29c736e6ae88c86a8687e61a62b41e1c430.diff LOG:

[clang] 0a512a5 - [WebAssembly] Prototype i64x2.eq

Author: Thomas Lively Date: 2020-10-30T16:38:15-07:00 New Revision: 0a512a555a8dbcd00eeaff5aaa14842f8614c2b4 URL: https://github.com/llvm/llvm-project/commit/0a512a555a8dbcd00eeaff5aaa14842f8614c2b4 DIFF: https://github.com/llvm/llvm-project/commit/0a512a555a8dbcd00eeaff5aaa14842f8614c2b4.diff

[PATCH] D90508: [WebAssembly] Prototype i64x2.eq

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a512a555a8d: [WebAssembly] Prototype i64x2.eq (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D90514: [WebAssembly] Prototype i64x2.bitmask

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. As proposed in https://git

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. Even GLOBAL may have a better addressing mode, the unpromotable `alloca` resolved in this change has an even significant performance issue. We could favor GLOBAL LOAD/STORE for kernel function as I proposed in other threads but, considering that an aggregate argument may

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

tejohnson added a comment. In D89087#2359962 , @davidxl wrote: > There should be a related LLVM side of changes. Is it in a different patch? That's here too. See the change in llvm/lib/Transforms/Instrumentation/MemProfiler.cpp and a related test (they

[PATCH] D90514: [WebAssembly] Prototype i64x2.bitmask

tlively added a comment. Thanks for all the reviews! That's the last of them for now :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90514/new/ https://reviews.llvm.org/D90514 ___ cfe-commits mailing li

[PATCH] D90514: [WebAssembly] Prototype i64x2.bitmask

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa787e0977912: [WebAssembly] Prototype i64x2.bitmask (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] a787e09 - [WebAssembly] Prototype i64x2.bitmask

Author: Thomas Lively Date: 2020-10-30T17:23:30-07:00 New Revision: a787e0977912d53b7177e5c97e6e465be46285a2 URL: https://github.com/llvm/llvm-project/commit/a787e0977912d53b7177e5c97e6e465be46285a2 DIFF: https://github.com/llvm/llvm-project/commit/a787e0977912d53b7177e5c97e6e465be46285a2.diff

[PATCH] D90517: [clangd] Account for vendor in version string

smeenai created this revision. smeenai added reviewers: sammccall, kadircet, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. smeenai requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The vendor will be prefixed t

[PATCH] D90516: [clang] Limit scope of CLANG_VENDOR definition

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek, tstellar. Herald added subscribers: cfe-commits, dexonsmith, mgorny. Herald added a project: clang. smeenai requested review of this revision. It's only used by Version.cpp, so limit the definition to just that one fi

[PATCH] D90518: [clangd] Make tests depend on Clang

smeenai created this revision. smeenai added reviewers: jkorous, kadircet, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. smeenai requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The clangd lit confi

[clang] dd8297b - PR42513: Fix handling of function definitions lazily instantiated from

Author: Richard Smith Date: 2020-10-30T18:35:12-07:00 New Revision: dd8297b0669f8e69b03ba40171b195b5acf0f963 URL: https://github.com/llvm/llvm-project/commit/dd8297b0669f8e69b03ba40171b195b5acf0f963 DIFF: https://github.com/llvm/llvm-project/commit/dd8297b0669f8e69b03ba40171b195b5acf0f963.diff

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Reply code review suggestions. I will upload my change later. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:483 + std::move(CaseOptional), std::move(Prefix), std::move(Postfix), + std::move(HPOpt), HN

[PATCH] D89105: [X86] Support Intel avxvnni

LiuChen3 marked 2 inline comments as done. LiuChen3 added a comment. Thanks for all of your review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89105/new/ https://reviews.llvm.org/D89105 ___ cfe-commit

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Does anyone know why Harbormaster doesn't rebuild this revision after I update it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___

<    1   2