majnemer added inline comments.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2782
+
+ // construct the vector of 'unsigned char' type
+ QualType CharVecTy = Ctx.getVectorType(Ctx.CharTy, NumVectorBytes,
----------------
The code as written seems to be 'char' type, not 'unsigned char' type.
================
Comment at: clang/lib/CodeGen/CGExpr.cpp:2084-2085
Dst.isVolatileQualified());
+ auto *IRStoreTy = dyn_cast<llvm::IntegerType>(Vec->getType());
+ if (IRStoreTy) {
+ auto *IRVecTy = llvm::FixedVectorType::get(
----------------
`if (auto *IRStoreTy = dyn_cast<llvm::IntegerType>(Vec->getType()))`
================
Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:97
+ if (VT && VT->isExtVectorBoolean()) {
+ auto *FixedVT = dyn_cast<llvm::FixedVectorType>(R);
+ // Pad to at least one byte.
----------------
`dyn_cast` -> `cast`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88905/new/
https://reviews.llvm.org/D88905
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
