[PATCH] D90240: [SyntaxTree] Add reverse links to syntax Nodes.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:109 Node *getNextSibling() { return NextSibling; } + const Node *getPreviousSibling() const { return PreviousSibling; } + Node *getPreviousSibling() { return PreviousSibling; } ---

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 301029. DiggerLin added a comment. remove REQUIRES: powerpc-registered-target from test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/c

[PATCH] D90244: [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Remove the need to heap allocate a string for each style option lookup while reading or writing op

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

jamieschmeiser requested changes to this revision. jamieschmeiser added a comment. This revision now requires changes to proceed. The changes are specific to -print-before and -print-after (which is the intended target and this work originated before -print-changed) but could the change be made

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

arphaman added a comment. What's wrong with using `Optional` instead of `MaybeFileEntryRef`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89834/new/ https://reviews.llvm.org/D89834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:19 +// COMMON-LABEL: define amdgpu_kernel void @_Z7kernel1Pi(i32*{{.*}} %x) +// OPT: [[VAL:%.*]] = load i32, i32* %x, align 4 // OPT: [[INC:%.*]] = add nsw i32 [[VAL]], 1 --

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:19 +// COMMON-LABEL: define amdgpu_kernel void @_Z7kernel1Pi(i32*{{.*}} %x) +// OPT: [[VAL:%.*]] = load i32, i32* %x, align 4 // OPT: [[INC:%.*]] = add nsw i32 [[VAL]], 1 -

[PATCH] D90246: [clang-format] Improve BAS_DontAlign+AllowAllArgumentsOnNextLine=false

arichardson created this revision. arichardson added reviewers: MyDeveloperDay, JakeMerdichAMD, klimek. Herald added subscribers: cfe-commits, krytarowski. Herald added a project: clang. arichardson requested review of this revision. TokenAnnotator::splitPenalty() was always returning 0 for openin

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:19 +// COMMON-LABEL: define amdgpu_kernel void @_Z7kernel1Pi(i32*{{.*}} %x) +// OPT: [[VAL:%.*]] = load i32, i32* %x, align 4 // OPT: [[INC:%.*]] = add nsw i32 [[VAL]], 1 --

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

MaskRay added a comment. In D88566#2317248 , @stuij wrote: > Hi @MaskRay. Yes, so we're seeing a warning specific to our Armcompiler > toolchain, so I'm guessing that isn't relevant to OSS LLVM: > `armclang: warning: '--target=x86_64-unknown-linux' is not

[PATCH] D89980: [hip] Remove kernel argument coercion.

arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:19 +// COMMON-LABEL: define amdgpu_kernel void @_Z7kernel1Pi(i32*{{.*}} %x) +// OPT: [[VAL:%.*]] = load i32, i32* %x, align 4 // OPT: [[INC:%.*]] = add nsw i32 [[VAL]], 1 -

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a comment. Unfortunately, the patch does not apply against llvm9 (which is what we have as experimental setup) not to speak against llvm5 which is our production setup. Is the performance overhead for loaded module a % of the overall size

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

JonChesterfield updated this revision to Diff 301038. JonChesterfield added a comment. - prefer weak, update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89994/new/ https://reviews.llvm.org/D89994 Files: clang/lib/CodeGen/CGOpenMPRuntimeG

[PATCH] D88566: be more specific when testing for no fuse-ld warnings

stuij added a comment. > If this cannot be reproduced with the OSS LLVM, I am not sure you should > adjust such a test. Ok, fair enough. Thanks for the comment. Comment at: clang/test/Driver/fuse-ld.c:15 // RUN: FileCheck %s --check-prefix=CHECK-NO-WARN -// CHECK-NO-WARN-N

[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:352 + default: +llvm_unreachable("List children can only be elements or delimiters."); } eduucaldas wrote: > sammccall wrote: > > Let's avoid deliberately crashing on invalid c

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9195 + // If we lose precision, we use XXSPLTI32DX. + if (BVNIsConstantSplat && (SplatBitSize == 64) && Subtarget.hasPrefixInstrs()) { +if(convertToNonDenormSingle(APSplatBits) &&

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

JonChesterfield abandoned this revision. JonChesterfield added a comment. The diff doesn't look right here. I can't tell if that's a quirk of the phab gui or indicates a bad merge, going to recreate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

sfertile added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:184 if (TM.isPPC64()) { -if (Subtarget.hasAltivec()) +if (Subtarget.hasAltivec()) { + if (Subtarget.isAIXABI() && !TM.getAIXExtendedAltivecABI()) I suggest doi

[PATCH] D90248: [libomptarget][nvptx] Undef, weak shared variables

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, ABataev, grokos, tianshilei1992, ye-luo. Herald added a project: clang. Herald added a subscriber: cfe-commits. JonChesterfield requested review of this revision. [libomptarget][nvptx] Undef, weak shared variables

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

sepavloff added a comment. In D88913#2356152 , @kpn wrote: > In D88913#2353379 , @sepavloff wrote: > >> Generally the patch looks good. But the need to expect incorrect values in >> tests is a concern. Maybe this i

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski added inline comments. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include "flang/Frontend/FrontendOptions.h" +#include "flang/Parser/parsing.h" #include "clang/Basic/Diagnostic.h" sameeranjoshi wrote: > awarzynski wrote: > > sa

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames

[PATCH] D90129: Source location for -Wignored-qualifiers on lambda trailing return type

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:3092-3094 +SourceLocation Loc = D.getIdentifierLoc(); +if (Loc.isInvalid()) + Loc = FTI.getRParenLoc(); aaronpuchert wrote: > I'm open to always using the `RParenLoc`. Any r

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo updated this revision to Diff 301044. Hiralo added a comment. Added Lit test for --config-file cmdline option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89936/new/ https://reviews.llvm.org/D89936 Files: clang-tools-extra/test/clang-tidy/infrastructure/config-file.cpp Ind

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo updated this revision to Diff 301047. Hiralo added a comment. Latest patch with lit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89936/new/ https://reviews.llvm.org/D89936 Files: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp clang-tools-extra/test/clang-tidy/inf

[PATCH] D81508: [PowerPC] Add __vector_pair and __vector_quad types

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. Aside from the clang-format issues and as long as no one has any other concerns, this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo added a comment. In D89936#2356583 , @DmitryPolukhin wrote: > Yes, it is what I meant as a simpler solution. But please add Lit test even > for such trivial option. Please review latest patch and Lit test-case. CHANGES SINCE LAST ACTION https

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

tra added a subscriber: scanon. tra added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:486 + if (LangOpts.HIP) +Options.AllowFPOpFusion = llvm::FPOpFusion::Standard; + yaxunl wrote: > tra wrote: > > yaxunl wrote: > > > tra wrote: > > > > I

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

Szelethus added a comment. In D89987#2350649 , @NoQ wrote: > Honestly i'd rather eliminate `SymExpr` and go with `Symbol` everywhere. It's > an overloaded term but appending "Expr" to it doesn't really make it > significantly less overloaded. Why? I thi

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/config-file.cpp:2 +// REQUIRES: shell +// RUN: mkdir -p %T/config-file/ +// RUN: cp %s %T/read-file-config/test.cpp I think it is better to use some file in `%S/Inp

[PATCH] D90251: [AMDGPU] Add __builtin_amdgcn_grid_size

JonChesterfield created this revision. JonChesterfield added reviewers: yaxunl, arsenm, b-sumner, cfang, rjmccall, Anastasia. Herald added subscribers: openmp-commits, cfe-commits, dexonsmith, kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. Herald added projects: clang, OpenMP. JonCh

[PATCH] D90251: [AMDGPU] Add __builtin_amdgcn_grid_size

arsenm added a comment. What's the point of this? The reason for the other case was because there was no other way to attach the range metadata. The invariant load here is redundant since with AMDGPU AA the load from constant will be treated as invariant anyway Repository: rG LLVM Github M

[PATCH] D89481: [scan-build] Fix clang++ pathname again

NoQ accepted this revision. NoQ edited reviewers, added: NoQ, vsavchenko; removed: dergachev.a. NoQ added a comment. Nice, thanks! Since recently we started doing LIT tests for scan-build in `test/Analysis/scan-build`, if you find a good way to test this feature feel free to add a regression te

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

dexonsmith added a comment. In D89749#2356846 , @v.g.vassilev wrote: > Is the performance overhead for loaded module a % of the overall size of the > source files? `SourceManager::PrintStats` almost has the information you need. One of the lines is:

RE: [PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

Actually kludging it by just removing the assert isn't going to work. I'll ping Pengfei to see about developing a patch for this problem. > -Original Message- > From: dmajor via Phabricator > Sent: Tuesday, October 27, 2020 11:58 AM > To: Blower, Melanie I ; sepavl...@gmail.com; > rjmcc

[PATCH] D90251: [AMDGPU] Add __builtin_amdgcn_grid_size

JonChesterfield added a comment. Consistency really. It seemed strange to have a builtin for reading the workgroup size and not one for the grid size. There's probably a range limit that can be set on this one too, I'm just not sure what it is. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Nit: Add '.' add the end of comments and make them sentences. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89802/new/ https://revi

[PATCH] D90221: Include attribute details when dumping AST in JSON

aaron.ballman added a comment. In D90221#2356110 , @aronsky wrote: > In D90221#2356062 , @lebedev.ri > wrote: > >> Are there tests missing? > > Quite possible. I followed the trail of the existing functions to figu

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

aaron.ballman added a comment. In D90042#2356265 , @flx wrote: > In D90042#2356180 , @aaron.ballman > wrote: > >> In D90042#2350035 , @flx wrote: >> >>> I should note that I

[PATCH] D90253: [WebAssembly] Prototype extending multiplication SIMD instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. As proposed in https:

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

njames93 added a comment. If you plan on contributing quite a lot then it would be wise to upload your patches with arcanist - https://llvm.org/docs/Phabricator.html. It will help prevent issues with diffs being relative to previous revisions. Personally I just create a branch from master for a

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

craig.topper added a comment. In D87528#2357043 , @mibintc wrote: > Actually kludging it by just removing the assert isn't going to work. I'll > ping Pengfei to see about developing a patch for this problem. This is likely a WebAssembly backend problem.

[PATCH] D90251: [AMDGPU] Add __builtin_amdgcn_grid_size

yaxunl added a comment. I think there is value in this change. It may help simplify device library and hide some compiler details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90251/new/ https://reviews.llvm.org/D90251 __

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

dexonsmith added a comment. In D89834#2356769 , @arphaman wrote: > What's wrong with using `Optional` instead of > `MaybeFileEntryRef`? Two problems: 1. `const FileEntry*` is stored in lots of places. I am nervous after the memory regression from `File

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

sameeranjoshi added a comment. Looks good, I would wait for a couple of more days for someone to review from community may be from Nvidia's side if someone would verify the initial design. Thank you. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include "f

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt updated this revision to Diff 301059. trixirt added a comment. fix precheckin lint issues with auto vs const auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90180/new/ https://reviews.llvm.org/D90180 Files: clang-tools-extra/clang-tid

[PATCH] D90244: [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations

aaron.ballman added a comment. Was this caused by a performance concern when profiling something? I'm not opposed to the changes, but I do think the original formulation is easier to read. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90244/new/

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:19 +// COMMON-LABEL: define amdgpu_kernel void @_Z7kernel1Pi(i32*{{.*}} %x) +// OPT: [[VAL:%.*]] = load i32, i32* %x, align 4 // OPT: [[INC:%.*]] = add nsw i32 [[VAL]], 1 --

[PATCH] D39086: Performance tracing facility for clangd.

RKSimon added inline comments. Herald added subscribers: usaxena95, kadircet, arphaman, MaskRay. Comment at: clang-tools-extra/trunk/unittests/clangd/TraceTests.cpp:57 +} +std::string VS = V->getValue(Tmp).str(); +if (VS != I->second) { @sammccall PVS

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

trixirt added a comment. Discussion of change on LKML https://lkml.org/lkml/2020/10/27/2538 On why the existing clang fixit is not practical. tl;dr 10,000 changes to look for a treewide fix The fixit has whitespace issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

Eugene.Zelenko added a comment. In D90180#2357178 , @trixirt wrote: > Discussion of change on LKML > https://lkml.org/lkml/2020/10/27/2538 > > On why the existing clang fixit is not practical. > tl;dr > 10,000 changes to look for a treewide fix > The fixi

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

rjmccall added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:486 + if (LangOpts.HIP) +Options.AllowFPOpFusion = llvm::FPOpFusion::Standard; + tra wrote: > yaxunl wrote: > > tra wrote: > > > yaxunl wrote: > > > > tra wrote: > > > > > I don't

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

awarzynski updated this revision to Diff 301066. awarzynski added a comment. Rebase on top of master + rename accessor method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88381/new/ https://reviews.llvm.org/D88381 Files: clang/include/clang/Dri

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo updated this revision to Diff 301065. Hiralo added a comment. Latest patch with Lit test-case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89936/new/ https://reviews.llvm.org/D89936 Files: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp clang-tools-extra/test/clang-ti

[PATCH] D89980: [hip] Remove kernel argument coercion.

hliao added a comment. Besides the unpromotable `alloca` issue due to indirect accesses, such coercion to GLOBAL pointer directly is not safe as, in HIP/CUDA, both CONSTANT and GLOBAL pointers would be passed as the kernel arguments. Without introducing a new address space combing GLOBAL/CONSTA

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo marked 4 inline comments as done. Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:290 DefaultOptions.Checks = DefaultChecks; + DefaultOptions.ConfigFile = ""; DefaultOptions.WarningsAsErrors = ""; njames

[clang] 5046153 - Revert "[CodeView] Emit static data members as S_CONSTANTs."

Author: Amy Huang Date: 2020-10-27T11:29:58-07:00 New Revision: 504615353f31136dd6bf7a971b6c236fd70582be URL: https://github.com/llvm/llvm-project/commit/504615353f31136dd6bf7a971b6c236fd70582be DIFF: https://github.com/llvm/llvm-project/commit/504615353f31136dd6bf7a971b6c236fd70582be.diff LOG

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

Hiralo added a comment. In D89936#2357088 , @njames93 wrote: > If you plan on contributing quite a lot then it would be wise to upload your > patches with arcanist - https://llvm.org/docs/Phabricator.html. It will help > prevent issues with diffs being r

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling support for non-type template parameters of class type and template parameter objects.

rsmith updated this revision to Diff 301070. rsmith added a comment. - Ignore cv-qualifiers in member types for Itanium mangling. - Add MSVC-compatible mangling support. - Fix bug where template argument value mangling would be used when passing a template parameter object as a pointer or r

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

dblaikie added subscribers: mehdi_amini, dblaikie. dblaikie added a comment. @lattner minor detail/annoyance: Phabricator doesn't email the mailing lists if a review is "approved" with no comments. To ensure the approval is recorded on the list, please include some text (a stub "." would suffice

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

aaron.ballman added a comment. In D90180#2357178 , @trixirt wrote: > Discussion of change on LKML > https://lkml.org/lkml/2020/10/27/2538 > > On why the existing clang fixit is not practical. > tl;dr > 10,000 changes to look for a treewide fix > The fixit

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rsmith added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:657-660 // ::= $1? // ::= $H? // ::= $I? // ::= $J? For what it's worth, I'm fairly co

[clang] 917acac - FileManager: Shrink FileEntryRef to the size of a pointer

Author: Duncan P. N. Exon Smith Date: 2020-10-27T14:55:41-04:00 New Revision: 917acac960d40280ea02ea453e594034b1be1f6b URL: https://github.com/llvm/llvm-project/commit/917acac960d40280ea02ea453e594034b1be1f6b DIFF: https://github.com/llvm/llvm-project/commit/917acac960d40280ea02ea453e594034b1be

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

This revision was automatically updated to reflect the committed changes. dexonsmith marked 2 inline comments as done. Closed by commit rG917acac960d4: FileManager: Shrink FileEntryRef to the size of a pointer (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: htt

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

lattner added a comment. Oops, thanks for the head's up @dblaikie ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89893/new/ https://reviews.llvm.org/D89893 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D90188: Add support for attribute 'using_if_exists'

ldionne added inline comments. Comment at: clang/test/SemaCXX/using-if-exists-attr.cpp:16 +template +using template_alias UIE = NS::x; // expected-warning {{'using_if_exists' attribute only applies to named declarations, types, and value declarations}} + I assu

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang reopened this revision. akhuang added a comment. This revision is now accepted and ready to land. Reverted because my copied `isUnsignedDIType` function had problems (guess I copied it at first but then was messing with the code); I moved it to DebugHandlerBase.h so it doesn't need to be

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

akhuang updated this revision to Diff 301080. akhuang added a comment. Herald added a subscriber: jfb. Moved isUnsignedDIType to DebugHandlerBase to avoid copying it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/ https://reviews.llvm.org

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington added inline comments. Comment at: clang/test/SemaCXX/using-if-exists-attr.cpp:16 +template +using template_alias UIE = NS::x; // expected-warning {{'using_if_exists' attribute only applies to named declarations, types, and value declarations}} + ---

[clang] e025d09 - Revert multiple patches based on "Introduce CfgTraits abstraction"

Author: Nicolai Hähnle Date: 2020-10-27T20:33:30+01:00 New Revision: e025d09b216dc2239e1b502f4f277abb6fb4648a URL: https://github.com/llvm/llvm-project/commit/e025d09b216dc2239e1b502f4f277abb6fb4648a DIFF: https://github.com/llvm/llvm-project/commit/e025d09b216dc2239e1b502f4f277abb6fb4648a.diff

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

Mordante marked 10 inline comments as done. Mordante added a comment. Thanks for the feedback. I'll update the patch after making the requested changes. Comment at: clang/include/clang/Basic/AttrDocs.td:1866 + while(true) [[unlikely]] { +... // The attribute

[clang] 3700556 - [HIP][NFC] Use correct max in cuda_complex_builtins

Author: Aaron En Ye Shi Date: 2020-10-27T19:35:09Z New Revision: 3700556ecb062abf786ad52a5474c27b22c19107 URL: https://github.com/llvm/llvm-project/commit/3700556ecb062abf786ad52a5474c27b22c19107 DIFF: https://github.com/llvm/llvm-project/commit/3700556ecb062abf786ad52a5474c27b22c19107.diff LO

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1866 + while(true) [[unlikely]] { +... // The attribute has no effect + } // Clang elides comparison and generates an infinite loop Mordan

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

rjmccall added inline comments. Comment at: clang/lib/AST/APValue.cpp:1047 + if (MergeLV(getLVForType(*TI.getType(), computation))) +break; +} else if (const Expr *E = V.getLValueBase().dyn_cast()) { I'm not sure what ABIs you're thinking about,

[PATCH] D90188: Add support for attribute 'using_if_exists'

Mordante added a comment. A few questions. I'm not familiar enough with the code to accept the patch. Comment at: clang/include/clang/Basic/AttrDocs.td:5266 + let Content = [{ +The using_if_exists attribute applies to a using-declaration. It allows +programmers to import a dec

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

Paul-C-Anagnostopoulos added a comment. I'll remember this, too. @dblaikie How did you happen to notice? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89893/new/ https://reviews.llvm.org/D89893 ___ cfe-

[PATCH] D90054: Added remotely ran compiler-rt tests.

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90054/new/ https://reviews.llvm.org/D90054 ___

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

dblaikie added a comment. In D89893#2357480 , @Paul-C-Anagnostopoulos wrote: > I'll remember this, too. > > @dblaikie How did you happen to notice? Reading the mailing list & seeing the phab review and commit without any emails from anyone else in the r

[PATCH] D90244: [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations

njames93 added a comment. In D90244#2357130 , @aaron.ballman wrote: > Was this caused by a performance concern when profiling something? I'm not > opposed to the changes, but I do think the original formulation is easier to > read. It's not a huge perf

[PATCH] D89794: [SyntaxTree] Implement "by-pointer output parameter to return value" refactoring.

dblaikie added a comment. I imagine test coverage would be handy (I'm probably not the right reviewer for this in general, but was/am curious to see how it goes - you might want to search for other contributors/reviewers to the code you're changing and request/add them as reviewers for this pat

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

dblaikie added a comment. Idle curiosity: The patch description says "non-trivial C struct temporaries" - can C have non-trivial structs? Or is this limited to Objective C (judging/guessing by the tests)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

dblaikie added a comment. @tmsriram ping on the follow-up here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89500/new/ https://reviews.llvm.org/D89500 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Tue, Oct 27, 2020 at 2:14 PM David Blaikie via Phabricator < revi...@reviews.llvm.org> wrote: > dblaikie added a comment. > > @tmsriram ping on the follow-up here > I checked in the patch that emits llvm instead of obj which spews garbage to the terminal as I wasn't redirecting it to /dev/null

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

ahatanak added a comment. C structs with ObjC pointer fields are non-trivial when ARC is enabled since construction, destruction, and copy are non-trivial (see https://reviews.llvm.org/D41228). As far as I know, this is limited to ObjC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

dblaikie added a comment. In D83448#2357574 , @ahatanak wrote: > C structs with ObjC pointer fields are non-trivial when ARC is enabled since > construction, destruction, and copy are non-trivial (see > https://reviews.llvm.org/D41228). As far as I know,

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: ormris, MaskRay, ilya-biryukov. This introduces a mechanism for pro

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

djasper added a comment. Sorry for being a bit late here and thanks @klimek for bringing this to my attention. This has been years ago, but if I reconstruct my thinking (and look at the test cases), then I'd say that "left" alignment should not be applied to multi-variable decl statements ever.

[PATCH] D90188: Add support for attribute 'using_if_exists'

rsmith added a comment. In addition to moving the diagnostic to `DiagnoseUseOfDecl`, you may well get better error recovery if you teach `ClassifyName` about the new kind of declaration, and have it `DiagnoseUseOfDecl` it immediately and return `NameClassification::Error()` -- that way, the par

[PATCH] D90271: [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, rnk, phosek, srhines. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers requested review of this revision. Make the virtual method Toolchain::GetDefaultStackProtectorLevel() return an

[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. I split out the first logical change into https://reviews.llvm.org/D90271. I think I'll rework this to both be rebased, and to not add the new enum value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

thakis added inline comments. Herald added a subscriber: ormris. Comment at: clang/include/clang/Basic/FileManager.h:101 + /// Type used in the StringMap. + using MapEntry = llvm::StringMapEntry>; + It looks like this is too clever for gcc5.3: https://bugs.chr

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Any news regarding false-negatives? +Mitch Phillips On Mon, 19 Oct 2020 at 22:07, Galina Kistanova wrote: > Thanks, Vitaly. > Somebody is looking at this. > > > On Mon, Oct 19, 2020 at 9:56 PM Vitaly Buka wrote: > >> it's not just staging, this build must be marked as failed >> http://lab.llv

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dblaikie added a comment. In D90109#2356317 , @aaron.ballman wrote: > In D90109#2352180 , @dsanders11 > wrote: > >> Added a few inline comments for clarification. >> >> **Note**: I was not able to get a debug buil

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

It looks fixed. I haven't seen them in recent reports. On Tue, 27 Oct 2020 at 16:32, Vitaly Buka wrote: > Any news regarding false-negatives? > > +Mitch Phillips > > On Mon, 19 Oct 2020 at 22:07, Galina Kistanova > wrote: > >> Thanks, Vitaly. >> Somebody is looking at this. >> >> >> On Mon, Oc

[PATCH] D90271: [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90271/new/ https://reviews.llvm.org/D90271 ___ c

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

thakis added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:101 + /// Type used in the StringMap. + using MapEntry = llvm::StringMapEntry>; + thakis wrote: > It looks like this is too clever for gcc5.3: > https://bugs.chromium.org/p/chrom

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Hello Vitaly, This should be fixed. Please let me know if you still see the issue. Thanks Galina On Tue, Oct 27, 2020 at 4:45 PM Vitaly Buka wrote: > It looks fixed. I haven't seen them in recent reports. > > On Tue, 27 Oct 2020 at 16:32, Vitaly Buka wrote: > >> Any news regarding false-n

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

ychen added a comment. IIUC, this is the NPM version of EP_EarlyAsPossible in legacy PM for O0, right? Between the choice of (1) [this patch and ] reusing all existing EP callbacks and letting optnone filtering out non-required passes (which I think does not work for `-disable-O0-optnone`) and

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks updated this revision to Diff 301132. aeubanks added a comment. only run passes in PipelineStartEPCallbacks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files: clang/lib/CodeGen/BackendUtil.cp

Re: [clang] e97e985 - [c++20] For P0732R2: permit class template argument deduction for non-type template parameters.

gcc points out that DTST is unused in +if (auto *DTST = dyn_cast(DeducedT)) { Should it be used? Or should we delete the lhs of that assignment? On Wed, Oct 21, 2020 at 6:03 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-10-21T15

<    1   2   3   >