[clang-tools-extra] ba268d2 - [clangd] Fix a typo, NFC.

Author: Haojian Wu Date: 2020-10-08T09:35:49+02:00 New Revision: ba268d2fb09ceabfa03a6499258f973be62d7663 URL: https://github.com/llvm/llvm-project/commit/ba268d2fb09ceabfa03a6499258f973be62d7663 DIFF: https://github.com/llvm/llvm-project/commit/ba268d2fb09ceabfa03a6499258f973be62d7663.diff LO

[PATCH] D88881: [clangd] Add a NewName optional parameter to clangdServer::prepareRename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:277 + /// + /// If NewName is provided, it peforms a name validation. void prepareRename(PathRef File, Position Pos, danielmartin wrote: > oh, thanks! Fixed in ba268d2fb09ceab

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

teemperor added a comment. On macOS, LLDB's tests pass `-isysroot /path/to/SDK` to Clang but expect that Clang always prefers the the libc++ headers that are in the Clang build directory. So if we change this behaviour then we should have a way to keep the old behaviour around. Repository:

[PATCH] D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets

jhenderson added inline comments. Comment at: clang/lib/Basic/Cuda.cpp:1 #include "clang/Basic/Cuda.h" (aside - this file seems to be missing the copyright header - probably should be fixed separately though) Comment at: llvm/tools/llvm-rea

[PATCH] D84387: [AST][RecoveryExpr] Part4: Support dependent cast-expr in C for error-recovery.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa96bcfb19674: [AST][RecoveryExpr] Support dependent cast-expr in C for error-recovery. (authored by hokein). Changed prior to commit: https://revi

[clang] a96bcfb - [AST][RecoveryExpr] Support dependent cast-expr in C for error-recovery.

Author: Haojian Wu Date: 2020-10-08T10:00:29+02:00 New Revision: a96bcfb196740b5be217f6166462ee1206530520 URL: https://github.com/llvm/llvm-project/commit/a96bcfb196740b5be217f6166462ee1206530520 DIFF: https://github.com/llvm/llvm-project/commit/a96bcfb196740b5be217f6166462ee1206530520.diff LO

[PATCH] D84304: [AST][RecoveryExpr] Part 2: Build dependent callexpr in C for error-recovery.

hokein updated this revision to Diff 296885. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84304/new/ https://reviews.llvm.org/D84304 Files: clang/lib/Sema/SemaExpr.cpp clang/test/AST/ast-dump-recovery.c clang/

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fpetrogalli added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:91 Accelerate, // Use Accelerate framework. +LIBMVEC,// GLIBC Vector Math library. MASSV, // IBM MASS vector library. Can we call this LIBMVEC-X86

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

JonChesterfield added a comment. Nice patch. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88929/new/ https://reviews.llvm.org/D88929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 296901. jonpa marked an inline comment as done. jonpa added a comment. Updated per review to use SmallSet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/Cod

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm created this revision. david-arm added reviewers: sdesmalen, ctetreau, fhahn, c-rhodes. Herald added subscribers: cfe-commits, psnobl, tschuett. Herald added a reviewer: efriedma. Herald added a reviewer: aaron.ballman. Herald added a project: clang. david-arm requested review of this rev

[PATCH] D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. still LGTM Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:715 auto TU = TestTU::withCode(Test.code()); + TU.ExtraArgs.push_back("-std=c++17");

[PATCH] D88411: [clangd] Introduce MemoryTrees

kadircet added a comment. > Still LGTM, commit it already :-D Haha, waiting for dependents to be stamped as well :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88411/new/ https://reviews.llvm.org/D88411 _

[PATCH] D88411: [clangd] Introduce MemoryTrees

kadircet updated this revision to Diff 296910. kadircet marked an inline comment as done. kadircet added a comment. - Inline MemoryTree::self Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88411/new/ https://reviews.llvm.org/D88411 Files: clang-t

[PATCH] D88968: [WebAssembly] Prototype i16x8.q15mulr_sat_s

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117 +TARGET_BUILTIN(__builtin_wasm_q15mulr_saturate_s_i8x16, "V8UsV8UsV8Us", "nc", "simd128") + ---

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

sylvestre.ledru added a comment. @JakeMerdichAMD @MyDeveloperDay Do you know if the regression has been fixed? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https://reviews.llvm.org/D79388

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

nemanjai added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:91 Accelerate, // Use Accelerate framework. +LIBMVEC,// GLIBC Vector Math library. MASSV, // IBM MASS vector library. fpetrogalli wrote: > Can we cal

[PATCH] D89035: [clangd] New CC Ranking Model to fix bad inference due to overflow.

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Unreachable file distances are represented a

[clang] 70bf350 - [Driver] Add output file to properties of Command

Author: Serge Pavlov Date: 2020-10-08T18:23:39+07:00 New Revision: 70bf35070a74df02ed12b9988ce58d50e63a7c04 URL: https://github.com/llvm/llvm-project/commit/70bf35070a74df02ed12b9988ce58d50e63a7c04 DIFF: https://github.com/llvm/llvm-project/commit/70bf35070a74df02ed12b9988ce58d50e63a7c04.diff

[PATCH] D78902: [Driver] Add output file to properties of Command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70bf35070a74: [Driver] Add output file to properties of Command (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:738 +"Add include \"x.h\" for symbol ns::X"))), + AllOf(Diag(Test.range("nested"), + "incomplete type 'ns::X' named in nested

[PATCH] D88964: [clangd] Add a missing include-fixer test for incomplete_type, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4e27220c2a1: [clangd] Add a missing include-fixer test for incomplete_type, NFC. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88964/n

[clang-tools-extra] a4e2722 - [clangd] Add a missing include-fixer test for incomplete_type, NFC.

Author: Haojian Wu Date: 2020-10-08T13:33:38+02:00 New Revision: a4e27220c2a1046616556b8aadb0ae8f5e0255be URL: https://github.com/llvm/llvm-project/commit/a4e27220c2a1046616556b8aadb0ae8f5e0255be DIFF: https://github.com/llvm/llvm-project/commit/a4e27220c2a1046616556b8aadb0ae8f5e0255be.diff LO

[PATCH] D89035: [clangd] New CC Ranking Model to fix bad inference due to overflow.

usaxena95 updated this revision to Diff 296925. usaxena95 added a comment. Update model to LambdaMART instead of XE_NDCG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89035/new/ https://reviews.llvm.org/D89035 Files: clang-tools-extra/clangd/qu

Re: [cfe-dev] Upcoming upgrade of LLVM buildbot

Our Flang-aarch64 buildbots just won't connect to the main Buildbot master anymore. I switched them to the staging buildbot master instead and it seems fine for now. Is there anything that we can/should tweak at our end? http://lab.llvm.org:8014/#/waterfall?tags=flang -Andrzej On 08/10/2020

[PATCH] D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon updated this revision to Diff 296930. RKSimon added a comment. Herald added a subscriber: pengfei. rebased now that the reduction intrinsics are no longer experiemental Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87604/new/ https://review

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

fiesh added a comment. @aaron.ballman valid point. It would seem natural to diagnose both since the user is voluntarily causing the decay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 _

[clang] 6668e4c - [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

Author: Joseph Huber Date: 2020-10-08T08:20:38-04:00 New Revision: 6668e4cc685e74a17ebd386913e842ac3d7472e5 URL: https://github.com/llvm/llvm-project/commit/6668e4cc685e74a17ebd386913e842ac3d7472e5 DIFF: https://github.com/llvm/llvm-project/commit/6668e4cc685e74a17ebd386913e842ac3d7472e5.diff

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner added a comment. Great. I don't have commit access though. If I did, I would love to commit it to the release branch, which is what we use... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

jmorse added a comment. In D88363#2317241 , @Mordante wrote: > Can you explain the kind of issues you're having? At the shallowest level, our -O1 produces different IR and fails the test, which is more or less our problem; however my understanding is tha

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

kadircet added a comment. In D88414#2317106 , @sammccall wrote: > Now there's lots of usage (which looks good!) i'm finding it a bit hard to > keep track of what the tree will look like overall. > > At some point it'd be great to: > a) bind this to an LS

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2338 + Exprs = Exprs.drop_front(); + if (Exprs.size() == 0) +return llvm::ConstantPointerNull::get(Int8PtrTy); `Exprs.empty()` would be more concise. Com

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard added inline comments. Comment at: clang/test/CodeGen/volatile.c:1 -// RUN: %clang_cc1 -triple=%itanium_abi_triple -emit-llvm < %s | FileCheck %s -check-prefix CHECK -check-prefix CHECK-IT +// RUN: %clang_cc1 -triple=%itanium_abi_triple -emit-llvm < %s | FileCheck %s

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

bdf added a comment. In D88363#2319157 , @jmorse wrote: > In D88363#2317241 , @Mordante wrote: > >> Can you explain the kind of issues you're having? > > At the shallowest level, our -O1 produces different IR and fa

[clang-tools-extra] a0a6fd4 - [clangd] New CC Ranking Model to fix bad inference due to overflow.

Author: Utkarsh Saxena Date: 2020-10-08T15:30:00+02:00 New Revision: a0a6fd435c6066d40d9c20835f1e52aad1e8cc65 URL: https://github.com/llvm/llvm-project/commit/a0a6fd435c6066d40d9c20835f1e52aad1e8cc65 DIFF: https://github.com/llvm/llvm-project/commit/a0a6fd435c6066d40d9c20835f1e52aad1e8cc65.diff

[PATCH] D89035: [clangd] New CC Ranking Model to fix bad inference due to overflow.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0a6fd435c60: [clangd] New CC Ranking Model to fix bad inference due to overflow. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8903

[PATCH] D87451: add new option -mignore-xcoff-visibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. DiggerLin marked an inline comment as done. Closed by commit rG92bca1284308: [AIX] add new option -mignore-xcoff-visibility (authored by DiggerLin). Changed prior to c

[clang] 92bca12 - [AIX] add new option -mignore-xcoff-visibility

Author: diggerlin Date: 2020-10-08T09:34:58-04:00 New Revision: 92bca1284308452b8eb549e9382873645320cf19 URL: https://github.com/llvm/llvm-project/commit/92bca1284308452b8eb549e9382873645320cf19 DIFF: https://github.com/llvm/llvm-project/commit/92bca1284308452b8eb549e9382873645320cf19.diff LOG

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel added a comment. TL;DR Stephen's fix works; I'll drop this patch. > Why do you use `TK_IgnoreImplicitCastsAndParentheses` instead of > `TK_IgnoreUnlessSpelledInSource`? All you seem to be doing is showing that > the former is broken. I've always thought we should remove the former. `AsI

[PATCH] D88417: [clangd] Record memory usages after each notification

kadircet updated this revision to Diff 296955. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88417/new/ https://reviews.llvm.org/D88417 Files: clang-tools-ex

[PATCH] D88417: [clangd] Record memory usages after each notification

kadircet requested review of this revision. kadircet added a comment. Bad news, I was testing this with remote-index, hence background-index was turned off. Unfortunately traversing all of the slabs in `FileSymbols` takes quite a while in this case (~15ms for LLVM). I don't think it is feasible

[PATCH] D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

kadircet added a comment. Tests seem to be failing on premerge bots: - https://reviews.llvm.org/harbormaster/unit/view/177841/ - https://reviews.llvm.org/harbormaster/unit/view/177842/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89036/new/ https

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

aaron.ballman added a comment. In D69560#2292505 , @whisperity wrote: > I'd like to resurrect the discussion about this. Unfortunately, the concept > of `experimental-` group (in D76545 ) has > fallen silent, too. We will

[PATCH] D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

hokein updated this revision to Diff 296961. hokein added a comment. Fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89036/new/ https://reviews.llvm.org/D89036 Files: clang-tools-extra/clangd/IncludeFixer.cpp clang-tools-extra/clan

[PATCH] D89036: [clangd] Add more incomplete_type diagnostics that could be fixed by include-fixer.

hokein added a comment. In D89036#2319320 , @kadircet wrote: > Tests seem to be failing on premerge bots: > > - https://reviews.llvm.org/harbormaster/unit/view/177841/ > - https://reviews.llvm.org/harbormaster/unit/view/177842/ opps, sorry -- I made a few

[PATCH] D89045: [AST][RecoveryExpr] Don't perform early typo correction in C.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. The dependent mechanism for C error-recovery is mostly finished, this is the only place we have missed. Repository: rG LLVM Github Monorepo https://review

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein created this revision. Herald added subscribers: cfe-commits, arphaman, kbarton, nemanjai. Herald added a project: clang. hokein requested review of this revision. Not intent to land it now, we need to run internal experiments to make sure this is not crashy. It is ready for review, all ch

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu updated this revision to Diff 296965. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/aix-data-sections.c clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp lld/Comm

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added inline comments. Comment at: lld/Common/TargetOptionsCommandFlags.cpp:17 +llvm::TargetOptions +lld::initTargetOptionsFromCodeGenFlags(const llvm::Triple &TheTriple) { + return llvm::codegen::InitTargetOptionsFromCodeGenFlags(TheTriple); MaskRay wr

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

fpetrogalli added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:91 Accelerate, // Use Accelerate framework. +LIBMVEC,// GLIBC Vector Math library. MASSV, // IBM MASS vector library. nemanjai wrote: > fpetrogall

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

yaxunl added a subscriber: hans. yaxunl added a comment. I can help you commit it to trunk. For cherrypick to release branch, we may need help of @hans Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 _

[PATCH] D89046: [AST] Build recovery expression by default for all language.

hokein updated this revision to Diff 296968. hokein added a comment. fix unexpected format changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D89046 Files: clang/include/clang/Basic/LangOptions.def clang

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

stefanp updated this revision to Diff 296970. stefanp added a comment. Added the missing header file. Added the license comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 Files: clang/unittests/Tool

[PATCH] D88088: [clang] improve accuracy of ExprMutAnalyzer

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM though I may have spotted a potential improvement (it can be handled in a follow-up if you want). Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:61 + // below. + auto const ConditionalOperator

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

kadircet updated this revision to Diff 296971. kadircet added a comment. - Fix a bug in FileSymbols profiling. - Add unittests to ensure tree structure is as expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88414/new/ https://reviews.llvm.or

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L updated this revision to Diff 296972. Xiangling_L marked an inline comment as done. Xiangling_L added a comment. Remove emit errors for oversized long long bitfield and related testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/ https://reviews.llvm.org/D87029

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt:37 + clangLex + clangSerialization clangTidy Why do serialization and lex need to be pulled in? Comment at: clang-tools-extra/c

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

hans added a comment. In D88949#2319392 , @yaxunl wrote: > I can help you commit it to trunk. For cherrypick to release branch, we may > need help of @hans It's most likely too late for 11.0.0, but I will put it on my list of 11.0.1 candidates. Reposi

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps marked 2 inline comments as done. alanphipps added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1169 +createBranchRegion(S->getCond(), BodyCount, + subtractCounters(CondCount, BodyCount)); } vsk wro

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

glevner added a comment. Good enough for us... Thanks, @hans and @yaxunl! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https://reviews.llvm.org/D88949 ___ cfe-commits mailing list cfe-commits

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

dexonsmith added reviewers: rsmith, teemperor. dexonsmith added a comment. Hmm, that's right, to support user-provided libc++ headers it's simpler if we prefer the toolchain / next-to-clang. The reason we need to invert it is transitional. The status quo is that we have no headers in the SDKs (

[PATCH] D88949: DeferredDiagnosticsEmitter crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9225543e844: DeferredDiagnosticsEmitter crashes (authored by glevner, committed by yaxunl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88949/new/ https:

[clang] b922554 - DeferredDiagnosticsEmitter crashes

Author: Geoff Levner Date: 2020-10-08T11:42:21-04:00 New Revision: b9225543e844bee5091aa16108e0c54bd2abe485 URL: https://github.com/llvm/llvm-project/commit/b9225543e844bee5091aa16108e0c54bd2abe485 DIFF: https://github.com/llvm/llvm-project/commit/b9225543e844bee5091aa16108e0c54bd2abe485.diff

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rGd564409946a5: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by… (authored by jhuber6). Herald added a subscriber: mgorny. Changed prior to commit: https://reviews.llvm.org/D

[clang] d564409 - [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

Author: Joseph Huber Date: 2020-10-08T12:09:34-04:00 New Revision: d564409946a5a13cb6391fc0fec54dcbd6f6d249 URL: https://github.com/llvm/llvm-project/commit/d564409946a5a13cb6391fc0fec54dcbd6f6d249 DIFF: https://github.com/llvm/llvm-project/commit/d564409946a5a13cb6391fc0fec54dcbd6f6d249.diff

[PATCH] D88929: [OpenMP] Change CMake Configuration to Build for Highest CUDA Architecture by Default

jhuber6 closed this revision. jhuber6 added a comment. Screwed up and put the wrong revision in the commit message. Closed in rGd564409946a5a13cb6391fc0fec54dcbd6f6d249 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 reopened this revision. jhuber6 added a comment. This revision is now accepted and ready to land. Closed accidentally, had the wrong revision link in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.ll

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2095 +if (!GCCReg.empty() && !PhysRegOutputs.insert(GCCReg).second) + CGM.Error(S.getAsmLoc(), "Multiple outputs to hard register: " + GCCReg); + Diagnostics in Clang are typic

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

kadircet updated this revision to Diff 296992. kadircet marked 3 inline comments as done. kadircet added a comment. - Switch from substring to subscope matching. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88814/new/ https://reviews.llvm.org/D888

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:44 +// Returns true if \p Query can be found as a sub-scope inside \p Scope. +bool approximateScopeMatch(llvm::StringRef Scope, sammccall wrote: > kadircet wrote: > > sammccall

[PATCH] D88659: [FE]Split SuitableAlign into two parts

hubert.reinterpretcast added a comment. In D88659#2318203 , @jyknight wrote: > It seems like on AIX, `__BIGGEST_ALIGNMENT__` should just be set to 16, then. > I'm not sure why you want it to be 8? /// Return the alignment that is suitable for storing

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

aqjune added a comment. I think it makes sense - IIUC, for most of the clang tests, noundef won't be the attribute of interest. For brevity of tests, I think the change is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://revi

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 296994. eduucaldas added a comment. - [SyntaxTree] Provide iterator for `List` that iterates through `ElementAndDelimiter`s even for not well-defined lists. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8810

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 296996. eduucaldas added a comment. Better comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/To

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 297001. eduucaldas added a comment. Reorganize methods to minimize diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 Files: clang/include/clang/Tooling/Syntax/

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

ldionne updated this revision to Diff 297000. ldionne added a comment. Try to fix test failure on Linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89001/new/ https://reviews.llvm.org/D89001 Files: clang/lib/Driver/ToolChains/Darwin.cpp clan

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: steakhal, NoQ, martong, vsavchenko. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun.

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

shafik added a comment. This looks reasonable, I am guessing we can't test this b/c it would only come up in a cling use case? Was there ever a design document that Hal and JF were asking for? I was reading through the cfe-dev thread and I don't see it. Repository: rG LLVM Github Monorepo

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas updated this revision to Diff 297006. eduucaldas added a comment. Replace `auto .. = std::vector();` with `std::vector ..;` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88106/new/ https://reviews.llvm.org/D88106 Files: clang/include/

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 297003. jhuber6 added a subscriber: ABataev. jhuber6 added a comment. Removing the _loc suffix. The Mapper API hasn't been officially released in Clang 11.x so we're still free to make changes. Currently working on augmenting the mapper API with variable dec

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 297008. jhuber6 added a comment. Updating tests after landing D88594 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ https://reviews.llvm.org/D88430 Files: clang/l

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

erichkeane added a comment. *PING!* Any feedback? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88298/new/ https://reviews.llvm.org/D88298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

aaron.ballman added a comment. In D88833#2319118 , @fiesh wrote: > @aaron.ballman valid point. It would seem natural to diagnose both since the > user is voluntarily causing the decay? I'm on the fence. If the argument to the function is one that's defi

[clang] 64c0792 - [clang][feature] Add cxx_abi_relative_vtable feature

Author: Leonard Chan Date: 2020-10-08T10:30:54-07:00 New Revision: 64c0792946b792839b2f39e4e208fdd7398aaea0 URL: https://github.com/llvm/llvm-project/commit/64c0792946b792839b2f39e4e208fdd7398aaea0 DIFF: https://github.com/llvm/llvm-project/commit/64c0792946b792839b2f39e4e208fdd7398aaea0.diff

[PATCH] D85924: [clang][feature] Add cxx_abi_relative_vtable feature

This revision was automatically updated to reflect the committed changes. Closed by commit rG64c0792946b7: [clang][feature] Add cxx_abi_relative_vtable feature (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85924/new/ https

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

lebedev.ri added a comment. I think the current behavior should instead be configurable, with a way to opt-in into weaker guarantees. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88833/new/ https://reviews.llvm.org/D88833 ___

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. This is quite low priority, compared to the other branches of work, but it was almost ready work, so I decided to polish it and send it to review now. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:238

[clang] a15bd0b - [AIX] Add REQUIRES for powerpc test. NFC

Author: David Green Date: 2020-10-08T18:40:09+01:00 New Revision: a15bd0bfc20c2b2955c59450a67b6e8efe89c708 URL: https://github.com/llvm/llvm-project/commit/a15bd0bfc20c2b2955c59450a67b6e8efe89c708 DIFF: https://github.com/llvm/llvm-project/commit/a15bd0bfc20c2b2955c59450a67b6e8efe89c708.diff L

[PATCH] D87451: add new option -mignore-xcoff-visibility

dmgreen added a comment. Hello. I added a power-pc REQUIRES clause to the new clang test here in a15bd0bfc20c2b2955c59450a67b6e8efe89c708 . Hope that looks OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. *ping* Any objections to this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:139 + + switch (E->getStmtClass()) { + case Stmt::UnaryOperatorClass: { sepavloff wrote: > Actually this is not correct, because subclass relations are not preserved in > this case. F

[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

aaron.ballman added a comment. In D88833#2319799 , @lebedev.ri wrote: > I think the current behavior should instead be configurable, with a way to > opt-in into weaker guarantees. I think that's a good idea, thank you! Repository: rG LLVM Github Mono

[clang] 3cc1f1f - [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

Author: Joseph Huber Date: 2020-10-08T14:00:22-04:00 New Revision: 3cc1f1fc1d97952136185f4eafb827694875de17 URL: https://github.com/llvm/llvm-project/commit/3cc1f1fc1d97952136185f4eafb827694875de17 DIFF: https://github.com/llvm/llvm-project/commit/3cc1f1fc1d97952136185f4eafb827694875de17.diff

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

leonardchan added a comment. To what extent does the IR change? My only concern is the right codegen is still produced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88936/new/ https://reviews.llvm.org/D88936 _

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

aeubanks added a comment. diff for hwasan + -O1: 14a15 > @__hwasan_shadow = external global [0 x i8] 72a74,109 > declare void @__hwasan_loadN(i64, i64) > > declare void @__hwasan_load1(i64) > > declare void @__hwasan_load2(i64) > > declare void @__hwasan_load4(i64) > > declare void @__hwasan_l

[libunwind] 504bc07 - [runtimes] Use int main(int, char**) consistently in tests

Author: Louis Dionne Date: 2020-10-08T14:28:13-04:00 New Revision: 504bc07d1afc7bad7b980a977141696ec8298e7e URL: https://github.com/llvm/llvm-project/commit/504bc07d1afc7bad7b980a977141696ec8298e7e DIFF: https://github.com/llvm/llvm-project/commit/504bc07d1afc7bad7b980a977141696ec8298e7e.diff

[PATCH] D88936: [HWAsan][NewPM] Handle hwasan like other sanitizers

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. I see. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88936/new/ https://reviews.llvm.org/D88936

[PATCH] D88314: Added llvm-string-referencing check

aaron.ballman added a comment. Thank you for working on this check! Have you run the check over LLVM to see how much it reports? One of the concerns I have with this is that it's not always appropriate to replace a `const std::string&` with an `llvm::StringRef` and so I'm wondering what the "fa

  1   2   >