kpn added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:139 + + switch (E->getStmtClass()) { + case Stmt::UnaryOperatorClass: { ---------------- sepavloff wrote: > Actually this is not correct, because subclass relations are not preserved in > this case. For instance, `CompounsAssignmentOperator` is not handled, as it > does not return `BinaryOperatorClass`. > > I would recommend using `Expr::getFPFeaturesInEffect` or adding similar > method. That's much cleaner. Sorry I missed that earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88913/new/ https://reviews.llvm.org/D88913 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits