[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 292416. gamesh411 marked 2 inline comments as done. gamesh411 added a comment. Add abort and terminate handling Extend tests to cover every exit functions Extract matcher bind labels Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. In D86660#2278025 , @shafik wrote: > We are going to move forward with this approach (after dealing with the > multi-dimensional array case) temporar

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 marked 13 inline comments as done. gamesh411 added a comment. Note that there are no negative test cases that assert that we do NOT report in case a custom or an anonymous namespace is used. For that I would need a small patch in the testing infrastructure. Patch needed in check_clang_

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 292419. gamesh411 added a comment. Reformat diagnostic message Use explicit name longjmp instead of jump function Fix liberal auto inside Collector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ htt

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

aaronpuchert added a comment. In D87629#2278383 , @ajtowns wrote: > Not sure the `try { AssertHeld } catch (...) { a = 0; }` example reveals very > much: it seems like thread safety annotations aren't checked within a catch > block at all? > > Mutex m;

[PATCH] D87815: [clang] Fix a typo-correction crash

hokein created this revision. hokein added a reviewer: rsmith. Herald added a project: clang. hokein requested review of this revision. We leave a dangling TypoExpr when typo-correction is performed successfully in `checkArgsForPlaceholders`, which leads a crash in the later TypoCorrection. This

[PATCH] D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

awarzynski created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. awarzynski requested review of this revision. As per the documentation, the 2nd argument in printDiagnosticMessage should be a bool that specifies whether the underlying message is a continuati

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

vlebourl added a comment. Very interested in this one as well! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D26418/new/ https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage

sanwou01 accepted this revision. sanwou01 added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this! Could you wait a day or two before committing to allow others to comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

arichardson added a comment. Maybe add another test that checks for the @__cxx_global_var_init() constructor function? E.g. something like this: int init_func(int arg) { return arg + 1; } int my_global = init_func(2); Comment at: llvm/utils/update_cc_test_check

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

arichardson added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:331 +# are ordered by prefix instead of by function as in "normal" +# mode. +if '-emit-llvm' in clang_args: jdoerfert wrote: > This is all unfor

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro added a comment. In D87615#2278002 , @joerg wrote: > I'm still curious about the source of the vptr diff, but that's a minor > question, otherwise. LGTM Thanks. I think I've found what's going on here: the memory ranges are ultimately printed by `co

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro added a comment. In D87615#2278436 , @MaskRay wrote: >> This patch avoid the issue by defaulting to -mstackrealign, just like gcc. > > This sentence from the description should be removed. Sure: I usually review and eventually update the description on

[PATCH] D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function

curdeius added a comment. LGTM. Don't we risk any other side effects? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87291/new/ https://reviews.llvm.org/D87291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9cbe5cf30e3: [X86] Fix stack alignment on 32-bit Solaris/x86 (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87615/new/ https://reviews.llv

[clang] 9218f92 - [clang][aarch64] ACLE: Support implicit casts between GNU and SVE vectors

Author: Cullen Rhodes Date: 2020-09-17T09:35:30Z New Revision: 9218f9283802b2d1ff33c490761fdb925b1e56d9 URL: https://github.com/llvm/llvm-project/commit/9218f9283802b2d1ff33c490761fdb925b1e56d9 DIFF: https://github.com/llvm/llvm-project/commit/9218f9283802b2d1ff33c490761fdb925b1e56d9.diff LOG:

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

This revision was automatically updated to reflect the committed changes. Closed by commit rG9218f9283802: [clang][aarch64] ACLE: Support implicit casts between GNU and SVE vectors (authored by c-rhodes). Changed prior to commit: https://reviews.llvm.org/D87607?vs=292162&id=292441#toc Reposito

[PATCH] D87820: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Prior to this change `createTree` could not create arbitrary syntax trees. Now it dispatches to the constr

[PATCH] D87820: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use

eduucaldas updated this revision to Diff 292444. eduucaldas edited the summary of this revision. eduucaldas added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87820/new/ https://reviews.llvm.org/D87820 Files: clang/includ

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, mibintc, kpn. Herald added a project: clang. sepavloff requested review of this revision. The change implements evaluation of constant floating point expressions under non-default rounding modes. The main objective was t

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

DavidSpickett updated this revision to Diff 292454. DavidSpickett added a comment. Updated to fix all the vqmovun that have incorrect types. I'm working on a test specifically for intrinic types, using the function pointer idea. That will be a seperate change. Repository: rG LLVM Github Monor

[PATCH] D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function

MyDeveloperDay added a comment. In D87291#2278743 , @curdeius wrote: > LGTM. > Don't we risk any other side effects? There could be, but maybe we can address them as we see them. The original reason for including this was so that the Linux kernel could u

[PATCH] D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl

ro created this revision. ro added reviewers: JonasToth, aaron.ballman. ro added a project: clang. Herald added subscribers: usaxena95, kadircet, fedor.sergeev, jyknight. ro requested review of this revision. Herald added a subscriber: ilya-biryukov. D87588 broke

[PATCH] D87588: [ASTMatchers] extract public matchers from const-analysis into own patch

ro added a comment. As described in D87825 , this patch broke `Debug` builds on `sparcv9-sun-solaris2.11` and `amd64-pc-solaris2.11`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87588/new/ https://reviews.llvm.or

[PATCH] D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. SGTM, that's a pretty traditional issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87825/new/ https://reviews.llvm.org/D87825 _

[PATCH] D87825: [ASTMatchers] Define clang::ast_matchers::decompositionDecl

ro abandoned this revision. ro added a comment. Just found this had already been fixed in commit f0546173fa4bdde03ecb21a174fcaa8a6490adbd . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

hans added a comment. In D31413#2277085 , @sbc100 wrote: > Might even be worth backporting such as simple but useful fix to the 11 > release? I think it's too late in the process for that. Might be a good candidate for 11.0.1 though. Repository: rG

[clang] 40e771c - [clang-format][regression][PR47461] ifdef causes catch to be seen as a function

Author: mydeveloperday Date: 2020-09-17T13:23:06+01:00 New Revision: 40e771c1c0d33c687230111271060c2ba761269f URL: https://github.com/llvm/llvm-project/commit/40e771c1c0d33c687230111271060c2ba761269f DIFF: https://github.com/llvm/llvm-project/commit/40e771c1c0d33c687230111271060c2ba761269f.diff

[PATCH] D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function

This revision was automatically updated to reflect the committed changes. Closed by commit rG40e771c1c0d3: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added subscribers: trasz, dim, jrtc27. jrtc27 added a comment. Herald added a subscriber: dang. This has significantly regressed FreeBSD's performance with the new version of Clang. It seems Clang does not inline functions at -O1, unlike GCC, and since FreeBSD currently compiles its kerne

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 292469. djtodoro added a comment. - Rebasing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/includ

[clang] 788c7d2 - [clang][docs] Fix documentation of -O

Author: Jessica Clarke Date: 2020-09-17T13:44:01+01:00 New Revision: 788c7d2ec11dfc868a5b03478c922dc9699c6d47 URL: https://github.com/llvm/llvm-project/commit/788c7d2ec11dfc868a5b03478c922dc9699c6d47 DIFF: https://github.com/llvm/llvm-project/commit/788c7d2ec11dfc868a5b03478c922dc9699c6d47.diff

[PATCH] D84414: [RISCV] Support Shadow Call Stack

asb accepted this revision. asb added a comment. I think once @jrtc27 confirms all her issues are addressed this is good to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84414/new/ https://reviews.llvm.org/D84414

[PATCH] D84414: [RISCV] Support Shadow Call Stack

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. Yes I think everything's been addressed now (though if I keep looking over it I might start nit-picking even more :)). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

aganea added a subscriber: rnk. aganea added a comment. Please install & run `git clang-format` before uploading the patch. Comment at: clang/include/clang/Driver/Distro.h:27 +// Special value means that no detection was performed yet. +UninitializedDistro = -1, //

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

aaron.ballman added a comment. In D31413#2277985 , @ldionne wrote: > In D31413#2277630 , @smeenai wrote: > >> What was the conclusion for the comments about the priority level (100 vs. >> 101)? > > My understanding

[PATCH] D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks

ABataev added a comment. In D84470#2277991 , @ronlieb wrote: > The latest patch applied cleanly to our downstream port. > builds fine, tests very nicely as well. All the failing SOLLVE task wait > depend tests now pass. Could you accept it then? Reposi

[PATCH] D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks

ronlieb accepted this revision. ronlieb added a comment. This revision is now accepted and ready to land. accepted. not sure if there were any outstanding comments from Johannes. your call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84470/new/ h

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2179 +def SwiftNewType : InheritableAttr { + let Spellings = [GNU<"swift_newtype">, GNU<"swift_wrapper">]; + let Args = [EnumArgument<"NewtypeKind", "NewtypeKind", compnerd wrote

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1123-1124 + "abs", Summary(ArgTypes{IntTy}, RetType{IntTy}, EvalCallAsPure) + .Case({ArgumentCondition(0, WithinRange, SingleValue(0)), +

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3582 + +The parameter takes the single string representation of the Swift function name. +The name may be a compound Swift name. For a type, enum constant, property, or The p

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

gamesh411 created this revision. Herald added subscribers: cfe-commits, martong, steakhal, Szelethus, dkrupp, xazax.hun, whisperity. Herald added a project: clang. gamesh411 requested review of this revision. Currently there is no way to assert that a check does not produce warnings for a specif

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

gamesh411 updated this revision to Diff 292485. gamesh411 added a comment. Update commit msg with example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87830/new/ https://reviews.llvm.org/D87830 Files: clang-tools-extra/test/clang-tidy/check_cla

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

gamesh411 updated this revision to Diff 292487. gamesh411 added a comment. Tidy up commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87830/new/ https://reviews.llvm.org/D87830 Files: clang-tools-extra/test/clang-tidy/check_clang_tidy.

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

gamesh411 updated this revision to Diff 292488. gamesh411 added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83717/new/ https://reviews.llvm.org/D83717 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

aaron.ballman added a comment. One of the concerns I have with this not being a flow-sensitive check is that most of the bad situations are not going to be caught by the clang-tidy version of the check. The CERT rules show contrived code examples, but the more frequent issue looks like: void

[PATCH] D87812: [FPEnv] Use typed accessors in FPOptions

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. LGTM - thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87812/new/ https://reviews.llvm.org/D87812 __

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2189 + let Subjects = + SubjectList<[Enum, Function, Struct, TypedefName, + ObjCClassMethod, ObjCInstanceMethod, ObjCInterface, ObjCProperty, ObjCProtocol], ---

[PATCH] D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind

kbobyrev created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87831 Files: clang-tools-extra/clangd/Semant

[PATCH] D78305: [NFC] Rename Sema.FPFeatures to CurFPFeatures and accessor to getCurFPFeatures

mibintc abandoned this revision. mibintc added a comment. not needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78305/new/ https://reviews.llvm.org/D78305 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

mcarrasco marked an inline comment as done. mcarrasco added a comment. Great! Thanks a lot for your answer @jroelofs !! Then, do you think this current proposal to BareMetal.cpp is enough? Best, Manuel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/ https://reviews.llvm.org

[PATCH] D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind

riccibruno added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:99 +PPKeywordKind getPPKeywordFromSpelling(const std::string &Name); + A string is expensive here and unneeded. Why not a `StringRef`? Comment at: clang/lib/

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

ldionne added a comment. In D31413#2279182 , @aaron.ballman wrote: > Yes, and the way I would handle this is to change the `init_priority` value > checking to allow values <= 100 if the attribute location is within a system > header. This would allow li

[clang] d5ce823 - [OpenMP 5.0] Fix user-defined mapper privatization in tasks

Author: Alexey Bataev Date: 2020-09-17T11:21:10-04:00 New Revision: d5ce8233bfcfdeb66c715a1def8e0b34d236d48a URL: https://github.com/llvm/llvm-project/commit/d5ce8233bfcfdeb66c715a1def8e0b34d236d48a DIFF: https://github.com/llvm/llvm-project/commit/d5ce8233bfcfdeb66c715a1def8e0b34d236d48a.diff

[PATCH] D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5ce8233bfcf: [OpenMP 5.0] Fix user-defined mapper privatization in tasks (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 40df06c - [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

Author: Yaxun (Sam) Liu Date: 2020-09-17T11:30:42-04:00 New Revision: 40df06cdafc010002fc9cfe1dda73d689b7d27a6 URL: https://github.com/llvm/llvm-project/commit/40df06cdafc010002fc9cfe1dda73d689b7d27a6 DIFF: https://github.com/llvm/llvm-project/commit/40df06cdafc010002fc9cfe1dda73d689b7d27a6.dif

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG40df06cdafc0: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions (authored by yaxunl). Herald added a project: clang. Changed prior to

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

aaron.ballman added a comment. In D31413#2279404 , @ldionne wrote: > In D31413#2279182 , @aaron.ballman > wrote: > >> Yes, and the way I would handle this is to change the `init_priority` value >> checking to allo

[PATCH] D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:167 + struct StyleBlock { +// List of namespaces that should not appear in "using" declarations. +std::vector> FullyQualifiedNamespaces; sammccall wrote: > Can we describ

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Yeah, this should do what you're after. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/ https://reviews.llvm.org/D87164

[PATCH] D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces.

adamcz updated this revision to Diff 292521. adamcz marked 5 inline comments as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87775/new/ https://reviews.llvm.org/D87775 Files: clang-tools-e

[clang-tools-extra] 7f1f89e - Fix build failure in clangd

Author: Yaxun (Sam) Liu Date: 2020-09-17T11:51:09-04:00 New Revision: 7f1f89ec8d9944559042bb6d3b1132eabe3409de URL: https://github.com/llvm/llvm-project/commit/7f1f89ec8d9944559042bb6d3b1132eabe3409de DIFF: https://github.com/llvm/llvm-project/commit/7f1f89ec8d9944559042bb6d3b1132eabe3409de.dif

[PATCH] D87837: [Driver] Remove the deprecation warning for -fuse-ld=/abs/path

MaskRay created this revision. MaskRay added reviewers: chandlerc, hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay requested review of this revision. The feature has been used in the widespread build system Bazel https://github.com/bazelbuild/bazel/commit/cdd0c

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 292533. Xiangling_L added a comment. Fix the PragmaStack is empty assertion failure when we do: #pragma pack(2) then #pragma align(reset) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files: clang/i

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L updated this revision to Diff 292537. Xiangling_L added a comment. Rebased on the pragma/pack patch; Added packed related testcase for bitfield; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/ https://reviews.llvm.org/D87029 Files: clang/lib/AST/RecordLayoutBuild

[clang] 1e19165 - [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use

Author: Eduardo Caldas Date: 2020-09-17T16:09:35Z New Revision: 1e19165bd89db6671a80e0b25b32d5c7ae79455c URL: https://github.com/llvm/llvm-project/commit/1e19165bd89db6671a80e0b25b32d5c7ae79455c DIFF: https://github.com/llvm/llvm-project/commit/1e19165bd89db6671a80e0b25b32d5c7ae79455c.diff LOG

[PATCH] D87820: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e19165bd89d: [SyntaxTree][Synthesis] Fix allocation in `createTree` for more general use (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

eduucaldas updated this revision to Diff 292539. eduucaldas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87749/new/ https://reviews.llvm.org/D87749 Files: clang/include/clang/Tooling/Syntax/BuildTree.h clang/lib/Toolin

[PATCH] D85685: Support dwarf fission for wasm object files

aardappel added inline comments. Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1313 + } + return writeOneObject(Asm, Layout, DwoMode::AllSections); +} Nit picking on this because I can't find anything else to complain about: This line would be more readable insi

[clang] e09107a - [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

Author: Raul Tambre Date: 2020-09-17T19:28:57+03:00 New Revision: e09107ab80dced55414fa458cf78e6cdfe90da6e URL: https://github.com/llvm/llvm-project/commit/e09107ab80dced55414fa458cf78e6cdfe90da6e DIFF: https://github.com/llvm/llvm-project/commit/e09107ab80dced55414fa458cf78e6cdfe90da6e.diff L

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe09107ab80dc: [Sema] Introduce BuiltinAttr, per-declaration builti

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd marked 11 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3977 +// Swift attributes. +def warn_attr_swift_name_function aaron.ballman wrote: > I want to make sure we're clear with th

[PATCH] D87839: [SyntaxTree] Test the List API

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87839 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/unittests/Toolin

[PATCH] D87839: [SyntaxTree] Test the List API

eduucaldas updated this revision to Diff 292547. eduucaldas added a comment. Apply arc lint patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87839/new/ https://reviews.llvm.org/D87839 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/u

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd updated this revision to Diff 292548. compnerd marked 2 inline comments as done. compnerd added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87534/new/ https://reviews.llvm.org/D87534 Files: clang/include/cl

[PATCH] D87785: [analyzer][StdLibraryFunctionsChecker] Fix a BufferSize constraint crash

martong updated this revision to Diff 292550. martong added a comment. - apply -> assume, Add isApplicable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87785/new/ https://reviews.llvm.org/D87785 Files: clang/lib/StaticAnalyzer/Checkers/StdLibra

[PATCH] D87785: [analyzer][StdLibraryFunctionsChecker] Fix a BufferSize constraint crash

martong added a comment. Alright, I refactored the change a bit. A Constraint::assume works similarly to an engine DualAssume. Plus I added `isApplicable` to check if it is meaningful to call the assume at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

hctim added a comment. Looks like this patch broke the MSan buildbots, PTAL (repro instructions https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild): http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/46239/steps/check-clang%20msan/logs/stdio FAIL: Clang ::

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

tra added a comment. Apparently this patch triggers compiler crashes on some of our code. I'll try to create a reproducer, but it would be great to revert the patch for now. *** SIGSEGV (@0x7f68892d8fe8), received by PID 8210 (TID 8225) on cpu 65; stack trace: *** PC: @ 0x7f686d8a169d

[PATCH] D87095: [Triple][MachO] Define "arm64e", an AArch64 subarch for Pointer Auth.

ab updated this revision to Diff 292557. ab added a comment. Herald added a subscriber: pzheng. Reformat ValidArchs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87095/new/ https://reviews.llvm.org/D87095 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Driver/ToolChain.cpp

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

rnk added inline comments. Comment at: clang/lib/Driver/Distro.cpp:205 +const llvm::Triple &TargetOrHost) { + static Distro::DistroType Type = Distro::UninitializedDistro; + aganea wrote: > I'm not sure if this is safe. @rnk D

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279045 , @jrtc27 wrote: > This has significantly regressed FreeBSD's performance with the new version > of Clang. It seems Clang does not inline functions at -O1, unlike GCC, and > since FreeBSD currently compiles it

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279812 , @Bdragon28 wrote: > In D79916#2279045 , @jrtc27 wrote: > >> This has significantly regressed FreeBSD's performance with the new version >> of Clang. It seems Clang does n

[PATCH] D87187: [Driver] Perform Linux distribution detection just once

rnk added inline comments. Comment at: clang/lib/Driver/Distro.cpp:205 +const llvm::Triple &TargetOrHost) { + static Distro::DistroType Type = Distro::UninitializedDistro; + rnk wrote: > aganea wrote: > > I'm not sure if this

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

tra added a comment. In D87791#2278417 , @yaxunl wrote: > Therefore in either case there is no need to rename the intermediate .o files > since they are temporary files which have unique names. > > The .dwo files are not temporary files. They are supposed

[clang-tools-extra] 772bd8a - Revert "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions"

Author: Yaxun (Sam) Liu Date: 2020-09-17T13:55:31-04:00 New Revision: 772bd8a7d99b8db899f594d393986e4b6cd85aa1 URL: https://github.com/llvm/llvm-project/commit/772bd8a7d99b8db899f594d393986e4b6cd85aa1 DIFF: https://github.com/llvm/llvm-project/commit/772bd8a7d99b8db899f594d393986e4b6cd85aa1.dif

[clang] 829d14e - Revert "[NFC] Refactor DiagnosticBuilder and PartialDiagnostic"

Author: Yaxun (Sam) Liu Date: 2020-09-17T13:56:09-04:00 New Revision: 829d14ee0a6aa79c89f7f3d9fcd9d27d3efd2b91 URL: https://github.com/llvm/llvm-project/commit/829d14ee0a6aa79c89f7f3d9fcd9d27d3efd2b91 DIFF: https://github.com/llvm/llvm-project/commit/829d14ee0a6aa79c89f7f3d9fcd9d27d3efd2b91.dif

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

yaxunl added a comment. In D84364#2279684 , @hctim wrote: > Looks like this patch broke the MSan buildbots, PTAL (repro instructions > https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild): > > http://lab.llvm.org:8011/builders/sanitizer-x

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

tra added a comment. In D84362#2279688 , @tra wrote: > Apparently this patch triggers compiler crashes on some of our code. I'll try > to create a reproducer, but it would be great to revert the patch for now. It's likely the same issue as the one report

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279816 , @jrtc27 wrote: > In D79916#2279812 , @Bdragon28 wrote: > >> In D79916#2279045 , @jrtc27 wrote: >> >>> This has significantly re

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

yaxunl marked an inline comment as done. yaxunl added a comment. In D87791#2279821 , @tra wrote: > In D87791#2278417 , @yaxunl wrote: > >> Therefore in either case there is no need to rename the intermediate .o >>

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279863 , @Bdragon28 wrote: > In D79916#2279816 , @jrtc27 wrote: > >> In D79916#2279812 , @Bdragon28 >> wrote: >> >>> In D79916#2279045

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279863 , @Bdragon28 wrote: > In D79916#2279816 , @jrtc27 wrote: > >> In D79916#2279812 , @Bdragon28 >> wrote: >> >>> In D79916#2279045

[PATCH] D79916: Map -O to -O1 instead of -O2

Bdragon28 added a comment. In D79916#2279866 , @jrtc27 wrote: > In D79916#2279863 , @Bdragon28 wrote: > >> In D79916#2279816 , @jrtc27 wrote: >> >>> In D79916#2279812

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. (and FreeBSD has an `__always_inline` in sys/sys/cdef.s like `__inline`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79916/new/ https://reviews.llvm.org/D79916 ___ cfe-commits m

Re: [clang] 829d14e - Revert "[NFC] Refactor DiagnosticBuilder and PartialDiagnostic"

On Thu, Sep 17, 2020 at 8:57 PM Yaxun Liu via cfe-commits wrote: > > > Author: Yaxun (Sam) Liu > Date: 2020-09-17T13:56:09-04:00 > New Revision: 829d14ee0a6aa79c89f7f3d9fcd9d27d3efd2b91 > > URL: > https://github.com/llvm/llvm-project/commit/829d14ee0a6aa79c89f7f3d9fcd9d27d3efd2b91 > DIFF: > http

Re: [clang-tools-extra] 772bd8a - Revert "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions"

Same comment about commit message, thanks On Thu, Sep 17, 2020 at 8:56 PM Yaxun Liu via cfe-commits wrote: > > > Author: Yaxun (Sam) Liu > Date: 2020-09-17T13:55:31-04:00 > New Revision: 772bd8a7d99b8db899f594d393986e4b6cd85aa1 > > URL: > https://github.com/llvm/llvm-project/commit/772bd8a7d99b8

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279871 , @Bdragon28 wrote: > In D79916#2279866 , @jrtc27 wrote: > >> In D79916#2279863 , @Bdragon28 >> wrote: >> >>> In D79916#2279816

RE: [clang] 829d14e - Revert "[NFC] Refactor DiagnosticBuilder and PartialDiagnostic"

[AMD Public Use] It was reverted because it caused regressions in some CUDA apps. Is there a way for me to modify the commit message? Thanks. Sam -Original Message- From: Roman Lebedev Sent: Thursday, September 17, 2020 2:14 PM To: Liu, Yaxun (Sam) ; Yaxun Liu Cc: cfe-commits@lists.

[PATCH] D79916: Map -O to -O1 instead of -O2

jrtc27 added a comment. In D79916#2279875 , @jrtc27 wrote: > In D79916#2279871 , @Bdragon28 wrote: > >> In D79916#2279866 , @jrtc27 wrote: >> >>> In D79916#2279863

  1   2   >