[PATCH] D87737: Add -fprofile-update={atomic,prefer-atomic,single}

MaskRay added a comment. I think an interesting extension (not in GCC) is `-fprofile-update=set`, a boolean counter like `-covermode set` in go: sometimes we don't need the numbers at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87737/new/

[PATCH] D87710: [clangd] Actually parse Index section of the YAML file.

sammccall accepted this revision. sammccall added a subscriber: hans. sammccall added a comment. This revision is now accepted and ready to land. Argh, sorry. I think this might be too late to get into 11 - we're in the "soon=final" stage and maybe any changes at all cause logistical problems? :-

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

sammccall accepted this revision. sammccall added a comment. Thanks, this seems better than crashing. The practical result isn't wonderful: the two are going to fight over index files to some extent. But this can happen with different clangd versions (that use different index format versions) an

[PATCH] D87745: [clangd] Config: handle Index block

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. ArcsinX requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Without this patch config parser ignores `Index` block and repor

[PATCH] D87745: [clangd] Config: handle Index block

ArcsinX abandoned this revision. ArcsinX added a comment. Sorry, it's already here https://reviews.llvm.org/D87710 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87745/new/ https://reviews.llvm.org/D87745 ___

[PATCH] D86137: Add ignore-unknown-options flag to clang-format.

grimar accepted this revision. grimar added a comment. This revision is now accepted and ready to land. LGTM. It worth wainting for a second approvement and/or other comments to verify that people are happy with doing this for `clang-format`. Comment at: clang/unittests/Format

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd427df6369f1: [clangd] Don't use zlib when it's unavailable. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] d427df6 - [clangd] Don't use zlib when it's unavailable.

Author: Aleksandr Platonov Date: 2020-09-16T11:05:18+03:00 New Revision: d427df6369f1d229a9f498b4dc621433ada380d2 URL: https://github.com/llvm/llvm-project/commit/d427df6369f1d229a9f498b4dc621433ada380d2 DIFF: https://github.com/llvm/llvm-project/commit/d427df6369f1d229a9f498b4dc621433ada380d2.

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 292130. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address another round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files:

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:234 + LastStatus.getLastModificationTime(), Status->getLastModificationTime()); + std::unique_ptr NewIndex = loadIndex(IndexPath); + if (!NewIndex) { kadi

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 292131. kbobyrev added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files: clang-tools-extra/clangd/index/remote/server/Server.cpp Ind

[PATCH] D87686: [clang-tidy] Improve documentation on Clangd integration

sammccall added a comment. Thanks for doing this! (Agree with Haojian's comments too) Comment at: clang-tools-extra/docs/clang-tidy/Integrations.rst:10 Apart from being a standalone tool, :program:`clang-tidy` is integrated into -various IDEs, code analyzers, and editors. Besi

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

sammccall added a comment. We should check if the mangling matches GCC (or if it depends on -std), if we can. Comment at: clang/lib/AST/Type.cpp:3429 toTypeDependence(E->getDependence()) | - (E->isInstantiationDependent() ? TypeDependence::Dependent -

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:234 + LastStatus.getLastModificationTime(), Status->getLastModificationTime()); + std::unique_ptr NewIndex = loadIndex(IndexPath); + if (!NewIndex) { kbob

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

hans accepted this revision. hans added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87749 Files: clang/include/clang/Tooli

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 292144. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Save last status to prevent redundant updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:234 + LastStatus.getLastModificationTime(), Status->getLastModificationTime()); + std::unique_ptr NewIndex = loadIndex(IndexPath); + if (!NewIndex) { kadi

[PATCH] D87749: [SyntaxTree][Synthesis] Implement `deepCopy`

eduucaldas updated this revision to Diff 292145. eduucaldas added a comment. Remove extraneous qualifiers in `createTree` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87749/new/ https://reviews.llvm.org/D87749 Files: clang/include/clang/Tooling

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:342 + HotReloadThread.join(); } kbobyrev wrote: > kadircet wrote: > >

[PATCH] D87686: [clang-tidy] Improve documentation on Clangd integration

kbobyrev updated this revision to Diff 292149. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87686/new/ https://reviews.llvm.org/D87686 Files: clang-to

[clang-tools-extra] 3a0a2a6 - [clangd] Implement hot index reloading for clangd-index-server

Author: Kirill Bobyrev Date: 2020-09-16T11:12:14+02:00 New Revision: 3a0a2a6347f5a79ebfba2cc2b763dd02001d9baa URL: https://github.com/llvm/llvm-project/commit/3a0a2a6347f5a79ebfba2cc2b763dd02001d9baa DIFF: https://github.com/llvm/llvm-project/commit/3a0a2a6347f5a79ebfba2cc2b763dd02001d9baa.diff

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a0a2a6347f5: [clangd] Implement hot index reloading for clangd-index-server (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware updated this revision to Diff 292151. baloghadamsoftware added a comment. `std::size_t` defined correctly in the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87683/new/ https://reviews.llvm.org/D87683 Files: clang-tools-extra/clang-tidy/bugprone/MisplacedP

[PATCH] D87710: [clangd] Actually parse Index section of the YAML file.

hans added a comment. In D87710#2275933 , @sammccall wrote: > Argh, sorry. I think this might be too late to get into 11 - we're in the > "soon=final" stage and maybe any changes at all cause logistical problems? :-( > > @hans to confirm - this is a featu

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

c-rhodes added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8522 + return VT->getElementType().getCanonicalType() == + getBuiltinVectorTypeInfo(BT).ElementType; } efriedma wrote: > c-rhodes wrote: > > efriedma wrote: >

[PATCH] D87686: [clang-tidy] Improve documentation on Clangd integration

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87686/new/ https://reviews.llvm.org/D87686 __

[clang-tools-extra] a909a84 - [clang-tidy] Improve documentation on Clangd integration

Author: Kirill Bobyrev Date: 2020-09-16T12:10:00+02:00 New Revision: a909a84ef2d9220242512b8be1206ee3d9b3d8b9 URL: https://github.com/llvm/llvm-project/commit/a909a84ef2d9220242512b8be1206ee3d9b3d8b9 DIFF: https://github.com/llvm/llvm-project/commit/a909a84ef2d9220242512b8be1206ee3d9b3d8b9.diff

[PATCH] D87686: [clang-tidy] Improve documentation on Clangd integration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa909a84ef2d9: [clang-tidy] Improve documentation on Clangd integration (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

c-rhodes updated this revision to Diff 292162. c-rhodes added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87607/new/ https://reviews.llvm.org/D87607 Files: clang/lib/AST/ASTContext.cpp clang/test/CodeGen/attr-arm-sve-vector-bits-cast.c clang/test/Sem

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

c-rhodes added inline comments. Comment at: clang/test/Sema/attr-arm-sve-vector-bits.c:237 +// Test implicit conversion between SVE and GNU vector is invalid when +// __ARM_FEATURE_SVE_BITS != N +#if defined(__ARM_FEATURE_SVE_BITS) && __ARM_FEATURE_SVE_BITS == 512 ---

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

sylvestre.ledru added a comment. Thanks for this checker. FYI, it found (at least) 3 defects in Firefox code: https://hg.mozilla.org/mozilla-central/rev/651e68f628d0 https://bugzilla.mozilla.org/show_bug.cgi?id=1664747 (unlikely that it was causing any actual bugs in the product) Repository:

[clang-tools-extra] 3e5a4ef - Fix table formatting after D87686

Author: Kirill Bobyrev Date: 2020-09-16T12:27:59+02:00 New Revision: 3e5a4ef51a1d0def10525b2059f5cdab0cb0ae8d URL: https://github.com/llvm/llvm-project/commit/3e5a4ef51a1d0def10525b2059f5cdab0cb0ae8d DIFF: https://github.com/llvm/llvm-project/commit/3e5a4ef51a1d0def10525b2059f5cdab0cb0ae8d.diff

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

baloghadamsoftware updated this revision to Diff 292170. baloghadamsoftware added a comment. Checker `modernize-use-equals-delete` adjusted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87527/new/ https://reviews.llvm.org/D87527 Files: clang-tools-extra/clang-tidy/modernize/UseEqual

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro updated this revision to Diff 292153. ro added a comment. - Rely on `stackAlignment` default for 32-bit Solaris/x86 - Handle Solaris in `llvm/test/CodeGen/X86/stack-align2.ll` Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

ro added a comment. In D87615#2275045 , @efriedma wrote: > Also, it would be nice to have some regression test coverage; add a Solaris > RUN line to llvm/test/CodeGen/X86/stack-align2.ll ? Sure, done in the updated patch. I'd checked that if `FAIL`s wit

[PATCH] D87710: [clangd] Actually parse Index section of the YAML file.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7029e5d4ca20: [clangd] Actually parse Index section of the YAML file. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang-tools-extra] 7029e5d - [clangd] Actually parse Index section of the YAML file.

Author: Adam Czachorowski Date: 2020-09-16T13:11:02+02:00 New Revision: 7029e5d4ca20d20982da8efe89de27acd8d7d75b URL: https://github.com/llvm/llvm-project/commit/7029e5d4ca20d20982da8efe89de27acd8d7d75b DIFF: https://github.com/llvm/llvm-project/commit/7029e5d4ca20d20982da8efe89de27acd8d7d75b.d

[PATCH] D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry added a comment. Thanks @MyDeveloperDay, I appreciate your input in this review. You're a good reviewer. :) Also, I think you've made some good points there and I'm going to turn this review into "non-breaking the world" one. I'll be back in a few days with a new diff. Repository: rG

[clang-tools-extra] 779a2a2 - [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc

Author: Adam Balogh Date: 2020-09-16T13:16:44+02:00 New Revision: 779a2a2edcea89ad5f5bf99eeac90516542159d9 URL: https://github.com/llvm/llvm-project/commit/779a2a2edcea89ad5f5bf99eeac90516542159d9 DIFF: https://github.com/llvm/llvm-project/commit/779a2a2edcea89ad5f5bf99eeac90516542159d9.diff L

[PATCH] D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc

This revision was automatically updated to reflect the committed changes. Closed by commit rG779a2a2edcea: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang-tools-extra] dbd45b2 - [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

Author: Adam Balogh Date: 2020-09-16T13:16:51+02:00 New Revision: dbd45b2db8e0c396fa20d4c72734c4f31f54af96 URL: https://github.com/llvm/llvm-project/commit/dbd45b2db8e0c396fa20d4c72734c4f31f54af96 DIFF: https://github.com/llvm/llvm-project/commit/dbd45b2db8e0c396fa20d4c72734c4f31f54af96.diff L

[PATCH] D87527: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl`

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbd45b2db8e0: [ASTMatchers] Fix `hasBody` for the descendants of `FunctionDecl` (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] aa1e15d - TokenAnnotator.cpp - remove useless pointer null test. NFCI.

Author: Simon Pilgrim Date: 2020-09-16T12:30:24+01:00 New Revision: aa1e15dda9e5941611f2183ba34087c2d02beb1a URL: https://github.com/llvm/llvm-project/commit/aa1e15dda9e5941611f2183ba34087c2d02beb1a DIFF: https://github.com/llvm/llvm-project/commit/aa1e15dda9e5941611f2183ba34087c2d02beb1a.diff

[clang] 439f574 - [AST] ASTReader::ReadModuleMapFileBlock - assert non-null Module. NFCI.

Author: Simon Pilgrim Date: 2020-09-16T12:30:24+01:00 New Revision: 439f5749d978acfa69f1a2d20c797c3fc0d97989 URL: https://github.com/llvm/llvm-project/commit/439f5749d978acfa69f1a2d20c797c3fc0d97989 DIFF: https://github.com/llvm/llvm-project/commit/439f5749d978acfa69f1a2d20c797c3fc0d97989.diff

[clang] 4abb5cd - CGBlocks.cpp - assert non-null CGF pointer. NFCI.

Author: Simon Pilgrim Date: 2020-09-16T12:30:24+01:00 New Revision: 4abb5cd83902f1351db473c720ee0b95ebdcb338 URL: https://github.com/llvm/llvm-project/commit/4abb5cd83902f1351db473c720ee0b95ebdcb338 DIFF: https://github.com/llvm/llvm-project/commit/4abb5cd83902f1351db473c720ee0b95ebdcb338.diff

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

sammccall added a comment. Ugh, the hole goes deeper, because the Itanium ABI unambiguously follows the C++11 (instantiation-dependent) behavior. Definitely need Richard's input here as I'm fairly sure this will break things as-is. Comment at: clang/test/CodeGenCXX/mangle-exp

[clang] f5c7102 - Update dead links to Itanium and ARM ABIs. NFC

Author: Sam McCall Date: 2020-09-16T13:42:01+02:00 New Revision: f5c7102dbc7223e98ce5c0f02b343ed92062987c URL: https://github.com/llvm/llvm-project/commit/f5c7102dbc7223e98ce5c0f02b343ed92062987c DIFF: https://github.com/llvm/llvm-project/commit/f5c7102dbc7223e98ce5c0f02b343ed92062987c.diff LO

[clang] 0a0abc0 - [Sema] isOpenMPCapturedDecl - assert we locate CapturedRegionScopeInfo. NFCI.

Author: Simon Pilgrim Date: 2020-09-16T12:42:35+01:00 New Revision: 0a0abc0ede0ff8015e30aae89a3f89c7dc5b3f0f URL: https://github.com/llvm/llvm-project/commit/0a0abc0ede0ff8015e30aae89a3f89c7dc5b3f0f DIFF: https://github.com/llvm/llvm-project/commit/0a0abc0ede0ff8015e30aae89a3f89c7dc5b3f0f.diff

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292188. usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tool

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:39 +'''Returns the header guard for the generated header.''' +return "GENERATED_DECISION_FOREST_MODEL_{}_H".format(filename.upper()) + adamcz wrote: >

[PATCH] D87352: Fix typo

MyDeveloperDay added a subscriber: arichardson. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:778 - For example: __capability. - So this is an example of where someone has changed the .rst and not the Format.h! @aric

[PATCH] D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function

MyDeveloperDay added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87291/new/ https://reviews.llvm.org/D87291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D87352: Fix typo

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd9c709ef1b: [clang-format] [NFC] Fix spelling mistake in the documentation (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8735

[clang] 4dd9c70 - [clang-format] [NFC] Fix spelling mistake in the documentation

Author: mydeveloperday Date: 2020-09-16T13:46:34+01:00 New Revision: 4dd9c709ef1b59f0ec8e71100c624ec946b95fe2 URL: https://github.com/llvm/llvm-project/commit/4dd9c709ef1b59f0ec8e71100c624ec946b95fe2 DIFF: https://github.com/llvm/llvm-project/commit/4dd9c709ef1b59f0ec8e71100c624ec946b95fe2.diff

[PATCH] D87710: [clangd] Actually parse Index section of the YAML file.

hans added a comment. Pushed to 11.x as 4a26e3b33798424dc5a4843f7b29a617bef81656 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87710/new/ https://reviews.llvm.org/D87710 _

[PATCH] D87745: [clangd] Config: handle Index block

sammccall added a comment. Thanks for catching this! Lucky coincidence it was spotted twice just before rc3! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87745/new/ https://reviews.llvm.org/D87745 ___

[PATCH] D87710: [clangd] Actually parse Index section of the YAML file.

sammccall added a comment. Thanks Hans! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87710/new/ https://reviews.llvm.org/D87710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4341c6618dec: [OPENMP]Do not allow threadprivates as base for array-like reduction. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8576

[clang] 4341c66 - [OPENMP]Do not allow threadprivates as base for array-like reduction.

Author: Alexey Bataev Date: 2020-09-16T09:30:32-04:00 New Revision: 4341c6618decb4014a167bc83aeeed49ab49b34f URL: https://github.com/llvm/llvm-project/commit/4341c6618decb4014a167bc83aeeed49ab49b34f DIFF: https://github.com/llvm/llvm-project/commit/4341c6618decb4014a167bc83aeeed49ab49b34f.diff

[PATCH] D87352: Fix typo

arichardson added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:778 - For example: __capability. - MyDeveloperDay wrote: > So this is an example of where someone has changed the .rst and not the > Format.h! @arichardson > > I recommend

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

sammccall added inline comments. Comment at: clang/test/CodeGenCXX/mangle.cpp:805 - // CHECK-LABEL: define weak_odr void @_ZN6test341fIiEEvDTstDTplcvT__EcvS1__EEE + // CHECK-LABEL: define weak_odr void @_ZN6test341fIiEEvm template void f(decltype(sizeof(1)));

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

Xiangling_L updated this revision to Diff 292207. Xiangling_L added a comment. Use default argument; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86790/new/ https://reviews.llvm.org/D86790 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/CodeGen

[PATCH] D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM

amyk added a comment. In D87729#2275667 , @Conanap wrote: > Looks like there's some unit test failures; could you double check? We discussed offline; I've tested this again afterwards and looked into failures. Unit tests failures are not a result of this

[PATCH] D87761: [clang][codegen] Skip adding default function attributes on intrinsics.

hliao created this revision. hliao added reviewers: rjmccall, tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao requested review of this revision. - After loading builtin bitcode for linking, skip adding default function attributes on LLVM intrinsics as the

[PATCH] D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation

MyDeveloperDay added a comment. In D87587#2276462 , @kuzkry wrote: > Thanks @MyDeveloperDay, I appreciate your input in this review. You're a good > reviewer. :) > Also, I think you've made some good points there and I'm going to turn this > review into

[PATCH] D87624: [SystemZ][z/OS] Set default wchar_t type for zOS

fanbo-meng accepted this revision. fanbo-meng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87624/new/ https://reviews.llvm.org/D87624 _

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

sammccall added a comment. Just some naming and doc nits. This looks really solid now, nice job! In D83814#2261458 , @jkorous wrote: > Hi @usaxena95 and @sammccall, > > I am wondering about couple high-level things. > > Do you guys intend to open-source a

[PATCH] D87624: [SystemZ][z/OS] Set default wchar_t type for zOS

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87624/new/ https://reviews.llvm.org/D87624 ___ cfe-commits maili

[clang] f054617 - [ASTMatchers] Add missing definition for decompositionDecl

Author: Benjamin Kramer Date: 2020-09-16T17:32:29+02:00 New Revision: f0546173fa4bdde03ecb21a174fcaa8a6490adbd URL: https://github.com/llvm/llvm-project/commit/f0546173fa4bdde03ecb21a174fcaa8a6490adbd DIFF: https://github.com/llvm/llvm-project/commit/f0546173fa4bdde03ecb21a174fcaa8a6490adbd.dif

[PATCH] D87451: add new clang option -mignore-xcoff-visibility

jasonliu added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2310 +.. option:: -mignore-xcoff-visibility + We should move this option to where all the other -m options resides. Comment at: clang/docs/ClangCommandLineRe

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

dmajor added a comment. In D87163#2275896 , @asbirlea wrote: > I checked in a fix in https://reviews.llvm.org/rGfc8200633122, but I haven't > yet verified it addresses all the failures reported. Thanks, I've confirmed that this fixes our tests in their o

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd marked 8 inline comments as done. compnerd added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4289 +if (Inline->getName() != Name && !Inline->isImplicit()) { + Diag(Inline->getLocation(), diag::warn_attribute_ignored) << Inline; + Diag(CI.ge

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

fanbo-meng updated this revision to Diff 292237. fanbo-meng added a comment. Herald added a reviewer: aaron.ballman. get platform name from triple instead of hardcoding, and convert its spelling CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87611/new/ https://reviews.llvm.org/D87611 Fi

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:773-774 } + +this->PlatformName = llvm::Triple::getOSTypeName(Triple.getOS());; } There is an extra semi-colon. CHANGES SINCE LAST ACTION https://review

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

fanbo-meng updated this revision to Diff 292240. fanbo-meng set the repository for this revision to rG LLVM Github Monorepo. fanbo-meng added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87611/new/ https://reviews.llvm.org/D876

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87611/new/ https://reviews.llvm.org/D87611 ___

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7216 + "aligned %select{allocation|deallocation}0 function of type '%1' is " + "%select{only|not}4 available on %2 %select{%3 or newer|}4">; def note_silence_aligned_allo

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

ldionne commandeered this revision. ldionne added a reviewer: EricWF. ldionne added a comment. Herald added subscribers: dexonsmith, jkorous. I did some work on trying to reproduce this a while ago but never got to reproducing it on macOS. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D3

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski created this revision. Herald added subscribers: cfe-commits, dang, mgorny. Herald added a reviewer: DavidTruby. Herald added a reviewer: sscalpone. Herald added a project: clang. awarzynski requested review of this revision. Currently Flang uses TextDiagnostic, TextDiagnosticPrinter &

[PATCH] D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces.

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. For style guides forbid "using

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

danielkiss updated this revision to Diff 292250. danielkiss added a comment. Rebased top of D85649 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/ https://reviews.llvm.org/D80791 Files: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp llvm/t

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd updated this revision to Diff 292253. compnerd marked an inline comment as done. compnerd added a comment. Address feedback from @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87534/new/ https://reviews.llvm.org/D87534 Files

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

ldionne updated this revision to Diff 292254. ldionne added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Added a test. I can't reproduce the issue, so I don't know whether the test is useful or not. Please help with that!

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

sbc100 accepted this revision. sbc100 added a comment. I'd love to see this land so we can drop our downstream patch in emscripten and also fix the outstanding wasi-sdk issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31413/new/ https://review

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

sbc100 added a comment. Might even be worth backporting such as simple but useful fix to the 11 release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31413/new/ https://reviews.llvm.org/D31413 ___ cfe-c

[clang] 4cff1b4 - Do not apply calling conventions to MSVC entry points

Author: Elizabeth Andrews Date: 2020-09-16T09:39:37-07:00 New Revision: 4cff1b40dacf6a5489b09657d94ea4757b8cd3b0 URL: https://github.com/llvm/llvm-project/commit/4cff1b40dacf6a5489b09657d94ea4757b8cd3b0 DIFF: https://github.com/llvm/llvm-project/commit/4cff1b40dacf6a5489b09657d94ea4757b8cd3b0.d

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cff1b40dacf: Do not apply calling conventions to MSVC entry points (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

eandrews added a comment. In D87701#2274860 , @rnk wrote: > lgtm, thanks. Thanks for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

fanbo-meng added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7216 + "aligned %select{allocation|deallocation}0 function of type '%1' is " + "%select{only|not}4 available on %2 %select{%3 or newer|}4">; def note_silence_aligned_allocation_unava

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

eastig added a comment. In D31413#2277070 , @ldionne wrote: > Added a test. I can't reproduce the issue, so I don't know whether the test > is useful or not. Please help with that! There are tests in https://reviews.llvm.org/D12689 . Repository: rG L

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

fanbo-meng updated this revision to Diff 292259. fanbo-meng added a comment. remove trailing whitespace from diagnostic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87611/new/ https://reviews.llvm.org/D87611 Files: clang/include/clang/Basic/AlignedAllocation.h clang/include/clang/

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

ldionne added a comment. In D31413#2277118 , @eastig wrote: > In D31413#2277070 , @ldionne wrote: > >> Added a test. I can't reproduce the issue, so I don't know whether the test >> is useful or not. Please help wi

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87611/new/ https://reviews.llvm.org/D87611 ___ cfe-commi

[PATCH] D87761: [clang][codegen] Skip adding default function attributes on intrinsics.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87761/new/ https://reviews.llvm.org/D87761

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

ldionne updated this revision to Diff 292261. ldionne added a comment. Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31413/new/ https://reviews.llvm.org/D31413 Files: libcxx/src/iostream.cpp libcxx/test/std/input.output/iostream.obj

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

ldionne added inline comments. Comment at: libcxx/test/std/input.output/iostream.objects/init.pass.cpp:15 +// +// This test works by checking that 'std::{cin/cout,cerr}' is the same in a +// static object constructor and in the main function. It dumps the memory of --

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39faf428164a: [libc++] Ensure streams are initialized early (autho

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

eastig added a comment. In D31413#2277133 , @ldionne wrote: > In D31413#2277118 , @eastig wrote: > >> In D31413#2277070 , @ldionne wrote: >> >>> Added a test. I can't reprodu

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

ldionne added a subscriber: hans. ldionne added a comment. @hans Is there still time to cherry-pick this to the 11 release? In D31413#2277198 , @eastig wrote: > I don't mind. > Just to check, in PR28954 it is mentioned the solution based on > 'init_prio

  1   2   3   >