kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
Thanks, LGTM! ================ Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:342 + HotReloadThread.join(); } ---------------- kbobyrev wrote: > kadircet wrote: > > kbobyrev wrote: > > > kadircet wrote: > > > > nit: `return 0;` ? > > > No need for that in C++. > > > > > > https://en.cppreference.com/w/cpp/language/main_function > > > > > > > 4) The body of the main function does not need to contain the return > > > > statement: if control reaches the end of main without encountering a > > > > return statement, the effect is that of executing `return 0;` > > right, hence the `nit` > Hm, why do you think it is better then? I'm not sure if adding no-op lines of > code will increase readability/clarity. > > I'm curious now, is there any reason you prefer explicit `return 0;`? I suppose, mostly aesthetics and being used to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
