[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb109c42d91c: [DSE] Switch to MemorySSA-backed DSE by default. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

rnk added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:383 +const NonTypeTemplateParmDecl *PD = nullptr, +QualType *TemplateArgType = nullptr); + void mangleExpression(const Expr *E, const NonTypeTemplateP

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Driver/Options.td:1992 +def fsplit_machine_functions : Flag <["-"], "fsplit-machine-functions">, + Group, Flags<[CC1Option]

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftObjCMembers : Attr { + let Spellings = [GNU<"swift_objc_members">]; aaron.ballman wrote: > Should this be inherited by redec

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

ro added a comment. Ping? It's been a week and AFAICT there's nothing left for me to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-commits mailing

[PATCH] D86621: [clang][Sparc] Default to -mcpu=v9 for SparcV8 on Solaris

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86621/new/ https://reviews.llvm.org/D86621 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

chrish_ericsson_atx added a comment. Thank you for the comments, @aaron.ballman . I'll update with the changes you requested shortly. I did have some requests for clarification of you, though. Thanks! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8841-8844

[PATCH] D87463: [clang][aarch64] Fix mangling of bfloat16 neon vectors

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. Thanks, this one crept in during mass-renaming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87463/new/ https://reviews.llvm.org/D87463

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

gribozavr2 added inline comments. Comment at: clang/test/SemaObjC/attr-swift_objc_members.m:4 +#if !__has_attribute(swift_objc_members) +#error cannot verify precense of swift_objc_members attribute +#endif compnerd wrote: > aaron.ballman wrote: > > gribozavr2 wr

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291108. snehasish added a comment. Use OptInFFlag, split-file and update tests. - Change the flag type to OptInFFlag. - Use split-file in the test to avoid "RUN: echo" lines. - Use an existing warn message (if no profile is available) and add a check for i

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish marked 3 inline comments as done. snehasish added a comment. PTAL, thanks! Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4259 options::OPT_fno_unique_basic_block_section_names, +options::OPT_fsplit_machine_functions, +options::OPT_fno_spli

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

junparser added a comment. Thanks for the change. LGTM, and testcase？ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D80409: [MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral

zequanwu updated this revision to Diff 29. zequanwu marked 2 inline comments as done. zequanwu retitled this revision from "[MS ABI] Add mangled type for auto template parameter whose argument kind is Integeral " to "[MS ABI] Add mangled type for auto template parameter whose argument kind is

Re: r364428 - Make CodeGen depend on ASTMatchers

That change was added long ago to fix the shared library build. Possibly, there are changes removing that dependency then. Just verified that removing that dependency is just fine. On Thu, Sep 10, 2020 at 6:48 AM Vassil Vassilev wrote: > > Hello, > >IIUC, clang's CodeGen does not immediately

[clang] b22d450 - Remove dependency on clangASTMatchers.

Author: Michael Liao Date: 2020-09-10T22:17:48-04:00 New Revision: b22d45049682d1461b6b786f159681e2e5c2ce24 URL: https://github.com/llvm/llvm-project/commit/b22d45049682d1461b6b786f159681e2e5c2ce24 DIFF: https://github.com/llvm/llvm-project/commit/b22d45049682d1461b6b786f159681e2e5c2ce24.diff

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu updated this revision to Diff 291118. zequanwu added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. - Address comment. - Add cl::opt to disable emitting skipped regions for empty lines and comments (used on test case only), and update test cases under

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in an hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291122. snehasish marked an inline comment as done. snehasish added a comment. Fix test formatting. Added clang-format off to disable clang format for the test which contains both profile data (as text) and c code. Repository: rG LLVM Github Monorepo

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish marked an inline comment as done. snehasish added inline comments. Comment at: clang/test/CodeGen/split-machine-functions.c:3 + +// RUN: echo "foo"> %t.proftext +// RUN: echo "# Func Hash:" >> %t.proftext snehasish wrote: > MaskRay

[libclc] 16ba78e - libclc/spirv: Add missing files from D85911

Author: Jan Vesely Date: 2020-09-10T23:41:38-04:00 New Revision: 16ba78ee627c3fe66906349e8c90ee8cc1224298 URL: https://github.com/llvm/llvm-project/commit/16ba78ee627c3fe66906349e8c90ee8cc1224298 DIFF: https://github.com/llvm/llvm-project/commit/16ba78ee627c3fe66906349e8c90ee8cc1224298.diff LO

Upcoming upgrade of LLVM buildbot

Hello everyone, The buildbot upgrade is entering the phase when the results to become visible. No change is required at this time on any of the builders. The bot owners could upgrade the buildbot on build computers later, at their convenience, as this is not on the critical path. We are going to

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind added a comment. In D87470#2267060 , @junparser wrote: > Thanks for the change. LGTM, and testcase？ Not sure how to add a test case for this though. We don't seem to explicitly test AST output. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

rjmccall added a comment. In D75574#2262622 , @lanza wrote: >> I don't think it'll actually error out at link time: protocol objects get >> emitted eagerly on use, cross-module linking is just a code-size >> optimization. This actually has caused longsta

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

rjmccall added a comment. Also LGTM with a testcase. It's fine to test the result of IRGen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 ___ cfe-commits maili

[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr

rjmccall added a comment. Follow-up on my previous request. It's fine by me if you commit with that fix. Comment at: clang/lib/Analysis/BodyFarm.cpp:188 + const_cast(Arg), nullptr, VK_RValue, + FPOptionsOverride

[PATCH] D85473: [Clang] Add option to allow marking pass-by-value args as noalias.

rjmccall added a reviewer: ahatanak. rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2198 +// reference to the underlying object. Mark it accordingly. +Attrs.addAttribute(llvm::Attribute::NoAlias); + fhahn wrote: > rjmccal

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2131 +.. option:: -fsplit-machine-functions, -fno-split-machine-functions + You don't need to edit this file. It is auto-generated from Options.td Comment at:

[PATCH] D86632: [Fixed Point] Add codegen for conversion between fixed-point and floating point.

rjmccall added inline comments. Comment at: llvm/include/llvm/IR/FixedPointBuilder.h:126 + /// \p Ty, or a floating point type with a larger exponent than Ty. + Type *getAccommodatingFloatType(Type *Ty, const FixedPointSemantics &Sema) { +const fltSemantics *FloatSema = &Ty

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind updated this revision to Diff 291140. lxfind added a comment. Add test case. Verify that the size of the frame reduced by 8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87470/new/ https://reviews.llvm.org/D87470 Files: clang/lib/Sema/Se

[PATCH] D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets.

snehasish updated this revision to Diff 290884. snehasish marked an inline comment as done. snehasish added a comment. Update test to use `not` tool and `-c` flag. - Use the not tool to indicate failure is expected. - Use -c instead of -### for failing invocations. Repository: rG LLVM Github

[PATCH] D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets.

snehasish marked 4 inline comments as done. snehasish added a comment. Thanks for explaining the rationale, PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87426/new/ https://reviews.llvm.org/D87426

[PATCH] D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87426/new/ https://reviews.llvm.org/D87426 ___

[clang] 157cd93 - [clang] Disallow fbasic-block-sections on non-ELF, non-x86 targets.

Author: Snehasish Kumar Date: 2020-09-10T00:15:33-07:00 New Revision: 157cd93b48a90f484e9eb2ed9997e0372b9c7ebb URL: https://github.com/llvm/llvm-project/commit/157cd93b48a90f484e9eb2ed9997e0372b9c7ebb DIFF: https://github.com/llvm/llvm-project/commit/157cd93b48a90f484e9eb2ed9997e0372b9c7ebb.dif

[PATCH] D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG157cd93b48a9: [clang] Disallow fbasic-block-sections on non-ELF, non-x86 targets. (authored by snehasish). Repository: rG LLVM Github Monorepo CH

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D79431#2263693 , @martong wrote: > In D79431#2263690 , @martong wrote: > >> What if we'd add a `toStri

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. In D83660#2264963 , @OikawaKirie wrote: > After reviewing the code of this snippet, I think it would be very difficult > to make a regression test case for the crash, as far as what I know about Z3 > and SMT solvers. > > First o

[PATCH] D87374: [SyntaxTree] Specialize `TreeTestBase` for `BuildTreeTest` and `MutationsTest`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/MutationsTest.cpp:48 + +TEST_P(MutationTest, Mutations) { + if (!GetParam().isCXX11OrLater()) { ==

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

martong added a comment. In D79431#2265155 , @Szelethus wrote: > In D79431#2263693 , @martong wrote: > >> In D79431#2263690 , @martong wrote: >> >>> What if we'd add a `toStr

[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

Szelethus added a comment. In D86736#2257880 , @NoQ wrote: > i'm very glad that we now consistently use expressions in our Environment. *except for `ReturnStmt`, but I haven't dug myself into that pit just yet :) Thanks! Repository: rG LLVM Github Mo

[PATCH] D87118: Add an explicit toggle for the static analyzer in clang-tidy

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87118/new/ https://reviews.llvm.org/D87118 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp updated this revision to Diff 290886. nullptr.cpp added a comment. [NFC] Fix pessimizing-move warnings due to std::move in return statements Gcc warning: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return std::move(Err);

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

baloghadamsoftware updated this revision to Diff 290917. baloghadamsoftware added a comment. Fix for base constructors, test extended. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85351/new/ https://reviews.llvm.org/D85351 Files: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp cla

[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:138-139 SVal ThisVal = State->getSVal(ThisPtr); + if (Init->isBaseInitializer() || Init->isDelegatingInitializer(

[PATCH] D82784: [clang-tidy] For `run-clang-tidy.py` do not treat `allow_enabling_alpha_checkers` as a none value.

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82784/new/ https://reviews.llvm.org/D82784 ___

[PATCH] D87338: [Driver][PGO] Driver support for de-Optimizing cold functions (PATCH 2/2)

rengolin added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2021 + +Adds ``optnone`` attributes to functions whose instrumentation-based PGO profiling counts are equal to zero (i.e. "cold"). + Following discussions in the mailing list, I

[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7586afc4dcd: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp (authored by martong). Changed prior to commit: https://reviews.llvm.org/D8

[clang] b7586af - [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

Author: Gabor Marton Date: 2020-09-10T12:29:39+02:00 New Revision: b7586afc4dcddd1abc70724585c3eb3857e27f43 URL: https://github.com/llvm/llvm-project/commit/b7586afc4dcddd1abc70724585c3eb3857e27f43 DIFF: https://github.com/llvm/llvm-project/commit/b7586afc4dcddd1abc70724585c3eb3857e27f43.diff

[clang] a97648b - [analyzer][StdLibraryFunctionsChecker] Add better diagnostics

Author: Gabor Marton Date: 2020-09-10T12:43:40+02:00 New Revision: a97648b93846f163af262b9a0db684c7f5efc43f URL: https://github.com/llvm/llvm-project/commit/a97648b93846f163af262b9a0db684c7f5efc43f DIFF: https://github.com/llvm/llvm-project/commit/a97648b93846f163af262b9a0db684c7f5efc43f.diff

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa97648b93846: [analyzer][StdLibraryFunctionsChecker] Add better diagnostics (authored by martong). Changed prior to commit: https://reviews.llvm.o

Re: r364428 - Make CodeGen depend on ASTMatchers

Hello,   IIUC, clang's CodeGen does not immediately depend on ASTMatchers. I was wondering what is the reason for inserting such a dependency to fix the shared library builds?   Can you give more details about the failure you are fixing?   Sorry for the late question. Best, Vassil On 6/26/1

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

richard.barton.arm accepted this revision. richard.barton.arm added a comment. This revision is now accepted and ready to land. This LGTM. I think all the previous comments from other reviewers and me have been dealt with so I am happy to accept this revision based on the reviews so far. I have

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

gribozavr2 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3386-3388 +The ``swift_objc_members`` attribute maps to the ``@objcMembers`` Swift +attribute, which indicates that Swift members of this class, its subclasses, and +all extensions thereof, will

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3377-3382 +def SwiftDocs : DocumentationCategory<"Controlling Swift Import"> { + let Content = [{ +Clang supports additional attributes for controlling how APIs

[clang] 576bd52 - [Codegen][X86] Move AMX specific codegen tests into X86 subfolder.

Author: Simon Pilgrim Date: 2020-09-10T12:38:23+01:00 New Revision: 576bd52f778405de08f309678e4fe4f7523bf7c4 URL: https://github.com/llvm/llvm-project/commit/576bd52f778405de08f309678e4fe4f7523bf7c4 DIFF: https://github.com/llvm/llvm-project/commit/576bd52f778405de08f309678e4fe4f7523bf7c4.diff

[clang-tools-extra] 875b853 - [clang-tidy] Fix reST syntax

Author: serge-sans-paille Date: 2020-09-10T13:56:57+02:00 New Revision: 875b8537eea0662ead820979f18c83d5e31b4b8b URL: https://github.com/llvm/llvm-project/commit/875b8537eea0662ead820979f18c83d5e31b4b8b DIFF: https://github.com/llvm/llvm-project/commit/875b8537eea0662ead820979f18c83d5e31b4b8b.d

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

nullptr.cpp updated this revision to Diff 290944. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347 Files: clang/lib/Lex/Pragma.cpp llvm/lib/Analysis/VectorUtils.cpp llvm/lib/MC/WasmObjectWriter.cpp llv

[clang] 2239882 - [CodeGen][X86] Move x86 builtin intrinsic/codegen tests into X86 subfolder.

Author: Simon Pilgrim Date: 2020-09-10T12:58:21+01:00 New Revision: 2239882f7d0e4e6d5702bc20ba071a92ec75d37c URL: https://github.com/llvm/llvm-project/commit/2239882f7d0e4e6d5702bc20ba071a92ec75d37c DIFF: https://github.com/llvm/llvm-project/commit/2239882f7d0e4e6d5702bc20ba071a92ec75d37c.diff

[PATCH] D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness

RKSimon accepted this revision. RKSimon added a comment. LGTM - I'll try to commit this later today Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87347/new/ https://reviews.llvm.org/D87347 ___ cfe-commit

[PATCH] D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time

hans added a comment. I'm not sure that changing isPotentiallyEvaluated() is the right thing to do. The meaning of that corresponds to text in the standard: https://eel.is/c++draft/expr.typeid#3 so changing it to something that doesn't match the standard exactly seems wrong. I think it would b

[clang] 05d02e5 - Fix invalid link format in Clang LanguageExtension

Author: Guillaume Chatelet Date: 2020-09-10T12:27:50Z New Revision: 05d02e5a4e54a04f050b52ee30d1860073bd8b34 URL: https://github.com/llvm/llvm-project/commit/05d02e5a4e54a04f050b52ee30d1860073bd8b34 DIFF: https://github.com/llvm/llvm-project/commit/05d02e5a4e54a04f050b52ee30d1860073bd8b34.diff

Clang-Format, Clang-Tidy - Absolute Path to config files

Hi all, I have recently started to work with Clang-Format and Clang-Tidy tools as part of a methodology project in my company. We want to have a uniform style and format in the entire department and for that we want to use the two tools to automatically keep this in order. For this we need to

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added inline comments. Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:312 switch (II->getIntrinsicID()) { default: llvm_unreachable("doesn't pass 'hasAnalyzableMemoryWrite' predicate"); case Intrinsic::lifetime_end: asbirlea

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C.

balazske created this revision. Herald added subscribers: cfe-commits, martong, phosek, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity, mgorny. Herald added a project: clang. balazske requested review of this revision. SIG30-C. Call only asynchronous-safe functions within signal handlers Fi

[PATCH] D87374: [SyntaxTree] Specialize `TreeTestBase` for `BuildTreeTest` and `MutationsTest`

eduucaldas updated this revision to Diff 290951. eduucaldas marked 3 inline comments as done. eduucaldas added a comment. - `MutationsTest`: Split tests and infrastructure - `SynthesisTest`: Split tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D87374: [SyntaxTree] Specialize `TreeTestBase` for `BuildTreeTest` and `MutationsTest`

eduucaldas updated this revision to Diff 290952. eduucaldas added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87374/new/ https://reviews.

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This patch adds a mechanism to load

[clang-tools-extra] ebf496d - Revert "[clang-tidy] New check readability-prefer-member-initializer"

Author: Roman Lebedev Date: 2020-09-10T16:32:18+03:00 New Revision: ebf496d805521b53022a351f35854de977fee844 URL: https://github.com/llvm/llvm-project/commit/ebf496d805521b53022a351f35854de977fee844 DIFF: https://github.com/llvm/llvm-project/commit/ebf496d805521b53022a351f35854de977fee844.diff

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. So i've just reverted this. @aaron.ballman @baloghadamsoftware how's QC going on nowadays here? Was this evaluated on anything other than it's tests? It appears to be either unacceptab

[PATCH] D87451: add new clang option -fnovisibility.

DiggerLin created this revision. DiggerLin added reviewers: hubert.reinterpretcast, jasonliu, daltenty. Herald added subscribers: cfe-commits, dang, steven.zhang. Herald added a project: clang. DiggerLin requested review of this revision. In IBM compiler Xlclang , there is option -fnovisibiilty. T

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C.

Eugene.Zelenko added a comment. Please add entry in Release Notes. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:26 +namespace { +constexpr StringRef SignalFun = "signal"; +constexpr StringRef AbortFun = "abort"; Only type definitions sho

[PATCH] D87451: add new clang option -fnovisibility.

lebedev.ri added a comment. Bad commit message - links will go dead eventually, all the relevant stuff needs to be specified in the commit message itself. Comment at: clang/docs/ClangCommandLineReference.rst:2310-2320 .. option:: -fvisibility-ms-compat +Ignore all the visib

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

baloghadamsoftware added a comment. In D71199#2265594 , @lebedev.ri wrote: > So i've just reverted this in rGebf496d805521b53022a351f35854de977fee844 > . > > @aaron.ballman @baloghadamso

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

lebedev.ri added a comment. In D71199#2265692 , @baloghadamsoftware wrote: > In D71199#2265594 , @lebedev.ri > wrote: > >> So i've just reverted this in rGebf496d805521b53022a351f35854de977fee844 >>

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

baloghadamsoftware updated this revision to Diff 290967. baloghadamsoftware added a comment. Test added. Thank you for the test @steakhal! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85424/new/ https://reviews.llvm.org/D85424 Files: clang/lib/StaticAnalyzer/Checkers/IteratorRangeCh

[PATCH] D85424: [Analyzer] Crash fix for alpha.cplusplus.IteratorRange

baloghadamsoftware added a comment. In D85424#2258886 , @steakhal wrote: > void foo(int x) { > > int uninit; > x - uninit; // will-crash > > } This is not even related to the iterators. We could check first whether `LHS` is an iterator and early exit

[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer

aaron.ballman added a comment. In D71199#2265693 , @lebedev.ri wrote: > In D71199#2265692 , > @baloghadamsoftware wrote: > >> In D71199#2265594 , @lebedev.ri >> wrote: >> >

[PATCH] D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins

nemanjai added inline comments. Comment at: clang/lib/Headers/altivec.h:7743 + return __builtin_altivec_vrlqnm(__a, ((__c << ShiftMask) | +(__b << ShiftRotation))); +} While correct, this implementation will require two co

[clang-tools-extra] 33c9dbb - Add an explicit toggle for the static analyzer in clang-tidy

Author: Nico Weber Date: 2020-09-10T10:48:17-04:00 New Revision: 33c9dbbd380913e8ab7e5a8e82468f9f7d092187 URL: https://github.com/llvm/llvm-project/commit/33c9dbbd380913e8ab7e5a8e82468f9f7d092187 DIFF: https://github.com/llvm/llvm-project/commit/33c9dbbd380913e8ab7e5a8e82468f9f7d092187.diff LO

[PATCH] D87358: [clang][aarch64] Fix ILP32 ABI for arm_sve_vector_bits

c-rhodes updated this revision to Diff 290974. c-rhodes edited the summary of this revision. c-rhodes added a comment. - Get the element type of scalable vectors from `getBuiltinVectorTypeInfo` when creating VLS types. This fixes the ABI issue since it calls `ASTContext::getIntTypeForBitwidth` w

[PATCH] D87358: [clang][aarch64] Fix ILP32 ABI for arm_sve_vector_bits

c-rhodes added inline comments. Comment at: clang/lib/AST/Type.cpp:2339 case BuiltinType::SveInt32: -return Ctx.IntTy; +return IsILP32 ? Ctx.LongTy : Ctx.IntTy; case BuiltinType::SveUint32: efriedma wrote: > sdesmalen wrote: > > Rather than comparin

[PATCH] D87455: Restrict UnnecessaryCopyInitialization check to variables initialized from methods/functions without arguments

flx created this revision. flx added reviewers: alexfh, sbenza. Herald added a project: clang. Herald added a subscriber: cfe-commits. flx requested review of this revision. This restriction avoids cases where an alias is returned to an argument and which could lead to to a false positive change.

Re: Clang-Format, Clang-Tidy - Absolute Path to config files

Hello, I worked on adding a similar feature some time back : https://reviews.llvm.org/D50147 It supports specifying styles by absolute file name as well as lookup of a style by name in various locations (like ~/.local/share/clang-format or /usr/share/clang-format), allowing to install styles on th

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

ASDenysPetrov added a comment. Here is my five cents. I haven't done with the review yet. I'm gonna return to it a bit later. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:56 + bool operator==(const Range &RHS) const { return Imp

[clang-tools-extra] 29cecbc - Fix clangd build after 33c9dbbd380

Author: Nico Weber Date: 2020-09-10T11:05:53-04:00 New Revision: 29cecbc5d6fe2ee36635d593171d59eab631639f URL: https://github.com/llvm/llvm-project/commit/29cecbc5d6fe2ee36635d593171d59eab631639f DIFF: https://github.com/llvm/llvm-project/commit/29cecbc5d6fe2ee36635d593171d59eab631639f.diff LO

[PATCH] D87451: add new clang option -fnovisibility.

DiggerLin updated this revision to Diff 290978. DiggerLin added a comment. add a pragmas test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451 Files: clang/docs/ClangCommandLineReference.rst clang/i

Re: [clang-tools-extra] 156b127 - Add a new altera check for structure packing and alignment.

Looks like this broke the sphinx bot: http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs/builds/65757/steps/docs-clang-tools-html/logs/stdio Can you take a look? On Tue, Sep 8, 2020 at 9:36 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Frank Derry Wanye

[PATCH] D87458: [Clang] Clarify __builtin_memcpy_inline documentation

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet requested review of this revision. This patch updates the documentation about `__builtin_memcpy_inline` and reorders the sections so it is more co

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

CaseyCarter created this revision. CaseyCarter added reviewers: ldionne, mclow.lists, EricWF. Herald added subscribers: libcxx-commits, dexonsmith. Herald added a project: libc++. Herald added a reviewer: libc++. CaseyCarter requested review of this revision. Although libc++ doesn't yet implement

[clang-tools-extra] 66ac212 - Speculatively fix the Sphinx builder.

Author: Aaron Ballman Date: 2020-09-10T11:35:10-04:00 New Revision: 66ac212ea97a529e171a7b8aea10638d7b9b9907 URL: https://github.com/llvm/llvm-project/commit/66ac212ea97a529e171a7b8aea10638d7b9b9907 DIFF: https://github.com/llvm/llvm-project/commit/66ac212ea97a529e171a7b8aea10638d7b9b9907.diff

[PATCH] D87451: add new clang option -fnovisibility.

DiggerLin updated this revision to Diff 290987. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451 Files: clang/docs/ClangCommandLineReference.rst clang/include/c

Re: [clang-tools-extra] 156b127 - Add a new altera check for structure packing and alignment.

On Thu, Sep 10, 2020 at 11:27 AM Nico Weber wrote: > > Looks like this broke the sphinx bot: > http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs/builds/65757/steps/docs-clang-tools-html/logs/stdio > > Can you take a look? Hopefully 66ac212ea97a529e171a7b8aea10638d7b9b9907 will resolve th

RE: Clang-Format, Clang-Tidy - Absolute Path to config files

Hi Francois, I read your usecase. Our usecase is similar, but the difference is that we use Artifactory to store our tools and Conan to manage and install them. This way, having a Conan package with everything in it, including the config file is very scalable and maintainable. I did not quite

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

ldionne added a comment. What paper is this? I searched but failed to find a paper this falls off from. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87459/new/ https://reviews.llvm.org/D87459 ___ cfe-co

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: clang/test/SemaObjC/attr-swift-error.m:55 + +// This is unconventional and very odd but we do process it. +- (int)q0:(const NSError **)error __attribute__((__swift_error__(nonzero_result))); -

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

CaseyCarter added a comment. In D87459#2265864 , @ldionne wrote: > What paper is this? I searched but failed to find a paper this falls off from. P0896R4 "The One Ranges Proposal" - Ranges demands that all iterators have useful difference types. Reposi

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd updated this revision to Diff 290990. compnerd added a comment. Address @gribozavr2's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87331/new/ https://reviews.llvm.org/D87331 Files: clang/include/clang/Basic/Attr.td clang/inc

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

ldionne added a comment. In D87459#2265871 , @CaseyCarter wrote: > In D87459#2265864 , @ldionne wrote: > >> What paper is this? I searched but failed to find a paper this falls off >> from. > > P0896R4 "The One Ran

[PATCH] D87459: [libcxx][test] ostream{,buf}_iterator::difference_type changes in C++20

CaseyCarter added a comment. > Ah, I see it. I'll add that bit to libc++ so we don't need special casing in > the tests. Feel free to steal this for your test changes. Shall I close this differential then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D87461: Disable sanitizer options for AMDGPU

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added subscribers: t-tye, tpr, dstuttard, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. Currently AMDGPU does not support sanitizer. Disable sanitizer options for now until they are sup

[PATCH] D87463: [clang][aarch64] Fix mangling of bfloat16 neon vectors

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, SjoerdMeijer, stuij. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: clang. c-rhodes requested review of this revision. The AAPCS64 specifies the internal type is used for c++ mangling. For bfloat16 i

  1   2   >