gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/unittests/Tooling/Syntax/MutationsTest.cpp:48 + +TEST_P(MutationTest, Mutations) { + if (!GetParam().isCXX11OrLater()) { ---------------- ================ Comment at: clang/unittests/Tooling/Syntax/MutationsTest.cpp:70 "void test() { if (true) ; else {} }"}, {"void test() { [[;]] }", "void test() { }"}}; for (const auto &C : Cases) ---------------- Could we split it into multiple test cases? ``` TEST_P(MutationTest, RemoveStatement_BinaryExpression) { CheckTransformation( RemoveStatement, "void test() { [[100+100;]] test(); }", "void test() { test(); }"); } ``` Also consider moving the std::function argument in CheckTransformation to the first position for readability of the call. ================ Comment at: clang/unittests/Tooling/Syntax/SynthesisTest.cpp:1-2 + +//===- MutationsTest.cpp --------------------------------------------------===// +// ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87374/new/ https://reviews.llvm.org/D87374 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits