[PATCH] D78902: [Driver] Add output file to properties of Command

MaskRay added a comment. What's the advantage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. @lanza I did it as a CodeGen option for now because we don't want anything like this to be the default until the ABI is fleshed out. I think one danger in altering the name of the function to some extent is you dont want to clash potentially with user defined C functions.

[clang] 038edf6 - Don't reject uses of void-returning consteval functions.

Author: Richard Smith Date: 2020-08-20T15:40:09-07:00 New Revision: 038edf6029bafe70b1f7165abe2b0e61ddf506b3 URL: https://github.com/llvm/llvm-project/commit/038edf6029bafe70b1f7165abe2b0e61ddf506b3 DIFF: https://github.com/llvm/llvm-project/commit/038edf6029bafe70b1f7165abe2b0e61ddf506b3.diff

[clang] 3d82c9b - Fix 32 bit build broken by D85990 by dropping align from filecheck pattern

Author: JonChesterfield Date: 2020-08-20T23:50:33+01:00 New Revision: 3d82c9b6960afe50a76b8c23e9bc42c51d41e767 URL: https://github.com/llvm/llvm-project/commit/3d82c9b6960afe50a76b8c23e9bc42c51d41e767 DIFF: https://github.com/llvm/llvm-project/commit/3d82c9b6960afe50a76b8c23e9bc42c51d41e767.dif

[PATCH] D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types

JonChesterfield added inline comments. Comment at: clang/test/CodeGenCXX/attr-loader-uninitialized.cpp:34 + +// CHECK: @templ_int = global %struct.templ undef, align 8 +templ templ_int [[clang::loader_uninitialized]]; This broke 32 bit builds where the pointer is

[PATCH] D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file

MaskRay added inline comments. Comment at: compiler-rt/lib/builtins/int_mulv_impl.inc:1 -//===-- mulvdi3.c - Implement __mulvdi3 ---===// +//===-- int_mulv_impl.inc - Implement __mulv[sdt]i3 ---===// // `---*

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

mehdi_amini added a comment. Overall that would likely work for XLA. Something I'd like to mention though in response to: > The veclib type is also tied to the accepted values for -fveclib, which is a > list of supported lib, `-fveclib` is a Clang thing, it shouldn't limit what LLVM does. Of c

[clang-tools-extra] efeb65d - Fix up clangd after Clang 038edf6029bafe70b1f7165abe2b0e61ddf506b3.

Author: Richard Smith Date: 2020-08-20T16:36:25-07:00 New Revision: efeb65d53b88d9c3ac3a185c396efd8db8c9f7d9 URL: https://github.com/llvm/llvm-project/commit/efeb65d53b88d9c3ac3a185c396efd8db8c9f7d9 DIFF: https://github.com/llvm/llvm-project/commit/efeb65d53b88d9c3ac3a185c396efd8db8c9f7d9.diff

[clang] 7092398 - Improve pretty-printing for APValues of void type.

Author: Richard Smith Date: 2020-08-20T17:14:22-07:00 New Revision: 70923983e54253723600eb2f4cdfb0fbb347a364 URL: https://github.com/llvm/llvm-project/commit/70923983e54253723600eb2f4cdfb0fbb347a364 DIFF: https://github.com/llvm/llvm-project/commit/70923983e54253723600eb2f4cdfb0fbb347a364.diff

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

vsapsai added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ac737e56bee: [HeaderSearch] Fix processing #import-ed headers multiple times with modules… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 7ac737e - [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

Author: Volodymyr Sapsai Date: 2020-08-20T17:41:28-07:00 New Revision: 7ac737e56bee721fb3535006140362c6e08726bb URL: https://github.com/llvm/llvm-project/commit/7ac737e56bee721fb3535006140362c6e08726bb DIFF: https://github.com/llvm/llvm-project/commit/7ac737e56bee721fb3535006140362c6e08726bb.di

[PATCH] D83929: [clang]: Remove assertion which checks explicit declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe86dbb32da2: [clang]: Remove assertion which checks explicit declaration (authored by gousemoodhin, committed by rsmith). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repositor

[clang] fe86dbb - [clang]: Remove assertion which checks explicit declaration

Author: Gousemoodhin Nadaf Date: 2020-08-20T18:15:43-07:00 New Revision: fe86dbb32da21e1c8c6eb4864a00f61ed3d003a3 URL: https://github.com/llvm/llvm-project/commit/fe86dbb32da21e1c8c6eb4864a00f61ed3d003a3 DIFF: https://github.com/llvm/llvm-project/commit/fe86dbb32da21e1c8c6eb4864a00f61ed3d003a3.

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

asbirlea requested changes to this revision. asbirlea added a comment. This revision now requires changes to proceed. A couple of quick comments, I haven't gone into details yet. - please split off the changes that are NFCs (deleted spaces) and clang-format for ease to review. - the test changes

[PATCH] D86218: Teach the swift calling convention about _Atomic types

rjmccall added a comment. Please do this as a very late check rather than the first check. You need to check for extra atomic padding. If there's any difference between the sizes of the atomic type and its element, just add it as opaque data. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

NoQ added a comment. Heh, nice! Did you try to measure the actual impact of this change on memory and/or performance? I think it'd make perfect sense to keep the offset in a side map. We don't compute it for all regions, and for most regions it doesn't need to be computed *at all*. Repositor

[PATCH] D86329: Fix spelling errors in the doc

YangZhihui created this revision. YangZhihui added reviewers: rsmith, craig.topper. Herald added a project: clang. Herald added a subscriber: cfe-commits. YangZhihui requested review of this revision. Fix some spelling error in the doc Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +// FIXME: __BOOL__ should be defined under strict -std=c89. +Builder.defineMacro("__BOOL__"); MaskRay wrote: > What is

[PATCH] D85031: [builtins] Unify the softfloat division implementation

sepavloff added inline comments. Comment at: compiler-rt/lib/builtins/fp_div_impl.inc:99 + // 0 < x0(b) < 1 + // abs(x0(b) - 1/b) <= 3/4 - 1/sqrt(2) + atrosinenko wrote: > sepavloff wrote: > > This estimation is absent from the original comment. Do you have

[PATCH] D86176: [clang-tidy] readability-simplify-boolean-expr detects negated literals

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:66 + if (const auto *Negated = Result.Nodes.getNodeAs(Id)) { +if (Negated->getOpcode() == UO_LNot && +isa(Negated->getSubExpr())) aaron

<    1   2