NoQ added a comment.

Heh, nice! Did you try to measure the actual impact of this change on memory 
and/or performance?

I think it'd make perfect sense to keep the offset in a side map. We don't 
compute it for all regions, and for most regions it doesn't need to be computed 
*at all*.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86295/new/

https://reviews.llvm.org/D86295

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to