[PATCH] D85401: [clang-tidy] Fix bugprone-bad-signal-to-kill-thread crash when `SIGTERM` was undefined after definition.

2020-08-05 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX created this revision. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, xazax.hun. Herald added a project: clang. ArcsinX requested review of this revision. `PP->getMacroInfo()` returns nullptr for undefined macro, which leads to null-dereference at `MI->tockens()

[PATCH] D85282: [Concepts] Dump template arguments for immediately declared constraint.

2020-08-05 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added inline comments. Comment at: clang/test/AST/ast-dump-concepts.cpp:18 // CHECK: TemplateTypeParmDecl {{.*}} referenced Concept {{.*}} 'binary_concept' - // CHECK-NEXT: |-ConceptSpecializationExpr {{.*}} 'bool' Concept {{.*}} 'binary_concept' - // CHECK-NE

[PATCH] D85301: [clang-tidy] Fix crashes in bugprone-bad-signal-to-kill-thread check.

2020-08-05 Thread Aleksandr Platonov via Phabricator via cfe-commits
ArcsinX added a comment. In D85301#2197263 , @hokein wrote: > while this patch fixes multiple issues (as described in the message), I'd > suggest splitting it. Thanks for you suggestion. > SIGTERM is not a literal D85398

<    1   2   3