ArcsinX added a comment.

In D85301#2197263 <https://reviews.llvm.org/D85301#2197263>, @hokein wrote:

> while this patch fixes multiple issues (as described in the message), I'd 
> suggest splitting it.

Thanks for you suggestion.

> SIGTERM is not a literal

D85398 <https://reviews.llvm.org/D85398>

> SIGTERM is a literal but Token::PtrData == nullptr (happens in clangd, 
> because clang-tidy in clangd has some limitations to ensure reasonable 
> performance)

For this I will create after if/when previous one will be accepted. Seems it's 
more related to clangd then clang-tidy.

> SIGTERM undefined after definition

D85401 <https://reviews.llvm.org/D85401>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85301/new/

https://reviews.llvm.org/D85301

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to