[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske updated this revision to Diff 279133. balazske added a comment. Rebase to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82845/new/ https://reviews.llvm.org/D82845 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp clan

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. There were two problems here: - RecursiveASTVisitor did not traverse TypeConstraint::ImmediatelyDeclaredConstraint - ConceptSpecial

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:246 + + if ([[B && I > 42 || ~([[++I]])]]) {[[ +++I; sammccall wrote: > confused about [[++I]] - why is this foldable but not I > 42 etc

[PATCH] D83914: [clangd] Plan features for FoldingRanges

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:329 + )cpp", + // Argument lists. + R"cpp( kbobyrev wrote: > sammccall wrote: > > missing lambdas, blocks, objc methods. > > cover bodies in

[PATCH] D84140: [clang] Set the error-bit for ill-formed semantic InitListExpr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kbobyrev, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. When a semantic checking fails on a syntactic InitListExpr, we will get an ill-formed semantic InitListExpr (e.g. some inits

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

danielkiss added a comment. Patch for gcc is merged. https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=a70d5d81c41048556fd86eaa1036018a6bfba115 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 ___ cf

[PATCH] D84140: [clang] Set the error-bit for ill-formed semantic InitListExpr.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaInit.cpp:965 } + if (hadError && FullyStructuredList) +FullyStructuredList->markError(); Can we have a clang

[PATCH] D84140: [clang] Set the error-bit for ill-formed semantic InitListExpr.

sammccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:4697 +assert(isSemanticForm()); +setDependence(getDependence() | ExprDependence::Error | + ExprDependence::ValueInstantiation); Hmm, actually hardcoding the error

[PATCH] D84140: [clang] Set the error-bit for ill-formed semantic InitListExpr.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang/include/clang/AST/Expr.h:4697 +assert(isSemanticForm()); +setDependence(getDependence() | ExprDependence::Error | + ExprDependence::ValueInstantiation); -

[PATCH] D83966: Enable the test for hasArraySize() AST matcher in all language modes

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6073ee9ae84: Enable the test for hasArraySize() AST matcher in all language modes (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D839

[clang] b6073ee - Enable the test for hasArraySize() AST matcher in all language modes

Author: Dmitri Gribenko Date: 2020-07-20T10:23:00+02:00 New Revision: b6073ee9ae842d1999fd7798a0aac0f8427d6aea URL: https://github.com/llvm/llvm-project/commit/b6073ee9ae842d1999fd7798a0aac0f8427d6aea DIFF: https://github.com/llvm/llvm-project/commit/b6073ee9ae842d1999fd7798a0aac0f8427d6aea.dif

[Differential] D83966: Enable the test for hasArraySize() AST matcher in all language modes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6073ee9ae84: Enable the test for hasArraySize() AST matcher in al

[PATCH] D84122: [clangd] Handle deduction guides in TargetFinder and ExplicitReferenceCollector

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: kbobyrev. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:403 + )cpp"; + Flags.push_back("-std=c++17"); + EXPECT_DECLS("C

[PATCH] D84103: [clang-format] Make sure rst documentation matches comments

MyDeveloperDay added a comment. Thanks for doing this.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84103/new/ https://reviews.llvm.org/D84103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

ArcsinX created this revision. Herald added subscribers: cfe-commits, kbobyrev, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This patch mostly reverts D74850 . We could not use `AST.getTokens()` here, because it do

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.org/D83407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D84145: [AST][RecoveryExpr] Fix a crash on opencl C++.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: Anastasia, yaxunl. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84145 Files: clang/lib/Sema/SemaDecl.cpp clang/test/SemaOpenCL/recovery-expr.cl Inde

[PATCH] D84032: [clang] Make clear Sema::CheckForConstantInitializer is for C-only codepath.

hokein abandoned this revision. hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11072 // rules there don't matter.) + assert(!getLangOpts().CPlusPlus || getLangOpts().OpenCLCPlusPlus); const Expr *Culprit;

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

kadircet added a comment. ah embarrassing :/ thanks for catching this! It should've been obvious from the fact that there's a "FilePath" and a "TUPath" going on .. Comment at: clang-tools-extra/clangd/XRefs.cpp:1191 + SourceLocation EndLoc = SM.getSpellingLoc(SM.getFileLoc(ND

[Differential] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b7c43d341da: [Analyzer][StreamChecker] Report every leak, clean up state. (authored by balazske). Changed prior to commit: https://reviews.llvm.o

[clang] 9b7c43d - [Analyzer][StreamChecker] Report every leak, clean up state.

Author: Balázs Kéri Date: 2020-07-20T11:49:00+02:00 New Revision: 9b7c43d341da319c69b11205ee1deb642f286e59 URL: https://github.com/llvm/llvm-project/commit/9b7c43d341da319c69b11205ee1deb642f286e59 DIFF: https://github.com/llvm/llvm-project/commit/9b7c43d341da319c69b11205ee1deb642f286e59.diff L

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b7c43d341da: [Analyzer][StreamChecker] Report every leak, clean up state. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82845/new/

[PATCH] D84146: [AST][RecoveryExpr] Add recovery-ast tests for C language, NFC.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. some examples are working already. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84146 Files: clang/test/AST/ast-dump-recovery.c Index: clang/test/AST/ast-dump-recovery.c

[clang] 8513a68 - [clang-cl] Allow a colon after the /Fe option (PR46720)

Author: Hans Wennborg Date: 2020-07-20T12:06:41+02:00 New Revision: 8513a681f7d8d1188706762e712168aebc3119dd URL: https://github.com/llvm/llvm-project/commit/8513a681f7d8d1188706762e712168aebc3119dd DIFF: https://github.com/llvm/llvm-project/commit/8513a681f7d8d1188706762e712168aebc3119dd.diff

[PATCH] D84147: Use typedef to represent storage type in FPOption and FPOptionsOverride

sepavloff created this revision. sepavloff added reviewers: rjmccall, mibintc. Herald added a project: clang. Size of FPOption is now 14 bit, which is closed to the current limit of 16 bits. Adding new properties to FPOption would require change of the types, which represent storage of FPOption an

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

ArcsinX updated this revision to Diff 279168. ArcsinX added a comment. NameRange => DeclRange Simplify TypeHierarchy.Preamble test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84144/new/ https://reviews.llvm.org/D84144 Files: clang-tools-extra

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

ArcsinX marked 2 inline comments as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1191 + SourceLocation EndLoc = SM.getSpellingLoc(SM.getFileLoc(ND.getEndLoc())); + const auto NameRange = + toHalfOpenFileRange(SM, Ctx.getLangOpts(), {B

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. This checker can have two purposes, one is to verify that all paths have the error check, other is to find at least one path without error check. The first is the one that can be done with dataflow based analysis but looks like a difficult problem. For example is it po

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, just some improvements to the testing. also please let me know if I should land this for you. Comment at: clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp

[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

krasimir added a comment. @wanders, thank you for digging through code to get a feeling of the usage! I agree with others to have an enum option. +1 to `None` over `Neither`. I'd prefer `Before` / `After` instead of `Left` / `Right`; those seem more prevalent in names and values of existing opti

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.org/D83407

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Herald added a subscriber: kbobyrev. thanks, looks good. Comment at: clang-tools-extra/clangd/FindTarget.cpp:71 + + if (const auto *RT = T->getAs()) { +return dyn_cast(R

[Differential] D84021: [Driver] Add support for -msve-vector-bits=scalable.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab7abd8bf41b: [Driver] Add support for -msve-vector-bits=scalable. (authored by paulwalker-arm). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] ab7abd8 - [Driver] Add support for -msve-vector-bits=scalable.

Author: Paul Walker Date: 2020-07-20T10:46:22Z New Revision: ab7abd8bf41b558aef402a21c637211760bc2739 URL: https://github.com/llvm/llvm-project/commit/ab7abd8bf41b558aef402a21c637211760bc2739 DIFF: https://github.com/llvm/llvm-project/commit/ab7abd8bf41b558aef402a21c637211760bc2739.diff LOG: [

[PATCH] D84021: [Driver] Add support for -msve-vector-bits=scalable.

This revision was automatically updated to reflect the committed changes. Closed by commit rGab7abd8bf41b: [Driver] Add support for -msve-vector-bits=scalable. (authored by paulwalker-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84021/new/ ht

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

ArcsinX updated this revision to Diff 279174. ArcsinX added a comment. Check source range for Parent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84144/new/ https://reviews.llvm.org/D84144 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

ArcsinX marked 2 inline comments as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp:533 + + Annotations HeaderInPreambleAnnotations(R"cpp( +struct Parent { kadircet wrote: > this doesn't need to be an `A

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

ArcsinX added a comment. In D84144#2161579 , @kadircet wrote: > also please let me know if I should land this for you. Yes, could you please land this for me? I do not have commit access. Aleksandr Platonov Repository: rG LLVM Github Monorepo CHANG

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

Szelethus added a comment. I find the summary here a bit lacking. We detected this issue in D83120 , where a lot of discussion can be found, so its worth linking in. On its own, I'm not immediately sold on whether this is the correct solution, and even if it is,

[PATCH] D83665: [OpenCL] Fixed missing address space for templated copy constructor

olestrohm marked an inline comment as done. olestrohm added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3811 + if(S.getLangOpts().OpenCL) +ArgType = S.deduceOpenCLPointeeAddrSpace(ArgType); ArgType = S.Context.getLValueReferenceType(A

[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

hokein updated this revision to Diff 279176. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81090/new/ https://reviews.llvm.org/D81090 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/AST/ast-dump-recovery.cpp c

[clang] 17ef788 - [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

Author: Haojian Wu Date: 2020-07-20T13:11:15+02:00 New Revision: 17ef788df56096ca5affdfc29d562c103f0e534c URL: https://github.com/llvm/llvm-project/commit/17ef788df56096ca5affdfc29d562c103f0e534c DIFF: https://github.com/llvm/llvm-project/commit/17ef788df56096ca5affdfc29d562c103f0e534c.diff LO

[Differential] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17ef788df560: [AST][RecoveryExpr] Preserve the AST for invalid class constructions. (authored by hokein). Changed prior to commit: https://reviews

[PATCH] D81090: [AST][RecoveryExpr] Preserve the AST for invalid class constructions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG17ef788df560: [AST][RecoveryExpr] Preserve the AST for invalid class constructions. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81090

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp:533 + + Annotations HeaderInPreambleAnnotations(R"cpp( +struct Parent { ArcsinX wrote: > kadircet wrote: > > this doesn't need to be an `Annotation` and sorry f

[PATCH] D84146: [AST][RecoveryExpr] Add recovery-ast tests for C language, NFC.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/AST/ast-dump-recovery.c:20 +// CHECK-NEXT: `-DeclRefExpr {{.*}} 'a' +int prefix_inc = ++a; + why is this an interesting dis

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 279178. c-rhodes added a comment. Changes: - Remove internal type attributes (defined for each vector-size). - Get the vector size from the `arm_sve_vector_bits` attribute via the `AttributedTypeLoc` associated with the typedef decl. - Change `NumBits` argu

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

ArcsinX updated this revision to Diff 279180. ArcsinX added a comment. AdditionalFiles["header_in_preamble.h"] => HeaderCode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84144/new/ https://reviews.llvm.org/D84144 Files: clang-tools-extra/clangd

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes marked an inline comment as done. c-rhodes added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 +def ArmSveVectorBits128 : TypeAttr { + let Spellings = []; c-rhodes wrote: > aaron.ballman wrote: > > c-rhodes wrote: > > > aaron.bal

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

kadircet added a comment. just some drive-by comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:433 + )cpp"; + Flags.push_back("-std=c++20"); + EXPECT_DECLS("ConceptSpecializationExpr", `Flags` is preserved between `EXPECT_DECLS` ca

[PATCH] D83912: [llvm-readobj] Update tests because of changes at llvm-readobj behavior

jhenderson added a comment. Hi @Elvina, Just to let you know that I had to fix up three clang tests that were using the old behaviour too, prior to committing. I also noticed that you've got the stack the wrong way around - you needed to fix the tests before changing the behaviour in this case

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp:533 + + Annotations HeaderInPreambleAnnotations(R"cpp( +struct Parent { kadircet wrote: > ArcsinX wrote: > > kadircet w

[PATCH] D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.

walrus created this revision. Herald added subscribers: cfe-commits, kbobyrev, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The fix improves handling of Windows UNC paths to align with Appendix E. Nonstandard Syntax Variations of RFC 8089. Before

[PATCH] D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. This is an attempt to improve handling of Windows UNC paths in clangd. Any feedback is appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84150/new/ https://reviews.llvm.org/D84150 ___

[Differential] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0ab336e7455: [Syntax] expose API for expansions overlapping a spelled token range. (authored by sammccall). Repository: rG LLVM Github Monorepo

[clang] f0ab336 - [Syntax] expose API for expansions overlapping a spelled token range.

Author: Sam McCall Date: 2020-07-20T14:48:12+02:00 New Revision: f0ab336e745505f3bb7e8570f12937cf0fbc11aa URL: https://github.com/llvm/llvm-project/commit/f0ab336e745505f3bb7e8570f12937cf0fbc11aa DIFF: https://github.com/llvm/llvm-project/commit/f0ab336e745505f3bb7e8570f12937cf0fbc11aa.diff LO

[PATCH] D84009: [Syntax] expose API for expansions overlapping a spelled token range.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0ab336e7455: [Syntax] expose API for expansions overlapping a spelled token range. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84

[PATCH] D83652: Merge some of the PCH object support with modular codegen

hans added a comment. In D83652#2159585 , @dblaikie wrote: > @hans - could you perhaps give me a quick summary of commands I could use to > test this feature in Chromium (or anything else you might suggest) on a Linux > box? I don't have a Windows machin

[clang-tools-extra] 72f2fb1 - [clangd] Exclude preprocessed-to-nothing tokens from selection

Author: Sam McCall Date: 2020-07-20T14:50:12+02:00 New Revision: 72f2fb1db4ea19b543265ceba67964174848a875 URL: https://github.com/llvm/llvm-project/commit/72f2fb1db4ea19b543265ceba67964174848a875 DIFF: https://github.com/llvm/llvm-project/commit/72f2fb1db4ea19b543265ceba67964174848a875.diff LO

[Differential] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

This revision was automatically updated to reflect the committed changes. Closed by commit rG72f2fb1db4ea: [clangd] Exclude preprocessed-to-nothing tokens from selection (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84012/new

[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

This revision was automatically updated to reflect the committed changes. Closed by commit rG72f2fb1db4ea: [clangd] Exclude preprocessed-to-nothing tokens from selection (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84012/new

[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

sammccall marked an inline comment as done. sammccall added inline comments. Herald added a subscriber: kbobyrev. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:568 +#if 0 +void fu^nc(); +#endif kadircet wrote: > nit: i am not sure

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

sammccall added a comment. Herald added a subscriber: kbobyrev. In D83508#2157954 , @ArcsinX wrote: > In D83508#2157859 , @sammccall wrote: > > > Tried this out in D84012 /D84009 >

[clang] 684e416 - [AST][RecoveryExpr] Preserve the AST for invalid conditions.

Author: Haojian Wu Date: 2020-07-20T14:58:36+02:00 New Revision: 684e416ef1361fc3cc93bebbee1466b844751497 URL: https://github.com/llvm/llvm-project/commit/684e416ef1361fc3cc93bebbee1466b844751497 DIFF: https://github.com/llvm/llvm-project/commit/684e416ef1361fc3cc93bebbee1466b844751497.diff LO

[Differential] D81163: [AST][RecoveryExpr] Preserve the AST for invalid conditions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG684e416ef136: [AST][RecoveryExpr] Preserve the AST for invalid conditions. (authored by hokein). Changed prior to commit: https://reviews.llvm.org

[PATCH] D81163: [AST][RecoveryExpr] Preserve the AST for invalid conditions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG684e416ef136: [AST][RecoveryExpr] Preserve the AST for invalid conditions. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D81163?vs=270413&id=279213#toc Repository: rG LLVM G

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

balazske marked an inline comment as done. balazske added a comment. The problem in D83120 is fixed by this patch. What I figured out from the code is that `BugReporter::FlushReport` calls `findReportInEquivalenceClass` that returns a report that has not necessar

[PATCH] D71760: [POC][SVE] Allow code generation for fixed length vectorised loops [Patch 1/2].

paulwalker-arm updated this revision to Diff 279217. paulwalker-arm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71760/new/ https://reviews.llvm.org/D71760 Files: clang/lib/Driver/ToolChains/Clang.cpp Index: clang/lib

[clang-tools-extra] 61d664c - Fix clangd build, NFC

Author: Haojian Wu Date: 2020-07-20T15:13:20+02:00 New Revision: 61d664c9383c53339db756278ec84fbacec2bf4b URL: https://github.com/llvm/llvm-project/commit/61d664c9383c53339db756278ec84fbacec2bf4b DIFF: https://github.com/llvm/llvm-project/commit/61d664c9383c53339db756278ec84fbacec2bf4b.diff LO

[clang] 4b5b7c7 - [AST][RecoveryExpr] Fix a crash on opencl C++.

Author: Haojian Wu Date: 2020-07-20T15:15:30+02:00 New Revision: 4b5b7c75415be0837389fe694e1843422b4cd115 URL: https://github.com/llvm/llvm-project/commit/4b5b7c75415be0837389fe694e1843422b4cd115 DIFF: https://github.com/llvm/llvm-project/commit/4b5b7c75415be0837389fe694e1843422b4cd115.diff LO

[PATCH] D84145: [AST][RecoveryExpr] Fix a crash on opencl C++.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b5b7c75415b: [AST][RecoveryExpr] Fix a crash on opencl C++. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84145/new/ https://reviews.

[PATCH] D84146: [AST][RecoveryExpr] Add recovery-ast tests for C language, NFC.

hokein updated this revision to Diff 279223. hokein marked 4 inline comments as done. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84146/new/ https://reviews.llvm.org/D84146 Files: clang/test/AST/

[PATCH] D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko updated this revision to Diff 279224. ilya-golovenko added a comment. Consistent naming: Name => Path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84150/new/ https://reviews.llvm.org/D84150 Files: clang-tools-extra/clangd/URI.cpp

[clang] 70e2c7a - [AST][RecoveryExpr] Add recovery-ast tests for C language, NFC.

Author: Haojian Wu Date: 2020-07-20T15:33:59+02:00 New Revision: 70e2c7ad2e891ccecbf59a0562586538de96aeaa URL: https://github.com/llvm/llvm-project/commit/70e2c7ad2e891ccecbf59a0562586538de96aeaa DIFF: https://github.com/llvm/llvm-project/commit/70e2c7ad2e891ccecbf59a0562586538de96aeaa.diff LO

[PATCH] D84146: [AST][RecoveryExpr] Add recovery-ast tests for C language, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG70e2c7ad2e89: [AST][RecoveryExpr] Add recovery-ast tests for C language, NFC. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84146/new/

[PATCH] D84140: [clang] Set the error-bit for ill-formed semantic InitListExpr.

hokein updated this revision to Diff 279227. hokein added a comment. add "ErrorDependent" alias to `ExprDependence` enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84140/new/ https://reviews.llvm.org/D84140 Files: clang-tools-extra/clangd/un

[PATCH] D84012: [clangd] Exclude preprocessed-to-nothing tokens from selection

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:568 +#if 0 +void fu^nc(); +#endif sammccall wrote: > kadircet wrote: > > nit: i am not sure if this is worth it's own test > Moved into CommonAncestor te

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 279228. MForster marked 13 inline comments as done. MForster added a comment. - Run test also in C and C++ mode - Address more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://r

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1860 +def NSErrorDomain : Attr { + let Spellings = [GNU<"ns_error_domain">]; + let Args = [IdentifierArgument<"ErrorDomain">]; aaron.ballman wrote: > gribozavr2 wrote: > > aaron.ballm

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. In D67833#2161241 , @Meinersbur wrote: > Seems that it already has been applied ;-) Yes, thanks Michael. Hope everything goes well with you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D84150: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko updated this revision to Diff 279233. ilya-golovenko added a comment. Consistent naming: hasDriveLetter => isWindowsPath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84150/new/ https://reviews.llvm.org/D84150 Files: clang-tools-e

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster marked an inline comment as done. MForster added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1860 +def NSErrorDomain : Attr { + let Spellings = [GNU<"ns_error_domain">]; + let Args = [IdentifierArgument<"ErrorDomain">]; MForster wrot

[PATCH] D81311: [RFC] LangRef: Define byref parameter attribute

arsenm closed this revision. arsenm added a comment. Merged with D83518 as 5e999cbe8db0b50dc9828a1c062b4ffe84c5b137 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81311/new/ https://

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko created this revision. Herald added subscribers: cfe-commits, kbobyrev, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The fix improves handling of Windows UNC paths to align with Appendix E. Nonstandard Syntax Variations of RFC 8089

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

wanders updated this revision to Diff 279237. wanders retitled this revision from "[clang-format] Add SpaceAroundBitFieldColon option" to "[clang-format] Add BitFieldColonSpacing option". wanders edited the summary of this revision. wanders added a comment. Renamed option to "BitFieldColonSpacin

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus added a comment. I chased my own tail for weeks before realizing that there is indeed another instance when a live **statement** is stored, other then `ObjCForCollectionStmt`... void clang_analyzer_eval(bool); void test_lambda_refcapture() { int a = 6; [&](int &a) { a =

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske updated this revision to Diff 279248. balazske added a comment. NFC code improvements. Detect expressions in conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 Files: clang/include/clang

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

sammccall added a comment. Thanks for doing this! And sorry about the shaky windows support... (There are potentially other lurking issues due to filenames being used as keys internally, particularly case-insensitivity issues...) Comment at: clang-tools-extra/clangd/URI.cpp:2

[clang] 33c9d03 - Upgrade SmallSets of pointer-like types to SmallPtrSet

Author: Benjamin Kramer Date: 2020-07-20T16:54:29+02:00 New Revision: 33c9d0320e96ba17a3c7e84e04e22536f4b0a9e8 URL: https://github.com/llvm/llvm-project/commit/33c9d0320e96ba17a3c7e84e04e22536f4b0a9e8 DIFF: https://github.com/llvm/llvm-project/commit/33c9d0320e96ba17a3c7e84e04e22536f4b0a9e8.dif

[clang] f3f1ce4 - [Driver] Promote SmallSet of enum to a bitset. NFCI.

Author: Benjamin Kramer Date: 2020-07-20T16:54:30+02:00 New Revision: f3f1ce4fa9f49c9d862fcc873eed92fee02b0685 URL: https://github.com/llvm/llvm-project/commit/f3f1ce4fa9f49c9d862fcc873eed92fee02b0685 DIFF: https://github.com/llvm/llvm-project/commit/f3f1ce4fa9f49c9d862fcc873eed92fee02b0685.dif

[clang] 66aff32 - Issue error on invalid arithemtic conversions in C ternary

Author: Erich Keane Date: 2020-07-20T08:02:37-07:00 New Revision: 66aff3239849507861d050c013cbe17c4a5781a7 URL: https://github.com/llvm/llvm-project/commit/66aff3239849507861d050c013cbe17c4a5781a7 DIFF: https://github.com/llvm/llvm-project/commit/66aff3239849507861d050c013cbe17c4a5781a7.diff L

[PATCH] D84176: [CMake][CTE] Add "check-clang-tools-..." targets to test only a particular Clang extra tool

whisperity created this revision. whisperity added a reviewer: klimek. whisperity added a project: clang-tools-extra. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp, rnkovacs, mgorny. Herald added a project: clang. Create targets `check-clang-tools-clang-tidy`, `chec

[PATCH] D84176: [CMake][CTE] Add "check-clang-tools-..." targets to test only a particular Clang extra tool

lebedev.ri added a comment. Thank you, this would be very helpful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84176/new/ https://reviews.llvm.org/D84176 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:68 +DeadlineWaitingTime(DeadlineTime) { +ProtobufMarshaller = std::unique_ptr( +new

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added a comment. Looks like it breaks unified_shared_memory/close_enter_exit.c test. Could check this, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83922/new/ https://reviews.llvm.org/D83922

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

vsavchenko added a comment. In D83942#2156320 , @NoQ wrote: > > Sizes assigned to the projects in this commit, do not directly > > correspond to the number of lines or files in the project. > > Maybe `QUICK`/`NORMAL`/`SLOW` then? Or by purpose: > `BENCHM

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

MyDeveloperDay added a comment. Nit:clang-format the patch Here is a Tip as to what I do (In case it helps other): 1. I generate the diff off the staged items so I've already git added all the files I'm working on. 2. then I can do `git clang-format`, this will fix up any files in the diff th

[clang] 177e5ac - [Sema] Promote SmallSet of enum to bitset

Author: Benjamin Kramer Date: 2020-07-20T17:35:43+02:00 New Revision: 177e5acbe4b9ca0df3edd6b720ea8851c33baba2 URL: https://github.com/llvm/llvm-project/commit/177e5acbe4b9ca0df3edd6b720ea8851c33baba2 DIFF: https://github.com/llvm/llvm-project/commit/177e5acbe4b9ca0df3edd6b720ea8851c33baba2.dif

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 279263. arames added a comment. Herald added a subscriber: dang. Rebase on top-of-tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst

[Differential] D84067: Fix issue in typo handling which could lead clang to hang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdde98c82c0ad: Fix issue in typo handling which could lead clang to hang (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

  1   2   3   >