hokein abandoned this revision. hokein marked an inline comment as done. hokein added inline comments.
================ Comment at: clang/lib/Sema/SemaDecl.cpp:11072 // rules there don't matter.) + assert(!getLangOpts().CPlusPlus || getLangOpts().OpenCLCPlusPlus); const Expr *Culprit; ---------------- hokein wrote: > openCL for C++ is tricky, see > https://github.com/llvm/llvm-project/blob/master/clang/lib/Sema/SemaDecl.cpp#L12134-L12135. actually, I think the code is correct, the above comment is not up-to-date, so we just need to update the comment, see D84145. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84032/new/ https://reviews.llvm.org/D84032 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
