[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

lxfind added a comment. In D82928#2126018 , @fhahn wrote: > Looks like this causes a bunch of build bot failures, e.g > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31465 b > > It would be great if you could take a look. Let me rev

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7c5da57a5f3: [CodeGen] Add public function to emit C++ destructor call. (authored by zoecarver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82392/new/ h

[PATCH] D82984: Revert "[Coroutines] Fix code coverage for coroutine"

lxfind abandoned this revision. lxfind added a comment. Fix up in https://reviews.llvm.org/D82986 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82984/new/ https://reviews.llvm.org/D82984 ___ cfe-commit

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

lxfind created this revision. lxfind added reviewers: modocache, fhahn. Herald added a project: clang. Herald added a subscriber: cfe-commits. modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks for the fix! The test file in D82928

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

lxfind added a comment. In D82928#2126018 , @fhahn wrote: > Looks like this causes a bunch of build bot failures, e.g > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/31465 b > > It would be great if you could take a look. Fix patch

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/ https://reviews.llvm.org/D82986 __

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

This revision was automatically updated to reflect the committed changes. Closed by commit rGddcf063dd52f: [Coroutines] Fix test breakage in D82928 (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/ https://reviews.llvm.o

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. In D79773#2125040 , @MyDeveloperDay wrote: > Just so I'm clear for this and your Allman coment would you show me what you > are seeing and what you expect to see? just so I understand. Sure, thank you. This is what I have, as

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

rsmith accepted this revision. rsmith added a comment. This introduces a non-uniformity between `RecursiveASTVisitor` and `StmtVisitor`. `StmtVisitor` contains matching logic to treat the various kinds of unary and binary operators as if they were distinct AST node kinds, and that functionality

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay added a comment. Thank you I see now... super subtle but I'll take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

asmith added a comment. Thanks for all the helpful feedback. Before we commit this just want to double check there are no final comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77982/new/ https://reviews.llvm.org/D77982 _

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

riccibruno added a comment. In D82940#2125939 , @martong wrote: > In D82940#2125183 , @riccibruno > wrote: > > > > I'm not certain I understand, but I'm removing my LG while we figure it > > > out. Can you expound

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

chill added a comment. Needs a regression test. This patch and the dependent patch clash, better with a single patch. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:288 +static void appendNoFPUnsupportedFeatures(const arm::FloatABI ABI, +

[clang-tools-extra] e158154 - [clang-tidy] Allows the prevailing include header guard in Flang to be recognized rather than flagged as a violation in phabricator.

Author: Eric Schweitz Date: 2020-07-01T12:47:36-07:00 New Revision: e1581540876f51af1aa1389bdb21388ae88c1b90 URL: https://github.com/llvm/llvm-project/commit/e1581540876f51af1aa1389bdb21388ae88c1b90 DIFF: https://github.com/llvm/llvm-project/commit/e1581540876f51af1aa1389bdb21388ae88c1b90.diff

[PATCH] D82908: [SVE] ACLE: Fix builtins for svdup_lane_bf16 and svcvtnt_bf16_f32_x

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you. Comment at: clang/utils/TableGen/SveEmitter.cpp:1265-1279 + OS << "#if defined(__ARM_FEATURE_SVE_BF16)\n"; + OS << "#define svcvtnt_bf16_x s

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

thakis added inline comments. Comment at: clang/test/CoverageMapping/coroutine.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fcoroutines-ts -std=c++14 -emit-llvm -fprofile-instrument=clang -fcoverage-mapping -dump-coverage-mapping %s | FileCheck %s + -

[PATCH] D82807: [clang-tidy] Allows the prevailing include header guard in Flang ...

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1581540876f: [clang-tidy] Allows the prevailing include header guard in Flang to be… (authored by schweitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D82992: clang CoverageMapping tests bot cleanup

lxfind created this revision. lxfind added a reviewer: thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. D82928 generated unexpected tmp files in the CoverageMapping test directory. This patch cleans it up and remove the file in the

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

riccibruno added a subscriber: majnemer. riccibruno added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1159 + case BuiltinType::UInt128: +OS << "Ui128"; +break; riccibruno wrote: > davidstone wrote: > > riccibruno wrote: > > > `i128` and `U

[clang] ecfa0b2 - [libTooling] Fix `maybeExtendRange` to support `CharRange`s.

Author: Gabriel Matute Date: 2020-07-01T20:40:48Z New Revision: ecfa0b24189abf4bb172a8860048af05fa17daee URL: https://github.com/llvm/llvm-project/commit/ecfa0b24189abf4bb172a8860048af05fa17daee DIFF: https://github.com/llvm/llvm-project/commit/ecfa0b24189abf4bb172a8860048af05fa17daee.diff LOG

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

Nathan-Huckleberry created this revision. Herald added subscribers: llvm-commits, cfe-commits, arphaman, hiraditya, mgorny. Herald added projects: clang, LLVM. Nathan-Huckleberry edited the summary of this revision. Nathan-Huckleberry edited the summary of this revision. Nathan-Huckleberry edited

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

thakis added a comment. That's not enough, you also need to add an rm to remove the stale .LL file still on disk, see my comment on your original change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82986/new/ https://reviews.llvm.org/D82986 _

[PATCH] D82901: [libTooling] Fix `maybeExtendRange` to support `CharRange`s.

This revision was automatically updated to reflect the committed changes. Closed by commit rGecfa0b24189a: [libTooling] Fix `maybeExtendRange` to support `CharRange`s. (authored by gmatute, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D82986: [Coroutines] Fix test breakage in D82928

lxfind added a comment. In D82986#2126479 , @thakis wrote: > That's not enough, you also need to add an rm to remove the stale .LL file > still on disk, see my comment on your original change. It's in https://reviews.llvm.org/D82992 if you could help ac

[PATCH] D82967: [analyzer][tests] Measure peak memory consumption for every project

NoQ added inline comments. Comment at: clang/utils/analyzer/SATestUtils.py:113 +peak_mem = max(peak_mem, get_memory(process)) +time.sleep(.5) + Do i understand correctly that this basically adds roughly 0.25 second delay to every

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:969 + // Do not warn for non-closed stream at program exit. + if (Pred && Pred->getCFGBlock() && Pred->getCFGBlock()->hasNoReturnElement()) +return Pred; balazske wro

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 marked 5 inline comments as done. njames93 added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.cpp:124 +llvm::Optional getRegexFlag(llvm::StringRef Flag) { + for (auto &StringFlag : RegexMap) { +if (Flag == StringFlag.first)

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing temporaries created in conditional expressions

ahatanak created this revision. ahatanak added reviewers: rsmith, rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. The temporary of the true operand shouldn't be destructed when the false operand is evaluated and throws. rdar://problem/64829372

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

lebedev.ri added a comment. New files are missing standard license header blurb. Also probably missing some tests. Comment at: clang/lib/Driver/Driver.cpp:3754 + // We don't need to count the assembler as a job since it doesn't + // cause the memory issue that requires disa

[PATCH] D82807: [clang-tidy] Allows the prevailing include header guard in Flang ...

njames93 added a comment. Would you be able to add some unit tests for this in a follow up. `clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp` is where they live. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82807/new/ https://reviews.llv

[PATCH] D50229: [ARM][AArch64] Add feature +fp16fml

fpetrogalli added inline comments. Herald added a subscriber: danielkiss. Comment at: test/Driver/aarch64-cpus.c:518 +// RUN: %clang -target aarch64 -march=armv8.4-a -### -c %s 2>&1 | FileCheck -check-prefix=GENERICV84A-NO-FP16FML %s +// GENERICV84A-NO-FP16FML-NOT: "-target-feat

[clang] 9fc8772 - clang CoverageMapping tests bot cleanup

Author: Xun Li Date: 2020-07-01T16:06:56-07:00 New Revision: 9fc877213e075a76831fe71291d7c072c64c27e3 URL: https://github.com/llvm/llvm-project/commit/9fc877213e075a76831fe71291d7c072c64c27e3 DIFF: https://github.com/llvm/llvm-project/commit/9fc877213e075a76831fe71291d7c072c64c27e3.diff LOG: c

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

vabridgers created this revision. vabridgers added a reviewer: martong. Herald added subscribers: cfe-commits, teemperor, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. vabridgers updated this revision to Diff 274945. vabridgers added a

[PATCH] D83009: [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

riccibruno created this revision. riccibruno added reviewers: vabridgers, martong, aaron.ballman. riccibruno added a project: clang. Herald added subscribers: cfe-commits, rnkovacs. 05843dc6ab97a00cbde7aa4f08bf3692eb83109d chan

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

vabridgers updated this revision to Diff 274945. vabridgers added a comment. Updated commit header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83006/new/ https://reviews.llvm.org/D83006 Files: clang/unittests/AST/ASTImporterTest.cpp Index:

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 274949. jfb added a comment. Arcanist ate the rest of my commit and I am confused. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/include/clang/Basic/Builti

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

shafik created this revision. shafik added reviewers: teemperor, jingham, jasonmolenda, friss. Herald added a subscriber: kristof.beyls. shafik marked an inline comment as done. shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/lib/AST/RecordLayou

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

riccibruno added a comment. > Yes, I think that my patch just traded-off a bug for another bug. What about > the following instead: > > Initially zero the `Stmt *` for the body, then when the body is needed > (either with `getBody` or with `children`) > populate it if needed from the call oper

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

shafik marked an inline comment as done. shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1190 if (UseExternalLayout) { -// FIXME: This appears to be reversed. if (Base->IsVirtual) @rsm

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 274948. jfb added a comment. This builtin doesn't return anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/include/clang/Basic/Builtins.def Index:

[PATCH] D82992: clang CoverageMapping tests bot cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fc877213e07: clang CoverageMapping tests bot cleanup (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82992/new/ https://reviews.llvm.or

[clang] ac8d059 - typo fixes to cycle bots

Author: Nico Weber Date: 2020-07-01T19:20:05-04:00 New Revision: ac8d059c8e80fc84d16ad79d08e25010ffa114c2 URL: https://github.com/llvm/llvm-project/commit/ac8d059c8e80fc84d16ad79d08e25010ffa114c2 DIFF: https://github.com/llvm/llvm-project/commit/ac8d059c8e80fc84d16ad79d08e25010ffa114c2.diff LO

[PATCH] D82992: clang CoverageMapping tests bot cleanup

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D82992: clang CoverageMapping tests bot cleanup

lxfind added a comment. In D82992#2126898 , @MaskRay wrote: > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > > arcfilter

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

vabridgers added a comment. I confirmed that a crash was seen when the change for https://reviews.llvm.org/D82882 was reverted, then the unittests pass with the change associated with https://reviews.llvm.org/D82882. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D83006: [ASTImporter] Add unittest case for friend decl import

vabridgers updated this revision to Diff 274961. vabridgers added a comment. update for pre-merge lint checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83006/new/ https://reviews.llvm.org/D83006 Files: clang/unittests/AST/ASTImporterTest.cpp

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) yaxunl wrote: > arsenm wrote: > > I don't think the detection sho

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

MaskRay created this revision. MaskRay added reviewers: echristo, jyknight, martell, theraven, whitequark. Herald added a project: clang. Herald added a subscriber: cfe-commits. Supersedes D80225 . Add -fld-path= to avoid strange target specific prefixes and make

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > yaxunl wrote: > > arsenm wrote: > > > I don't thi

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

MaskRay added a comment. I got pinged for my GCC -fuse-ld=path patch today. On GCC side, Martin Liška is fine with clang's choice if we can reach a reasonable consensus: https://gcc.gnu.org/pipermail/gcc-patches/2020-July/549236.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D82906: [flang][openmp] Use common Directive and Clause enum from llvm/Frontend

MaskRay added a comment. In D82906#2127047 , @clementval wrote: > Fix for warning I find clang better at -Wswitch related warnings than GCC. Might be nice building llvm-project with clang and testing with `check-clang`. If you don't mind `curl | sh`, `c

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

whitequark added a comment. Thank you for making this change. IIRC I introduced `-fuse-ld=` out of frustration with the inability to change the linker path in any way other than with a shell script on `PATH`. It was not a good design. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

keith accepted this revision. keith added a comment. Awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83015/new/ https://reviews.llvm.org/D83015 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] 88874f0 - [PowerPC]Implement Vector Shift Double Bit Immediate Builtins

Author: Biplob Mishra Date: 2020-07-01T20:34:53-05:00 New Revision: 88874f07464467f3852dd662d180f7738756649b URL: https://github.com/llvm/llvm-project/commit/88874f07464467f3852dd662d180f7738756649b DIFF: https://github.com/llvm/llvm-project/commit/88874f07464467f3852dd662d180f7738756649b.diff

[PATCH] D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG88874f074644: [PowerPC]Implement Vector Shift Double Bit Immediate Builtins (authored by biplmish, committed by lei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: r

[PATCH] D83009: [clang][Serialization] Don't duplicate the body of LambdaExpr during deserialization

vabridgers added a comment. I cherry picked this change and retried the case that was failing. This change addresses the issue I was seeing. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83009/new/ https://reviews.llvm.org/D83009 __

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. Using parameter packs within non-parenthesized requires-clauses results in weird formatting: template requires std::invocable < F, std::invoke_result_t ... > struct constant; vs template requires(std::invocable...>) struct constant; CHANGES SIN

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2416 - // Double and long long should be naturally aligned if possible. + // Double, long double (only when the target supports AIX power alignment) and + // long long should be naturally

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 275005. jfb added a comment. Add memmove and memset (but still missing the codegen tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/include/clang/Basic

[PATCH] D82967: [analyzer][tests] Measure peak memory consumption for every project

vsavchenko marked 2 inline comments as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/SATestUtils.py:113 +peak_mem = max(peak_mem, get_memory(process)) +time.sleep(.5) + NoQ wrote: > Do i understand correc

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ConfigProvider.h:59 + + // Reads fragments from a single YAML file with an fixed path. + static std::unique_ptr fromYAMLFile(llvm::StringRef AbsPathPath, `a` fixed path Repository: rG LLVM

[clang] fdbd783 - Add parenthesized expression to SyntaxTree

Author: Eduardo Caldas Date: 2020-07-02T06:28:41Z New Revision: fdbd78333fc6f1deb3037d0961130f05dce059e7 URL: https://github.com/llvm/llvm-project/commit/fdbd78333fc6f1deb3037d0961130f05dce059e7 DIFF: https://github.com/llvm/llvm-project/commit/fdbd78333fc6f1deb3037d0961130f05dce059e7.diff LOG

[clang] 2a36f29 - [clang] Re-add deleted forward declaration.

Author: Alexander Belyaev Date: 2020-07-02T08:57:48+02:00 New Revision: 2a36f29fce91b6242ebd926d7c08381c31138d2c URL: https://github.com/llvm/llvm-project/commit/2a36f29fce91b6242ebd926d7c08381c31138d2c DIFF: https://github.com/llvm/llvm-project/commit/2a36f29fce91b6242ebd926d7c08381c31138d2c.d

[PATCH] D82960: Add parenthesized expression to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdbd78333fc6: Add parenthesized expression to SyntaxTree (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82960/new/ https://reviews.

[clang-tools-extra] 4da65c2 - [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

Author: Adam Balogh Date: 2020-07-01T09:04:27+02:00 New Revision: 4da65c2920b68a1cf47054a7d655cc2a19a4aa28 URL: https://github.com/llvm/llvm-project/commit/4da65c2920b68a1cf47054a7d655cc2a19a4aa28 DIFF: https://github.com/llvm/llvm-project/commit/4da65c2920b68a1cf47054a7d655cc2a19a4aa28.diff L

[clang] 40c50bd - [Sema][NFC] Remove Redundant Condition

Author: Adam Balogh Date: 2020-07-01T09:04:27+02:00 New Revision: 40c50bdee443dd48424ac7d724ced8874c40ee33 URL: https://github.com/llvm/llvm-project/commit/40c50bdee443dd48424ac7d724ced8874c40ee33 DIFF: https://github.com/llvm/llvm-project/commit/40c50bdee443dd48424ac7d724ced8874c40ee33.diff L

[clang] ea563da - [Analyzer] Fix errors in iterator modeling

Author: Adam Balogh Date: 2020-07-01T09:04:28+02:00 New Revision: ea563daae5232a03e08e43e68da813f76548f36a URL: https://github.com/llvm/llvm-project/commit/ea563daae5232a03e08e43e68da813f76548f36a DIFF: https://github.com/llvm/llvm-project/commit/ea563daae5232a03e08e43e68da813f76548f36a.diff L

[clang] 9e63b19 - [Analyzer] Handle pointer implemented as iterators in iterator checkers

Author: Adam Balogh Date: 2020-07-01T09:04:28+02:00 New Revision: 9e63b190af76c798b06b1e3b75216abfdeb1bce3 URL: https://github.com/llvm/llvm-project/commit/9e63b190af76c798b06b1e3b75216abfdeb1bce3 DIFF: https://github.com/llvm/llvm-project/commit/9e63b190af76c798b06b1e3b75216abfdeb1bce3.diff L

[clang] f3b3446 - [clang][CrossTU] Invalidate parent map after get cross TU definition.

Author: Balázs Kéri Date: 2020-07-01T09:13:05+02:00 New Revision: f3b34466104877b024e168cac054bded6b9279a0 URL: https://github.com/llvm/llvm-project/commit/f3b34466104877b024e168cac054bded6b9279a0 DIFF: https://github.com/llvm/llvm-project/commit/f3b34466104877b024e168cac054bded6b9279a0.diff L

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. In D82314#2124661 , @junparser wrote: > @lxfind This patch causes some mismatch when variable is used in both resume > and destroy function. Besides, we should move this patch and the check in > buildCoroutineFrame. @lxfind,

[PATCH] D81396: [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop`

This revision was automatically updated to reflect the committed changes. Closed by commit rG4da65c2920b6: [clang-tidy] New util `Aliasing` factored out from `bugprone-infinite-loop` (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274690. djtodoro added a comment. - Remove redundant line from the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/Code

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. @lxfind This patch causes some mismatch when variable is used in both resume and destroy function. Besides, we should move this patch and the check in buildCoroutineFrame. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/Driver/debugify-each-original.c:9 + +// RUN: rm -rf %t.json +// RUN: %clang -g -Xclang -fenable-debugify-each-original \ aprantl wrote: > I think this is redundant?

[PATCH] D82385: [Analyzer] Fix errors in iterator modeling

This revision was automatically updated to reflect the committed changes. Closed by commit rGea563daae523: [Analyzer] Fix errors in iterator modeling (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82385/new/ https://

[PATCH] D82563: [Sema][NFC] Remove Redundant Condition

This revision was automatically updated to reflect the committed changes. Closed by commit rG40c50bdee443: [Sema][NFC] Remove Redundant Condition (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82563/new/ https://revi

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3b344661048: [clang][CrossTU] Invalidate parent map after get cross TU definition. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D825

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e63b190af76: [Analyzer] Handle pointer implemented as iterators in iterator checkers (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D82185?vs=272973&id=274700#toc

[clang] a8e582c - [ThinLTO] Always parse module level inline asm with At&t dialect (PR46503)

Author: Hans Wennborg Date: 2020-07-01T09:43:45+02:00 New Revision: a8e582c8307ba1d33c05d272b5c1b755fa809b51 URL: https://github.com/llvm/llvm-project/commit/a8e582c8307ba1d33c05d272b5c1b755fa809b51 DIFF: https://github.com/llvm/llvm-project/commit/a8e582c8307ba1d33c05d272b5c1b755fa809b51.diff

[PATCH] D82862: [ThinLTO] Always parse module level inline asm with At&t dialect

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8e582c8307b: [ThinLTO] Always parse module level inline asm with At&t dialect (PR46503) (authored by hans). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] f12cd99 - [clangd] Config: compile Fragment -> CompiledFragment -> Config

Author: Sam McCall Date: 2020-07-01T10:04:19+02:00 New Revision: f12cd99c440a83d53a8717a9c8cdc4df41f39f3d URL: https://github.com/llvm/llvm-project/commit/f12cd99c440a83d53a8717a9c8cdc4df41f39f3d DIFF: https://github.com/llvm/llvm-project/commit/f12cd99c440a83d53a8717a9c8cdc4df41f39f3d.diff LO

[clang] 52f6532 - [analyzer][CrossTU] Lower CTUImportThreshold default value

Author: Endre Fülöp Date: 2020-07-01T10:08:52+02:00 New Revision: 52f65323660051a5d039d475edfd4a3018682dcb URL: https://github.com/llvm/llvm-project/commit/52f65323660051a5d039d475edfd4a3018682dcb DIFF: https://github.com/llvm/llvm-project/commit/52f65323660051a5d039d475edfd4a3018682dcb.diff L

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

rogfer01 added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:796 } return ""; } Minor nit that we missed in the patch of 0.8: can you replace this return with ```lang=cpp llvm_unreachable(); ``` as recommended in t

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall marked 8 inline comments as done. sammccall added a comment. Thanks a lot for the review, I think this is a lot better now. And particularly on where docs are lacking - I'm happy to write comments but it's hard for me to know which bits are least clear. Comment at: c

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82937 Files: clang/lib/AST/ExprCXX.cpp clang/unittests/Tooling/CMakeLists.txt clang/unittests/Tooling/CXXOperatorC

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGf12cd99c440a: [clangd] Config: compile Fragment -> CompiledFragment -> Config (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D8261

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

This revision was automatically updated to reflect the committed changes. Closed by commit rG52f653236600: [analyzer][CrossTU] Lower CTUImportThreshold default value (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82561/new/ h

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas updated this revision to Diff 274720. eduucaldas added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82937/new/ https://reviews.llvm.org/D82937 Files: clang/lib/AST/ExprCXX.cpp clang/unittests/Tooling/CMakeLists.txt

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kbobyrev updated this revision to Diff 274719. kbobyrev added a comment. Herald added a subscr

[PATCH] D82937: Fix `isInfixBinaryOp` that returned true for postfix ++

eduucaldas added a reviewer: gribozavr2. eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/CXXOperatorCallExprTest.cpp:1 +//===- unittests/Tooling/CXXOperatorCallExprTest.cpp --===// +// ---

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

kbobyrev updated this revision to Diff 274719. kbobyrev added a comment. Herald added a subscriber: ormris. %s/PrefixPath/ProjectRoot/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/ https://reviews.llvm.org/D82938 Files: clang-tools-e

[clang-tools-extra] 7dcc385 - [clangd] Fix name conflict again, unbreak GCC. NFC

Author: Sam McCall Date: 2020-07-01T11:28:25+02:00 New Revision: 7dcc3858e72666dc12240c8a4bd278775cd807ea URL: https://github.com/llvm/llvm-project/commit/7dcc3858e72666dc12240c8a4bd278775cd807ea DIFF: https://github.com/llvm/llvm-project/commit/7dcc3858e72666dc12240c8a4bd278775cd807ea.diff LO

[PATCH] D82891: [clangd] Fix race in FileIndex that sometimes temporarily lost updates.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.h:97 + unsigned Version = 0; llvm::StringMap> SymbolsSnapshot; oh and also maybe use `size_t` ? as there's only one (well three actually, if you count both preamble and m

[PATCH] D82891: [clangd] Fix race in FileIndex that sometimes temporarily lost updates.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:269 + +++this->Version; +if (Version) Bumping the version in `update` and

[PATCH] D82940: [ASTReader][ASTWriter][PCH][Modules] Fix (de)serialization of SwitchCases

martong created this revision. martong added reviewers: vabridgers, riccibruno, aaron.ballman. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a project: clang. https://github.com/llvm/llvm-project/commit/05843dc6ab97a00cbde7aa4f08bf3692eb83109d introduc

[PATCH] D81169: [clangd] Improve hover on arguments to function call

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang-tools-extra/clangd/Hover.cpp:929 +if (CallPassType->PassBy != HoverInfo::PassType::Value) {

[PATCH] D82943: [SVE] Add more warnings checks to clang and LLVM SVE tests

david-arm created this revision. david-arm added reviewers: sdesmalen, ctetreau, kmclaughlin. Herald added subscribers: llvm-commits, cfe-commits, psnobl, arphaman, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: efriedma. Herald added projects: clang, LLVM. There a

[PATCH] D81787: [clang] Fix the serialization of LambdaExpr and the bogus mutation in LambdaExpr::getBody

martong added a comment. This patch causes a regression (crash) during the deserialization of certain functions. Please see the details and review the supposed fix here: https://reviews.llvm.org/D82940 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82288/new/ https://reviews.llvm.org/D82288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 070acb1 - [Driver][ARM] parse version of arm/thumb architecture correctly

Author: Daniel Kiss Date: 2020-07-01T12:13:52+02:00 New Revision: 070acb1d1e51ffd289a46b8f93e993635d0053b7 URL: https://github.com/llvm/llvm-project/commit/070acb1d1e51ffd289a46b8f93e993635d0053b7 DIFF: https://github.com/llvm/llvm-project/commit/070acb1d1e51ffd289a46b8f93e993635d0053b7.diff L

<    1   2   3   >