NoQ added inline comments.
================ Comment at: clang/utils/analyzer/SATestUtils.py:113 + peak_mem = max(peak_mem, get_memory(process)) + time.sleep(.5) + ---------------- Do i understand correctly that this basically adds roughly 0.25 second delay to every invocation of the analyzer? If so, that may add up to a lot of seconds for a project with many small translation units which can potentially screw our wall clock measurements. I guess the ideal solution would be some sort of "select" that waits on process termination with timeout, or we could simply decrease the sleep interval and hope it won't consume too much cpu time. ================ Comment at: clang/utils/analyzer/requirements.txt:1-2 +humanize +psutil ---------------- Dunno, should we bother putting every utility into its own directory with its own requirements? Like, `exploded-graph-rewriter.py` certainly has different requirements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82967/new/ https://reviews.llvm.org/D82967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
