[PATCH] D79219: [CMake] Simplify CMake handling for zlib

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks Petr, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:2 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \ +// RUN: FileCheck %s -

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

zoecarver updated this revision to Diff 274616. zoecarver added a comment. - Remove `emitCXXDestructorCall` and add `getCXXDestructorImplicitParam`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82392/new/ https://reviews.llvm.org/D82392 Files:

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100 + + Finds pointers with the `noescape` attribute that are captured by an + asynchronously-executed block. Please use double back-ticks for language constructs. Repos

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis updated this revision to Diff 274618. ellis added a comment. Applied changes suggested in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 Files: clang-tools-extra/clang-tidy/bugprone/Bugpro

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

zoecarver added a comment. @rjmccall I updated this patch to introduce the function `getCXXDestructorImplicitParam` instead. This should be closer to D79942 . It seems like there is never more than one implicit parameter so, I just have it return a single `llvm:

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

tra added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:750 +bool Sema::CUDACheckLambdaCapture(CXXMethodDecl *Callee, + const sema::Capture &Capture) { What does the return value mean? We don't seem to check it anyway

[clang] 89a0c40 - [clang][diagnostics] Add '-Wundef-prefix' warning option

Author: Zixu Wang Date: 2020-06-30T13:57:47-07:00 New Revision: 89a0c4066b0e70edd257e30d7189f303e26251a0 URL: https://github.com/llvm/llvm-project/commit/89a0c4066b0e70edd257e30d7189f303e26251a0 DIFF: https://github.com/llvm/llvm-project/commit/89a0c4066b0e70edd257e30d7189f303e26251a0.diff LOG

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall updated this revision to Diff 274623. sammccall marked 13 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612 Files: clang-tools-

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis updated this revision to Diff 274622. ellis added a comment. Add double backtick to doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModul

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen marked 3 inline comments as done. aelitashen added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:337-340 +std::string(module.GetFileSpec().GetFilename())); + std::string module_path = std::string(module.GetFileSpec().GetDirectory()) + +

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65 +if (F.HasUnrecognizedCondition) + Conditions.push_back([&](const Params &) { return false; }); + hokein wrote: > sammccall wrote: > > hokein wrote: > > > I think

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev , I'm considering emitting an extra dimension for a non-contiguous descriptor to support stride in this patch (stride = 1 in array section is just a special case for computing stride, however, the formula computing stride do not change). Do you think I should do

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

probinson added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2155 + +Emit debug info for types that are unused but defined by the program. + I think this description goes counter to how other options are described, which basically is abo

[PATCH] D82642: [clangd] Run formatting operations asynchronously.

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:900 + llvm::Expected Result) mutable { +if (Result) + Reply(replacementsToEdits(Code, Result.get())); k

[clang-tools-extra] ffa63dd - [clangd] Run formatting operations asynchronously.

Author: Sam McCall Date: 2020-07-01T00:52:08+02:00 New Revision: ffa63dde8e97a34b8914a151556551f74d4227e7 URL: https://github.com/llvm/llvm-project/commit/ffa63dde8e97a34b8914a151556551f74d4227e7 DIFF: https://github.com/llvm/llvm-project/commit/ffa63dde8e97a34b8914a151556551f74d4227e7.diff LO

[clang] b6c4903 - A constexpr virtual function is implicitly inline so should never be a

Author: Richard Smith Date: 2020-06-30T16:07:50-07:00 New Revision: b6c490349d1524aefeb1c4a686411f860e6a3555 URL: https://github.com/llvm/llvm-project/commit/b6c490349d1524aefeb1c4a686411f860e6a3555 DIFF: https://github.com/llvm/llvm-project/commit/b6c490349d1524aefeb1c4a686411f860e6a3555.diff

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 274634. aelitashen added a comment. Make LLDB take care of the directory delimiter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files: clang/tools/clang-format/

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

lei added a comment. Please move encoding tests to `ppc64-encoding-ISA31.[txt|s]`. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:13792 + if ((LD->getValueType(0) != MVT::i128) || + (LD->getExtensionType() != ISD::ZEXTLOAD) || (!ValidLDType)) +return SDValue(

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

jkorous added a comment. Your patch definitely fixes the symptoms of the bug. I just want to make sure that we aren't covering some logic error with a bandaid as it would be harder to find out the root cause once we land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:967 + URIForFile FileURI = Params.textDocument.uri; + Server->foldingRanges( + Params.textDocument.uri.file(), one we fix the signature, you should just be able to pa

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 274636. nickdesaulniers added a comment. - fix documentation double negation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangCommandLin

[PATCH] D82642: [clangd] Run formatting operations asynchronously.

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rGffa63dde8e97: [clangd] Run formatting operations asynchronously. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. constexpr plane(const plane& other) noexcept( (detail::default_allocator_is_nothrow && std::is_nothrow_copy_constructible_v)) requires(std::copyable) : plane{to1d(other), other.sz.w} { } Without the parentheses in trailing requires-clauses, all cod

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: rsmith, sammccall, ymandel, aaron.ballman. gribozavr updated this revision to Diff 274643. gribozavr added a comment. Removed obsolete comments. This feature was on

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

gribozavr updated this revision to Diff 274643. gribozavr added a comment. Removed obsolete comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82921/new/ https://reviews.llvm.org/D82921 Files: clang-tools-extra/clang-tidy/modernize/LoopConv

[PATCH] D82924: [clang-tidy] fix cppcoreguidelines-init-variables with catch variables

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. Ignore catch statement var decls. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D8292

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

hctim created this revision. hctim added reviewers: morehouse, Dor1s. Herald added a project: clang. Herald added a subscriber: cfe-commits. Probably a useful feature for checking whether a file was built with -fsanitize=fuzzer or -fsanitize=fuzzer-no-link. N.B. __has_feature(fuzzing_coverage) do

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis marked an inline comment as done. ellis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:125 +CheckFactories.registerCheck( +"bugprone-no-escape"); CheckFactories.registerCheck( Not sure if we

[PATCH] D82924: [clang-tidy] fix cppcoreguidelines-init-variables with catch variables

njames93 updated this revision to Diff 274655. njames93 added a comment. New line at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82924/new/ https://reviews.llvm.org/D82924 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitV

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

hctim updated this revision to Diff 274656. hctim added a comment. Changed the filename and fixed up the inverted test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82926/new/ https://reviews.llvm.org/D82926 Files: clang/include/clang/Basic/Fea

[PATCH] D82924: [clang-tidy] fix cppcoreguidelines-init-variables with catch variables

njames93 updated this revision to Diff 274654. njames93 added a comment. Herald added a subscriber: wuzish. Remove unneeded include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82924/new/ https://reviews.llvm.org/D82924 Files: clang-tools-extra

[PATCH] D82926: [libfuzzer] [clang] Add __has_feature(fuzzing_coverage)

morehouse added a comment. Can we just use `FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION` instead? I'm a little wary of introducing a new way to do conditional compilation since fuzzers that don't use sancov can't rely on it. Repo

[clang] 4eff2be - [c++20] consteval functions don't get vtable slots.

Author: Richard Smith Date: 2020-06-30T18:22:09-07:00 New Revision: 4eff2beefb2b655fc02d35de235fc86d72d05755 URL: https://github.com/llvm/llvm-project/commit/4eff2beefb2b655fc02d35de235fc86d72d05755 DIFF: https://github.com/llvm/llvm-project/commit/4eff2beefb2b655fc02d35de235fc86d72d05755.diff

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

pfultz2 added inline comments. Comment at: clang/test/SemaCUDA/lambda.cu:27 + +kernel<<<1,1>>>([&](){ hd(b); }); +// dev-error@-1 {{capture host side class data member by this pointer in device or host device lambda function}} Will this still produce dia

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

steven.zhang added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:86 + +HasStrictFP = true; } nemanjai wrote: > I don't think we need this for now. Close is not quite there. @steven.zhang I > would prefer that we initially turn this off and on

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

amyk updated this revision to Diff 274667. amyk added a comment. Update patch to: - place MC tests in correct files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82431/new/ https://reviews.llvm.org/D82431 Files: clang/include/clang/Basic/Builti

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

ahatanak added a comment. Thank you, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

amyk updated this revision to Diff 274672. amyk added a comment. Update the patch to place MC tests into appropriate files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82467/new/ https://reviews.llvm.org/D82467 Files: clang/lib/Headers/altivec

[PATCH] D82562: Implement AVX ABI Warning/error

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM other than that one minor. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2515 + SourceLocation CallLoc, + ll

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

lei requested changes to this revision. lei added a comment. This revision now requires changes to proceed. Please move encoding tests to ppc64-encoding-ISA31.[txt|s]. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:108 + signed char *__c) { +

[PATCH] D81836: [PowerPC][Power10] Implement Vector Permute Builtins in LLVM/Clang

biplmish updated this revision to Diff 274670. biplmish added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81836/new/ https://reviews.llvm.org/D81836 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Headers/altivec.h clang/lib/Sema/SemaChecking.cpp clang/tes

[PATCH] D82928: [Coroutines] Fix code coverage for coroutine

lxfind created this revision. lxfind added reviewers: lewissbaker, modocache, junparser. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, source-based coverage analysis does not work properly for coroutine. This patch adds processing of coroutine body and co_retur

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

lei accepted this revision. lei added a comment. LGTM thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82431/new/ https://reviews.llvm.org/D82431 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

anchu-rajendran accepted this revision. anchu-rajendran added a comment. This revision is now accepted and ready to land. LGTM :). Thanks! Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1543 +OMPBuilder->getOrCreateIdent(SrcLocStr)); + } Nit: I th

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

amyk marked an inline comment as done. amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:108 + signed char *__c) { + // CHECK-BE: store i8 %{{.+}}, i8* %{{.+}}, align 1 + // CHECK-LE: store i8 %{{.+}}, i8* %{{.+}}, ali

[PATCH] D82930: [HIP] Fix rocm detection

yaxunl created this revision. yaxunl added reviewers: tra, arsenm. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. Do not detect device library by default in rocm detector. Only detect device library in HIP toolchain. Detect rocm path by version file in host toolchains. Also added d

[PATCH] D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

amyk updated this revision to Diff 274679. amyk edited the summary of this revision. amyk added a parent revision: D82584: [PowerPC][Power10] Exploit the High Order Vector Multiply Instructions on Power10. amyk added a comment. Rebased patch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

amyk updated this revision to Diff 274680. amyk edited the summary of this revision. amyk added a parent revision: D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests. amyk added a comment. Rebase patch, remove MC tests fro

[clang] 83fae3f - [CodeComplete] Add code completion after function equals

Author: lh123 Date: 2020-07-01T12:51:25+08:00 New Revision: 83fae3f762699655a4329fe3cf6fd3e2a2617559 URL: https://github.com/llvm/llvm-project/commit/83fae3f762699655a4329fe3cf6fd3e2a2617559 DIFF: https://github.com/llvm/llvm-project/commit/83fae3f762699655a4329fe3cf6fd3e2a2617559.diff LOG: [C

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 added a comment. In D82548#2124546 , @MaskRay wrote: > Hi, your git commit contains extra Phabricator tags. You can drop > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > commit with the following script: > > arcfilter

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83fae3f76269: [CodeComplete] Add code completion after function equals (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D82548?vs=274496&id=274685#toc Repository: rG LLVM Github

[PATCH] D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

eduucaldas added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:649 + case BO_##NAME: \ +if (isSameMethod(&RecursiveASTVisitor::TraverseBin##NAME, \ +

[PATCH] D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased

eduucaldas accepted this revision. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:501 WalkUpFromStmt IntegerLiteral(1) -WalkUpFromBinaryOperator BinaryOperator(+) - WalkUpFromExpr BinaryOperator(+) -WalkUpFromS

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

MaskRay added a comment. In D82548#2124549 , @lh123 wrote: > In D82548#2124546 , @MaskRay wrote: > > > Hi, your git commit contains extra Phabricator tags. You can drop > > `Reviewers:` `Subscribers:` `Tags:` and t

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

fghanim marked 3 inline comments as done. fghanim added a comment. In D79677#2119019 , @kiranchandramohan wrote: > Is the ordering of code generation for clauses important? > copyin -> firstprivate -> barrier -> private if we emitted a copyin, then pro

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

milianw added a comment. this relates to https://reviews.llvm.org/D82740 too, but comes with a test which is good. personally I would place the check directly within Visit to make it more generically prevent a crash on invalid input, but that's probably a subjective design decision. Repositor

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65 +if (F.HasUnrecognizedCondition) + Conditions.push_back([&](const Params &) { return fa

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. +1 to the complexity argument, and also for conceptual complexity: there's a lot of value in RAV being regular and predictable given that both its implementation and the AST itself are c

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw added a comment. Also see https://reviews.llvm.org/D82629 which I believe is also a fix for this crash. But I didn't use a VLA in my code, but maybe the parse error just triggered something similar like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw added a comment. @jkorous how would you use a debugger (would be GDB for me) to find the source - I would have to use RR or something like that to see why and where the invalid node is added, no? I also don't have the breaking code at hand anymore, I can try to come up with a way to re

<    1   2   3