[clang] c02332a - [CodeGen] Fix warning in getNode for EXTRACT_SUBVECTOR

Author: David Sherwood Date: 2020-06-30T08:11:41+01:00 New Revision: c02332a69399a82244298f0097bc98fafdeb3042 URL: https://github.com/llvm/llvm-project/commit/c02332a69399a82244298f0097bc98fafdeb3042 DIFF: https://github.com/llvm/llvm-project/commit/c02332a69399a82244298f0097bc98fafdeb3042.diff

[PATCH] D82526: [AST][RecoveryExpr] Add error-bit to NestNameSpecifierDependence and TemplateNameDependence.

hokein added a comment. friendly ping, we start encountering this crash in production. another reduced testcase: using a = decltype(b())::a; template < class c > class d { using UnderlyingBuilder = c::UnderlyingBuilder:template < class > class e class f { using g = Un

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

hokein marked an inline comment as done. hokein added a comment. In D82771#2120214 , @klimek wrote: > In what situation are we calling child matchers repeatedly with the same > matcher on the same node? I guess a pattern like https://github.com/llvm/ll

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

hokein updated this revision to Diff 274347. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82771/new/ https://reviews.llvm.org/D82771 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp Index: clang/lib/AS

[PATCH] D82844: [clangd] Set gRPC deadlines to all remote index requests

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. "TL;DR: Always set a deadline.", https://grpc.io/blog/deadlines/ Repository: rG LLVM Gith

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. balazske added a

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske added a comment. Why does this not work? I get only warning for the first resource leak (in the test `f_leak_2`). How to fix this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82845/new/ https://reviews.llvm.org/D82845 ___

[PATCH] D82746: [CodeGen] Fix warning in getNode for EXTRACT_SUBVECTOR

This revision was automatically updated to reflect the committed changes. Closed by commit rGc02332a69399: [CodeGen] Fix warning in getNode for EXTRACT_SUBVECTOR (authored by david-arm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://revi

[PATCH] D82793: [clangd] Suppress GCC -Woverloaded-virtual by renaming ThreadsafeFS extension point

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/clangd/Preamble.cpp:232 class EmptyFS : public ThreadsafeFS { public: +llvm::IntrusiveRefCntPtr viewImpl() const ove

[PATCH] D82642: [clangd] Run formatting operations asynchronously.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Looks nice just a couple of nits. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:900 + llvm::Expected Result) mutable { +if (Result) +

[PATCH] D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation.

RKSimon added a comment. LGTM with a couple of minors Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2835 // CHECK_ZNVER1_M32: #define __F16C__ 1 +// CHECK_ZNVER1_M32-NOT: #define __FMA4__ 1 // CHECK_ZNVER1_M32: #define __FMA__ 1 The additional

[PATCH] D82729: [clangd] Make sure headers are available in FS inside FindSymbolsTests

kadircet added a comment. In D82729#2120647 , @sammccall wrote: > Why? workspaceSymbols depends on the index only. > ISTM the dynamic index + blockUntilIdle should be enough - what does the FS > have to do with it? Yes it does, but tests that I updated

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal added a comment. In D79400#2121685 , @vsapsai wrote: > Seems like this change causes `ninja clean` to fail with the error > > > ninja: error: remove(include/llvm/Support): Directory not empty > > Full repro steps are > > > ninja install >

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 updated this revision to Diff 274353. njames93 added a comment. Address doc backticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82824/new/ https://reviews.llvm.org/D82824 Files: clang-tools-extra/clang-tidy/readability/ElseAfterRet

[clang-tools-extra] 60cde47 - [clang-tidy][docs] Fix malformed link in ReleaseNotes

Author: Nathan James Date: 2020-06-30T09:17:48+01:00 New Revision: 60cde47893476581218c380921e5489c98be40ce URL: https://github.com/llvm/llvm-project/commit/60cde47893476581218c380921e5489c98be40ce DIFF: https://github.com/llvm/llvm-project/commit/60cde47893476581218c380921e5489c98be40ce.diff

[PATCH] D82714: [clangd] Remove redundant `findRefs` calls. NFC.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Oops, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82714/new/ https://reviews.llvm.org/D82714 _

[PATCH] D82844: [clangd] Set gRPC deadlines to all remote index requests

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:63 + std::shared_ptr Channel, + std::chrono::milliseconds DeadlineTime = std::chrono::millise

[PATCH] D82526: [AST][RecoveryExpr] Add error-bit to NestNameSpecifierDependence and TemplateNameDependence.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DependenceFlags.h:67 -struct TemplateArgumentDependenceScope { - enum TemplateArgumentDependence : uint8_t { -UnexpandedP

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

klimek added a comment. In D82771#2121924 , @hokein wrote: > In D82771#2120214 , @klimek wrote: > > > In what situation are we calling child matchers repeatedly with the same > > matcher on the same node? > > > I g

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 updated this revision to Diff 274359. njames93 added a comment. Address doc backticks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82825/new/ https://reviews.llvm.org/D82825 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ee439b705e8: [builtins] Change si_int to int in some helper declarations (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

olestrohm added a comment. Essentially, in each pass the type for the variable starts off being extract from the SourceTypeInfo, but since the address space isn't specified, this type is then missing an address space. Adding the address space deduction then reintroduces the address space to the

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/new/ https://reviews.llvm.org/D75453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82631: [AST][RecoveryAST] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaTemplate/missing-typename-recovery.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s + nit: name of this test seems sli

[PATCH] D82626: [CodeComplete] Tweak completion for else.

sammccall added a comment. I like the behavior in this patch - I think multiple options is going to be distracting and crowd out other good results, and the heuristic seems pretty good. This needs a test in e.g. `llvm-project/clang/test/CodeCompletion/patterns.cpp`. Comment

[clang] d28267f - [AST][RecoveryExpr] Add error-bit to NestNameSpecifierDependence and TemplateNameDependence.

Author: Haojian Wu Date: 2020-06-30T11:56:24+02:00 New Revision: d28267f9810ce8642b27279b91a3a195ba932ce2 URL: https://github.com/llvm/llvm-project/commit/d28267f9810ce8642b27279b91a3a195ba932ce2 DIFF: https://github.com/llvm/llvm-project/commit/d28267f9810ce8642b27279b91a3a195ba932ce2.diff LO

[clang-tools-extra] 84ced55 - [clangd] Remove redundant `findRefs` calls. NFC.

Author: lh123 Date: 2020-06-30T18:10:52+08:00 New Revision: 84ced55d9b7bade7c9db39f3bcebc6af333dc325 URL: https://github.com/llvm/llvm-project/commit/84ced55d9b7bade7c9db39f3bcebc6af333dc325 DIFF: https://github.com/llvm/llvm-project/commit/84ced55d9b7bade7c9db39f3bcebc6af333dc325.diff LOG: [c

[PATCH] D81456: [clangd] Get rid of WantDiagnostics::Yes

sammccall added a comment. Sorry for the long delay here... Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:670 auto Version = DraftMgr.addDraft(File, Params.textDocument.version, Contents); - Server->addDocument(File, Contents, encodeVersion(Version), -

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

gamesh411 added a comment. Good job, massive props to you for such an overhaul. Comment at: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h:155 /// Constructs a CheckerManager without requiring an AST. No checker - /// registration will take place. Only useful for

[PATCH] D81750: [analyzer] Don't allow hidden checkers to emit diagnostics

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. LGTM if nobody is against moving the checker. I will accept nevertheless. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81750/new/ https:/

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

hokein added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:41 + ConfigCompile.cpp ConfigYAML.cpp Diagnostics.cpp sammccall wrote: > hokein wrote: > > we have a few config-related files now, I wonder would it make sense to > > create

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

Szelethus added a comment. In D82845#2121940 , @balazske wrote: > Why does this not work? > I get only warning for the first resource leak (in the test `f_leak_2`). How > to fix this? First off, are two errors detected by the checker? You could check t

[PATCH] D82714: [clangd] Remove redundant `findRefs` calls. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG84ced55d9b7b: [clangd] Remove redundant `findRefs` calls. NFC. (authored by lh123). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82714/new/ https://reviews

[PATCH] D82526: [AST][RecoveryExpr] Add error-bit to NestNameSpecifierDependence and TemplateNameDependence.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd28267f9810c: [AST][RecoveryExpr] Add error-bit to NestNameSpecifierDependence and… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82526

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

sammccall added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11968 bool AfterAmpersand); + void CodeCompleteFunctionDeleteAndDefaultSpecifier(); nit: "specifier" isn't an accurate term here. I don't know tha

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/CheckerRegistryData.h:83 + +using CmdLineOptionList = llvm::SmallVector; + gamesh411 wrote: > Could you please explain why use zero fo

[PATCH] D81728: [InstCombine] Add target-specific inst combining

foad added a subscriber: bogner. foad added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:1444 + *this, *II, DemandedElts, UndefElts, UndefElts2, UndefElts3, + simplifyAndSetOp, &V)) +return V; -

[PATCH] D82856: [analyzer][Z3-refutation] Add statistics for refutation visitor

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, Szelethus, martong. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. This patc

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

sammccall added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:468 +// Memoize result even doing a single-level match, it might be expensive. +Key.Type = MaxDepth == 1 ? MatchType::Child : MatchType::Descendants; MemoizationMap::iterator I = Re

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:328-331 + HelpText<"Enable migration to modern ObjC literals">, + MarshallingInfoFlag<"FrontendOpts.ObjCMTAction", "0", "unsigned">, Normalizer<"normalizeFlagTo

[PATCH] D82738: [clang] Fix a null-NSS-access crash in DependentNameType.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:4869 LookupResult::NotFoundInCurrentInstantiation) { +if (SS.isEmpty()) + // bail out if we don't have a NNS, this could be happened during two concerns h

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith. Herald added projects: clang, LLVM. dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Driver/Option

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

sammccall added a comment. (I can't quite follow the original reason for disabling memoization in the non-recursive case, so this seems reasonable but going to leave that to Manuel who knew the argument) Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:468 +// Memoize

[PATCH] D82856: [analyzer][Z3-refutation] Add statistics for refutation visitor

xazax.hun added a comment. Yay! This looks good to me and I love statistics, so a huge +1. I have one question though. Isn't this counting all the reports in an equivalence class? I.e. if the analyzer finds something multiple times it will only be displayed once but here it will be counted mult

[PATCH] D82862: [ThinLTO] Always parse module level inline asm with At&t dialect

hans created this revision. hans added a reviewer: pcc. Herald added subscribers: llvm-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: LLVM. clang-cl passes -x86-asm-syntax=intel to the cc1 invocation so that assembly listings produced by the /FA flag are printed in

[clang] 33bae9c - [AST] Fix handling of some edge cases in fixed-point division.

Author: Bevin Hansson Date: 2020-06-30T13:47:12+02:00 New Revision: 33bae9c265486cd37e0612711a863f0a4b865a26 URL: https://github.com/llvm/llvm-project/commit/33bae9c265486cd37e0612711a863f0a4b865a26 DIFF: https://github.com/llvm/llvm-project/commit/33bae9c265486cd37e0612711a863f0a4b865a26.diff

[PATCH] D81761: [analyzer] Force dependency checkers to be hidden

baloghadamsoftware added a comment. In D81761#2097737 , @Szelethus wrote: > In D81761#2097561 , @balazske wrote: > > > My observation is, if there is an example checker, it should be really > > "example" and not "t

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

ASDenysPetrov added a comment. @NoQ, thanks for the examples. I didn't get the first one. How do you get to the "//In reality we don't know//", if we don't touch `a[index1]`: void test1(int *a, int index1, int index2) { int x = a[index1]; a[index2] = 0; int y = a[index1]; /

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

martong added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:723 + // Parent map is invalidated after changing the AST. + ToDecl->getASTContext().getParentMapContext().clear(); + > ... the TU is modified by getCrossTUDefinition the pare

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:468 +// Memoize result even doing a single-level match, it might be expensive. +Key.Type = MaxDepth == 1 ? Mat

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson updated this revision to Diff 274427. arichardson added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478 F

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang updated this revision to Diff 274425. dang added a comment. Denormalizer should also use the extractor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files: clang/include/clang/Driver/Options.td c

[PATCH] D82856: [analyzer][Z3-refutation] Add statistics for refutation visitor

steakhal added a comment. In D82856#2122330 , @xazax.hun wrote: > Yay! This looks good to me and I love statistics, so a huge +1. > I have one question though. Isn't this counting all the reports in an > equivalence class? I.e. if the analyzer finds som

[PATCH] D82729: [clangd] Make sure headers are available in FS inside FindSymbolsTests

sammccall added a comment. In D82729#2121999 , @kadircet wrote: > Yes it does, but tests that I updated are also adding a "foo.cpp" file, which > tries to include some headers. Those headers can only be retrieved from FS > and not from the dirty buffer (

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:16 +// CHECK: Force set function attributes: {{.*}} +// CHECK-NEXT: Infer set function attributes: {{.*}} +// CHECK-NEXT: Interprocedural Sparse Co

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

phil-blain added a comment. Great, thanks ! Note that I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82733/new/ https://reviews.llvm.org/D82733 ___ cfe-commits mailing list c

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274433. djtodoro added a comment. - Add the Driver test - Remove the old high level test in order to avoid troubles when someone updates an LLVM pass with the impact on Debugify output (e.g. a new debug info bugs) - clang-formatted CHANGES SINCE LAST ACTI

[PATCH] D82815: [clang-tidy] Sanity checks in ClangTidyTest header.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM (the harbormaster failure looks unrelated to your changes from what I can tell) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ExprObjC.h:1719-1721 + VersionTuple getVersion() { return VersionToCheck.Version; } + VersionTuple getVersionAsWritten() { return VersionToCheck.SourceVersion; } Any reason these functio

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82720/new/ https://reviews.llvm.org/D82720

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-else-after-return.rst:67 + + When `true`, Emit a warning for cases where the check can't output a + Fix-It. These can occur with declarations inside the ``else`` branch tha

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-else-after-return.rst:3 +.. meta:: + :http-equiv=refresh: 5;URL=readability-else-after-return.html + Hmmm, this means users have five seconds to read the text below

[clang-tools-extra] 7256898 - [clangd] Suppress GCC -Woverloaded-virtual by renaming ThreadsafeFS extension point

Author: Sam McCall Date: 2020-06-30T15:06:15+02:00 New Revision: 72568984b8040fa8de70a6b4f9c63b6a5aac8d3f URL: https://github.com/llvm/llvm-project/commit/72568984b8040fa8de70a6b4f9c63b6a5aac8d3f DIFF: https://github.com/llvm/llvm-project/commit/72568984b8040fa8de70a6b4f9c63b6a5aac8d3f.diff LO

[clang] 05c4794 - Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB

Author: serge-sans-paille Date: 2020-06-30T15:13:53+02:00 New Revision: 05c479491c1d3236cae4eccaa3fcd2794598522c URL: https://github.com/llvm/llvm-project/commit/05c479491c1d3236cae4eccaa3fcd2794598522c DIFF: https://github.com/llvm/llvm-project/commit/05c479491c1d3236cae4eccaa3fcd2794598522c.d

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

kpn added a comment. Ping. I'm really hoping to get this into 11. Otherwise we're going multiple releases with options that people already use causing crashes on most architectures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952 ___

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. dang edited the summary of this revision. Keep track of -fansi-escape-codes in DiagnosticOptions and move the option to the new option parsing system. D

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-else-after-return.rst:3 +.. meta:: + :http-equiv=refresh: 5;URL=readability-else-after-return.html + aaron.ballman wrote: > Hmm

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

Szelethus updated this revision to Diff 274445. Szelethus added a comment. Fixes according to reviewer comments! edit: from @gamesh411. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82585/new/ https://reviews.llvm.org/D82585 Files: clang/include/clang/StaticAnalyzer/Core/CheckerMana

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-else-after-return.rst:74 + + When `true`, The check will attempt to refactor a variable defined inside + the condition of the ``if`` st

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

balazske added a comment. It looks like that the dependency manipulation and computation functions, and the checker and option add functions can be member of `CheckerRegistryData`. It would be a bit more simple (no `Data.` call), and these belong naturally to there. Comment

[PATCH] D82291: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB

This revision was automatically updated to reflect the committed changes. Closed by commit rG05c479491c1d: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LL

[PATCH] D82793: [clangd] Suppress GCC -Woverloaded-virtual by renaming ThreadsafeFS extension point

This revision was automatically updated to reflect the committed changes. Closed by commit rG72568984b804: [clangd] Suppress GCC -Woverloaded-virtual by renaming ThreadsafeFS extension… (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D82793?vs=274181&id=274451#toc Re

[clang] 9f86524 - [ASTMatcher] Fix a performance regression: memorize the child match.

Author: Haojian Wu Date: 2020-06-30T15:43:51+02:00 New Revision: 9f865246a81759cdcb056c883e6f92fe6693b3d3 URL: https://github.com/llvm/llvm-project/commit/9f865246a81759cdcb056c883e6f92fe6693b3d3 DIFF: https://github.com/llvm/llvm-project/commit/9f865246a81759cdcb056c883e6f92fe6693b3d3.diff LO

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane updated this revision to Diff 274450. erichkeane marked an inline comment as done. erichkeane added a comment. As @craig.topper suggested, extract the four lookups into 2 bool instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82562/new/ https://reviews.llvm.org/D82562 F

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1952 +std::shared_ptr createAndVerifyRegex(StringRef Regex, + llvm::Regex::RegexFlags Flags, Is there a reas

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

Quuxplusone abandoned this revision. Quuxplusone added a comment. Superseded by D82793 . :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82736/new/ https://reviews.llvm.org/D82736 ___

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

riccibruno added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4539 +if (CXXRecordDecl *T2RecordDecl = +dyn_cast(T2RecordType->getDecl())) { + const auto &Conversions = T2RecordDecl->getVisibleConversionFunctions(); ArcsinX wrote: > ri

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

Szelethus marked 6 inline comments as done. Szelethus added a comment. In D82585#2122634 , @balazske wrote: > It looks like that the dependency manipulation and computation functions I guess there are two ways of looking at this: - CheckerRegistry only

[PATCH] D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:398 -TEST(RecursiveASTVisitor, StmtCallbacks_TraverseBinaryOperator) { +TEST(RecursiveASTVisitor, StmtCallbacks_TraverseUnar

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-else-after-return.rst:74 + + When `true`, The check will attempt to refactor a variable defined inside + the condition of the ``if`` statement that is used in the ``else`` b

[PATCH] D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: ymandel, eduucaldas. gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/RecursiveAST

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f865246a817: [ASTMatcher] Fix a performance regression: memorize the child match. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82771/

[libunwind] 70f6389 - [runtimes] Rename newformat to just format, now that the old format has been removed

Author: Louis Dionne Date: 2020-06-30T10:10:30-04:00 New Revision: 70f6389257a85a8fa7f128a05a1ccbd0dbba191c URL: https://github.com/llvm/llvm-project/commit/70f6389257a85a8fa7f128a05a1ccbd0dbba191c DIFF: https://github.com/llvm/llvm-project/commit/70f6389257a85a8fa7f128a05a1ccbd0dbba191c.diff

[clang] d285f29 - [AST][RecoveryExpr] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

Author: Haojian Wu Date: 2020-06-30T16:18:32+02:00 New Revision: d285f29317d6086e9ab941730f1ee5a468196a4e URL: https://github.com/llvm/llvm-project/commit/d285f29317d6086e9ab941730f1ee5a468196a4e DIFF: https://github.com/llvm/llvm-project/commit/d285f29317d6086e9ab941730f1ee5a468196a4e.diff LO

[PATCH] D81761: [analyzer] Force dependency checkers to be hidden

Szelethus updated this revision to Diff 274466. Szelethus added a comment. Revert changes to plugins and to the related tests, allow the `example` package to bypass the new restriction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81761/new/ https://reviews.llvm.org/D81761 Files: c

[PATCH] D82631: [AST][RecoveryAST] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

hokein updated this revision to Diff 274463. hokein added a comment. rename the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82631/new/ https://reviews.llvm.org/D82631 Files: clang/include/clang/AST/NestedNameSpecifier.h clang/lib/

[PATCH] D82626: [CodeComplete] Tweak completion for else.

njames93 updated this revision to Diff 274469. njames93 added a comment. Address comments and add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82626/new/ https://reviews.llvm.org/D82626 Files: clang/include/clang/Sema/Sema.h clang/lib/

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

ab added a comment. In D82699#2118313 , @arphaman wrote: > @t.p.northover @ab I noticed that the use of "apple-a12" doesn't infer the > right target features when we're passing in a11 or older, so that's why my > test file has the `INFER-A12` separate li

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall marked 8 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:41 + ConfigCompile.cpp ConfigYAML.cpp Diagnostics.cpp hokein wrote: > sammccall wrote: > > hokein wrote: > > > we have a few co

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall updated this revision to Diff 274470. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612 Files: clang-tools-e

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:723 + // Parent map is invalidated after changing the AST. + ToDecl->getASTContext().getParentMapContext().clear(); + balazske wrot

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:723 + // Parent map is invalidated after changing the AST. + ToDecl->getASTContext().getParentMapContext().clear(); + martong wrote

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Other than the documentation and settling on the option name in the parent revision, I think this LGTM (the changes will be mechanical and can be done without further review once

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware added a comment. True positive confirmed in //PostGreS//: Mailing List Archive . It is fixed by now, so you cannot see it on the link in my previous comment anymore.

[PATCH] D82631: [AST][RecoveryAST] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd285f29317d6: [AST][RecoveryExpr] Avoid spurious 'missing typename' diagnostic when the NNS… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:1 +// Tests that aix toolchain adds system includes to the search path + nit: aix->AIX nit: period at end of comment. Comment at: clang/test/Driver/aix-tool

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigProvider.h:47 + /// This always produces a usable compiled fragment (errors are recovered). + explicit CompiledFragment(Fragment, DiagnosticCallback); + -

[clang] 9945bd5 - Add Metadata to Transformer tooling

Author: Andy Soffer Date: 2020-06-30T15:03:07Z New Revision: 9945bd5911636e7f821ac82fdcf8fdb22126e7dc URL: https://github.com/llvm/llvm-project/commit/9945bd5911636e7f821ac82fdcf8fdb22126e7dc DIFF: https://github.com/llvm/llvm-project/commit/9945bd5911636e7f821ac82fdcf8fdb22126e7dc.diff LOG: A

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 updated this revision to Diff 274473. njames93 added a comment. Renamed new option to WarnOnConditionVariables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82824/new/ https://reviews.llvm.org/D82824 Files: clang-tools-extra/clang-tidy/

  1   2   3   >